Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-07
15:20:42 kashyap sean-k-mooney: Wonder if you have thoughts on my last two comments on the design here: https://review.openstack.org/#/c/497457/18
15:20:45 kashyap (No hurry.)
15:27:00 mriedem o/
15:27:54 cdent o/
15:28:46 openstackgerrit Lajos Katona proposed openstack/nova master: WIP: Add nested resources to server moving tests https://review.openstack.org/527728
15:28:52 hrw http://logs.openstack.org/28/541728/1/check/build-openstack-sphinx-docs/7a3bf19/html/user/support-matrix.html is nice. had no idea that zuul will make it available
15:28:56 lyarwood \o morning
15:30:20 dansmith mriedem: so we just merged another compute rpc bump that breaks my patches
15:30:28 dansmith mriedem: surely we should be in lock down for that except for critical bits
15:30:33 stephenfin ltomasbo: Two comments left on https://review.openstack.org/#/c/540679/
15:30:42 stephenfin Ooops, lyarwood ^
15:30:45 stephenfin Sorry ltomasbo :)
15:31:21 ltomasbo :D
15:31:43 mriedem dansmith: it was likely gibi's evacuate late affinity check bug patch,
15:31:48 dansmith yup
15:31:48 mriedem which we wanted to get in since we can't backport it
15:32:08 mriedem that's the last thing i'm aware of
15:32:22 dansmith mriedem: ack, well, it broke a lot of stuff I just got done fixing, so I want to make sure we're done before I fix this again
15:33:09 mriedem i'm not aware of any other patches for rc1 that require rpc version bumps
15:33:38 dansmith okay
15:34:18 kashyap dansmith: Something less grumbly: As 'promised', I've spent a couple of hours this morning digging into the 'bandwidth' parameter. I also got the source reviewed by 2 upstream libvirt devs. Noted the review. Refer my latest two comments on the change: https://review.openstack.org/#/c/497457/
15:34:29 dansmith kashyap: I've already replied
15:34:37 kashyap Ah, didn't even see yours!
15:34:52 kashyap dansmith: So here's even _more_ source-code deep dive discussion with Eric Blake, on that parameter: https://kashyapc.fedorapeople.org/virt/libvirt-bandwidth-API-parameter.txt
15:35:09 kashyap I cleaned up IRC conversation with Eric (libvirt / QEMU dev) on OFTC. And posted it there.
15:35:32 kashyap I learnt interesting things. I'm going to post an upstream libvirt API doc. These semantics should be documented.
15:35:35 dansmith kashyap: yep, the line of code sahid quoted makes it pretty clear which takes precedence
15:35:59 kashyap Eagle eyes there
15:37:52 kashyap So, your suggestion is also reasonable to me (instead of flipping the sequence of calls). Just setting it first, and run it _without_ setting the bandwidth parameter
15:41:57 kashyap Ah, I said the samething as you in the psuedo code - i.e. not supply the 'bandwidth' parameter on the second call.
15:43:05 lyarwood stephenfin: thanks updated, we don't do anything with the return in both cases.
15:44:48 stephenfin ltomasbo: Sweet. +2 from moi
15:47:39 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: wip: minimal qemu/libvirt for aarch64 https://review.openstack.org/541756
15:50:02 stephenfin Anyone want to introduce some of that NUMA goodness into their day? Could do we another set of eyes on https://review.openstack.org/#/c/537363/ and the patches either side of it
15:52:45 mriedem efried: on https://bugs.launchpad.net/nova/+bug/1747511 - i was thinking, could we maybe try to rule out glanceclient as being an issue by doing a straight image API request to GET /images/{image_id} using KSA?
15:52:45 openstack Launchpad bug 1747511 in OpenStack Compute (nova) "server create fails with "Can not find requested image" when CONF.glance.api_servers is not set and [service_user] is set" [High,Confirmed]
15:53:36 hrw mriedem: maybe 3.6.0 libvirt a bit high but it is first version which worked nicely with nova without any extra changes
15:54:16 efried mriedem: Yeah, mordred would love you for that.
15:54:24 mriedem hrw: my point in that comment was i don't think docs is good enough, which is why we have the min version check per arch when the driver starts up
15:54:42 mriedem efried: i was thinking that /v2/v2/images thing is the issue as you pointed out, but you said it shouldn't be
15:54:45 hrw mriedem: sure.
15:55:02 hrw mriedem: the docs patch is something to start with
15:55:02 mriedem hrw: obviously introducing a min version check like that in the code would require an upgrade release note
15:55:04 efried mriedem: I said what?
15:55:12 mriedem hrw: i'd do it in the same patch
15:55:27 mriedem efried: i thought you said that glanceclient bug where the double versions are in the URL wouldn't be an issue for our ksa adapter code
15:55:43 hrw mriedem: you mean supportmatrix docs + min libvirt + relnote?
15:55:45 mriedem if that's definitely the issue, then we can try to see if the direct-to-ksa request would be better
15:55:48 efried mriedem: I thought that *was* the issue. But looking at the results from the latest runs, I'm not as sure. I was going to ask you to glance (hah) over them and see how they compared to yours.
15:55:50 mriedem hrw: yesh
15:55:53 hrw mriedem: ok
15:56:10 mriedem efried: link?
15:57:13 efried mriedem: https://review.openstack.org/#/q/owner:%22Eric+Fried+%253Cefried%2540us.ibm.com%253E%22+project:openstack/nova+dnm+debug+nova-next
15:58:32 mriedem efried: i don't think those nova patches are actually running with https://review.openstack.org/#/c/541431/ since it's not a src job
15:58:44 mriedem i.e. i think the nova CI results are only using the u-c version of ksa, not that patch
15:58:58 efried They changed that recently, I thought.
15:59:00 mriedem legacy-tempest-dsvm-neutron-src on the ksa patch is what you'd want
15:59:05 mriedem hmm
16:02:10 mordred efried, mriedem: just reading scrollback - yes, I think you should stop using glanceclient.
16:02:34 mordred efried, mriedem is there a thing I can help debug?
16:03:25 mriedem https://bugs.launchpad.net/nova/+bug/1747511
16:03:26 openstack Launchpad bug 1747511 in OpenStack Compute (nova) "server create fails with "Can not find requested image" when CONF.glance.api_servers is not set and [service_user] is set" [High,Confirmed]
16:03:35 mriedem https://review.openstack.org/#/c/541008/
16:03:56 mriedem ^ shows that when nova uses ksa to find the image endpoint (rather than CONF.glance.api_servers), and [service_user] tokens,
16:04:07 mriedem we get an image endpoint url like image/v2/v2/
16:04:37 mriedem http://logs.openstack.org/08/541008/2/check/legacy-tempest-dsvm-neutron-nova-next-full/f24c9d2/logs/screen-n-api.txt.gz#_Feb_05_21_46_51_455934
16:05:10 mriedem http://logs.openstack.org/08/541008/2/check/legacy-tempest-dsvm-neutron-nova-next-full/f24c9d2/logs/screen-g-api.txt.gz#_Feb_05_21_46_51_651885
16:05:25 mriedem GET /v2/v2/images/d5659eaf-1c56-4b35-970b-229a91b84bbd
16:05:30 mordred yes. you cannot find a proper endpoint and then pass it to glanceclient
16:05:49 mriedem efried said it was https://bugs.launchpad.net/python-glanceclient/+bug/1707995
16:05:50 openstack Launchpad bug 1707995 in Glance Client "Can't use versioned endpoints" [Undecided,New]
16:06:09 bauzas mriedem: good point for https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L552
16:06:13 bauzas about hrw
16:06:23 bauzas I just wonder if that should be in the same change, but meh
16:06:30 mordred mriedem, efried https://github.com/openstack/os-client-config/blob/master/os_client_config/cloud_config.py#L415-L430
16:06:47 mordred that's what one has to do to make a glanceclient connection from an endpoint
16:07:22 mriedem bauzas: i bring it up because we are now implicitly requiring a minimum version of libvirt if using aarch64 https://review.openstack.org/#/c/538003/10/nova/virt/libvirt/config.py@1641
16:07:26 mriedem due to that change ^
16:07:28 mriedem which is why i kept -1ing it
16:07:32 mriedem but it was approved anyway
16:07:53 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: Provide basic data for AArch64 support matrix/functionality https://review.openstack.org/541728
16:08:01 mriedem mordred: ok let me hack that in quick
16:08:17 bauzas mriedem: oh okay, I wasn't knowing that
16:08:46 hrw mriedem: like I wrote in reply: index=0 is set on calling that class
16:08:48 bauzas mriedem: I discussing this GMT morning with hrw about live-migration not possible for ARM64 due to some libvirt config issue (not having the cpu model)
16:09:12 mordred mriedem: you can skip lines 423 and 424 - those are for different logic
16:09:19 mriedem hrw: oh here https://review.openstack.org/#/c/538003/15/nova/virt/libvirt/driver.py@4952
16:09:24 mriedem hrw: ok i hadn't seen that update
16:09:51 openstackgerrit melissaml proposed openstack/nova-specs master: Modify grammatical errors https://review.openstack.org/541765
16:09:58 hrw mriedem: no problem
16:13:34 bauzas hrw: comment in https://review.openstack.org/#/c/541728/2
16:13:44 bauzas I could be wrong tho
16:13:58 bauzas we use "upgrade" section for telling operators what to change before upgrading
16:14:05 hrw ok
16:14:07 bauzas from the previous Nova version
16:15:01 openstackgerrit Dan Smith proposed openstack/nova master: Bump compute RPC API to version 5.0 https://review.openstack.org/541005
16:15:02 openstackgerrit Dan Smith proposed openstack/nova master: Compute RPC client bump to 5.0 https://review.openstack.org/541035
16:15:12 bauzas hrw: and you could link your feature matrix page to the relnote like I said by `feature matrix`_
16:15:23 hrw bauzas: at Linaro we use 3.4.0-with-backports with newton, was 3.6.0+ with pike+
16:15:53 bauzas hrw: same in Red Hat, sometimes libvirt features are backported to some RHEL version

Earlier   Later