Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-06
20:17:29 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: TrivialFix: Add a space between messages https://review.openstack.org/541436
20:17:30 dansmith kashyap: are you joking? I can't tell
20:17:33 kashyap :P
20:17:40 kashyap Okay, it's clearly too late for me
20:17:51 odyssey4me looks like we have a bug in the log collection - I'll figure that out
20:17:57 dansmith kashyap: and if not, no. we have races that sit dormant for years until something changes in infra, things go in a different order, and we start getting breakage
20:18:01 dansmith kashyap: ack
20:18:33 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: TrivialFix: Add a space between messages https://review.openstack.org/541436
20:18:49 mriedem odyssey4me: ok here was that error you mentioned http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/openstack/openstack1/nova/nova-conductor.log.txt.gz#_2018-02-05_18_19_11_428
20:19:19 odyssey4me mriedem yep, eith the instance error state just a little later
20:21:21 mriedem odyssey4me: i see that nova-manage cell_v2 create_cell didn't exist in newton, so when those commands run, are they against ocata?
20:21:45 odyssey4me yes, in our newton deploy there is no cell management done
20:22:25 kashyap dansmith: Scooping up my final active neurons: You want to see clear _functional test_ evidence that the override of CONF.libvirt.live_migration_bandwidth doesn't happen, yes? (Though, Sahid claims it doesn't.)
20:22:33 odyssey4me mriedem newton only does these: https://github.com/openstack/openstack-ansible-os_nova/blob/stable/newton/tasks/nova_db_setup.yml
20:22:51 dansmith kashyap: no.
20:22:53 mriedem odyssey4me: there are a bunch of errors in the nova-compute logs http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/host/nova/nova-compute.log.txt.gz
20:23:08 dansmith kashyap: I want human analysis of whether or not setting the thing to 1 and 100 in two threads is asking for trouble
20:23:48 dansmith kashyap: as far as I can tell, the migration is started with the CONF value, and then set to 1 to slow things down, but there is no locking or mechanism to ensure the slowdown call is done after the value is set to the one from conf
20:24:04 odyssey4me mriedem hmm, even late in the log, yes: http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/host/nova/nova-compute.log.txt.gz#_2018-02-05_18_15_57_449
20:24:04 kashyap (Okay, between the two threads where it is being set. Needs more code reading...)
20:24:21 odyssey4me mriedem actually, that seems to recover: http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/host/nova/nova-compute.log.txt.gz#_2018-02-05_18_15_57_469
20:24:28 dansmith kashyap: I can ask someone else, I thought you would be able to dig into the libvirt docs and validate or discredit sahid's assertion that it doesn't matter (which doesn't make sense to me)
20:24:31 kashyap dansmith: Yeah, it is started with the CONF value
20:25:03 dansmith kashyap: right, but I don't think there's anything that ensures that that is set before we make the call to slow it down
20:25:15 mriedem odyssey4me: right it logs a warning on the first time it doesn't find it
20:25:50 dansmith kashyap: so it seems to me like it could be started, not reach the point at which the conf value is used, we set the speed limit, then the conf value gets applied
20:25:50 odyssey4me these are somewhat odd though: http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/host/nova/nova-compute.log.txt.gz#_2018-02-05_18_14_01_860
20:25:55 kashyap dansmith: Okay, you'd want to know how the two values that are being set are coordinated with some locking mechanism with the underlying libvirt API
20:26:12 dansmith kashyap: no. nevermind, go to sleep, I'll try to dig into it
20:26:52 mriedem odyssey4me: ok so in the console output, we see that compute show up in the service list here http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/job-output.txt.gz#_2018-02-05_18_15_43_557748
20:27:03 ameeda_ mriedem: Hello :)
20:28:58 mriedem odyssey4me: it might be worthwhile to run discover_hosts with --verbose http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/job-output.txt.gz#_2018-02-05_18_15_48_024543
20:29:02 mriedem to see what it dumps out
20:29:40 mriedem odyssey4me: i do remember that with devstack-based CI, we'd have issues in grenade where nova-compute would take awhile to bring up and create the compute_nodes record, and discover_hosts would miss it
20:30:25 mriedem https://review.openstack.org/#/c/488381/
20:30:36 odyssey4me mriedem yeah, that's why we added the wait until a compute agent was found - that seems to have worked for us so far, but perhaps we need more sheps
20:30:39 mriedem however, you have that "openstack compute service list" check
20:31:32 mordred efried: looks like you have a fun debugging task on your plate
20:31:33 odyssey4me but yeah, lemme add the --verbose CLI option when our debug flag is enabled, which would be very useful here
20:31:45 efried mordred: indeeed
20:33:08 mriedem odyssey4me: are the /etc/ files captured?
20:33:28 odyssey4me mriedem unfortunately not - we had to turn that off 'cos we were eating up all the infra inodes :/
20:33:50 odyssey4me we could add that back, but tar.gz them so we eat fewer inodes :)
20:33:58 mriedem ok, i can't tell if the [database]/connection value in nova.conf that the nova-compute is using is the same database connection as the cell1 this creates
20:36:42 mriedem odyssey4me: anyway i think we can see that the compute_nodes entry is created here for the compute host http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/host/nova/nova-compute.log.txt.gz#_2018-02-05_18_15_57_469
20:36:49 mriedem at 18:15:57.469
20:36:58 mriedem it shows up in the service list here:
20:36:58 mriedem http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/job-output.txt.gz#_2018-02-05_18_15_43_557748
20:37:09 mriedem "end": "2018-02-05 18:15:43.505982",
20:37:31 odyssey4me mriedem db config template is here, if that helps a bit: https://github.com/openstack/openstack-ansible-os_nova/blob/stable/ocata/templates/nova.conf.j2#L213-L233
20:37:56 odyssey4me each db will have a unique name, and each db user/password will also be unique
20:38:17 dansmith kashyap: I explained my concern in more detail, maybe you could dig into docs/code tomorrow with that extra info to validate one way or the other?
20:39:33 mriedem odyssey4me: looks ok
20:39:37 openstackgerrit melanie witt proposed openstack/nova master: Refine waiting for vif plug events during _hard_reboot https://review.openstack.org/541442
20:41:44 dansmith melwitt: nice
20:41:48 mriedem odyssey4me: also throw the --verbose option on create_cell
20:43:18 mriedem ultimately my guess is discover_hosts isn't picking up the compute host and mapping it to the cell
20:43:26 mriedem just not sure why
20:43:43 mriedem could be a timing issue, but that's what the openstack service list check is for
20:44:28 melwitt dansmith: thanks for pointing it out on the original review
20:44:36 dansmith melwitt: yar
20:44:48 efried mriedem: What's your trick for seeing those nova-new results before they're reported to gerrit?
20:44:57 dansmith melwitt: that race is the whole reason I wrote this eventing stuff so I get all sad when it gets broken
20:45:01 odyssey4me yeah, that's my one suspicion... a race condition of some sort - the other is that perhaps there's an online migration required which wasn't executed
20:45:19 mriedem efried: status.openstack.org/zuul
20:45:37 mriedem odyssey4me: i see that the online data migrations are skipped
20:45:37 efried Oh, look, those are links!
20:45:52 odyssey4me mriedem thanks again for looking through all that, and for sanity checking the process to verify that everything looks like it's doing what it should... I'll get a better set of test logs/configs going and we can revisit when those are good
20:46:16 mriedem odyssey4me: http://logs.openstack.org/29/540329/5/check/openstack-ansible-upgrade-ubuntu-xenial/30ae3e2/job-output.txt.gz#_2018-02-05_18_03_50_709904
20:46:22 mriedem <openstack1> Task "Disable the online migrations requirement" has been omitted from the job because the conditional "[u"inventory_hostname == groups['nova_conductor'][0]", u'not data_migrations | skipped', u'data_migrations | succeeded']" was evaluated as "False"
20:46:37 odyssey4me mriedem yep, they're skipped due to the check to see whether all hosts are upgraded before running them... and I don't think we have something in these role tests which actually check for that and execute them, so I think I'll patch that up
20:47:01 odyssey4me I thought we had one, but perhaps it got patched in later and not ported back
20:47:23 efried eff me, guess I need to wait for some of those four hundred patches to clear out of the check queue.
20:47:57 melwitt dansmith: understandable. I'm pretty new to the neutron event scene and have been learning
20:54:29 efried D'oh. The check queue seems to be smart enough not to run functional tests if no .py files were touched.
20:55:58 mriedem someone want to fast approve this? https://review.openstack.org/#/c/539978/
20:56:04 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Debug nova-next failure: user headers https://review.openstack.org/541427
20:56:29 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Debug nova-next failure: invalidate https://review.openstack.org/541430
20:56:45 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Debug nova-next failure: connection params https://review.openstack.org/541432
20:57:14 efried mriedem: There is no fast. There is only zuul.
20:58:18 sean-k-mooney efried: zull used to be fast for small projects. now zuul is fair to all projects. as some who also works on small projects this make me sad
20:58:43 efried Seems snappy for nova-powervm - unless the whole world is broken.
21:00:16 sean-k-mooney efried: ah well the upstream zuul used to round robin taking the first job from each queue in a pipline so small pojects with short to no queue were more likely to have jobs run. now it handels jobs in the order it arrived being fair to all pojects
21:01:29 cdent melwitt, mriedem: would you have any objection to me setting a little goal for myself for nova: remove code from all the __init__.py files (to avoid inadvertent imports)? That is, if I were to do it, is there a chance it would get merged.
21:01:31 sean-k-mooney efried: if you have your own zuul instance for thirdparty testing then it is still fast for your on defintion(policy of job selection) of fast
21:02:41 mriedem cdent: that's somehow related to splitting out placement right?
21:03:22 cdent mriedem: I discovered it because of that, yes, but it's also beneficial for the rest of nova: the fact that it is a common behavior means that various processes are often importing many more modules than they actually need.
21:03:42 mriedem i'd say it has as good a chance at getting merged as anything else
21:04:24 sean-k-mooney cdent: mriedem even if it not related to splitting out placement can we do it anyway. haveing side effect form importing moduels makes testing harder and is really unintuitive to people who have not worked with that module before
21:04:46 cdent mriedem: for latest example see my note to self on https://review.openstack.org/#/c/541435/
21:04:51 mriedem sean-k-mooney: you act like i said no one could push patches
21:05:24 cdent would a spec or blueprint be of any value?
21:05:40 sean-k-mooney mriedem: hehe sorry i know that is not what you ment. i just hate seeing __init__.py files with anything but constants in them
21:05:47 mriedem cdent: idk
21:06:11 sean-k-mooney mriedem: its a pet pev of mine.
21:06:20 mriedem cdent: if it's a non-trivial amount of work, and is a depednency for the eventual placement split, then i could see a specless bp
21:07:04 cdent yeah, sadly it would probably be non-trivial as it often ends with wiggle here causing ripples way over there
21:07:56 cdent I'll put it my queue, thanks.
21:08:22 cdent and I think that can be the end of my work day
21:08:38 sean-k-mooney cdent: that part of why i dont like that patten in python. for example import anyting in nova.cmd results in your process being monkey patched https://github.com/openstack/nova/blob/master/nova/cmd/__init__.py

Earlier   Later