| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-02 | |||
| 10:50:12 | gibi | ildikov: hello :) I will try to look at it before end of today | |
| 10:59:43 | ildikov | andreaf: lol, I would say cross-project work has its challenges :) | |
| 11:00:01 | ildikov | andreaf: I mean overall | |
| 11:00:22 | ildikov | gibi: sounds good, thanks :) | |
| 11:01:03 | ildikov | gibi: the patch is small, but an important one for testing the new multi-attach stuff constantly | |
| 11:01:08 | andreaf | ildikov yes especially if QA is one of the projects :D | |
| 11:01:35 | ildikov | andreaf: that was the easy part this time :D | |
| 11:01:45 | Spazmotic | Ugh just found a more simple way to do my own commit | |
| 11:01:48 | Spazmotic | damn you eyes | |
| 11:04:16 | openstackgerrit | Chris Dent proposed openstack/nova master: Remove microversion fallback code from report client https://review.openstack.org/528794 | |
| 11:10:27 | openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | |
| 11:18:25 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Move resource provider objects into placement hierarchy https://review.openstack.org/540049 | |
| 12:17:34 | openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | |
| 12:45:36 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Test LM with encrypted volumes https://review.openstack.org/536350 | |
| 13:09:25 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Marker reset option for nova-manage map_instances https://review.openstack.org/539501 | |
| 13:19:17 | Spazmotic | giblet always makes me think of a tiny pig. | |
| 13:19:23 | Spazmotic | like real tiny, like ant sized | |
| 13:20:33 | efried | @/ | |
| 13:21:58 | giblet | Spazmotic: this giblet is full of birthday cake today so it is not so small of a pig now | |
| 13:22:16 | Spazmotic | Birthday pig.. sounds delicious. | |
| 13:22:39 | Spazmotic | Happy birthday man, if it is your own cake :) | |
| 13:22:40 | giblet | the cake was delicious too. :) | |
| 13:22:57 | giblet | Spazmotic: Yes, it is. Thank you | |
| 13:23:24 | cdent | happy birthday giblet | |
| 13:24:31 | giblet | cdent: thanks | |
| 13:25:13 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax (Rocky) https://review.openstack.org/540179 | |
| 13:26:03 | efried | Wow, is it Friday already?? | |
| 13:30:44 | Spazmotic | That spec made my eyes fall out of my head so I assume it's super good | |
| 13:32:30 | fried_rice | Which one? | |
| 13:32:50 | Spazmotic | Yours.. impressive I feel dumber for even being too close to it.. I'll save that for when I want to make one later hehe | |
| 13:34:17 | fried_rice | Spazmotic: I wouldn't model your bp off of that one. *Some* folks thought it was too long. | |
| 13:38:12 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Move resource provider objects into placement hierarchy https://review.openstack.org/540049 | |
| 13:57:22 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | |
| 13:59:13 | giblet | edleafe: I figured out how can we ensure that no new UUID validation warning is merged to nova: https://review.openstack.org/#/c/540386 | |
| 14:08:35 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax (Rocky) https://review.openstack.org/540179 | |
| 14:11:42 | mriedem | lyarwood: mdbooth: can you comment on melwitt's question here https://review.openstack.org/#/c/539739/2/nova/virt/libvirt/driver.py@7430 | |
| 14:11:43 | openstackgerrit | Eric Fried proposed openstack/nova master: Avoid inventory DELETE API (no conflict detection) https://review.openstack.org/539712 | |
| 14:11:51 | mriedem | i don't see anything ever setting connection_info['volume_id'] | |
| 14:12:44 | figleaf | giblet: nice | |
| 14:13:08 | mdbooth | mriedem: When I was working on an HLR for a telco many, many moons ago, we'd have called that sort of request tromboning :) | |
| 14:13:27 | figleaf | giblet: working on fixing the merge conflict | |
| 14:13:59 | mriedem | mdbooth: ok i don't know what that means | |
| 14:14:10 | ildikov | mriedem: when we did the connection_info translation for the new attach API we didn't explicitly add the volume_id field to 'data' there so it doesn't seem to come from Cinder either | |
| 14:14:18 | lyarwood | mriedem: yup looking now | |
| 14:15:33 | mdbooth | mriedem: It was a request sent externally only to be bounced back to an internal source :) | |
| 14:16:16 | mdbooth | mriedem: Ah, that's interesting. I made some comments about that in review. | |
| 14:16:23 | mriedem | mdbooth: ok? i asked you guys because you were reviewing/working on the luks patch that i'm trying to fix. | |
| 14:16:54 | mdbooth | mriedem: Sorry, IRC failure. My mind was just wandering... | |
| 14:17:12 | mdbooth | mriedem: So I don't think we should be fetching stuff out of connection_info at all | |
| 14:17:27 | mriedem | this line specifically can be using bdm.volume_id | |
| 14:17:33 | mdbooth | I let it pass in review because I believed we always set volume_id in practise | |
| 14:17:38 | mdbooth | in connection_info | |
| 14:17:40 | mriedem | i was just asking if there was some specific logic as to why it was using connection_info | |
| 14:17:52 | lyarwood | mriedem: vol['id'] no? | |
| 14:18:10 | cdent | fried_rice: you'll probably appreciate the fun of https://bugs.launchpad.net/nova/+bug/1747001 | |
| 14:18:11 | openstack | Launchpad bug 1747001 in OpenStack Compute (nova) "Use of parse.urlencode with dict in nova/tests/unit/scheduler/client/test_report.py can result in unpredictable query strings and thus unreliable tests" [Low,Triaged] | |
| 14:18:13 | mdbooth | No, it was only out of expediency to avoid a larger refactor | |
| 14:18:14 | lyarwood | mriedem: we don't set the id on these LibvirtLiveMigrateBDMInfo objects | |
| 14:18:22 | mriedem | lyarwood: vol['id'] would be the primary key of the bdm | |
| 14:18:41 | mriedem | block_device_mapping = driver.block_device_info_get_mapping( | |
| 14:18:41 | mriedem | block_device_info) | |
| 14:18:46 | mdbooth | Although not *much* larger... | |
| 14:18:48 | lyarwood | right sorry, volume_id | |
| 14:19:01 | mriedem | so i'll fix in my change, good thing mel noticed it, | |
| 14:19:11 | mriedem | was just wondering if there was any good reason behind this being here, and i guess there isn't | |
| 14:19:14 | lyarwood | that and the detach lookup | |
| 14:19:36 | fried_rice | cdent: Appreciating the fun... | |
| 14:19:39 | lyarwood | mdbooth: which refactor? Do you have a link to the comment talking about that? | |
| 14:19:45 | mdbooth | mriedem: If we're going to change that code, we should entirely stop poking around inside connection_info, because we *always* have volume_id in the caller context | |
| 14:19:57 | mdbooth | mriedem: i.e. we can just pass in volume_id | |
| 14:20:14 | lyarwood | nack, lets fix the bug and then talk about that refactor | |
| 14:20:16 | fried_rice | cdent: I thought I had dealt with that issue... | |
| 14:20:23 | mriedem | mdbooth: with 6 days to RC1, i want to just fix the bug | |
| 14:20:40 | mdbooth | It's really not a big refactor, just shuffling some argument | |
| 14:20:57 | giblet | ildikov, mriedem: I left some comments in https://review.openstack.org/#/c/532689 | |
| 14:20:59 | mdbooth | And it will be more robust as you're no longer beholden to the vagiaries of connection_info | |
| 14:21:26 | lyarwood | mriedem's suggested change isn't | |
| 14:21:30 | mdbooth | With 6 days to RC1, personally I'd just buckle down and do it. No heuristics means no late surprises. | |
| 14:22:25 | mriedem | with 6 days to RC1 how about we just revert https://review.openstack.org/#/c/523958/ ? | |
| 14:22:28 | mriedem | would that help? | |
| 14:22:32 | bauwser | FWIW, we have more than 50 open bugs | |
| 14:22:36 | bauwser | 6 days before RC1 | |
| 14:22:41 | bauwser | that's what it tramples me | |
| 14:22:55 | bauwser | 50 "new" bugs, my bad | |
| 14:23:12 | bauwser | and I don't have so much time reviewing those bug reports | |
| 14:23:25 | mriedem | lee answered my question so i'll just make this fix and we can move on | |
| 14:23:30 | bauwser | so, if anyone can help me on that, many thanks | |
| 14:23:33 | lyarwood | please, thanks :) | |
| 14:23:45 | mriedem | bauwser: several of those new bugs are old-ish at this point | |
| 14:23:59 | mriedem | like, "should instance group policies be empty?" | |
| 14:24:05 | bauwser | several, but I don't know if we have regressions yet | |
| 14:24:11 | mriedem | i don't know if that's a bug or what so i didn't know how to triage it | |
| 14:24:21 | bauwser | okay, I'll really need to help you | |
| 14:24:22 | mdbooth | Meh, this is how we play virt driver Jenga :( | |
| 14:24:32 | bauwser | ... once I'm done with other internal work :) | |
| 14:24:56 | mriedem | bauwser: i went through these after the meeting yesterday, there is only one new one in there since then | |
| 14:25:04 | bauwser | cool then | |
| 14:25:21 | bauwser | anyway, let's not diverge | |
| 14:26:59 | ildikov | giblet: tnx | |
| 14:28:36 | mriedem | lyarwood: looks like there were no tests for that pre_live_migration code | |