| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-31 | |||
| 17:18:20 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | |
| 17:18:55 | hrw | mriedem, jaypipes: this version adds usb host controller ONLY if pointer device is 'usbtablet' so ps/2 mouse lovers are not touched | |
| 17:22:54 | mriedem | hrw: that needs tests | |
| 17:23:45 | tssurya | dansmith : no | |
| 17:23:49 | tssurya | do you want me to open one ? | |
| 17:24:19 | hrw | mriedem: I am aware. Will ask someone to write one for me as I know how get functionality working but completely out of ideas when it comes to tests. | |
| 17:24:20 | dansmith | tssurya: I was thinking maybe you already had bugs for both of these things when I asked on the first review, but then realized maybe not | |
| 17:24:38 | dansmith | tssurya: I think it'd be good to have the bugs coming from cern as backport justification, if you don't mind | |
| 17:25:01 | hrw | mriedem: having info are the idea and it's implementation ok is also helpful to me | |
| 17:25:06 | tssurya | dansmith : yea sure, I can do open them | |
| 17:25:15 | tssurya | you want it to be two seperate bugs ? | |
| 17:25:24 | mriedem | hrw: there should be at least one existing test in nova.tests.unit.virt.libvirt.test_driver that you could copy and modify | |
| 17:25:26 | dansmith | tssurya: yeah they're separate issues I think | |
| 17:25:40 | hrw | mriedem: ok | |
| 17:26:14 | hrw | mriedem: any other comments than unit testing? | |
| 17:26:31 | tssurya | cool will do and btw I have done the same for the bdm querying as we had discussed, for nova list, so will post that and open a bug for that too | |
| 17:26:54 | dansmith | tssurya: cool | |
| 17:27:01 | mriedem | hrw: haven't looked | |
| 17:27:05 | hrw | ok | |
| 17:27:14 | mriedem | don't wait for me though | |
| 17:27:23 | hrw | mriedem: do not plan to | |
| 17:27:34 | hrw | mriedem: and thanks a lot for reviews | |
| 17:27:40 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | |
| 17:27:41 | bauzas | mriedem: tssurya: I missed your discussion about ReqSpec deletions | |
| 17:28:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a nova-caching-scheduler job to the experimental queue https://review.openstack.org/539260 | |
| 17:28:14 | bauzas | mriedem: tssurya: I'll try to provide a new patchset this week, but no promises | |
| 17:29:00 | tssurya | bauzas : you have checked the last comment from mriedem on PS9 ? | |
| 17:29:07 | bauzas | not really | |
| 17:33:33 | bauzas | tssurya: dansmith: mmm, honestly, given https://review.openstack.org/#/c/515034/ I think we can abandon https://review.openstack.org/#/c/391060/ | |
| 17:33:35 | bauzas | mriedem: ^ | |
| 17:33:53 | bauzas | purging the spec records when we archive the deleted instances is enough | |
| 17:34:06 | dansmith | bauzas: no it's not | |
| 17:34:13 | bauzas | what are we missing then ? | |
| 17:34:14 | dansmith | for the case we were taking about above | |
| 17:34:34 | dansmith | because we wanted to use the deleted-reqspec as the sentinel to not include the instance in a list of instances from a downed cell | |
| 17:34:40 | dansmith | I want to talk about it in dublin | |
| 17:34:45 | dansmith | so don't abandon yet | |
| 17:34:48 | tssurya | bauzas : we are trying to find some way in which we can include information regarding the status of an instance : whether its deleted or not in the api DB | |
| 17:34:51 | bauzas | okay | |
| 17:37:39 | bauzas | dansmith: so the idea would be that if you don't find the related spec record for a specific instance UUID, then it implies that the instance is deleted, hence not needed to be shown from the instance mapping records ? | |
| 17:38:05 | bauzas | so we wouldn't have stale content if the cell is down? | |
| 17:38:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Check for leaked server resource allocations in post_test_hook https://review.openstack.org/538510 | |
| 17:38:14 | dansmith | bauzas: yeah | |
| 17:38:22 | bauzas | mmm, ok | |
| 17:38:26 | bauzas | I see | |
| 17:38:28 | dansmith | bauzas: we'd only be showing instance shells, but we don't want any to come back from the dead | |
| 17:38:39 | dansmith | we could have a deleted flag, but.. I really don't want to go down that road | |
| 17:38:48 | dansmith | if we can help it | |
| 17:38:58 | bauzas | the main problem is that I'm not sure we can deterministacally destroy a spec record | |
| 17:39:06 | bauzas | oh man | |
| 17:39:16 | bauzas | deterministically-something | |
| 17:42:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Check for leaked server resource allocations in post_test_hook https://review.openstack.org/538510 | |
| 17:43:17 | dansmith | bauzas: yeah I understand the potential issue there | |
| 17:43:18 | dansmith | hence the need to discuss | |
| 17:43:29 | bauzas | cool | |
| 17:43:50 | bauzas | okay, let's keep that open until Dublin then | |
| 17:43:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | |
| 17:43:58 | bauzas | dansmith: thanks for explaining me the need | |
| 17:44:01 | dansmith | tssurya: ^ I'll update with the bug number when you get it | |
| 17:46:57 | hrw | hm. I am reading _get_guest_pointer_model() again and again... It returns anything ONLY if that anything is usbtablet... | |
| 17:47:17 | hrw | or I do not understand Python (which is highly possible) | |
| 17:47:37 | bauzas | mriedem: before leaving, just left +1 on https://review.openstack.org/#/c/530743/ because I need to consider whether it's acceptable to have exceptions or not that are popped by the API, based on the compute version | |
| 17:48:25 | bauzas | like, say I'm upgrading half of my nodes, is that a problem if I'm getting a different disk calculation logic ? | |
| 17:48:33 | bauzas | either way, the master change is merged | |
| 17:48:47 | bauzas | so maybe it's just me overthinking | |
| 17:49:04 | bauzas | anyway, need to disappear | |
| 17:50:18 | hrw | function starts. then hw_pointer_model is read from image properties. if it is not set then check for use_usb_tablet option and if it is set then set pointer_model to usbtablet and issue a warning that configuration needs update. Then is a check is pointer_model a usbtablet. If it is not then function ends. It it is then check for is Vnc or (is spice but without spice agent) and then return usbtablet | |
| 17:50:24 | hrw | through _get_guest_usb_tablet() function which checks for VMMode and creates structure for add_device() call | |
| 17:52:26 | hrw | mriedem: added one more comment and ending a day | |
| 17:53:12 | tssurya | dansmith : https://bugs.launchpad.net/nova/+bug/1746558 , https://bugs.launchpad.net/nova/+bug/1746561 | |
| 17:53:14 | openstack | Launchpad bug 1746558 in OpenStack Compute (nova) "Make service all-cells min version helper use scatter-gather" [Undecided,New] - Assigned to Dan Smith (danms) | |
| 17:53:15 | openstack | Launchpad bug 1746561 in OpenStack Compute (nova) "Make host_manager use scatter-gather and ignore down cells" [Undecided,New] - Assigned to Dan Smith (danms) | |
| 17:53:32 | tssurya | dansmith: thanks again! | |
| 17:53:58 | openstackgerrit | Dan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590 | |
| 17:53:59 | openstackgerrit | Dan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | |
| 17:54:01 | dansmith | tssurya: they haven't started running tests yet, so ^ | |
| 17:54:03 | dansmith | tssurya: thanks! | |
| 18:01:41 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280 | |
| 18:27:09 | mriedem | esberglu: can you post a patch that adds powervm to the hpc feature support matrix page? https://docs.openstack.org/nova/latest/user/feature-classification.html#matrix-hpc | |
| 18:29:18 | mdbooth | dansmith: jaypipes Thanks. NP holding off for queens either. | |
| 18:30:10 | mriedem | kashyap: re http://logs.openstack.org/66/539266/2/check/build-openstack-sphinx-docs/f7a1712/html/admin/virtual-gpu.html#how-to-know-a-gpu-type where it says, "Note that the current libvirt API doesn’t provide a way to access that information." | |
| 18:30:16 | mriedem | is that true at least for libvirt 4.0.0? | |
| 18:30:18 | mriedem | which is the latest release? | |
| 18:30:29 | mdbooth | dansmith: I responded to your comments and I'm expecting to make some changes. Given that it's not going to land in Queens it's hardly urgent, but just in case you wanted to respond while you still have context... I'm looking for further feedback on which changes are really required. | |
| 18:34:17 | mriedem | efried_rollin: the in-tree powervm driver doesn't support gpu passthrough right? | |
| 18:49:22 | mriedem | esberglu: nvm i've just about got this | |
| 18:52:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: update the GPU passthrough HPC feature entry https://review.openstack.org/539638 | |
| 19:02:31 | mriedem | artom: we don't throw exceptions in python! | |
| 19:02:33 | mriedem | :P | |
| 19:02:44 | artom | mriedem, eh? | |
| 19:02:54 | mriedem | https://review.openstack.org/#/c/539266/2/doc/source/admin/virtual-gpu.rst@116 | |
| 19:03:05 | artom | I said something stupid, didn't I? | |
| 19:03:23 | artom | "Libvirt will throw an exception" | |
| 19:03:26 | artom | Yep :( | |
| 19:09:00 | artom | Oh wait, you mean we raise, not throw. | |
| 19:09:05 | artom | Yeah, that too. | |
| 19:09:13 | artom | It's not my fault they taught us Java :( | |
| 19:13:10 | melwitt | well, libvirt itself throws because it's C right :P | |
| 19:13:37 | dansmith | C doesn't throw | |
| 19:14:07 | dansmith | it returns -1 and sets ERRNO | |