| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-31 | |||
| 14:33:07 | ccamacho | mrieden thanks for the link | |
| 14:33:37 | ccamacho | mrieden are the shadow tables there for ever? | |
| 14:33:39 | mriedem | there has been a spec and code up before for a command to do similar to archive_deleted_rows but actually hard delete the records rather than move them | |
| 14:33:45 | mriedem | ccamacho: yeah | |
| 14:33:52 | mriedem | so there is still bloat in the db for deleted stuff | |
| 14:34:49 | mriedem | https://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd | |
| 14:35:36 | mriedem | https://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd | |
| 14:35:38 | mriedem | oops | |
| 14:35:42 | mriedem | this is the spec https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/purge-deleted-instances-cmd.html | |
| 14:35:57 | mriedem | and a poc from someone at red hat https://review.openstack.org/#/c/330791/ | |
| 14:36:15 | ccamacho | mrieden thanks, the idea is to write +- a procedure to verify and clean the DBs before the upgrade and be sure they are cleaned.. hopefully we can try to implement it after | |
| 14:36:18 | ccamacho | thanks man | |
| 14:36:42 | ameeda | mriedem: I should remove this from my branch https://review.openstack.org/#/c/528069 ? or create new branch for this https://review.openstack.org/#/c/528385/ and resubmit the review with new change id ? | |
| 14:36:56 | mriedem | ameeda: i think you should abandon https://review.openstack.org/#/c/528069 | |
| 14:37:14 | mriedem | ameeda: to do that locally, rebase your series and drop that change from the local branch, | |
| 14:37:18 | mriedem | git rebase -i master | |
| 14:37:23 | mriedem | <remove that commit> | |
| 14:37:30 | mriedem | git review | |
| 14:37:39 | ameeda | Ok let me check | |
| 14:37:40 | ameeda | Thanks | |
| 14:38:28 | mriedem | ccamacho: the man page doesn't list the option, but nova-manage db archive_deleted_rows [--max_rows <number>] [--verbose] has an option for running until complete | |
| 14:38:47 | mriedem | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L494 | |
| 14:39:00 | ccamacho | mrieden ack thanks! | |
| 14:39:19 | efried | jaypipes: I opened some bugs on the subject. https://bugs.launchpad.net/nova/+bug/1746075 https://bugs.launchpad.net/nova/+bug/1746373 https://bugs.launchpad.net/nova/+bug/1746374 | |
| 14:39:21 | openstack | Launchpad bug 1746075 in OpenStack Compute (nova) "Report client placement cache consistency is broken" [Undecided,New] | |
| 14:39:22 | openstack | Launchpad bug 1746373 in OpenStack Compute (nova) "Placement APIs with missing conflict detection" [Undecided,New] | |
| 14:39:23 | openstack | Launchpad bug 1746374 in OpenStack Compute (nova) "Report client _delete_inventory violates generation consistency" [Undecided,New] | |
| 14:39:34 | efried | At a minimum, that last one needs to be fixed. | |
| 14:40:01 | efried | ...whenever we get to a point where there's actually a possibility of concurrency. | |
| 14:40:13 | mriedem | ameeda: it's all yours https://bugs.launchpad.net/nova/+bug/1746531 | |
| 14:40:14 | openstack | Launchpad bug 1746531 in OpenStack Compute (nova) "nova-manage db archive_deleted_rows man page does not mention --until-complete option" [Medium,Confirmed] - Assigned to Ameed Ashour (ameeda) | |
| 14:40:16 | jaypipes | efried: well, DELETE <uri> and PUT <uri> have different semantics, no? | |
| 14:40:38 | jaypipes | efried: I mean, PUT <uri> can do more than DELETE some object in a collection... | |
| 14:41:13 | jaypipes | efried: you are getting gibi-like bug-happy. | |
| 14:41:45 | efried | jaypipes: Correct. I'm saying PUT encompasses what DELETE does. But in these particular cases, DELETE doesn't actually provide us with enough functionality to allow us to ensure consistency. | |
| 14:41:54 | jaypipes | efried: how impactful are those bugs? do they need to be addressed for queens, in your opinion? | |
| 14:42:19 | efried | jaypipes: Probably not, since we have that big ol' lock preventing concurrency in the first place. | |
| 14:42:39 | jaypipes | efried: ack. can you add this to the list of discussion topics for Dublin? | |
| 14:44:10 | ameeda | mriedem: Thank you very much !! | |
| 14:45:43 | openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | |
| 14:46:25 | ameeda | mriedem: patch uploaded https://review.openstack.org/#/c/528385/ | |
| 14:46:50 | efried | jaypipes: https://etherpad.openstack.org/p/nova-ptg-rocky L50-59 | |
| 14:47:13 | jaypipes | efried: danke | |
| 14:47:28 | efried | jaypipes: To put possibilities in your head, we could have a DELETE that accepts a payload and returns a payload. | |
| 14:47:55 | efried | or just use PUT :) | |
| 14:48:26 | jaypipes | cdent might shit a brick, though. | |
| 14:48:57 | cdent | i've laid so many bricks in the past few days I'm not sure I have any left | |
| 14:48:59 | mriedem | if another core can look at this, i think we should get it in before rc1 https://review.openstack.org/#/c/522112/ beause backports with new config options are generally gross | |
| 14:49:09 | jaypipes | cdent: poor guy. still under the weather? | |
| 14:49:17 | jaypipes | mriedem: on it. | |
| 14:49:19 | mriedem | ^ adds the ability for nova to do cinder api stuff, like neutron, without a user token, for things like periodic cleanup tasks | |
| 14:49:43 | jaypipes | mriedem: reading the bugs now... | |
| 14:50:04 | openstackgerrit | Sen Yang proposed openstack/python-novaclient master: Implement hypervisor hostname exact pattern match https://review.openstack.org/520187 | |
| 14:50:11 | cdent | jaypipes: I _am_ still under the weather, but the bricks I was talking about in this case is the number of conversations in the past few days about generations and provider tree and related stuff that are still up in the air | |
| 14:50:21 | jaypipes | cdent: heh, ok :) | |
| 14:50:27 | ameeda | mriedem: about assigned bug https://bugs.launchpad.net/nova/+bug/1746531 where I should add the description and what should I write ? | |
| 14:50:28 | openstack | Launchpad bug 1746531 in OpenStack Compute (nova) pike "nova-manage db archive_deleted_rows man page does not mention --until-complete option" [Medium,Confirmed] | |
| 14:50:35 | openstackgerrit | Eric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | |
| 14:50:35 | openstackgerrit | Eric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | |
| 14:50:36 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._delete_provider https://review.openstack.org/535463 | |
| 14:50:36 | openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering https://review.openstack.org/536624 | |
| 14:50:37 | openstackgerrit | Eric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625 | |
| 14:50:37 | openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | |
| 14:50:38 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | |
| 14:50:38 | openstackgerrit | Eric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | |
| 14:50:39 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | |
| 14:50:40 | openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | |
| 14:50:40 | jaypipes | cdent: I seem to have gracefully avoided all of those conversations... | |
| 14:50:40 | openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | |
| 14:50:58 | ameeda | is still gate broken ? https://review.openstack.org/#/c/526900/ | |
| 14:51:21 | cdent | jaypipes: they've been interesting and I think for the most part useful with regard to longer term considerations | |
| 14:51:26 | efried | gibi, jaypipes, mriedem: easy manual rebases on that series | |
| 14:51:37 | gibi | efried: looking... | |
| 14:51:38 | cdent | jaypipes but trying to parse them while still ill is ow | |
| 14:51:40 | mriedem | melwitt: i think the functional test failures in your patch https://review.openstack.org/#/c/340614/ are real | |
| 14:52:34 | jaypipes | cdent: ack on that... | |
| 14:53:47 | jaypipes | mriedem: hmm, delete_on_termination=True && boot_from_volume=True don't seem to be a good mix... | |
| 14:53:57 | jaypipes | but whatevs, I will try to keep an open mind.' | |
| 14:54:31 | mriedem | jaypipes: that's super old behavior | |
| 14:54:47 | mriedem | delete the backing volume once i delete the instance | |
| 14:54:48 | bauzas | mriedem: on https://review.openstack.org/#/c/522112/ | |
| 14:56:14 | ameeda | mriedem: should I follow https://docs.openstack.org/doc-contrib-guide/ ? | |
| 14:56:40 | mriedem | ameeda: no, the nova-manage man pages are in the nova tree | |
| 14:56:45 | mriedem | under doc/source/cli | |
| 14:57:00 | mriedem | it's just a restructured text file | |
| 14:58:01 | ameeda | great , what I should write there ? | |
| 14:58:11 | mriedem | ameeda: dude | |
| 14:58:23 | mriedem | i'm not going to write the patch fo you | |
| 14:58:24 | mriedem | *for | |
| 14:58:29 | gibi | jaypipes, mriedem: the first patch in efried's series needs a second core https://review.openstack.org/#/c/521098 the rest is +Wd | |
| 14:58:45 | ameeda | mriedem: sorry :$ | |
| 14:58:46 | mriedem | see how existing entries document CLI options, take a stab at doing similar for the missing option, and then post it for review and get feedback | |
| 14:58:49 | ameeda | Thank you !! | |
| 14:59:12 | mriedem | gibi: if it was a rebase you can just fast approve | |
| 14:59:58 | gibi | mriedem: it was a manual rebase, but yeah, I can fast approve it, sure. | |
| 15:00:29 | mriedem | we need some cores to look at this too https://review.openstack.org/#/c/537351/ | |
| 15:00:35 | mriedem | fixes nits in alex's traits series | |
| 15:01:26 | bauzas | mriedem: are we considering https://review.openstack.org/#/c/537351/4 not impact by FF ? | |
| 15:01:29 | bauzas | impacted* | |
| 15:01:49 | mriedem | bauzas: it's docs and nit cleanups | |