| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-23 | |||
| 09:27:09 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: WIP: VMware: implement update_provider_tree() https://review.openstack.org/536348 | |
| 09:33:03 | bauzas | jianghuaw: around ? | |
| 09:33:40 | bauzas | jianghuaw: I don't know if you tested your vGPU patches with all the instance actions | |
| 09:34:23 | bauzas | jianghuaw: but see my relnote for libvirt https://review.openstack.org/#/c/533818/5/releasenotes/notes/add-support-for-vgpu-libvirt-91d2983e643f5ff1.yaml | |
| 09:34:41 | bauzas | jianghuaw: IMHO, you should be impacted by possibly the same problems | |
| 09:34:47 | bauzas | like for migrating | |
| 09:34:55 | bauzas | or resizing | |
| 09:35:54 | gibi | esberglu_: thanks for the update, I'm +2 on the SEA patch | |
| 09:37:17 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: using the dict format for the allocations https://review.openstack.org/536083 | |
| 09:37:18 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | |
| 09:40:00 | Spazmotic | Morning UK Nova | |
| 09:40:04 | Spazmotic | good to see you all :) | |
| 09:40:26 | alex_xu | gibi: bauzas ^, I just fix the functional tests | |
| 09:40:41 | Spazmotic | jianghuaw had some meetings, fyi bauzas | |
| 09:41:00 | alex_xu | bauzas: also there need one more +2 https://review.openstack.org/#/c/535642/4 :) appreciate you can help it | |
| 09:42:30 | Spazmotic | If anyone gets a chance with XenAPI knowledge, would love a look at https://review.openstack.org/#/c/533168/. Been sitting idle for about 12 days | |
| 09:46:11 | bauzas | Spazmotic: ok, thanks | |
| 09:46:15 | bauzas | Spazmotic: you working on Xen ? | |
| 09:46:30 | bauzas | alex_xu: looking | |
| 09:46:37 | alex_xu | bauzas: thanks! | |
| 09:47:11 | maciejjozefczyk | Hello everyone! | |
| 09:47:32 | bauzas | alex_xu: I promised today to be a review day | |
| 09:47:52 | bauzas | unfortunately, I have some nits to modify and then I'm looking | |
| 09:48:05 | bauzas | the placement API for traits is something really crucial so yeah | |
| 09:48:32 | alex_xu | bauzas: got it, appreciate for that! | |
| 09:51:40 | Spazmotic | yes sir bauzas | |
| 09:51:50 | gibi | alex_xu: looking as well | |
| 09:53:09 | Spazmotic | Back and forth planting my pepper seeds for the season, sorry :) | |
| 09:56:41 | Spazmotic | Superhot Peppers and XenAPI.. essentially the same thing when caring for them. | |
| 09:56:53 | cdent | handle with care | |
| 09:57:07 | Spazmotic | Indeedie heh | |
| 10:01:45 | amoralej | melwitt, we are hitting a problem in last periodic in a tempest test https://bugs.launchpad.net/tripleo/+bug/1744907 | |
| 10:01:46 | openstack | Launchpad bug 1744907 in tripleo "Tempest test: "test_create_second_image_when_first_image_is_being_saved" failing in featureset020 periodic job" [Critical,New] | |
| 10:01:53 | amoralej | i'm not sure if it's nova or glance related | |
| 10:02:01 | amoralej | any idea? | |
| 10:02:18 | amoralej | second image is being properly created when error is expected | |
| 10:04:53 | alex_xu | gibi: thanks | |
| 10:06:32 | mdbooth | lyarwood: Have you seen melwitt 's review of the luks patch? | |
| 10:07:16 | mdbooth | Spazmotic: Expect severe pain the morning after use? | |
| 10:07:52 | mdbooth | lyarwood: I think you're still good, but you are missing 2 tests. | |
| 10:09:07 | jianghuaw | bauzas, sorry for late response. Just ended a meeting. thanks Spazmotic:-) | |
| 10:09:33 | bauzas | no worries, see my earlier pings | |
| 10:09:33 | jianghuaw | bauzas, yes. XenAPI doesn't support suspend also. | |
| 10:09:38 | lyarwood | mdbooth: yup working through it now | |
| 10:09:51 | jianghuaw | XenAPI has precheck on it. | |
| 10:09:52 | bauzas | jianghuaw: and resize I guess ? | |
| 10:10:22 | jianghuaw | I've not verified resizing. | |
| 10:10:23 | mdbooth | lyarwood: I've replied to most things if you refresh (and you're interested) | |
| 10:11:01 | jianghuaw | The suspend will be rejected by XenServer XAPI if there is vGPU attached in the VM. | |
| 10:14:11 | jianghuaw | bauzas, resizing works well from my side. | |
| 10:15:10 | jianghuaw | XAPI handles more things beyond the virt driver than libvirt. | |
| 10:16:02 | bauzas | jianghuaw: so XenAPI persists which vGPUs are used ? | |
| 10:16:27 | jianghuaw | bauzas, XAPI handle it. it has records in Db. | |
| 10:17:01 | jianghuaw | So nova needn't worry about status. | |
| 10:17:04 | jianghuaw | :-) | |
| 10:17:52 | bauzas | k | |
| 10:21:11 | jianghuaw | bauzas, actually you need handle more things which may be more suitable be handled by hypervisor. | |
| 10:21:30 | jianghuaw | Anyway you're super bauzas:-) | |
| 10:23:17 | openstackgerrit | Merged openstack/osc-placement master: CLI for usages https://review.openstack.org/457535 | |
| 10:24:24 | Spazmotic | sweet sweet state.db | |
| 10:24:30 | Spazmotic | peppers all planted.. hopefully none of them will kill me | |
| 10:29:27 | Spazmotic | Thanks bob, if you're in here ;) | |
| 10:30:54 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: pass the mdevs when rebooting the guest https://review.openstack.org/533818 | |
| 10:30:55 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Avoid suspending guest with attached vGPUs https://review.openstack.org/535693 | |
| 10:31:37 | bauzas | jianghuaw: just provided all the comments in the relnote $ | |
| 10:31:39 | bauzas | ^ | |
| 10:32:49 | bauzas | gibi: you were +2 on https://review.openstack.org/533818 | |
| 10:33:02 | bauzas | gibi: I actually just modified the relnote+ rebased | |
| 10:33:10 | kashyap | mdbooth: I'm still duking aroud the XML generation locally. As there 4 different classes I have to navigate: | |
| 10:33:13 | kashyap | - LibvirtConfigCPUFeature - base class for defining CPU features | |
| 10:33:15 | kashyap | - LibvirtConfigCPU - base class for defining CPU models | |
| 10:33:18 | kashyap | - LibvirtConfigGuestCPUFeature - extension for setting the guest | |
| 10:33:20 | kashyap | specific feature policy | |
| 10:33:23 | kashyap | - LibvirtConfigGuestCPU - extension for setting the guest specific | |
| 10:33:25 | kashyap | match policy, and allowing use of host CPU model passthrough | |
| 10:33:58 | jianghuaw | bauzas, sure. I will look at the patches. | |
| 10:34:23 | kashyap | Context: It was in reference to https://review.openstack.org/#/c/534384/ | |
| 10:34:42 | mdbooth | kashyap: Yep, guessed. | |
| 10:35:30 | mdbooth | kashyap: Incidentally, it sounded from that ml discussion that we might want to propose adding PCID automatically in Nova if it's not present in the explicit cpu model? | |
| 10:36:21 | mdbooth | Or were we still erring towards triple-o? | |
| 10:36:31 | kashyap | mdbooth: It's the latter. | |
| 10:36:40 | mdbooth | I guess the advantage of doing it in Nova is that you can query libvirt to expand the cpu flags from the specified model | |
| 10:36:43 | kashyap | mdbooth: Because, adding it automatically indeed is a bit too magic | |
| 10:37:03 | mdbooth | i.e. You don't need to duplicate the list | |
| 10:37:30 | gibi | bauzas: I put back my +2 | |
| 10:37:32 | kashyap | Yes, it should be. | |
| 10:39:20 | kashyap | mdbooth: Do you have a few more minutes to confirm I'm reading code correctly? /me begins to type | |
| 10:39:34 | bauzas | gibi: <3 | |
| 10:40:07 | kashyap | mdbooth: So if you look at the class LibvirtConfigGuestCPUFeature() in libvirt/config.py. The infrastrucutre already _exists_ | |
| 10:40:26 | kashyap | To generate something like: | |
| 10:40:26 | kashyap | <cpu match='exact'> | |
| 10:40:27 | kashyap | <model fallback='forbid'>IvyBridge</model> | |
| 10:40:27 | kashyap | <vendor>Intel</vendor> | |
| 10:40:27 | kashyap | <feature policy='require' name='pcid'/> | |
| 10:40:29 | kashyap | </cpu> | |
| 10:41:16 | kashyap | mdbooth: Also see corresponding test: LibvirtConfigGuestCPUFeatureTest() in test_libvirt_config.py. | |
| 10:42:48 | kashyap | So since I'm introducing a config variable, I need to generate the objects for LibvirtConfigGuestCPUFeature() -- for every CPU flag configured in nova.conf | |
| 10:43:23 | mdbooth | kashyap: Yep | |
| 10:45:06 | ameeda | WARNING: when I pull the last version of nova "DevStack" , the system doesn't work anymore . | |
| 10:45:13 | kashyap | mdbooth: Okido. So my change here is wrong -- https://review.openstack.org/#/c/534384/2/nova/virt/libvirt/config.py. Because the root element 'feature' is already handled in the existing class LibvirtConfigCPUFeature() | |