| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-19 | |||
| 15:41:52 | giblet | leakypipes: sorry, I always forget | |
| 15:42:20 | fried_rice | giblet finucannot leakypipes I'm going to rebase the series real quick to get rid of the merge conflicts on the top few patches... | |
| 15:42:34 | giblet | fried_rice: thanks for the headsup | |
| 15:42:37 | leakypipes | ok dokey | |
| 15:43:04 | fried_rice | leakypipes Your +2s will ride. Only the _delete_provider patch was manual. | |
| 15:43:11 | leakypipes | ack | |
| 15:43:12 | fried_rice | Here it comes. | |
| 15:43:17 | openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.data => ProviderData https://review.openstack.org/533244 | |
| 15:43:18 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | |
| 15:43:18 | openstackgerrit | Eric Fried proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539 | |
| 15:43:19 | openstackgerrit | Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | |
| 15:43:19 | openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | |
| 15:43:20 | openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | |
| 15:43:20 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_aggregates_for_provider https://review.openstack.org/533808 | |
| 15:43:21 | openstackgerrit | Eric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | |
| 15:43:21 | openstackgerrit | Eric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | |
| 15:43:22 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._delete_provider https://review.openstack.org/535463 | |
| 15:43:22 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | |
| 15:43:23 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | |
| 15:43:23 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | |
| 15:43:24 | openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | |
| 15:43:27 | rgerganov | cool | |
| 15:43:28 | fried_rice | leakypipes giblet finucannot ^ done. Thanks. | |
| 15:43:32 | finucannot | (y) | |
| 15:44:01 | leakypipes | fried_rice: and you just killed your clean check run ;) | |
| 15:44:05 | fried_rice | rgerganov I still haven't addressed your comments. I can start on that now. But I also had some other stuff I was gonna do to those WIPs today. | |
| 15:44:07 | leakypipes | but alas, c'est la vie | |
| 15:44:13 | fried_rice | leakypipes Ah, dang, that too :( | |
| 15:45:28 | rgerganov | fried_rice, no rush, I will head out soon. Will ping you on monday at 1300 UTC | |
| 15:46:01 | fried_rice | rgerganov Roger wilco. At 1400 is the scheduler meeting, where some of this stuff might get discussed, if you're interested in joining. | |
| 15:46:16 | rgerganov | ah, thanks for letting me know, I will consider it | |
| 15:47:00 | fried_rice | rgerganov https://wiki.openstack.org/wiki/Meetings/NovaScheduler -- feel free to add agenda items if you think of something that needs to be addressed. | |
| 15:47:08 | rgerganov | ok, thanks | |
| 15:50:57 | openstackgerrit | Merged openstack/nova master: Fix format in flavors.rst https://review.openstack.org/535777 | |
| 15:51:14 | leakypipes | rgerganov: I mean... what ELSE would you rather do on a Monday afternoon other than spend time with me and fried_rice? ;) | |
| 15:52:57 | rgerganov | leakypipes, lol | |
| 15:53:04 | fried_rice | Thanks giblet! It's all downhill from here. | |
| 15:53:59 | cfriesen | anyone feel like a fairly quick code review? https://review.openstack.org/#/c/484381/ has been sitting with a single +2 for a couple weeks now | |
| 15:54:24 | cfriesen | ^ this is related to instance evacuation with PCI devices | |
| 15:54:33 | leakypipes | cfriesen: evacuate? PCI devices? oh hell, sign me up! | |
| 15:54:49 | cfriesen | leakypipes: it's under 20 lines. :) | |
| 15:54:57 | leakypipes | cfriesen: I'm looking at it :) | |
| 15:55:05 | cfriesen | sweet, thanks | |
| 15:55:48 | giblet | fried_rice: I have left like 15 minutes then boardgame night... | |
| 15:56:01 | fried_rice | ooo :) | |
| 15:56:18 | fried_rice | cfriesen How does this actually fix anything? | |
| 15:56:44 | fried_rice | cfriesen Oh, it passes in a thing that's being checked by something that happened in a different patch? | |
| 15:57:20 | fried_rice | got it. | |
| 15:57:24 | cfriesen | fried_rice: not actually my patch, but I think it's passing in a thing that something else already in the code is looking for | |
| 15:58:13 | finucannot | fried_rice: Yup. Something we already do for one code path (cold migration, resize) should now being done for another (evacuation) | |
| 15:58:20 | fried_rice | cfriesen Yeah, I see _update_port_binding_for_instance takes a migration kwarg | |
| 15:58:36 | leakypipes | cfriesen: +Wallaby'd | |
| 15:58:49 | cfriesen | leakypipes: awesome, thanks | |
| 15:59:08 | fried_rice | cfriesen Left a passive-aggressive +0 with a nit. | |
| 15:59:49 | cfriesen | lol | |
| 16:00:28 | leakypipes | jackiet: how about "fullmetaljackie"? ;) | |
| 16:00:47 | leakypipes | jackiet: though that might be too long for irc. | |
| 16:01:52 | fried_rice | ++! | |
| 16:01:53 | fullmetaljackiet | leakypipes: niceeee I like it | |
| 16:01:57 | leakypipes | heh | |
| 16:02:00 | leakypipes | :) | |
| 16:02:12 | leakypipes | fullmetaljackiet: glad to be of service. | |
| 16:02:13 | cfriesen | leakypipes: want me to quick make the change suggested by fried_rice? | |
| 16:02:59 | leakypipes | cfriesen: meh? the way the gate is I'd prefer to just leave it for now. | |
| 16:03:08 | cfriesen | works for me | |
| 16:03:15 | cfriesen | figured I'd offer | |
| 16:03:16 | leakypipes | fried_rice is right, of course. | |
| 16:03:22 | leakypipes | but it's a nit | |
| 16:03:49 | fried_rice | Not even worth a followon. | |
| 16:04:56 | leakypipes | fried_rice: so, your comment on this one unit test "_get_provider_aggregates and _traits were called thrice" just makes me think of the monty python holy hand grenade scene. | |
| 16:05:13 | fried_rice | leakypipes Five is RIGHT OUT. | |
| 16:05:19 | leakypipes | "The number shall be THREE!" | |
| 16:05:28 | leakypipes | :) | |
| 16:05:33 | fried_rice | Then lobbest thou the holy hand grenade... | |
| 16:05:37 | fried_rice | okay okay. | |
| 16:05:40 | leakypipes | hehe | |
| 16:05:54 | fried_rice | Back to Airplane! quotes. | |
| 16:06:20 | openstackgerrit | Matthew Edmonds proposed openstack/nova master: Fix bad autospec usage https://review.openstack.org/535806 | |
| 16:07:17 | edmondsw | claudiub I would prefer ^ to the oslotest fixture | |
| 16:07:33 | edmondsw | but it's at least a first step even if you want to continue to push use of that fixture | |
| 16:07:42 | edmondsw | (which could be done subsequently) | |
| 16:08:58 | bauzas | ildikov: I don't see any change in the series that does things at the driver level with https://review.openstack.org/#/c/531244/10/nova/compute/manager.py@5190 | |
| 16:09:16 | bauzas | ildikov: I mean, you and matt made the RPC changes for asking for multiattach, sure | |
| 16:09:31 | bauzas | but then, how do we pass that down to libvirt? I'm confused | |
| 16:10:03 | bauzas | oh f***, nevermind | |
| 16:10:05 | ildikov | bauzas: it's in the capabilities | |
| 16:10:26 | ildikov | bauzas: I guess you found it :) | |
| 16:10:30 | bauzas | ildikov: yeah, so basically the RPC change is just for asking whether the compute driver supports it | |
| 16:10:37 | ildikov | bauzas: yes | |
| 16:10:40 | bauzas | if not, raise | |
| 16:10:45 | ildikov | exactly | |
| 16:10:51 | bauzas | if yes, let's the volume say whether it's multiattached | |
| 16:10:54 | bauzas | gotcha | |
| 16:10:59 | claudiub | edmondsw: sure, that works too, but i've had nightmares with mock.create_autospec | |
| 16:11:18 | bauzas | ildikov: sorry, I'm in general used to see things happening at the manager level once you pass a new attribute | |
| 16:11:27 | ildikov | bauzas: yeah, many pieces to put together | |
| 16:11:27 | bauzas | a new *RPC* attribute | |
| 16:11:34 | claudiub | I've had run times increase exponentially because of mock.create_autospec | |
| 16:11:43 | bauzas | ildikov: yeah, https://review.openstack.org/#/c/532928/4/nova/compute/manager.py does that | |
| 16:12:26 | edmondsw | claudiub hmm | |