| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-17 | |||
| 13:46:48 | ameeda | jaypipes: ? | |
| 13:48:46 | edmondsw | gibi we respun https://review.openstack.org/#/c/422512/ for a comment from stephenfin and lost your +2. Please take another look when you get a chance. Thanks! | |
| 13:50:37 | edmondsw | stephenfin do you think you'll be able to look at the SEA patch? It's similar to OVS, builds on that to add another type of networking: https://review.openstack.org/#/c/523216/ | |
| 13:53:54 | gibi | edmondsw: it is on my list for today | |
| 13:54:05 | edmondsw | gibi great, tx | |
| 13:59:57 | bauzas | gibi: could I beg you for reviewing https://review.openstack.org/#/c/528832/10 ? ;) | |
| 14:00:26 | bauzas | FWIW, there will be a GPU track for the OpenStack Summit, and I'd love to showcase with Xen folks ;) | |
| 14:07:51 | gibi | bauzas: I will try to look at it, but no promises for today | |
| 14:08:04 | bauzas | np, I totally understand :) | |
| 14:08:11 | bauzas | I basically have the same answer | |
| 14:09:19 | gibi | bauzas: btw, multiattach also need a second core https://review.openstack.org/#/c/267587 :) | |
| 14:09:36 | ildikov | gibi: I typed it in, but then I thought I will not put you in a mood where you just throw it to the end of your list :) | |
| 14:09:49 | ildikov | gibi: so I haven't sent the message | |
| 14:09:53 | gibi | ildikov: no worries :) | |
| 14:10:28 | ildikov | gibi: yeah, I'm trying my best not to worry about it... :) | |
| 14:10:58 | bauzas | gibi: just sayin' | |
| 14:11:04 | bauzas | (15:07:51) gibi: bauzas: I will try to look at it, but no promises for today | |
| 14:11:10 | bauzas | same for multiattach :p | |
| 14:11:15 | gibi | bauzas: understood :p | |
| 14:11:25 | ildikov | gibi: I thought to ask jaypipes or melwitt to look at the chain as it's not terribly long and Matt touched all of them so it can't be terribly wrong either :) | |
| 14:11:27 | bauzas | why for the hell all the things I need to do happen at the same time ? | |
| 14:12:02 | gibi | bauzas: feels like a deadline comming up | |
| 14:12:03 | ildikov | bauzas: I believe it's called code freeze? :) | |
| 14:12:49 | stephenfin | sean-k-mooney: That os-vif patch is +Wd now. Thanks for the review, jaypipes :) | |
| 14:13:26 | stephenfin | bauzas: I'm assuming you were linking the vGPU patch earlier? Won't get to it today, but I'll star it for review later this week :) | |
| 14:13:39 | stephenfin | edmondsw: Ditto for your SEA patch ^ | |
| 14:13:58 | bauzas | stephenfin: yup, see gibi's harassement ping I made to him | |
| 14:14:02 | edmondsw | stephenfin tx | |
| 14:14:24 | bauzas | ildikov: gibi: the multiattach patch doesn't seem crazy to review | |
| 14:14:40 | bauzas | I'll try to look at it today if I have time | |
| 14:14:40 | ildikov | bauzas: it's a chain | |
| 14:14:52 | bauzas | I know | |
| 14:14:56 | ildikov | bauzas: there's one longer patch but it's mostly tests | |
| 14:15:10 | ildikov | bauzas: would be a huge help, thanks in advance! | |
| 14:15:17 | bauzas | I first need to do internal stuff, but 'll try | |
| 14:15:49 | ildikov | bauzas: sure, I know how that goes :) | |
| 14:16:28 | bauzas | the fact that internal stuff becomes prioritary litterally one week before FF makes me puzzled, but yeah, that's life | |
| 14:16:29 | gibi | bauzas: I still have to look at the api part of the multiattach but what I saw is not worrying | |
| 14:19:07 | openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | |
| 14:23:14 | gibi | edmondsw: I +W-d the powerVM os-vif. Nice work! | |
| 14:26:59 | edmondsw | gibi thanks! | |
| 14:28:14 | jaypipes | ameeda: sorry, went breakfasting | |
| 14:29:03 | jaypipes | ameeda: yeah, I see you getting 'metadata': {} | |
| 14:29:14 | jaypipes | ameeda: try running as admin instead of a normal user. | |
| 14:29:15 | cdent | at long last the monster rises from the crypt in search of food | |
| 14:29:28 | jaypipes | cdent: rooooaaarrr! | |
| 14:30:02 | cdent | jaypipes: you see my bloggy thing about placement container experiment from yesterday? | |
| 14:30:17 | jaypipes | bauzas: "why for the hell all the things I need to do happen at the same time ?" <-- I don't... I don't even know what that means :) | |
| 14:30:35 | efried | Central Texas is experiencing a cold snap, and my Internet is down. Awkwardly connected to irc from mobile. What news? | |
| 14:30:38 | bauzas | jaypipes: you mean you don't understand my point ? | |
| 14:31:00 | jaypipes | bauzas: oh, you're just saying that you need to get a bunch of things done all at once? | |
| 14:31:21 | bauzas | I mean I just have a shit lot of things to do by end of this week | |
| 14:31:22 | jroll | efried: when that happens you're supposed to call it a snow day and drink hot cocoa and watch movies :P | |
| 14:31:43 | bauzas | efried: if that's ski-able, that's not a problem | |
| 14:31:48 | openstackgerrit | Merged openstack/os-vif master: adds iptools driver for ip commands https://review.openstack.org/534307 | |
| 14:31:50 | cdent | jroll++ | |
| 14:33:38 | efried | bauzas I wish. Even if there was snow (there isn’t) there’s nothing approaching a skiable slope. | |
| 14:34:04 | efried | No, it’s only 15F, but we are NOT set up to handle that. | |
| 14:34:07 | jroll | excuses. https://www.youtube.com/watch?v=waPRZu9iBJw | |
| 14:36:28 | edleafe | Not set to handle cold: http://www.mysanantonio.com/news/local/article/TxDOT-All-San-Antonio-area-roadways-open-no-12500663.php | |
| 14:37:12 | ameeda | jaypipes: please check this out "http://paste.openstack.org/show/646514/" | |
| 14:38:50 | ameeda | jaypipes: I think that image properties don't appears on nova side, on cli I have to execute "glance image-show <image_uuid> to see the new key | |
| 14:41:25 | efried | jaypipes Mainly looking for a comeback on my... uhh, dissertation on the ProviderTree.snapshot patch today https://review.openstack.org/#/c/533244/ | |
| 14:42:20 | cdent | my weather adventure is that sometime in the night the various official bags and bins that are used for setting out the recycling were gone this morning. Just plain gone. As winds were gusting into the 60s and 70s overnight it is entirely possible they are in france now. | |
| 14:42:27 | efried | That’s a tall stack of pancakes; want to get it moving | |
| 14:47:38 | jaypipes | ameeda: and what I'm telling you is that that code path (doing self.image_api.get()) is *not* going to hit the code path you are modifying in the patch (around the utils.py module). | |
| 14:48:42 | jaypipes | ameeda: so you may need to just either rely on unit tests or convert your functional tests to validate the patch's behaviour changes by manually checking the length of the instance_metadata DB record's values. | |
| 14:48:59 | jaypipes | efried: ya, getting there... | |
| 14:49:07 | efried | Thx | |
| 14:50:39 | edleafe | As long as we're begging for reviews, it would be nice to get the last alternate hosts patch merged: https://review.openstack.org/#/c/526436/ | |
| 14:50:47 | ameeda | jaypipes: so If I remove my functional test. you would accept that and merge ? | |
| 14:51:04 | jaypipes | ameeda: not without a change to unit tests. | |
| 14:51:10 | edleafe | Matt was good with it before he left for holiday - just wanted some more eyes on it | |
| 14:51:30 | ameeda | jaypipes: what kind of change you want on unit tests ? | |
| 14:51:55 | jaypipes | ameeda: at least something that demonstrates the code changes in your patch work as expected. | |
| 14:52:39 | ameeda | jaypipes: so If I want to checking the length of the instance_metadata DB record's values, what do you think | |
| 14:54:01 | ameeda | jaypipes: what about this "images = self._image_api.get_all(self.admin_api)" , it will get the info from instance_metadata DB | |
| 14:54:11 | jaypipes | no. | |
| 14:54:19 | jaypipes | the image api doesn't touch the nova db. | |
| 14:54:44 | ameeda | jaypipes: how you can help me to check record manually ? | |
| 14:54:48 | jaypipes | ameeda: https://review.openstack.org/#/c/531512/6/nova/tests/functional/db/test_allocation_candidates.py | |
| 14:54:58 | jaypipes | ameeda: check out the utility method on line 1453 there | |
| 14:55:13 | jaypipes | ameeda: that shows an example of how to query the nova DB from a functional test manually. | |
| 14:55:35 | jaypipes | ameeda: you would need to do something like that. only instead of hitting the API DB, you'd want to hit the nova cell DB | |
| 14:55:47 | jaypipes | ameeda: so something like this: | |
| 14:55:57 | jaypipes | with self.db.get_engine().connect() as conn: | |
| 14:56:39 | jaypipes | return conn.execute("SELECT key, value FROM instance_metadata WHERE instance_uuid = '%s'" % instance.uuid) | |
| 14:56:54 | jaypipes | ameeda: I will leave it up to you to figure it out from here. | |
| 14:57:28 | ameeda | jaypipes: thank you very much, I appropriate that from you, Thank you for your time | |
| 14:57:46 | jaypipes | np | |
| 14:58:16 | ameeda | jaypipes: this case must be in unit test, so I should remove functional test ? | |
| 14:58:33 | jaypipes | ameeda: no, you can keep the functional test. | |
| 14:59:04 | jaypipes | ameeda: and instead of asserting the return value from self.images_api.get(), you would instead assert the length of the DB record | |
| 15:00:00 | ameeda | jaypipes: well, so I will add the code to check the record in functional test ? | |
| 15:00:29 | jaypipes | ameeda: yes | |
| 15:00:38 | ameeda | great ! | |
| 15:01:05 | ameeda | jaypipes: again thank you very much, I was feeling bad before, I have to leave now, I will complete the work tomorrow. | |
| 15:01:24 | jaypipes | ameeda: np | |
| 15:06:11 | sean-k-mooney | is mriedem around this week? | |
| 15:11:13 | edleafe | sean-k-mooney: on holiday without computer | |