| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-16 | |||
| 11:38:56 | stephenfin | mdbooth: Done | |
| 11:39:04 | mdbooth | stephenfin: Thanks | |
| 11:40:05 | mdbooth | Hmm, that patch series is starting to descend into merge conflict hell. | |
| 12:13:51 | mdbooth | How do I hate thee? Let me count the ways. | |
| 12:14:17 | mdbooth | Actually, I'm out of fingers :/ | |
| 12:15:08 | lyarwood | mdbooth: it did | |
| 12:15:11 | lyarwood | * mdbooth sent a long message: mdbooth_2018-01-16_12:13:39.txt | |
| 12:15:11 | lyarwood | <https://matrix.devlab.redhat.com/_matrix/media/v1/download/redhat.com/ZOkiHajvlKvFxQUcknOXyfhJ> | |
| 12:15:23 | mdbooth | lyarwood: Hehe, yeah. | |
| 12:17:03 | mdbooth | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7519 | |
| 12:17:09 | mdbooth | There down to... | |
| 12:17:12 | mdbooth | except Exception: pass | |
| 12:17:17 | mdbooth | Yes, really | |
| 12:17:56 | mdbooth | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7519-L7530 | |
| 12:21:38 | openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 12:36:05 | cdent | Does anyone recall if nova/objects/ec2.py is used any more. It seems only in tests | |
| 12:37:25 | cdent | hard to be clear | |
| 12:40:42 | cdent | (╯°□°）╯︵ ┻━┻ | |
| 12:45:52 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | |
| 12:45:54 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | |
| 12:49:17 | alex_xu | cdent: just found there still have a lot of returns by searching 'ec2' in the source code | |
| 12:49:49 | cdent | alex_xu: yes, but at least some of that is dead (only some) | |
| 12:49:53 | cdent | and it is hard to tell which | |
| 12:50:39 | cdent | alex_xu: I'm trying to work on the "less imports" goal implied by this bug https://bugs.launchpad.net/nova/+bug/1743120 and it is ... messy | |
| 12:50:40 | openstack | Launchpad bug 1743120 in OpenStack Compute (nova) "placement inadvertently imports many python modules it does not need" [Low,In progress] - Assigned to Chris Dent (cdent) | |
| 12:51:59 | alex_xu | cdent: yea, I guess nova/api/openstack/__init__.py is source of evil :) | |
| 12:52:19 | cdent | i was able to get some of it: https://review.openstack.org/#/c/533797/ | |
| 12:52:43 | cdent | registering objects is also a culprint | |
| 12:54:37 | alex_xu | interesting, put it in my review list, I still have circle import in the nova api, hope to get some clue | |
| 12:56:36 | cdent | alex_xu: another source of trouble is conf, it tends to imports lots of stuff that isn't always needed. but I reckon the main culprit is code in __init__.py being common | |
| 12:57:40 | gibi | cdent: you have to rebase your patch https://review.openstack.org/#/c/533797 to have this revert in your history https://review.openstack.org/#/c/533190/ | |
| 12:57:49 | alex_xu | cdent: yea...__init__.py... | |
| 12:58:03 | cdent | gibi: ah cool, thanks | |
| 12:58:15 | gibi | cdent: this was last | |
| 12:58:20 | gibi | cdent: this was last Friday's fun | |
| 12:58:36 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] use simple FaultWrapper https://review.openstack.org/533752 | |
| 12:58:47 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 12:59:36 | cdent | ah | |
| 13:03:54 | cdent | yup, that fixed it gibi, thanks | |
| 13:04:00 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 13:04:12 | cdent | I guess I started this branch longer ago than I thought | |
| 13:15:45 | zioproto | sdague: ping, are you around ? | |
| 13:21:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | |
| 13:21:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 13:21:51 | bauzas | folks loving to see how vGPUs are possible with libvirt, the series is up for reviews https://review.openstack.org/#/c/528832/10 | |
| 13:22:33 | bauzas | there are still some corner cases (at least for suspend and migrations), but that's something I'll provide by next changes | |
| 13:22:55 | bauzas | gibi: stephenfin: in case you're interested in ^ | |
| 13:23:13 | sdague | zioproto: for a little bit, what's up? | |
| 13:23:25 | openstackgerrit | Merged openstack/os-vif master: Git ignore .stestr https://review.openstack.org/533699 | |
| 13:32:39 | zioproto | sdague: hey, you have been metioned on openstack-dev, make sure you look at the thread [oslo][oslo.log] JSON logs are missing the request ID | |
| 13:33:08 | zioproto | sdague: please read the thread (5 emails so far) and tell me if you have some important info for me :) | |
| 13:33:21 | zioproto | sdague: thanks ! | |
| 13:34:27 | mvenesio | Hi guys, i'm trying to configure nova and rabbitmq to use SSL with trusted certificates, but doing the configuration as is in the ssl security guide im getting the "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed" error when nova tries to connect with rabbitmq, any idea about what can be wrong ? | |
| 13:34:39 | openstackgerrit | sean mooney proposed openstack/os-vif master: adds iptools driver for ip commands https://review.openstack.org/534307 | |
| 13:35:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | |
| 13:35:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 13:36:00 | sean-k-mooney | stephenfin: ^ that is not done yet but need to run in to town for a bit. ill fix it up when i get back. if i dont have it working by this evening ill revert the original pyroute2 patch. | |
| 13:36:37 | sean-k-mooney | stephenfin: actully ill propose the revert now just ot have it in the gate but ill -1 it until this evening | |
| 13:37:46 | openstackgerrit | sean mooney proposed openstack/os-vif master: Revert "Migrate from 'ip' commands to 'pyroute2'" https://review.openstack.org/534308 | |
| 13:43:50 | sdague | zioproto: I didn't really touch the json log formatter, though it wouldn't be too hard to add I don't think | |
| 13:47:45 | openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | |
| 13:55:47 | Spazmotic | Poor XenAPI drivers, no love hehe | |
| 13:55:51 | zioproto | sdague: should I open a bug then ? | |
| 13:57:21 | openstackgerrit | Matthew Edmonds proposed openstack/nova master: Add taskflow to requirements https://review.openstack.org/533779 | |
| 13:57:28 | sdague | zioproto: are you sure that request_id isn't in there? | |
| 13:57:48 | sdague | because in looking at the code, it looks like it should be a key under the 'context' key, if it exists | |
| 13:58:31 | zioproto | it is not there | |
| 13:58:36 | zioproto | I even shared my all config in the thread | |
| 13:58:56 | zioproto | I see the same problem in neutron-server and nova-api | |
| 13:59:03 | gibi | gmann: I did what you suggested in https://review.openstack.org/#/c/533210/7 plus I made an override for irrelevant files to see if it works or not in this context. Based on zuul status the override does not work in this context either | |
| 13:59:05 | zioproto | I did not test other services so far | |
| 14:00:05 | sdague | zioproto: you have a json dump of what you see, I don't see that in the email thread | |
| 14:04:47 | efried | gibi You got the PowerVM OVS patch on your radar again today? https://review.openstack.org/#/c/422512/ | |
| 14:06:27 | efried | stephenfin I remember you saying you were really looking forward to that one ^ :) | |
| 14:06:46 | stephenfin | Ha! | |
| 14:06:51 | stephenfin | I'll look at it today :) | |
| 14:07:29 | efried | Thank you sir. | |
| 14:28:41 | bauzas | mdbooth: I think I addressed most of your concerns in https://review.openstack.org/#/c/528832/ and later patches | |
| 14:29:12 | bauzas | mdbooth: there are still some open issues (at least for suspend) that I'm working on, but after testing my series with a specific node, it works quite fine | |
| 14:31:13 | mdbooth | bauzas: Thanks. wrt side effects in _get_guest_xml, I wonder if I'll have to suck that up. Perhaps we should rename it. | |
| 14:31:48 | bauzas | renaming _get_guest_xml ? well, yes it's not a "get" | |
| 14:31:53 | bauzas | but anyway | |
| 14:34:30 | efried | jaypipes Given mgoddard's feedback, I'm thinking I do need to go to the trouble of reordering ProviderTree.snapshot ahead of set_traits_for_provider so we can get rid of that generation arg right away and have it be useful to him. Unless you see getting this series merged pretty quickly... | |
| 14:34:58 | jaypipes | efried: go for it. I'm workin' on the traits stuff for alloc cands | |
| 14:35:09 | jaypipes | efried: i.e. I won't get to reviews on that until this afternoon | |
| 14:35:33 | efried | ight | |
| 14:42:25 | jaypipes | sean-k-mooney: reverted that one patch in os-vif. you feel like cutting the 1.8.1 release? | |
| 14:42:50 | sean-k-mooney | jaypipes: which one kuryr? | |
| 14:42:55 | jaypipes | ya | |
| 14:43:01 | BKaminski | johnthetubaguy, You around today by chance sir? | |
| 14:43:02 | sean-k-mooney | we have another one | |
| 14:43:07 | jaypipes | oh>? | |
| 14:43:15 | sean-k-mooney | pyroute2 has a filehandel leak | |
| 14:43:32 | sean-k-mooney | im implentint an iptools driver until its patched | |
| 14:43:50 | sean-k-mooney | jaypipes: https://review.openstack.org/#/c/534307/ | |
| 14:44:00 | jaypipes | looking... | |
| 14:44:02 | sean-k-mooney | im gixing some tests currently | |
| 14:44:08 | sean-k-mooney | fixing | |
| 14:44:13 | jaypipes | hehe | |
| 14:44:26 | jaypipes | sean-k-mooney: have fun gixing the implentint | |