Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-01-12
16:20:30 gibi mriedem: second try looks good now in https://review.openstack.org/#/c/533210/2 , I will create the proper patches (one for nova and one for the project-config) on Monday
16:20:39 melwitt guh s/context/content/
16:21:21 finucannot melwitt: Yeah, there's no tests for 'TenantSock' because it was supposed to be just a shim around 'websockify.websocket.WebSocketRequestHandler'. Perhaps it's time we added them.
16:22:07 melwitt finucannot: yeah, I realized the same. we should do that as a follow up later
16:24:19 superdan bauwser: if you didn't see the pings from yesterday, this needs your eyes (and -2?) https://review.openstack.org/#/c/532924/
16:26:18 melwitt mriedem: on my consoles series, my reply was basically that we currently only invalidate console auths for delete instance and live migrate. and I was thinking not to change any behavior in my series since it's supposed to just be changing the backend of the console auth
16:27:09 melwitt I think you're right that we should be invalidating console auths for all instance moves including cold migrate and shelve but I was thinking that would be a separate change
16:28:23 cdent mriedem: nova-next as py3 makes excellent and vaguely poetic sense
16:28:42 mriedem cdent: did you just see my comment on stephen's patch?
16:28:45 cdent yes
16:28:48 mriedem heh
16:28:55 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210
16:28:56 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: Testing if funct test is triggered https://review.openstack.org/533211
16:29:12 mriedem cdent: i think we can make that happen once newton is dead
16:29:27 mriedem as nova-next should only run on pike+
16:37:57 openstackgerrit Eric Berglund proposed openstack/nova master: Add PowerVM to feature-classification https://review.openstack.org/533237
16:38:37 mriedem finucannot: got some nits in https://review.openstack.org/#/c/345397/ but those could be dealt with in a cleanup patch at the end of the series
16:39:17 finucannot mriedem: Cool. I can tackle those now
16:42:50 openstackgerrit Andreas Jaeger proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210
16:43:10 fried_rice gibi That host1 != host2 thing - is the fix merged at this point?
16:43:20 openstackgerrit Andreas Jaeger proposed openstack/nova master: DNM: Testing if funct test is triggered https://review.openstack.org/533211
16:44:02 superdan several things in the gate have failing tests and zuul doesn't seem to be responding to status queries
16:44:13 superdan might be headed for another reset
16:44:29 superdan oh yep, here it comes
16:45:16 fried_rice gibi Found it: https://review.openstack.org/#/c/533190/ -- Guess I can rebase on top of it, or wait for it to merge.
16:54:19 mriedem finucannot: cool. some more in https://review.openstack.org/#/c/345398/
16:54:32 finucannot Sweet
16:57:35 mriedem finucannot: oh boy, what is this about https://review.openstack.org/#/c/345399/42/nova/cmd/novncproxy.py@43 ?
16:57:50 mriedem is that asserting that is cool for all other virt drivers besides xen/
16:57:51 mriedem ?
16:58:56 finucannot Yup, melwitt and I discussed that. The drivers that support VNC support 3.8, and the ones that don't support VNC don't matter, obviously. It's only Xen that supports 3.3
16:59:19 mriedem ok
16:59:50 finucannot Yup, here's the thread https://review.openstack.org/#/c/345399/34/nova/cmd/novncproxy.py@43
17:07:07 openstackgerrit Eric Fried proposed openstack/nova master: WIP: ProviderTree.find => ReadOnlyProvider https://review.openstack.org/533244
17:07:22 fried_rice cdent figleaf gibi sean-k-mooney There's a start ^
17:13:46 mriedem finucannot: some questions in https://review.openstack.org/#/c/345399/
17:15:07 mriedem melwitt: i've gone through the meaty parts of the websocket proxy series
17:15:20 mriedem withholding +2 on the last rfb one until the questions are answered and CI results are done
17:15:59 cdent fried_rolls: noted, got it on my list for a looksee
17:18:06 melwitt mriedem: just skimmed through your comments. originally, finucannot had enabled TLS for only the libvirt driver and I suggested changing it to not xen because I thought generally when we add these features we don't aim to target them at one driver only and that some consensus around at least more than one driver is reached before going ahead
17:18:33 melwitt maybe I was mistaken on that
17:19:58 openstackgerrit Mathieu Rohon proposed openstack/nova master: Allow VMs to use unaddressed port https://review.openstack.org/533249
17:31:16 finucannot mriedem: I've addressed all the questions. Will tackle the cleanups in the follow-up patch
17:33:05 sean-k-mooney fried_rolls: the patch seams fine - the lack of any testing :)
17:35:40 sean-k-mooney fried_rolls: instead of _check_readonly and the current __setattr__ you could just asign a throwing __setattr__ at the end of the init. it might save some cycle during the copy of the childern that said the branch predictor should get this right 99% of the time
18:32:55 openstackgerrit Mathieu Rohon proposed openstack/nova master: Allow VMs to use unaddressed ports https://review.openstack.org/533249
18:41:52 mriedem melwitt: no you're correct that we want features adopted by a majority of virt drivers
19:04:12 mriedem melwitt: ok i'm +2 up through the rfb patch
19:04:22 mriedem and ci is happy http://logs.openstack.org/50/530950/1/check/legacy-tempest-dsvm-py35/6f0c24d/logs/screen-n-novnc.txt.gz#_Jan_12_17_42_32_200099
19:06:24 melwitt mriedem: sweet, I'll go through it again today
19:09:26 mriedem finucannot: comments in the docs patch and i'm done https://review.openstack.org/#/c/500544/
19:10:34 finucannot mriedem: Excellent, thanks :) I'll address all the comments in a follow-up by Monday
19:10:54 mriedem ack
19:11:01 mriedem tell danpb the good news :)
19:11:07 mriedem he is risen
19:11:14 finucannot :D
19:42:29 openstackgerrit Sriharsha Basavapatna proposed openstack/os-vif master: Fix VF-rep lookup routine to use parent PF number https://review.openstack.org/531674
20:00:15 superdan mriedem: oh you're back
20:00:31 superdan mriedem: wanna conduct a thought experiment with me?
20:02:52 mriedem umm
20:03:38 superdan you can have this lollipop if you get into my van...
20:05:43 mriedem stvnoyes: nice work on https://review.openstack.org/#/c/533285/
20:05:54 mriedem superdan: shoot
20:06:03 mriedem if it's overly complicated for my vacation brain i'll opt out
20:06:07 superdan mriedem: you wanna do hangout for expediency or here?
20:06:12 mriedem oh...
20:06:39 mriedem i have migrated to the game of thrones final episode of season 7 viewing area...
20:06:47 mriedem i didn't realize i'd have to put professional pants back on
20:06:54 superdan you don't, I can explain here
20:07:03 superdan it'd just be quicker via voice, but up to you
20:07:19 mriedem sec, i'll move back to the office
20:08:19 superdan mriedem: https://hangouts.google.com/call/BPfFHG1eYDY-HJyiblzMAAEE
20:08:21 superdan melwitt ^
20:13:25 mriedem reminds me of this https://review.openstack.org/#/c/529626/
20:21:31 superdan sdague: please +W this backport ASAP kthx
20:21:33 superdan https://review.openstack.org/#/c/529635
20:28:43 melwitt mriedem: couple stable backports needing review https://review.openstack.org/#/q/topic:bug/1713857 and https://review.openstack.org/#/q/topic:bug/1724573
20:29:09 melwitt oh wait, you did the backports in the first bug so you can't review them. guh
20:31:47 fried_rolls sean-k-mooney I actually tried that, and for some reason it didn't work. I'm actually not super worried about it; I'd almost be tempted to leave the read-only protections off entirely, since the point is for them not to be able to modify the original ProviderTree.
20:34:17 mriedem mtreinish: want to hit this backport? https://review.openstack.org/#/c/523911/
20:37:15 openstackgerrit Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
20:37:17 figleaf mriedem: ^^ addressed your comments
20:39:56 openstackgerrit Merged openstack/nova master: Revert "Deduplicate service status notification samples" https://review.openstack.org/533190
20:40:10 openstackgerrit Merged openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell' https://review.openstack.org/513771
20:40:27 openstackgerrit Merged openstack/nova master: Update FAQs about listing hosts in cellv2 https://review.openstack.org/531559
20:40:41 openstackgerrit Merged openstack/nova master: Document lack of side-effects in AllocationList.create_all() https://review.openstack.org/530997
20:41:29 mtreinish mriedem: +A
20:49:05 melwitt lyarwood: your review needed please for the libvirt driver re-init on hard reboot backport https://review.openstack.org/#/c/531422
21:00:47 openstackgerrit Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982
21:00:47 openstackgerrit Eric Fried proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189
21:00:48 openstackgerrit Eric Fried proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407
21:00:48 openstackgerrit Eric Fried proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409
21:00:49 openstackgerrit Eric Fried proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737
21:00:49 openstackgerrit Eric Fried proposed openstack/nova master: Fix comments in get_all_with_shared() https://review.openstack.org/533195
21:01:28 fried_rolls Cores, can I please get re+Ws on ^ after rebasing to pick up gibi fix?
21:03:09 mriedem fried_rice: done
21:03:15 fried_rice mriedem Thanks
21:03:36 fried_rice Considering how to deal with similar on https://review.openstack.org/#/c/521686/ series...
21:08:36 mriedem figleaf: thanks, comments ilnine
21:08:38 mriedem *inline

Earlier   Later