Posted	Nick	Remark
#openstack-nova - 2018-01-12
09:53:05	openstackgerrit	Merged openstack/nova master: Remove confusing comment in compute_node_get API method https://review.openstack.org/526718
09:53:22	openstackgerrit	Merged openstack/nova master: zuul: Move legacy jobs to project https://review.openstack.org/514309
09:53:31	openstackgerrit	Merged openstack/nova stable/pike: Don't try to delete build request during a reschedule https://review.openstack.org/529697
10:01:06	openstackgerrit	Stephen Finucane proposed openstack/nova master: console: Send bytes to sockets https://review.openstack.org/531834
10:01:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397
10:01:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398
10:01:08	openstackgerrit	Stephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation https://review.openstack.org/345399
10:01:08	openstackgerrit	Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544
11:34:46	openstackgerrit	Merged openstack/python-novaclient master: Remove deprecated certs CLIs and python bindings https://review.openstack.org/532974
11:36:55	openstackgerrit	Merged openstack/python-novaclient master: Remove deprecated cloudpipe CLIs and python API bindings https://review.openstack.org/532976
12:16:47	openstackgerrit	Brooks Kaminski proposed openstack/nova master: XenAPI/Stops the migration of volume backed VHDS https://review.openstack.org/533168
12:18:02	openstackgerrit	Matthew Booth proposed openstack/nova master: Rename block_device_info_get_root https://review.openstack.org/529028
12:18:03	openstackgerrit	Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346
12:18:03	openstackgerrit	Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347
12:18:04	openstackgerrit	Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029
12:18:04	openstackgerrit	Matthew Booth proposed openstack/nova master: Expose driver_block_device fields as attributes https://review.openstack.org/528362
12:18:05	openstackgerrit	Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363
12:27:39	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587
12:27:39	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Handle swapping to a multiattach volume https://review.openstack.org/532928
12:27:40	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244
12:27:40	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047
12:29:32	ildikov	gibi: johnthetubaguy: rebased the multi-attach chain and bumped the API microversion that was in conflict ^^
12:29:49	ildikov	gibi: thanks for the reviews!
12:38:32	gibi	ildikov: cool. I saw the merge conflict on the last patch so I stopped there. Now I don't have this excuse any more
12:48:24	openstackgerrit	Merged openstack/nova master: Handle glance exception during rotating instance backup https://review.openstack.org/523395
12:48:35	openstackgerrit	Merged openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381
13:06:23	ildikov	gibi: sorry :)
13:50:36	fried_rice	cdent Good morning.
13:50:44	cdent	mornin'
13:50:51	fried_rice	uh, afternoon for you, I guess.
13:51:42	gnuoy	Does a nova review need 2 x +2 ?
13:52:15	kashyap	Yes
13:52:20	fried_rice	gnuoy Almost always
13:52:27	kashyap	gnuoy: Actually, not quite
13:52:28	gnuoy	ack, ta
13:52:39	kashyap	gnuoy: Someone can just merge it with a single +2 & a +W
13:52:51	kashyap	2 +2s is a 'good pratcise' thing
13:52:52	fried_rice	Oh, right, it's not enforced by gerrit
13:53:01	fried_rice	It's by policy
13:53:01	cdent	fried_rice: it's always morning somewhere
13:53:08	gnuoy	ok, understood. thanks
13:53:24	bhagyashris	iawn: Hi, are you around?
13:53:51	fried_rice	gnuoy Sometimes trivial fixes are quick-approved, or a trivial patch set on a change that previously had multiple +2s, that kind of thing.
13:54:09	gnuoy	I see, makes sense
13:54:23	fried_rice	ianw ^ misspelled ping :)
13:54:47	bhagyashris	sorry sorry
13:54:59	bhagyashris	ianw: Hi, are you around?
13:56:00	gibi	I'm seening a lot of functional failures like on the gate like this: http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22u'host2'%20!%3D%20u'host1':%20path:%20root.payload.nova_object.data.host%5C%22
13:56:11	gibi	I opened https://bugs.launchpad.net/nova/+bug/1742935
13:56:12	openstack	Launchpad bug 1742935 in OpenStack Compute (nova) "TestServiceUpdateNotificationSample fails intermittently: u'host2' != u'host1': path: root.payload.nova_object.data.host " [Undecided,New] - Assigned to Balazs Gibizer (balazs-gibizer)
14:04:38	fried_rice	cdent Is report client single threaded today?
14:04:48	fried_rice	I thought it was, but started to think through it and realized it probably isn't.
14:05:07	cdent	greenthreaded
14:05:12	fried_rice	Because periodic tasks plus deploys
14:05:18	fried_rice	I meant in practice rather than by design
14:05:19	cdent	got somebody in the house, so gotta come back to it
14:08:52	bhagyashris	sdague: Hi, Could you please review my devstack patch https://review.openstack.org/#/c/527907/
14:12:28	bhagyashris	sdague: thank you :)
14:13:25	sdague	bhagyashris: no prob
14:18:30	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Revert "Deduplicate service status notification samples" https://review.openstack.org/533190
14:19:12	gibi	cores, the nova functional jobs are broken on master due to https://bugs.launchpad.net/nova/+bug/1742935 the revert unblocking the gate is https://review.openstack.org/533190
14:19:15	openstack	Launchpad bug 1742935 in OpenStack Compute (nova) "TestServiceUpdateNotificationSample fails intermittently: u'host2' != u'host1': path: root.payload.nova_object.data.host " [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)
14:21:53	mriedem	gibi: +W
14:24:30	gibi	mriedem: thank
14:24:45	gibi	mriedem: where do we store the functional test job definition? is it in the nova tree?
14:27:09	ildikov	mriedem: updated the multi-attach api patch to microversion 2.60
14:30:34	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Fix comments in get_all_with_shared() https://review.openstack.org/533195
14:35:50	gibi	mriedem: nvm, I found it https://github.com/openstack-infra/openstack-zuul-jobs/blob/21241aec13dd3d8eae2916518a5ad8933509a512/zuul.d/jobs.yaml#L352
14:38:46	mriedem	gibi: that's the global one, there might be an override in project-config
14:39:27	mriedem	gibi: https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L10600
14:39:37	mriedem	that's the nova-specific blacklist
14:40:22	gibi	mriedem: thanks, so we have to fix this line https://github.com/openstack-infra/project-config/blob/5017c2ba472bd0439392f037036dbf198e00c137/zuul.d/projects.yaml#L10604
14:40:48	mriedem	ok - don't forget the gate queue definition for the same
14:40:49	gibi	mriedem: hm, no
14:41:03	mriedem	https://github.com/openstack-infra/project-config/blob/5017c2ba472bd0439392f037036dbf198e00c137/zuul.d/projects.yaml#L10797
14:41:14	mriedem	ildikov: thanks
14:42:26	gibi	mriedem: these definitions looks correct, according to this the doc/notification_samples
14:42:42	gibi	mriedem: should trigger the functional test
14:43:47	mriedem	gibi: the parent override maybe? https://github.com/openstack-infra/openstack-zuul-jobs/blob/21241aec13dd3d8eae2916518a5ad8933509a512/zuul.d/jobs.yaml#L361
14:44:16	mriedem	i would think the one in project-config overrides the definition in the openstack-zuul-jobs repo though
14:44:20	mriedem	you'd have to ask in infra
14:44:29	gibi	OK, i will do that
14:53:55	mriedem	need another core on the bottom 2 novaclient patches here for 2.57 and 2.58 https://review.openstack.org/#/c/528128/
14:57:43	bauzas	mriedem: I was just about +Wing the 2.58 :-)
14:58:52	mriedem	bauzas: don't let me distract you
14:58:54	mriedem	ildikov: looky here logs.openstack.org/89/532689/1/experimental/nova-multiattach/720b3d4/
14:58:59	mriedem	http://logs.openstack.org/89/532689/1/experimental/nova-multiattach/720b3d4/
14:59:01	mriedem	finally ran
14:59:04	mriedem	stvnoyes: ^
14:59:18	bauzas	mriedem: the 2.58 is far quickier to review than the big 2.57
14:59:27	mriedem	yeah i know 2.57 wasn't fun
14:59:29	mriedem	wasn't fun to write it
14:59:47	ildikov	mriedem: I saw \o/ :)
14:59:49	mriedem	that's why it took me a year to do the file injection deprecation patch
14:59:56	stvnoyes	cool. working on the swap test now
15:01:21	mriedem	actually, weird, it ran a really small set of tempest tests http://logs.openstack.org/89/532689/1/experimental/nova-multiattach/720b3d4/job-output.txt.gz#_2018-01-12_03_10_33_860455
15:03:43	cdent	fried_rice: I'm more available now
15:04:06	fried_rice	cdent Trying to understand how urgent proper generation management is.
15:05:00	openstackgerrit	Andreas Jaeger proposed openstack/nova master: DNM: Test trigger openstack-tox-functional https://review.openstack.org/533202
15:05:12	fried_rice	cdent If we can't hit placement API calls for the same provider from multiple threads, not urgent at all.

Earlier   Later