Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-01-11
19:43:28 sean-k-mooney mriedem: sorry i ment to say upperconstriats not minium version
19:43:37 mriedem u-c bumps are automatic
19:43:46 mriedem g-r bumps are when some consumer needs to rely on the changes
19:44:06 mriedem and presumably we're doing this work so something can use it
19:44:56 sean-k-mooney its used by os-vif itself it allow use to not use process exec to create port and insted use the openvswitch python libs
19:45:17 mriedem sean-k-mooney: ok, but that's not a super high priority is it?
19:45:22 mriedem at this point in queens i think that's a bit risky
19:45:29 mriedem and would be better deferred to an early release in rocky
19:46:33 sean-k-mooney its just a nice to have yes so it we branched today and did a release it would not break anything
19:47:07 mriedem has claudiub seen this? https://review.openstack.org/#/c/487405/
19:47:16 mriedem i think the hyperv driver is using os-vif so how are they not blowing up?
19:47:49 sean-k-mooney the code that is pertected by the if would not fail if the if was removed so it does not explode
19:48:52 sean-k-mooney that said checking if an interface exists via a file exits check under sys on windows is not exactly well fucntional
19:49:20 mriedem the other 2 things in https://review.openstack.org/#/q/status:open+project:openstack/os-vif+branch:master+topic:bug/1672812 are not really something we need to get released
19:49:24 mriedem the testing related patches i mean
19:49:40 mriedem so i'm going to push an os-vif release today, and if something else gets in afteward before next thursday, bauzas or someone can propose a release
19:50:00 sean-k-mooney mriedem: ok that sound fine to me
19:50:18 sean-k-mooney as i said they are just nice to have not required
19:50:37 mriedem sean-k-mooney: kit me up when rocky rolls around and we can push for the native ovs ones
19:50:39 mriedem *hit me up
19:51:46 sean-k-mooney sure. we are keeping support for process exec and not enableing it by default anyway. we had push out makeing that change to S instead.
19:52:13 sean-k-mooney has a name been chosen for S yet by the way
20:07:05 mriedem squish
20:07:47 mriedem shizer?
20:10:22 bauzas mriedem: sylvain :p
20:10:31 mriedem there is nothing german about that
20:10:35 mriedem shizer it is
20:11:28 bauzas schnauze :p
20:12:09 bauzas mriedem: question for https://review.openstack.org/#/c/528128/7/novaclient/exceptions.py
20:12:12 bauzas mriedem: why ?
20:12:45 mriedem because if you do six.text_type(ex) you don't get the message from the exception
20:13:29 bauzas interesting to know
20:13:35 mriedem https://review.openstack.org/#/c/528128/7/novaclient/tests/unit/v2/test_servers.py@1640
20:13:40 mriedem if you remove it, that stuff blows up
20:13:42 dansmith bauzas: if we name it that, people will be pronouncing it wrong for a long time
20:14:19 bauzas I know :p
20:22:57 sean-k-mooney like meltdown and specter im sure marketing will prevent any name being chossen that would not be family frendly
20:23:26 sean-k-mooney or well are inside/techy jokes
20:25:42 bauzas dansmith: got a sec ?
20:25:48 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP libvirt: QEMU native LUKS decryption for volumes https://review.openstack.org/523958
20:25:52 dansmith bauzas: finishing an email, but then yes
20:25:57 bauzas dansmith: cool
20:26:32 bauzas dansmith: that's just about the libvirt issue about regenerating a wrong XML because missing allocs
20:26:35 bauzas so take your time
20:27:07 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094
20:27:24 efried Could one of y'all please re+W https://review.openstack.org/#/c/521686/ (auto rebase)
20:28:25 bauzas efried: .
20:28:37 efried bauzas Merci bien.
20:32:22 mriedem stvnoyes: on those tempest patches, when you push the changes, you need to use git review -R
20:32:29 mriedem you pulled my approved changes out of the gate
20:32:52 mriedem stvnoyes: i thought you were going to push a separate patch on top of https://review.openstack.org/#/c/266605/ ? not add to it.
20:33:17 stvnoyes hmm cr*p. what's the best way to undo that?
20:33:55 stvnoyes i can submit a new change that pulls it out...
20:34:10 claudiub mriedem: so, at the moment, hyperv-neutron-agent is still used in the CI. But i've fetched that patch and instances still spawn when using OVS.
20:34:21 mriedem stvnoyes: too late now
20:34:31 mriedem well too late for the git review -R
20:34:38 mriedem stvnoyes: you could just put the resize test on top in a different change
20:34:41 mriedem just don't git commit --amend
20:35:20 stvnoyes just to be clear, on top, you mean by using depends on?
20:35:35 mriedem no
20:35:40 mriedem stack the changes like i've done in that series
20:35:49 mriedem you don't need depends-on within the same repo
20:36:13 mriedem so just remove the resize test from the top patch, then commit it into a new change at the top of the series,
20:36:14 sean-k-mooney claudiub: ya the way os-vif is written it should work with or without the patch but it annoys me that it works just because we happened ot make the functions not fail if there preconditions were violated
20:36:19 mriedem and then git review -R -y
20:36:24 stvnoyes ok
20:36:51 mriedem if you need to go back within the series to change something, you do an interactive rebase (git rebase -i HEAD~4) or whatever
20:39:44 efried git restack is your friend
20:40:00 efried Well, *my* friend, anyway.
20:40:13 sean-k-mooney efried: git restack?
20:41:00 sean-k-mooney i use git rebase -i often but never heard of git restack
20:41:01 efried sean-k-mooney It rolls up rebase -i and some of the other paperwork associated with managing a big series.
20:41:24 efried sean-k-mooney I think it was developed by stackers. Separate plugin. pip install git-restack (I think)
20:41:36 sean-k-mooney https://github.com/openstack-infra/git-restack so yes
20:41:56 sean-k-mooney git review is also an infra tool
20:42:16 efried no kidding, really? TIL
20:42:40 efried Was using that long before I got involved with openstack.
20:42:43 sean-k-mooney yep https://github.com/openstack-infra/git-review
20:44:17 sean-k-mooney efried: stephenfin: also intoduced me to gerrithub.io which allows you to add gerrit to any github project so you can use the openstack/gerrit workflow with it insteadk of pull requests
20:44:41 efried oooooooo
20:44:44 bauzas I don't like git restack
20:44:51 bauzas I prefer the old but clean way
20:45:12 efried Would you like it better if it was git restaque?
20:45:16 bauzas because something you can be messed up in a long series and then git reflog is your friend
20:45:52 dansmith bauzas: you never started talking
20:46:07 bauzas dansmith: I was holding my breath till your email :p
20:46:08 dansmith bauzas: I was expecting you to start asking your question and I'd get to it when I was done
20:46:18 dansmith bauzas: but then I got distracted with no ping :)
20:46:23 bauzas my bad, misunderstanding
20:46:24 dansmith anyway, shoot
20:46:26 bauzas so
20:47:13 bauzas dansmith: in case you don't know yet, we're attaching a mdev device based on the allocation
20:47:22 bauzas that works fine
20:47:57 bauzas but the issue we have is that there are a shit ton of other methods that rebuild that guest XML, and those don't have the allocations passed yet
20:48:20 dansmith 1.0 shit tons?\
20:49:25 bauzas I mean, spawn() is calling it, but also for example hard_reboot
20:49:52 bauzas which itself is called by power_on()...
20:49:53 bauzas https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2658
20:49:54 dansmith yeah, I get it
20:50:30 bauzas so, I tested on my node, and indeed, if you stop/start your instance, you're not missing the mdev

Earlier   Later