| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-09 | |||
| 20:25:33 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 20:25:44 | ildikov | mriedem: ^^ | |
| 20:26:12 | mriedem | rybridges: yes | |
| 20:26:20 | mriedem | that's my understanding, nova doesn't inject something into the image | |
| 20:26:25 | openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094 | |
| 20:33:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | |
| 20:33:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | |
| 20:33:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add index(updated_at) on migrations table. https://review.openstack.org/531132 | |
| 20:34:08 | mriedem | dansmith: i addressed the 2 addressable comments in the migration multi-cell lister patch ^ | |
| 20:38:09 | rybridges | ok thanks mriedem | |
| 20:38:34 | mriedem | rybridges: https://www.sebastien-han.fr/blog/2015/02/09/openstack-perform-consistent-snapshots-with-qemu-guest-agent/ ? | |
| 20:38:42 | mriedem | old blog but probably still good | |
| 20:41:15 | mriedem | stvnoyes: finally got that snapshot test passing http://logs.openstack.org/86/531386/7/check/tempest-full/eca51c5/job-output.txt.gz#_2018-01-09_19_34_20_731609 | |
| 20:41:17 | mriedem | but failed in teardown | |
| 20:41:38 | mriedem | http://logs.openstack.org/86/531386/7/check/tempest-full/eca51c5/job-output.txt.gz#_2018-01-09_20_01_02_052268 | |
| 20:41:41 | mriedem | hmm, failed to delete the volume, | |
| 20:42:20 | stvnoyes | i never like it when problems happen in teardown... | |
| 20:42:25 | mriedem | but the test is explicitly deleting the volume and cascading it's snapshot delete https://review.openstack.org/#/c/266605/24/tempest/api/compute/volumes/test_attach_volume.py@417 | |
| 20:42:36 | mriedem | smcginnis: does the volume cascading delete stuff work? | |
| 20:42:52 | smcginnis | mriedem: Why do I feel like this is a trick question? | |
| 20:43:27 | mriedem | maybe i don't know what's possible, but, | |
| 20:43:38 | mriedem | i create a volume-backed instance and create a snapshot of it, which also creates a snapshot of the volume, | |
| 20:43:57 | mriedem | at the end of the test, i do a delete volume with cascade=True so i don't have to explicitly delete the volume snapshot | |
| 20:44:05 | mriedem | assuming that's OK? | |
| 20:44:37 | smcginnis | mriedem: So from Cinders perspective that's just a volume with a snapshot. So yeah, that should work if you pass cascade=True and it should delete any child snapshots on volume deletion. | |
| 20:45:30 | mriedem | weird, don't even see the error in the c-api logs | |
| 20:45:37 | mriedem | oh here we go | |
| 20:46:45 | mriedem | damn c-api log doesn't really tell me anything | |
| 20:47:24 | mriedem | OH | |
| 20:47:25 | mriedem | i see | |
| 20:47:31 | mriedem | INFO cinder.api.openstack.wsgi [None req-57d5906a-2c27-4546-8fbd-21d355fd886d tempest-AttachVolumeMultiAttachTest-336010326 tempest-AttachVolumeMultiAttachTest-336010326] https://10.0.1.221/volume/v3/1e7533c90d794cf8a7463d9a7473244e/volumes/42c444d7-4b3a-42f0-a2d6-3fe652814e05?cascade=True returned with HTTP 202 | |
| 20:47:39 | mriedem | that's the one i'm doing and it's a 202 | |
| 20:47:51 | mriedem | INFO cinder.api.openstack.wsgi [None req-4afc5bd6-64cd-444b-9d7f-51e87a67c0e4 tempest-AttachVolumeMultiAttachTest-336010326 tempest-AttachVolumeMultiAttachTest-336010326] https://10.0.1.221/volume/v3/1e7533c90d794cf8a7463d9a7473244e/volumes/42c444d7-4b3a-42f0-a2d6-3fe652814e05 returned with HTTP 400 | |
| 20:48:01 | mriedem | that's the one that tempest teardown is doing becaues i'm not waiting for my call to complete | |
| 20:48:02 | mriedem | drats | |
| 20:48:30 | smcginnis | Oh, so it's trying to delete the volume without cascade while your call is still cleaning up? | |
| 20:48:52 | mriedem | yeah | |
| 20:48:55 | mriedem | i just need to add a waiter | |
| 20:49:01 | mriedem | easy peasy | |
| 20:49:31 | mriedem | ildikov: i don't know why but your api update says it's in merge conflict | |
| 20:50:09 | ildikov | mriedem: maybe because the shared_targets patch didn't get through the gate due to zuul issues or smth? | |
| 20:50:52 | ildikov | mriedem: I didn't want to rebase until that's merged... | |
| 20:51:01 | mriedem | yeah that's fine, i'm going to update this tempest patch | |
| 20:51:57 | ildikov | I only changed the top patch and downloaded the whole chain fresh before | |
| 20:52:09 | ildikov | I will check on zuul and see where things are | |
| 20:57:13 | mriedem | 5: (529695,5) Use volume shared_targets to lock during attach/detach (8h17m/++++~+~++++/rem:1h56m) | |
| 20:57:29 | mriedem | #5 in the gate so should be merged soonish | |
| 20:57:56 | mriedem | it's only been there for 8.5 hours already.. | |
| 21:00:25 | mriedem | ildikov: ok i guess i'll start working on adding tests for the new flows when the microversion is high enough and multiattach is True | |
| 21:02:49 | ildikov | mriedem: ok, I'm not touching the chain then | |
| 21:03:04 | ildikov | mriedem: the unit and functional tests are fixed in the latest version | |
| 21:03:10 | ildikov | at least it worked for me... | |
| 21:14:10 | mriedem | mdbooth: damn, i ran that isolated test thing, 178 tests in my worker list to comb through :( | |
| 21:14:20 | mriedem | the bisect analyzer couldn't figure it out | |
| 21:15:45 | mriedem | although, i guess the idea is you can continue to wittle the results down with the smaller set of tests each time | |
| 21:23:40 | openstackgerrit | Merged openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | |
| 21:33:43 | openstackgerrit | Merged openstack/nova master: Use volume shared_targets to lock during attach/detach https://review.openstack.org/529695 | |
| 21:38:20 | openstackgerrit | Hongbin Lu proposed openstack/nova master: placement: add API reference for create inventory https://review.openstack.org/511342 | |
| 21:42:28 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | |
| 21:42:50 | edleafe | mriedem: ^^ addressed your concerns, and then some | |
| 22:14:52 | openstackgerrit | Merged openstack/nova stable/pike: doc: Add configuration index page https://review.openstack.org/531042 | |
| 22:16:12 | openstackgerrit | Merged openstack/nova stable/pike: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/526468 | |
| 22:26:39 | openstackgerrit | Merged openstack/nova stable/pike: Add missing unit tests for FilterScheduler._get_all_host_states https://review.openstack.org/529625 | |
| 22:43:46 | openstackgerrit | melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381 | |
| 22:43:46 | openstackgerrit | melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414 | |
| 22:43:47 | openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | |
| 22:54:18 | SamYaple | which scheduler filter is responsible for the cpu overallocation/ratio filtering? | |
| 22:56:14 | mriedem | SamYaple: CoreFilter | |
| 22:56:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | |
| 22:56:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244 | |
| 22:56:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 22:56:40 | mriedem | if you're ocata+, we filter VCPUs in placement when using the FilterScheduler, thus making the CoreFilter not necessary | |
| 22:56:43 | SamYaple | mriedem: was that aroundin mitaka? | |
| 22:56:51 | mriedem | was what around mitaka? | |
| 22:56:54 | mriedem | placement was ocata | |
| 22:57:00 | SamYaple | no sorry, itc lag | |
| 22:57:08 | mriedem | CoreFilter has been around awhile yes | |
| 22:57:11 | SamYaple | the corefilter, thats been around since before mitaka, yes | |
| 22:57:13 | SamYaple | cool | |
| 22:57:18 | SamYaple | sorry just looking at https://github.com/openstack/nova/blob/mitaka-eol/nova/conf/scheduler.py#L126 | |
| 22:57:31 | mriedem | yeah the CoreFilter was never a default filter for some reason | |
| 22:57:43 | SamYaple | didnt see it listed and we were removing the retryfilter and now its overcommitting vcpus | |
| 22:58:07 | SamYaple | we added the corefilter intothe copied list and it started filtering likeit should | |
| 22:58:14 | SamYaple | was just tryingto trackdown the disconnect | |
| 22:58:19 | mriedem | ildikov: a rebase and https://review.openstack.org/#/c/271047/51/nova/tests/unit/api/openstack/compute/test_serversV21.py is as far as i got; was trying to get that libvirt test that was race failing to pass, but couldn't after over an hour | |
| 22:59:16 | mriedem | rechecking the tempest test patch and calling it a day | |
| 23:00:22 | mriedem | dansmith: yes i hacked up that comment pretty bad :) | |
| 23:00:22 | ildikov | mriedem: sounds good enough, thanks! | |
| 23:00:29 | dansmith | mriedem: :P | |
| 23:00:37 | mriedem | will put a fix on top tomorrow | |
| 23:01:02 | ildikov | mriedem: I will look into it tomorrow too | |
| 23:09:33 | openstackgerrit | Merged openstack/nova stable/pike: Fix an error in _get_host_states when deleting a compute node https://review.openstack.org/529626 | |
| #openstack-nova - 2018-01-10 | |||
| 00:59:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix comment in MigrationSortContext https://review.openstack.org/532368 | |
| 01:01:23 | mriedem | alex_xu: need another reviewer on https://review.openstack.org/#/c/330406/ - we have +2s on the 2 changes below it | |
| 01:11:20 | mriedem | efried: i think you're wrong about https://bugs.launchpad.net/nova/+bug/1742311 | |
| 01:11:22 | openstack | Launchpad bug 1742311 in OpenStack Compute (nova) "AttributeError in report client error path" [Undecided,Invalid] | |
| 01:11:24 | mriedem | because https://github.com/requests/requests/blob/v2.18.4/requests/models.py#L663 | |
| 01:25:27 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | |
| 02:09:38 | alex_xu | mriedem: got it, will get it done today | |
| 02:31:24 | gmann | alex_xu: if you can check this simple one,we can close the BP - https://review.openstack.org/#/c/531061/ | |