| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-08 | |||
| 16:52:12 | mriedem | thanks | |
| 16:52:20 | lyarwood | mdbooth: yeah context down to _get_guest_storage_config and then merge the encryptor stuff into _connect/disconnect_volume | |
| 16:52:42 | mdbooth | lyarwood: And *remove* it from _create_domain_and_network | |
| 16:53:02 | mdbooth | We can already be confident that nothing is relying on that to do volume connection, because it never has | |
| 16:53:11 | lyarwood | mdbooth: in one change? | |
| 16:53:34 | mdbooth | Was just thinking about that. I don't see why not. | |
| 16:53:50 | lyarwood | mdbooth: k, I'll reuse the refactor change | |
| 16:53:50 | mdbooth | You might want the swap_volume patch first, though | |
| 16:53:54 | mdbooth | And lxc | |
| 16:54:02 | mdbooth | My WIP above? | |
| 16:54:04 | lyarwood | ah true | |
| 16:54:11 | lyarwood | mdbooth: no my original | |
| 16:54:14 | mdbooth | If you're going to take it I'll just abandon that | |
| 16:54:17 | ktibi | mdbooth nothing in neutron-server.log :/ 0warning 0 error | |
| 16:54:21 | mdbooth | kk, cool | |
| 16:55:07 | ktibi | oups sorrty for mriedem | |
| 16:58:43 | mriedem | jaypipes: interested if adding an index is worth it for this https://review.openstack.org/#/c/531132/3/nova/db/sqlalchemy/migrate_repo/versions/376_add_migrations_updated_at_index.py - it's adding an index for listing migrations and filtering on updated_at (--changes-since); the query could have other columns/filters in it, so not sure if the index really helps or not | |
| 16:59:16 | jaypipes | mriedem: soon as I'm done with two other series reviews, will review. | |
| 16:59:20 | mriedem | although my guess is if you just did "nova migration-list --changes-since x" it would help | |
| 17:06:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | |
| 17:06:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | |
| 17:06:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | |
| 17:06:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add index(updated_at) on migrations table. https://review.openstack.org/531132 | |
| 17:06:51 | stephenfin | ralonsoh: Can we merge [1], given that [2] isn't working yet? [1] https://review.openstack.org/#/c/484386/ [2] https://review.openstack.org/#/c/530961/ | |
| 17:08:27 | mriedem | dtantsur: re: CI testing for ironic+bfv https://review.openstack.org/#/c/468353/ - is there at least an existing job that ironic uses for this? if so, we can add that to nova's experimental queue | |
| 17:09:46 | dtantsur | mriedem: yep ironic-tempest-dsvm-bfv | |
| 17:14:07 | dtantsur | wanna me propose a patch? | |
| 17:14:14 | efried | jaypipes (and another core, maybe stephenfin or bauzas?) would you please add https://review.openstack.org/#/c/518633/ to your list? The patch above that is already +W, and it'll be nice to have for your nrp test case (https://review.openstack.org/#/c/531443/) | |
| 17:14:50 | stephenfin | efried: Won't get to it myself today, but if it's still there tomorrow then I'll take a shot | |
| 17:14:57 | efried | stephenfin Thanks | |
| 17:15:15 | mriedem | dtantsur: sure | |
| 17:15:40 | mriedem | efried: i'll take a look | |
| 17:15:48 | efried | mriedem Thanks. | |
| 17:20:47 | ralonsoh | stephenfin: sorry for the delay. [2] is working now | |
| 17:20:50 | ralonsoh | stephenfin: openstack-tox-functional-with-sudoSUCCESS in 4m 00s | |
| 17:21:07 | stephenfin | ralonsoh: Oh, congrats! Nice work | |
| 17:21:10 | ralonsoh | stephenfin: Am I missing something? | |
| 17:21:15 | ralonsoh | stephenfin: oooook! | |
| 17:21:33 | ralonsoh | stephenfin: Sean's magic.... you know | |
| 17:21:41 | stephenfin | Oh, I know :) | |
| 17:21:55 | stephenfin | Cool. I'll review that tomorrow morning so | |
| 17:22:03 | ralonsoh | stephenfin: thanks! | |
| 17:22:08 | stephenfin | np | |
| 17:25:41 | jaypipes | efried: just finishing up a review on that, yes. | |
| 17:29:01 | jaypipes | efried: done | |
| 17:29:15 | EmilienM | mriedem: hey matt, I remember we had a thread about how to handles patches like https://review.openstack.org/531055 - I don't recall the outcome, do you have the link of the thread? | |
| 17:31:02 | openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | |
| 17:31:40 | mriedem | EmilienM: the eventual outcome was the first contact SIG | |
| 17:31:57 | EmilienM | ok | |
| 17:32:00 | mriedem | https://wiki.openstack.org/wiki/First_Contact_SIG | |
| 17:32:50 | mriedem | and http://superuser.openstack.org/articles/sig-first-contact-openstack/ | |
| 17:32:54 | mriedem | i guess point them at that? | |
| 17:33:05 | EmilienM | mriedem: ok, thx | |
| 17:33:10 | mriedem | should probably build something into the first-time contributor comment that people get on their patch too | |
| 17:33:15 | EmilienM | mwhahaha: ^ | |
| 17:33:49 | EmilienM | the thing is I'm not sure this is a new contributor: https://review.openstack.org/#/q/owner:shangxiaobj%2540inspur.com+status:merged | |
| 17:34:11 | EmilienM | the person is doing http to https a lot and it waste so much CI resources imho | |
| 17:34:18 | mriedem | yeah they aren't, | |
| 17:34:27 | mriedem | i'd probably ping huang zhipeng (howard) | |
| 17:34:38 | mriedem | he's in china and on the first contact sig group | |
| 17:35:12 | mriedem | i think a bunch of these contributors from chinese companies actually hang out in a wechat group for openstack, | |
| 17:35:28 | mriedem | so he sometimes proxies stuff to that group where people are actually listening (and speaking the same language) | |
| 17:35:34 | EmilienM | mriedem: ok thx for the advises | |
| 17:35:51 | mriedem | yw | |
| 17:42:52 | jaypipes | tox -efast8 would be fast if it didn't try to reinstall all the global requirements each time I run it. | |
| 17:43:20 | mriedem | it shouldn't try to re-install them | |
| 17:43:29 | mriedem | pip + wheels should have all of that cached | |
| 17:43:40 | mriedem | plus your existing venv would have them | |
| 17:45:56 | openstackgerrit | Merged openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | |
| 17:50:39 | mriedem | efried: so i got looking at https://review.openstack.org/#/c/509892/ again, | |
| 17:50:54 | mriedem | and didn't realize it until now but we never leverage the session client stuff in neutronclient | |
| 17:50:58 | mriedem | https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L251 | |
| 17:51:49 | mriedem | oh nvm i guess that checks for a session kwarg https://github.com/openstack/python-neutronclient/blob/master/neutronclient/client.py#L389 | |
| 17:51:54 | mriedem | confusing method name | |
| 17:52:06 | jaypipes | mriedem: still takes 10+ seconds to run the "develop-inst-nodeps" part of the job :( | |
| 17:53:23 | jaypipes | mriedem: which I presume is just comparing pip freeze outputs? | |
| 17:53:32 | mriedem | no idea | |
| 17:54:16 | dtantsur | jaypipes: also downloads upper-constraint, if it's a typical job | |
| 17:54:24 | jaypipes | :) | |
| 17:56:58 | mriedem | probably an easy +W on efried's neutronclient change to use the ksa adapter stuff https://review.openstack.org/#/c/509892/ | |
| 17:58:38 | dtantsur | mriedem: oh, you guys haven't switched to in-tree zuul stuff, have you? | |
| 17:59:01 | mriedem | dtantsur: started to | |
| 17:59:06 | mriedem | but not much there yet | |
| 17:59:18 | mriedem | actually nothing until https://review.openstack.org/#/c/514309/ | |
| 17:59:19 | dtantsur | I see. so any changes still go to project-config? | |
| 17:59:25 | mriedem | dtantsur: yeah | |
| 17:59:32 | mriedem | unless you want to build it on top of https://review.openstack.org/#/c/514309/ | |
| 17:59:59 | mriedem | melwitt: you want to get https://review.openstack.org/#/c/514309/ since you've looked at the zuulv3 in-repo stuff before? | |
| 18:00:42 | dtantsur | lemme see what is easier | |
| 18:01:26 | mriedem | stvnoyes: an update on multiattach testing - i added some more tests over the weekend to https://review.openstack.org/#/c/266605/ - the list multiple attachments one and boot from volume one are passing ( https://review.openstack.org/#/c/531386/ ) - the snapshot one is failing, looks like due to some response validation in tempest that doesn't handle 2.59 | |
| 18:02:56 | stvnoyes | mreidem- ok thanks for the update. I am running into a m-a attach failure when attaching to the second instance. debugging that now. | |
| 18:03:15 | mriedem | stvnoyes: with libvirt 3.10? | |
| 18:03:48 | stvnoyes | no, with 3.6 | |
| 18:03:56 | mriedem | what version of qemu? | |
| 18:04:40 | stvnoyes | 2.8 | |
| 18:04:51 | mriedem | hmm | |
| 18:05:07 | mriedem | i'm getting things to work with lvm as the backend, and qemu 2.5 and libvirt 3.6 | |
| 18:05:10 | stvnoyes | may just be that I am missing a patch. I am running it down now | |
| 18:05:36 | stvnoyes | this had been working for me before | |
| 18:08:10 | dtantsur | mriedem: https://review.openstack.org/#/c/531868/ should do it. do you remember if Depends-On project-config changes works? | |