Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-01-05
15:55:35 johnthetubaguy mriedem: there is a type there s/scheduler service as down/compute service as down/
15:55:36 fried_rice leakypipes cdent Good deal. I can see both sides. I don't mind the idea of having intra-nova placement work funneled through this spot for the reasons stated (thread safety, code commonality) as long as we're not doing it with the expectation that e.g. OOT drivers have to conform.
15:55:59 fried_rice sean-k-mooney So where are you going to get that request info from? Just directly from the flavor?
15:56:29 mriedem finucannot: replied
15:56:48 mriedem finucannot: we could backport that to stable/pike upstream, but no further given ocata g-r requires glanceclient>=2.5
15:56:57 mriedem johnthetubaguy: yup i noticed that too
15:57:07 mriedem johnthetubaguy: i'm going to remove the deprecated names for that option, so i'll fix the typo at the same time
15:57:11 leakypipes fried_rice: well, it's Python so of course OOT drivers can always do whatever they want with things ;) but that said, yes, I'd prefer to have the virt drivers just update the ProviderTree object and rely on something else (the reportclient called from the resource tracker most likely) do the work of making placement REST API calls.
15:57:21 finucannot mriedem: Ta
15:57:26 johnthetubaguy mriedem: sweet, thank you
15:57:27 sean-k-mooney fried_rice: of course when i try to do that perhaps ill discovery why mriedem thinks ill what to stabs ye lol. am the requst for the port is encode by the new vnic type + neutron port bining profile info for mdev_type if needed.
15:59:29 fried_rice sean-k-mooney IMO what you're doing here is closer to what should be happening long term. It would be nice if the scheduler and resource tracker could accept requests for resources, allocate them via placement, and pass those allocations through to virt without introspecting or special-casing them at all.
15:59:54 mriedem johnthetubaguy: actually, a bit confused
16:00:18 mriedem johnthetubaguy: it says, "This is because the scheduler driver is responsible for sending a heartbeat and it will only do that as often as this option allows."
16:00:18 fried_rice sean-k-mooney I.e. compute code outside of virt doesn't need to care if a resource is a CPU, GPU, mdev (whatever that is), or peanut.
16:00:29 mriedem johnthetubaguy: i don't see how the compute service down time and the scheduler periodic task interval are linke
16:00:30 mriedem *linked
16:00:53 mriedem sean-k-mooney: you will get stabby because of the constant spelling corrections
16:01:13 mriedem like, "spell knife in the kidneys!"
16:01:58 fried_rice Oh, did I do that? Not consciously.
16:02:05 sean-k-mooney fried_rice: yes i had hopped to work on this as part of the nova neutron negociation stuff in queens and the multiple port binding before we change from upstream first to more poc/internal focoused.
16:03:16 sean-k-mooney mriedem: haha i would have taught i would be the other way round. jay has very kindly help me with this area over the past few years and im very greatful for that.
16:03:35 openstackgerrit Ed Leafe proposed openstack/nova master: Add functional test for resize reschedules https://review.openstack.org/531022
16:03:35 openstackgerrit Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
16:03:36 openstackgerrit Ed Leafe proposed openstack/nova master: Add regression test for resizing failing during retries https://review.openstack.org/531405
16:03:54 figleaf mriedem: ^^ added regression test and fix
16:04:09 mriedem cool
16:04:12 leakypipes sean-k-mooney: you would have *thought*.
16:04:16 leakypipes sean-k-mooney: you're welcome.
16:04:28 sean-k-mooney leakypipes: :)
16:04:39 leakypipes sean-k-mooney: also... it's *grateful", not greatful. you're welcome, too.
16:04:49 leakypipes sean-k-mooney: :P
16:05:43 kashyap mriedem: Hope you recorded your observation about raw & the shareable thing in the multi-attach review
16:06:00 openstackgerrit melanie witt proposed openstack/nova stable/pike: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot https://review.openstack.org/531407
16:06:01 kashyap Currently, I'm in split-brains mode, and trying to finishing something before the 'cache is flushed
16:06:43 mriedem kashyap: i did, and it was just something i should have realized wouldn't apply here earlier on
16:06:47 mriedem since imagebackend != volumes
16:08:03 mriedem johnthetubaguy: oh i think i see,
16:08:20 figleaf fried_rice: sorry, missed your question earlier - network issues.
16:08:20 mriedem the ComputeFilter is running every 60 seconds due to the caching scheduler's periodic task interval,
16:08:31 mriedem which means it's potentially using a stale version of the compute service reference,
16:08:33 figleaf fried_rice: mriedem answered what I would have said, so no worries
16:08:36 johnthetubaguy mriedem: sorry, yeah, that's it
16:08:38 mriedem which means it's last_seen_up would be old
16:08:42 johnthetubaguy mriedem: yeah
16:09:22 johnthetubaguy mriedem: hence the note about it not seeing instances being deleted, and being really bad if you run two schedulers
16:09:53 mriedem heh
16:10:03 leakypipes johnthetubaguy: make checks payable to fried_rice.
16:10:04 mriedem if you're wondering why i'm asking https://review.openstack.org/#/c/531020/
16:10:26 Roamer` johnthetubaguy, did you catch my earlier messages about your procedural -2 on https://review.openstack.org/140733/? or am I being annoying already? :)
16:10:27 mriedem people are still using the cachingscheduler but we don't really test it functionally anywhere, so i'm trying to flush out some squirrels
16:11:13 leakypipes totally off-topic, but why does gerrit allow someone to hit a "quote" button on a review comment that is on a source file but won't provide a "quote" button to respond to a review comment that is on the review (not a source file)...
16:11:50 johnthetubaguy Roamer: ah, sorry, I missed those, was visiting a customer this morning
16:12:31 melwitt leakypipes: there's a button but it doesn't say "quote". it's a curved arrow next to the comment timestamp
16:12:33 mriedem Roamer`: you should probably be talking to me - i haven't been tracking that blueprint for nova in queens at all
16:12:41 johnthetubaguy mriedem: I don't think this once has been re-approved: https://blueprints.launchpad.net/nova/+spec/libvirt-storpool-volume-attach
16:12:51 mriedem Roamer`: where is the patch that adds the storpool driver to cinder?
16:13:03 leakypipes melwitt: well, holy crap.
16:13:08 mriedem johnthetubaguy: yeah, because i didn't know about it until now and we're <2 weeks from FF
16:13:09 mriedem :)
16:13:11 leakypipes melwitt: I thought that was to close the comment...
16:13:26 Roamer` mriedem, yeah, actually things happened 1. a bit suddenly at the start of December, and then 2. a bit slower than we expected with getting our CI system running, so our timing is a bit less than impeccable
16:13:52 mriedem Roamer`: you also need an os-brick release
16:13:52 Roamer` mriedem, https://review.openstack.org/#/c/220155/ is Cinder and https://review.openstack.org/#/c/192639/ is os-brick
16:14:24 leakypipes melwitt: heh, and the more you click the button, the more gerrit repeats the comment in the reply box. fun!
16:14:40 melwitt leakypipes: hah, awesome
16:15:17 Roamer` mriedem, and, yeah, my last comment to 140733 was "oof, yeah, Zuul cannot pass without an os-brick release"
16:15:38 mriedem the unit tests are also all failing
16:15:56 Roamer` yep, since our driver refers to initiator.STORPOOL
16:16:16 Roamer` I could make it pass the "storpool" literal string, then it might fail in a slightly different way somewhat further
16:16:26 Roamer` but I think that since os-brick has the constants, it'd be best to use them
16:17:13 sean-k-mooney leakypipes: did you not tell me once you used gertty mainly for reviews or has the new mac forced you to the web in protest.
16:17:31 openstackgerrit Merged openstack/nova master: conf: hyperv: fix a comment typo https://review.openstack.org/531329
16:17:57 Roamer` mriedem, to make it clear: yes, the unit tests are also failing because the released version of os-brick doesn't know about the StorPool driver... if I patch it manually within the tox venv, the tests pass
16:19:00 mriedem Roamer`: so you need an os-brick release and a bump to the required minimum version of os-brick in global-requirements in the openstack/requirements repo,
16:19:06 mriedem non-client library freeze is jan 18
16:19:13 mriedem nova feature freeze is jan 25
16:19:13 leakypipes sean-k-mooney: I don't use the Mac for anything other than Verizon Slack and email. I use gertty as well but also use the Gerrit web UI just as much nowadays now that the whole "comment on this and the whole page goes haywire" bug was solved by mriedem.
16:19:42 mriedem s/mriedem/smcginnis/
16:19:48 Roamer` mriedem, so you're saying that if I bother the os-brick folks enough, there might be a chance? Thanks!
16:20:18 mriedem Roamer`: i'm not terribly keen on approving a nova blueprint 1 week before feature freeze
16:20:32 mriedem since it's a libvirt volume driver, it might get an exception
16:20:32 sean-k-mooney leakypipes: wait that has been fixed?
16:20:41 mriedem Roamer`: but the ducks need to be in a row first
16:20:54 Roamer` mriedem, okay, thanks a lot! I'll be on my way to bother others now
16:21:37 Roamer` hmm, does this mean that, at least for the next couple of days, it might be a good idea for johnthetubaguy to remove his procedural -2, or shall we think about that only if we do get our ducks in a row first?
16:23:29 leakypipes cdent: answered :)
16:23:40 cdent thanks
16:24:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove the deprecated scheduler_driver_task_period option https://review.openstack.org/531413
16:24:12 mriedem johnthetubaguy: see how that wording sounds ^
16:24:18 mriedem Roamer`: it's fine for johnthetubaguy to remove his -2
16:24:25 mriedem we can replace it with mine :)
16:24:55 openstackgerrit Merged openstack/nova master: Remove a duplicate line in a unit test https://review.openstack.org/531317
16:24:57 Roamer` :)
16:25:26 leakypipes sean-k-mooney: yeah. go into your profile -> settings -> diff preferences and set Render to "Slow"
16:25:45 leakypipes mriedem: is that right? ^
16:26:03 mriedem yup
16:28:12 leakypipes cdent: great questions, btw
16:28:48 cdent thanks, I'll try to make some more, by monday's meeting we can have a grand chat
16:29:26 sean-k-mooney leakypipes: mriedem awsome that bug was painful.

Earlier   Later