| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-03 | |||
| 20:58:56 | mriedem | edleafe: i can see that being true in the reschedule case, | |
| 20:59:12 | edleafe | exactly | |
| 20:59:16 | mriedem | because on the 2nd loop through conductor, the source node allocation will be held by the migration uuid and the first chosen and failed host is owned by the instance | |
| 20:59:33 | edleafe | (I forgot to mention that I'm working on functional tests for reschedules | |
| 20:59:50 | mriedem | ah - i was going to start working on a functional test this afternoon but got sidetracked with cinder | |
| 21:00:12 | mriedem | edleafe: so, we should (1) report a bug for the thing and (2) fix it separately before your alternate hosts patch for resize i think | |
| 21:00:17 | edleafe | I've been working on it, but it took a while to track down exactly why they were all failing | |
| 21:00:22 | mriedem | i was going to push the functional test before your alternate hosts patch in the series | |
| 21:00:39 | mriedem | yeah we need the functional resize + reschedule test regardless of alternate hosts | |
| 21:00:47 | mriedem | because it would have caught this earlier | |
| 21:00:55 | edleafe | makes sense | |
| 21:00:59 | mriedem | cool | |
| 21:01:23 | edleafe | so have you started on it? Should I wait and rebase on top of yours? | |
| 21:01:28 | mriedem | i haven't started | |
| 21:01:50 | mriedem | so feel free to report the regression bug and push a patch in nova/tests/functional/regressions | |
| 21:01:53 | mriedem | for that bug | |
| 21:02:06 | edleafe | ok, I can do it. I only have a little time left today, thanks to IBM adding a 2-hour each way commute to my schedule | |
| 21:02:24 | mriedem | how about report the bug and push what you have for the test | |
| 21:02:39 | mriedem | can work on a fix and such tomorrow | |
| 21:02:41 | edleafe | ok, I can do that. | |
| 21:02:44 | mriedem | thanks | |
| 21:05:38 | mriedem | i should probably start thinking about an rc1 bugs etherpad... | |
| 21:20:04 | openstackgerrit | Hongbin Lu proposed openstack/nova master: Handle not found error on taking snapshot https://review.openstack.org/511074 | |
| 21:26:02 | edleafe | mriedem: https://bugs.launchpad.net/nova/+bug/1741125 | |
| 21:26:03 | openstack | Launchpad bug 1741125 in OpenStack Compute (nova) "Instance resize always fails when rescheduling" [High,New] - Assigned to Ed Leafe (ed-leafe) | |
| 21:27:11 | mriedem | thanks; resize in general is probably just broken for the CachingScheduler | |
| 21:31:31 | mriedem | dansmith: we probably can't error out here https://github.com/openstack/nova/blob/f95f165b49fbc0efe29450b0e858a3ccadecedea/nova/conductor/tasks/migrate.py#L47-L48 | |
| 21:32:01 | mriedem | we won't have allocations if you're using the caching scheduler | |
| 21:32:35 | dansmith | hrm | |
| 21:33:27 | dansmith | and not create them either? that'll kinda screw with all the downstream logic for confirm/delete/undo-swap | |
| 21:33:29 | edleafe | if we do check, we should check against the instance or the migration | |
| 21:33:53 | mriedem | dansmith: compute won't create them once everything is pike+ | |
| 21:34:44 | dansmith | that's not what I meant, | |
| 21:35:00 | dansmith | but I guess we can't create the new allocations (on the dest) if we don't have some to copy from the source | |
| 21:35:03 | mriedem | edleafe: i think we can handle the logic in the conductor task based on whether or not we know we're doing a reschedule | |
| 21:35:41 | mriedem | edleafe: in the case of a reschedule, we'd swap the allocation from desthost1 to desthost2 for the migration uuid | |
| 21:35:51 | mriedem | and just leave the instance uuid allocation on the source node | |
| 21:36:34 | mriedem | not really a swap, just an update to the allocations for the migration consumer | |
| 21:37:29 | edleafe | yeah, I knew what you meant | |
| 21:39:16 | dansmith | reschedule of a migration is changing the instance uuid's allocation though not the migration one | |
| 21:39:45 | mriedem | oh right yeah, got those mixed up | |
| 21:39:55 | mriedem | migration stays on the source node, instance goes to the eventual dest host | |
| 21:40:01 | dansmith | so just need to update the instance's allocation for the new node | |
| 21:40:03 | dansmith | right | |
| 21:41:08 | melwitt | mriedem: what did you mean by your comment here? https://review.openstack.org/#/c/481700/7/nova/db/sqlalchemy/api.py@1867 update what, model_query? | |
| 21:42:43 | mriedem | the comment | |
| 21:42:51 | melwitt | oh, k | |
| 21:42:57 | mriedem | there is no 'deleted' in 'tags' or 'consoleauthtoken' tables | |
| 21:43:10 | melwitt | thanks | |
| 21:47:59 | mriedem | stvnoyes: got further on the multiattach tempest test; it appears to be failing to create the 2nd attachment | |
| 21:52:09 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | |
| 21:52:10 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add functional test for resize reschedules https://review.openstack.org/531022 | |
| 21:52:14 | edleafe | mriedem: ^^ resize reschedule func test | |
| 21:52:27 | mriedem | ok | |
| 21:58:37 | rybridges | Hey Guys! Had a really quick question. Is ephemeral GB included in snapshots for VMs? | |
| 22:58:16 | clarkb | I am pretty sure only the root device is snapshotted | |
| 22:58:27 | clarkb | (but I'm saying that as a user of random clouds not a nova dev that would know for sure) | |
| 23:19:36 | openstackgerrit | Merged openstack/nova master: Add test for assignment of uuid to a deleted BDM https://review.openstack.org/530774 | |
| 23:19:42 | openstackgerrit | Merged openstack/nova master: Add support for listing hosts in cellv2 https://review.openstack.org/524755 | |
| 23:20:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | |
| 23:20:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 23:26:38 | mriedem | stvnoyes: running the test again based on these changes to the libvirt patch ^ | |
| #openstack-nova - 2018-01-04 | |||
| 00:23:10 | mriedem | nailed it http://logs.openstack.org/67/529867/1/check/tempest-full/23d2919/controller/logs/screen-n-sch.txt.gz#_Dec_22_18_14_13_693048 | |
| 00:23:34 | mriedem | jaypipes: could you have guessed the stats / num_instances / host_state.instances stuff could have all gotten screwy? | |
| 00:26:58 | jaypipes | mriedem: not surprised. | |
| 00:31:00 | mriedem | heh "Reported number of instances (0) does not match the tracked number of instances (3)." | |
| 00:31:03 | mriedem | not even close | |
| 00:38:44 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: doc: Add configuration index page https://review.openstack.org/531042 | |
| 00:54:21 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.59 - List/Show all server migration types https://review.openstack.org/430839 | |
| 01:02:45 | mriedem | will need someone more familiar with ironic to triage this https://bugs.launchpad.net/nova/+bug/1730834 | |
| 01:02:46 | openstack | Launchpad bug 1730834 in OpenStack Compute (nova) "Ironic compute node doesn't take over nodes with instance when the owner compute node is down" [Undecided,New] | |
| 01:02:59 | mriedem | i don't know what "take over" means here | |
| 01:03:35 | jroll | mriedem: that's expected behavior | |
| 01:03:57 | jroll | 'take over' meaning have another compute service manage the instance, because the hash ring thing | |
| 01:04:37 | jroll | we should make that better so it isn't expected behavior, but low priority I guess | |
| 01:04:43 | mriedem | oh | |
| 01:04:44 | mriedem | well then | |
| 01:07:00 | jroll | oh, I can't set importance ¯\_(ツ)_/¯ | |
| 01:15:56 | mriedem | join the bug team | |
| 01:15:58 | mriedem | should be able to then | |
| 01:17:25 | jroll | idk, you might make me do stuff | |
| 01:26:51 | bjhuangr | mriedem, hi, do you have a chance to review https://review.openstack.org/#/c/523387/ ? Thanks in advance . | |
| 01:33:37 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631 | |
| 01:33:38 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451 | |
| 01:33:38 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049 | |
| 02:20:58 | mriedem | kashyap: could use some help with this if you get a chance https://review.openstack.org/#/c/267587/75/nova/virt/libvirt/guest.py - trying to get multiattach working which used to be ok before qemu 2.10 but now we hit issues with a write lock when attaching the volume to the 2nd guest, and i thought we could pass the force flag to the attach device call to libvirt but i got this error: | |
| 02:21:04 | mriedem | libvirtError: unsupported flags (0x4) in function qemuDomainAttachDeviceLiveAndConfig | |
| 02:25:11 | Kevin_Zheng | seems Nova is broken after add uuid to BDM | |
| 02:25:16 | Kevin_Zheng | due to https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L497 | |
| 02:25:31 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Simplify logic in get_enforcer https://review.openstack.org/531008 | |
| 02:25:48 | Kevin_Zheng | the field could not be added to cell1 db | |
| 02:27:05 | mriedem | Kevin_Zheng: that nova-manage code is really old | |
| 02:27:17 | mriedem | if the bdm uuid change broke that, we should have seen it in CI | |
| 02:27:19 | mriedem | since devstack runs this | |
| 02:27:38 | mriedem | the cell1 sync happens here https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L513 | |
| 02:27:45 | mriedem | after running the schema migrations for cell0 | |
| 02:28:46 | Kevin_Zheng | Hmm, but my db didn't got updated | |
| 02:28:53 | mriedem | is your nova.conf correct? | |
| 02:30:34 | Kevin_Zheng | I will check, but I have been using this for sometime, it should be correct. | |
| 02:32:11 | Kevin_Zheng | Hmm... in config file for api service, the database connection should be cell0 db, correct? | |