Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-12-21
06:04:10 Rambo .Could you please review it? https://review.openstack.org/#/c/528740/
06:07:24 openstackgerrit Chen Hanxiao proposed openstack/nova master: libvirt: implement NotImplementedError for _set_quiesced https://review.openstack.org/529278
06:14:49 openstackgerrit Mr Rambo proposed openstack/nova master: Fix the problems that volume-backed server rebuild https://review.openstack.org/528740
06:34:34 openstackgerrit Merged openstack/nova master: trivial: conf: libvirt: fix a typo https://review.openstack.org/529229
06:41:14 openstackgerrit Merged openstack/nova master: [placement] Separate API schemas (allocation) https://review.openstack.org/528630
07:09:24 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795
07:21:55 ameeda Hello, Can you please review my code here https://review.openstack.org/#/c/528385/ ?
07:29:03 openstackgerrit Chen Hanxiao proposed openstack/nova master: libvirt: validate SCSI controller model https://review.openstack.org/525055
08:13:02 ameeda Can you please review my code here https://review.openstack.org/#/c/526900/ ?
08:23:29 openstackgerrit xhzhf proposed openstack/nova master: [cellv2] performance issue when querying compute nodes in a cell https://review.openstack.org/529504
08:47:16 tetsuro sahid: I have updated this document revision patch about cpu topology on qemu TCG https://review.openstack.org/#/c/529294/
08:59:15 sahid tetsuro: oh, thanks a lot. I will see that :)
09:15:00 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Clean up foreign key before root resource provider deleting https://review.openstack.org/529519
09:16:28 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520
09:32:06 bauzas good morning Nova
10:28:10 openstackgerrit Ilya Shakhat proposed openstack/nova master: Initialize osprofiler in WSGI application https://review.openstack.org/519664
10:31:49 stephenfin Not sure who's about between now and new year, but I'd appreciate some eyes on this series to get it over the line https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/websocket-proxy-to-host-security
10:32:02 stephenfin It's been ongoing since 2013. Would be great to get the damn thing finished, heh
10:44:49 openstackgerrit Chen Hanxiao proposed openstack/nova master: InstanceInfo: store more runtime information of instance https://review.openstack.org/526348
10:53:16 openstackgerrit Chen Hanxiao proposed openstack/nova master: libvirt: validate SCSI controller model https://review.openstack.org/525055
11:08:16 openstackgerrit Alex Xu proposed openstack/nova master: Remove the LoadedExtensionInfo object https://review.openstack.org/529207
11:08:16 openstackgerrit Alex Xu proposed openstack/nova master: Merge ResourceV21 obj into Resource obj https://review.openstack.org/529217
11:08:17 openstackgerrit Alex Xu proposed openstack/nova master: Remove the inherits parameter for the Resource object https://review.openstack.org/529218
11:09:01 alex_xu oomichi: ^ thanks for the review, just updated
11:35:03 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Fix error when deleting any root resource provider https://review.openstack.org/529519
11:41:10 openstackgerrit xhzhf proposed openstack/nova master: [cellv2] performance issue when querying compute nodes in a cell https://review.openstack.org/529504
11:47:03 openstackgerrit Matthew Booth proposed openstack/nova master: Removed unused argument from LibvirtDriver._connect_volume https://review.openstack.org/529556
11:47:44 mdbooth lyarwood: Cleanup related to our earlier discussion ^^^
11:49:32 lyarwood mdbooth: ack nice!
11:50:20 lyarwood mdbooth: I wonder if we can do the same with disk_dev on _disconnect_volume
11:50:49 mdbooth lyarwood: Don't. I've been actively trying to limit the quantity of ocean I'm boiling lately.
11:52:00 mdbooth Cleanup as you go is a wonderful concept which I fully support, but in practice it seems to be where my patch series end up getting buried.
11:52:33 lyarwood meh, I'll do this as a standalone, if it lands great :)
11:53:08 mdbooth I wanted to do ^^^ because disk_info is relevant to my other series.
11:53:25 mdbooth I may actually incorporate it in there, as it probably reduces some test noise.
11:53:47 lyarwood kk
11:56:42 mdbooth lyarwood: FWIW, looks like disk_dev can also be removed. It's only used for logging.
11:57:01 mdbooth And the log messages aren't really required given the context.
11:57:16 mdbooth Meh, I'll do it anyway as I have it open
11:57:40 lyarwood wonderful
11:59:11 mdbooth lyarwood: Remind me, can connection_info contain secrets?
12:00:29 lyarwood mdbooth: yeah I think so
12:00:47 mdbooth I'd have thought so. I'll just confirm.
12:11:17 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls https://review.openstack.org/460243
12:12:46 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Introduce disk encryption config classes https://review.openstack.org/464008
12:13:56 lyarwood stephenfin: sorry, was about to do that, just respinning the refactor one final time
12:14:25 stephenfin lyarwood: No problem :) I didn't realize you'd pushed a new revision
12:14:32 stephenfin Comments on said revision incoming though
12:14:43 lyarwood stephenfin: thanks
12:16:26 stephenfin lyarwood: and done
12:17:11 lyarwood stephenfin: cheers, yeah that's why I was respinning
12:17:23 stephenfin :) Cool
12:19:45 openstackgerrit Matthew Booth proposed openstack/nova master: Fix unit test failures when direct IO not supported https://review.openstack.org/529568
12:20:20 mdbooth If we can get ^^^ in sharpish that would be awesome. It's really annoying.
12:21:13 stephenfin mdbooth: (y)
12:23:41 stephenfin mdbooth: Regarding the preceding patch, do you know if we support out-of-tree volume drivers? https://review.openstack.org/#/c/529556/
12:24:51 stephenfin Also, the one you linked could probably be rebased onto master to get it in sooner. No dependency that I can see
12:27:14 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls https://review.openstack.org/460243
12:27:42 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: remove pagesize from __init__ of InstanceNUMATopology https://review.openstack.org/485553
12:27:43 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: remove related pinning from __init__ of InstanceNUMATopology https://review.openstack.org/485554
12:27:43 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: remove cpuset_reserved from __init__ of InstanceNUMATopology https://review.openstack.org/466030
12:29:14 openstackgerrit Stephen Finucane proposed openstack/nova master: setup.cfg: Explicitly set [build_sphinx] builders https://review.openstack.org/508483
12:32:53 kashyap lyarwood: On this - https://review.openstack.org/#/c/464008/1/nova/virt/libvirt/config.py. Did you forget to add the comment describing the relation b/n classes & tags?
12:33:24 kashyap In response to Andrew Volkov's comments
12:35:08 openstackgerrit Stephen Finucane proposed openstack/nova master: Convert floating IP tests to ddt https://review.openstack.org/471360
12:36:58 lyarwood kashyap: I did, I'm not sure if it's really required tbh
12:40:36 kashyap lyarwood: Yeah, it's fine for me
13:05:56 openstackgerrit Merged openstack/nova master: Pass bdms to versioned notifications during finish_revert_resize https://review.openstack.org/527446
13:15:03 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Use correct response type in tests https://review.openstack.org/527182
13:15:13 openstackgerrit Stephen Finucane proposed openstack/nova master: Handle images with no data https://review.openstack.org/526329
13:16:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove dead parameter from '_create_domain_and_network' https://review.openstack.org/512352
13:19:58 jaypipes stephenfin: lol, sorry about the force=True thing...
13:20:13 jaypipes stephenfin: just goes to show the importance of kwargs ;)
13:20:27 stephenfin jaypipes: I'll be honest, you had me doubting myself :D
13:20:51 jaypipes stephenfin: well, sorry about that. :) but it was not obvious...
13:21:17 stephenfin No no, it's fine. Turned out the parameter wasn't necessary anyway
13:21:23 stephenfin So something good came out of it
13:23:01 stephenfin Think you might have called this one wrong too ;) https://review.openstack.org/#/c/527472/7/nova/pci/stats.py@265
13:23:27 jaypipes stephenfin: still looking at that one...
13:23:50 jaypipes stephenfin: you're probably right. I'm just getting old. but I still want to look into that further.
13:24:52 stephenfin jaypipes: Sounds good to me. I can rework in any case if it makes it a little easier to parse
13:25:29 mdbooth Waiting for my unit tests to run is the pythonistas waiting for a compile
13:25:51 jaypipes indeed
13:26:43 mdbooth Unfortunately I don't have a foosball table
13:28:54 openstackgerrit Matthew Booth proposed openstack/nova master: Fix unit test failures when direct IO not supported https://review.openstack.org/529568
13:28:54 openstackgerrit Matthew Booth proposed openstack/nova master: Removed unused argument from LibvirtDriver._connect_volume https://review.openstack.org/529556
13:28:55 openstackgerrit Matthew Booth proposed openstack/nova master: Remove unused argument from LibvirtDriver._disconnect_volume https://review.openstack.org/529585
13:29:06 mdbooth I blame lyarwood ^^^
13:32:08 jaypipes stephenfin: to be honest, the whole stats.py module makes me want to throw up a bit in my mouth.
13:32:11 kashyap mdbooth: Removing cruft is good. Thank you
13:32:24 openstackgerrit Lee Yarwood proposed openstack/nova master: conf: Do not inherit image signature props with snapshots https://review.openstack.org/527046
13:32:57 mdbooth kashyap: There's also also a lesson above in how a misunderstanding in one bit of code can be copied around and mutate.
13:33:00 stephenfin jaypipes: Agreed. The docstrings are a start. Next steps is a big de-dupe
13:33:18 stephenfin But I wasn't mixing that in here. Would like it to get in before the new year :)
13:33:20 kashyap mdbooth: Yeah, /me nods
13:34:56 stephenfin jaypipes: Is the move to resource providers going to get swept up in efried's generic device thing'y or is it separate? If latter, dibs
13:37:04 jaypipes stephenfin: the generic device manager ideas revolve around using the ProviderTree for managing PCI (and other) devices just like any other resource provider (like a compute node for VCPU/MEMORY_MB or a pGPU group for VGPU resources). the idea is to get rid of the whole PciDevicePoolList (stats) object entirely.
13:37:45 jaypipes stephenfin: and the generic device manager would *only* gather inventory and do the binding with the guest. it wouldn't do anything with scheduling/placement logic
13:38:22 stephenfin Right-o, that's what I suspected. So we need to do the reporting aspect and then build upon that to use what's been reported?
13:42:59 jaypipes stephenfin: not entirely sure what you mean by "build upon that to use what's been reported"

Earlier   Later