| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-15 | |||
| 14:35:49 | bauzas | artom: of course, denormalized works | |
| 14:36:06 | bauzas | mriedem: FWIW https://stackoverflow.com/questions/3516290/any-pitfalls-of-converting-mysql-text-field-to-mediumtext | |
| 14:36:25 | bauzas | only a client possible impact about memory usage | |
| 14:36:26 | bauzas | but meh | |
| 14:36:55 | giblet | maciejjozefczyk: left a small nit in https://review.openstack.org/#/c/520024 . Ping me when you fixed it and I will +2 the patch | |
| 14:37:31 | maciejjozefczyk | giblet: ok :) thanks | |
| 14:38:44 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: update_cell allows more than once cell to have the same db/transport url https://review.openstack.org/518556 | |
| 14:41:01 | openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899 | |
| 14:41:44 | bauzas | artom: mriedem: +Wd with a comment | |
| 14:43:07 | mriedem | ack thanks | |
| 14:43:27 | mriedem | bauzas: so before i even think about backports and releasing this in stable branches, | |
| 14:43:59 | mriedem | let me know now before i do that what kind of freakouts your internal deployment team is going to have if it's released with the wrong version | |
| 14:44:20 | mriedem | i'm assuming they want a minor version update | |
| 14:44:23 | mriedem | so 16.1.0 for pike | |
| 14:47:13 | lyarwood | mriedem: I don't see why they would have issues with this as a release or minor bump tbh | |
| 14:47:15 | bauzas | mriedem: good point | |
| 14:47:48 | bauzas | a DB alter is at least a minor change, not a .z | |
| 14:47:56 | bauzas | but I think it's acceptable for us | |
| 14:49:25 | openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024 | |
| 14:49:58 | maciejjozefczyk | giblet: ping :) you're right | |
| 14:50:03 | maciejjozefczyk | giblet: updated | |
| 14:50:09 | giblet | maciejjozefczyk: looking... | |
| 14:53:16 | artom | bauzas, lyarwood, so dansmith was saying that we can release it as a .z, and people who don't know about it won't do the db sync | |
| 14:53:28 | giblet | maciejjozefczyk: thanks, +2 | |
| 14:53:42 | artom | And they'll get the migration on their next major upgrade like everyone else | |
| 14:54:03 | artom | But people who are affected will have one more step in their .z upgrade path | |
| 14:54:07 | maciejjozefczyk | giblet: thanks too ;) | |
| 14:54:09 | lyarwood | artom: right, the NVR really doesn't change that for us, but it's still a minor release bump change as bauzas highlighted. | |
| 14:55:04 | artom | lyarwood, ah, I see | |
| 14:55:30 | artom | In any case, it's not like our deployment tooling/packaging does 'db sync' on yum update, so I think we're good | |
| 14:55:56 | lyarwood | artom: yup indeed | |
| 14:59:28 | mriedem | so after your red hat meeting, what have you agreed the rest of us must do? | |
| 14:59:31 | mriedem | minor bump? | |
| 14:59:51 | artom | Well, we'd like a interpretative-dance-off | |
| 14:59:58 | artom | But we'll settle for minor bump | |
| 15:00:03 | mriedem | i seem to remember the rdo / rhosp tooling used to do a full db sync on a minor update or something | |
| 15:00:28 | mriedem | idk, but last time we backported something like this and i didn't use the proper semver scheme i got in trouble | |
| 15:00:54 | mriedem | from frank in L3 RHOSP QE | |
| 15:01:06 | bauzas | mriedem: it's just the fact we don't package by numbering with semversioning | |
| 15:01:18 | bauzas | I know, it's sad | |
| 15:09:37 | mriedem | andreykurilin_: seems we should deprecate get_resource_manager_extra_kwargs within novaclient | |
| 15:09:52 | mriedem | used to call hooks to get extra boot kwargs to pass to POST /servers | |
| 15:10:10 | mriedem | which is likely broken since 2.1 in the server | |
| 15:10:55 | andreykurilin_ | mrieden: give me a sec to look what get_resource_manager_extra_kwargs is :) | |
| 15:13:24 | andreykurilin_ | mriedem: actually, not sure that it is broken. it looks like not used at all | |
| 15:13:31 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Add support for the 2.57 microversion https://review.openstack.org/528128 | |
| 15:13:54 | mriedem | andreykurilin_: i mean, if someone did have a hook and they passed extra arguments in the request body to POST /servers, | |
| 15:13:55 | mriedem | it would fail | |
| 15:14:03 | mriedem | because we have strict schema checking on the request body | |
| 15:14:45 | mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L59 | |
| 15:16:20 | andreykurilin_ | mriedem: yes. but get_resource_manager_extra_kwargs iterates over hooks which were added via add_resource_manager_extra_kwargs_hook. And I do not see any calls for that method. Since add_resource_manager_extra_kwargs_hook is documented as CLI helper, It should not be used outside the novaclient and I suppose we can just remove both of these methods without deprecation | |
| 15:17:09 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 15:18:17 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 15:19:01 | andreykurilin_ | mriedem: btw, https://review.openstack.org/#/c/424256 is waiting for your review ;) | |
| 15:19:22 | mriedem | ok | |
| 15:19:45 | mriedem | btw, single bed at the ptg hotel, it'll be like living in the dorms in college again | |
| 15:19:45 | mriedem | fun | |
| 15:20:04 | andreykurilin_ | lol | |
| 15:20:47 | leakypipes | mriedem: errr, no. | |
| 15:20:56 | mriedem | you don't miss those days? | |
| 15:21:01 | mriedem | shower caddy, flip flops? | |
| 15:21:14 | mriedem | rascals stealing your towel | |
| 15:21:49 | leakypipes | mriedem: as someone who went to boarding school with showers with no privacy... no. no, I don't. | |
| 15:22:07 | mriedem | we at least had curtains in the great shower room | |
| 15:23:16 | leakypipes | mriedem: no curtains for me. :( | |
| 15:23:31 | giblet | at some point we lost our dorm room door | |
| 15:23:32 | leakypipes | mriedem: four spigots in the ceiling. | |
| 15:23:32 | mriedem | leakypipes: oh well that's terrible | |
| 15:23:45 | mriedem | so gym class showers | |
| 15:23:47 | leakypipes | mriedem: thanks for the memories. | |
| 15:23:53 | mriedem | which went out of style in the late 80s i think | |
| 15:23:59 | leakypipes | mriedem: only not gym class... | |
| 15:24:03 | mriedem | heh | |
| 15:24:12 | mriedem | leakypipes: well, good effort out there today | |
| 15:24:20 | leakypipes | lmao | |
| 15:25:18 | andreykurilin_ | mriedem: returning to hooks. may I propose a patch? or you will do it yourself, so Vek and me will able to merge it? :) | |
| 15:25:47 | leakypipes | andreykurilin_: ty for changing the subject :) | |
| 15:25:58 | andreykurilin_ | ha | |
| 15:27:07 | andreykurilin_ | leakypipes: sorry, but such topic cannot be changed so quickly. Do you have any photos from your boarding school ? heh | |
| 15:27:59 | cdent | leakypipes: was that brit, yankee, or something else boarding school? | |
| 15:28:00 | leakypipes | andreykurilin_: yes :) you can see every room I lived in over four years in the movie: http://www.imdb.com/title/tt0097165/ | |
| 15:28:12 | leakypipes | cdent: yank | |
| 15:28:39 | cdent | thank you, that helps to distinguish the style of horrible abuse you experience | |
| 15:28:59 | leakypipes | heh | |
| 15:31:41 | leakypipes | andreykurilin_: btw, I'm not kidding. that really is the school I went to. | |
| 15:31:57 | leakypipes | andreykurilin_: it's not called the same name in the movie, but that's the school. | |
| 15:32:23 | leakypipes | andreykurilin_: in fact, three of my teachers from high school play parts in the movie :) | |
| 15:32:33 | leakypipes | I arrived the year after it was released. | |
| 15:33:20 | cfriesen | when shelving, do we preserve the contents of the ephemeral disk(s)? the code looks like it only snapshots the main image, but ephemeral disks are supposed to last the life of the server. | |
| 15:33:46 | mriedem | andreykurilin_: comments / questions in https://review.openstack.org/#/c/424256/ but looks pretty good | |
| 15:34:45 | mriedem | cfriesen: i doubt it | |
| 15:34:49 | cdent | aw, leakypipes, you are a youth | |
| 15:34:54 | mriedem | we snapshot the image and then delete the guest | |
| 15:34:56 | leakypipes | heh | |
| 15:35:23 | mriedem | andreykurilin_: go ahead on the hooks thing, i didn't dig into that very deep, just noticed it while doing something else | |
| 15:42:44 | andreykurilin_ | leakypipes: wow. cool | |
| 15:46:56 | leakypipes | figleaf: you can thank mriedem for that. | |
| 15:47:29 | mriedem | maciejjozefczyk: giblet: questions inline https://review.openstack.org/#/c/520024/ | |
| 15:47:36 | mriedem | and you probably want leakypipes to look at ^ as well | |
| 15:48:16 | vivsoni__ | mriedem: Hi | |