| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-13 | |||
| 09:49:43 | kashyap | Assuming you /others still have the appetite for it... :-) | |
| 09:49:49 | mdbooth | Using libvirt storage pools requires an on-disk change, because we don't layout our disks in a way that's easy to manage with storage pools. | |
| 09:50:21 | mdbooth | It's not specifically on my agenda right now. I rehash it from time to time (like this morning) when somebody else brings it up. | |
| 09:50:44 | mdbooth | I've done the work twice already. | |
| 09:53:30 | kashyap | Nod; thanks for the explanation. | |
| 10:03:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add PCI NUMA policy fields https://review.openstack.org/527470 | |
| 10:03:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Pass InstanceNUMATopology to consume_request https://review.openstack.org/527471 | |
| 10:03:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add PCI NUMA policies https://review.openstack.org/527472 | |
| 10:03:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs https://review.openstack.org/527473 | |
| 10:12:29 | openstackgerrit | Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | |
| 10:13:42 | openstackgerrit | Chason Chan proposed openstack/nova master: Fix the bug report link of API Guide https://review.openstack.org/527660 | |
| 10:32:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Move legacy jobs to project https://review.openstack.org/514309 | |
| 10:32:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Remove WSGI functional tests https://review.openstack.org/527140 | |
| 11:38:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove pagesize from __init__ of InstanceNUMATopology https://review.openstack.org/485553 | |
| 11:38:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove related pinning from __init__ of InstanceNUMATopology https://review.openstack.org/485554 | |
| 11:38:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove cpuset_reserved from __init__ of InstanceNUMATopology https://review.openstack.org/466030 | |
| 11:39:17 | stephenfin | dansmith: When you're about, could you take a punt at https://review.openstack.org/#/q/topic:bug/1636338 Guess you're best placed for them | |
| 11:39:40 | stephenfin | dansmith: Or stick em on your list for the new year. Either-or (they're just there a looong time) | |
| 11:43:10 | openstackgerrit | Li Xipeng proposed openstack/nova master: Fix bug case by none token context https://review.openstack.org/522112 | |
| 12:10:27 | openstackgerrit | Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399 | |
| 12:55:05 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Enable limiting GET /allocation_candidates https://review.openstack.org/513526 | |
| 12:58:41 | gmann | nova api meeting in 2 min.. | |
| 13:41:12 | openstackgerrit | Merged openstack/nova master: Re-use existing ComputeNode on ironic rebalance https://review.openstack.org/508555 | |
| 13:46:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 14:01:27 | openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: guest: introduce blockStats instead of domain.blockStats https://review.openstack.org/526833 | |
| 14:02:04 | cdent | edleafe: are you actually asking for changes on that commit message or just pointing out some potential changes if there's another version. On the random stuff I'm not sure that your version is more clear, at least not to me. | |
| 14:02:39 | edleafe | cdent: Well, you *did* push another version :) | |
| 14:03:10 | cdent | yeah, and totally forgot the commit message stuff because I was focused on the merge conflict (and forgot about your suggestions because no vote) | |
| 14:03:28 | edleafe | cdent: The random comment simply seemed to describe the implementation rather than the effect of changing the settings | |
| 14:04:32 | cdent | right, the commit message is for describing the implementation, the conf help and the reno are for describing why/how someone might use the conf setting | |
| 14:10:05 | mriedem | gibi: replied to your questions in https://review.openstack.org/#/c/507473/ | |
| 14:13:23 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: conf: libvirt: Cleanup CPU modelling related options https://review.openstack.org/527691 | |
| 14:16:44 | stephenfin | kashyap: Per ^, you'll probably like this https://review.openstack.org/#/c/526012/ | |
| 14:21:17 | kashyap | stephenfin: OCD: If you have to respin, please captialize the proper noun: s/nova/Nova/ :-) | |
| 14:21:44 | stephenfin | kashyap: Ahem https://docs.openstack.org/doc-contrib-guide/writing-style/openstack-components.html | |
| 14:21:53 | stephenfin | My OCD trumps yours | |
| 14:22:14 | kashyap | Haha | |
| 14:22:18 | gibi | mriedem: thanks for the answers, I'm +2 now | |
| 14:22:46 | kashyap | Okay, my brain just feels a twitch when a sentence starts with a smaller case letter. | |
| 14:22:54 | mriedem | gibi: cool. i'm going to update the nits in the last change in the series too just to get that going | |
| 14:23:17 | mnaser | mdbooth: thanks for the informative text. The more I look into this the more I see that it’s too much for me to bite to make that image backend change | |
| 14:24:18 | mdbooth | mnaser: Hopefully that's not true. I'd just say don't underestimate the size of the chunk :) | |
| 14:24:33 | mdbooth | And I completely agree with your initial conclusion. | |
| 14:25:10 | mnaser | mdbooth: the thing is we’re fairly pressed on time and a change like this would probably take a long time to get through | |
| 14:25:15 | kashyap | stephenfin: Nice Olso change in that; Zuul seems to complain for tox-py35, must've noticed it | |
| 14:25:19 | mdbooth | Oh, right. | |
| 14:25:29 | mdbooth | Yeah, this isn't going to be a quick fix. | |
| 14:25:43 | stephenfin | kashyap: I did indeed. I'll be fixing it shortly | |
| 14:25:45 | gibi | mriedem: hit me with the link when you are done and we can push the last patch through as well | |
| 14:26:09 | mnaser | Figuring out how to work with Glance and multiple locations seems far more feasable. I think. | |
| 14:26:10 | mdbooth | mnaser: Although, the current state of that code is the sum of a bunch of quick fixes... | |
| 14:26:13 | kashyap | stephenfin: Thanks for the fast +2 on that change! | |
| 14:26:17 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955 | |
| 14:26:43 | stephenfin | kashyap: np. Doc fixes like that easy-peasy | |
| 14:26:55 | mnaser | mdbooth: I think the huge challenge would be maintaining those two formats on disk | |
| 14:27:04 | mnaser | Essentially and possibly forever... | |
| 14:27:21 | mdbooth | Reliably, and maintainably | |
| 14:27:41 | mnaser | We can’t assume the instances which are cloned from local cache will eventually disappear because we’d block upgrades. | |
| 14:29:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add PCI NUMA policies https://review.openstack.org/527472 | |
| 14:29:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs https://review.openstack.org/527473 | |
| 14:29:30 | kashyap | stephenfin: I'll answer your question on the review | |
| 14:34:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Wait for live_migration_rollback.end notification https://review.openstack.org/527444 | |
| 14:35:10 | kashyap | stephenfin: Is it just me, or the rendered page looks like full of "alerts" with the red colour -- https://docs.openstack.org/nova/pike/configuration/config.html | |
| 14:35:27 | kashyap | The whole config page looks like an "exceptions" page | |
| 14:35:55 | stephenfin | kashyap: Are you referring to the titles of each options or the 'warning' admonitions? | |
| 14:36:17 | kashyap | The 'warning' admonitions, and every option enumerated in red color | |
| 14:36:47 | stephenfin | The warning options are warranted - we don't want people using those as they're deprecated | |
| 14:36:51 | kashyap | (Looking at that really messing with my briain :-) I'll just stick to looking at the code.) | |
| 14:36:56 | kashyap | The warnings are fine | |
| 14:37:07 | stephenfin | and we've been removing deprecated options at a decent clip, though it's low priority | |
| 14:37:15 | kashyap | But the options should be changed to 'lime green' or something saner | |
| 14:37:23 | stephenfin | The other stuff is the fault of openstackdocstheme, I'm afraid | |
| 14:37:40 | kashyap | Okido; no worries. | |
| 14:37:42 | stephenfin | I'm not sure what colour I _would_ use though, tbh | |
| 14:42:43 | mriedem | at some point i (or someone) should follow the pattern yikun has here for the 2.57 samples and do those for the 2.1 and 2.51 samples | |
| 14:42:51 | mriedem | and use real operations rather than fakes | |
| 14:43:08 | mriedem | i've always hated that we use fakes for the instance action api samples | |
| 14:46:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove dead parameter from '_create_domain_and_network' https://review.openstack.org/512352 | |
| 14:53:40 | gibi | mriedem: indeed it looks a lot cleaner now, I approved it | |
| 14:54:26 | mriedem | gibi: cool, thanks | |
| 14:54:28 | mriedem | one more down | |
| 15:04:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: see what else is doing useless migration context stuff https://review.openstack.org/471491 | |
| 15:07:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Change CONF.my_ip to be IPOpt https://review.openstack.org/498095 | |
| 15:14:16 | niraj_singh | efried_cya_jan: in cinder to nova interaction using service token. I am getting roles': [u'Member'], for service user in nova. | |
| 15:15:44 | niraj_singh | efried_cya_jan: I was logged in as admin. Is there anything need to do to assign role to service user. | |
| 15:17:04 | jaypipes | niraj_singh: Eric is out until January (thus his nick is efried_cya_jan) :) | |
| 15:17:23 | niraj_singh | ooh sorry | |
| 15:17:59 | jaypipes | niraj_singh: not a problem. you will likely need more roles than "Member" for the cinder service user. | |
| 15:19:21 | niraj_singh | jaypipes: can i assign role to service user explicitlely? | |
| 15:23:03 | jaypipes | niraj_singh: hmm, I *think* you should be able to do that, yes. via Keystone... | |
| 15:23:22 | jaypipes | niraj_singh: you'll want to restart the nova services after that, though, since the token will be cached in the Nova services. | |
| 15:23:55 | niraj_singh | jaypipes: ok. i will try this. | |
| 15:23:59 | niraj_singh | thanks | |
| 15:24:04 | dansmith | jaypipes: you gonna rev that patch that needs the comment added? | |
| 15:24:17 | dansmith | jaypipes: sounds like modulo those nits gibi and I are ready to send it to heaven | |
| 15:28:51 | mriedem | stephenfin: your comment in https://review.openstack.org/#/c/523919/ - i think the code your pointing at has nothing to do with what i'm removing in that patch | |
| 15:30:18 | stephenfin | mriedem: It's quite possible. The thing that put me onto that was that we _were_ storing 'self.extra_info' in the line you're removing, but once that's removed we don't appear to use it anywhere | |
| 15:30:35 | stephenfin | ergo, I figure the storing aspect should be removed to | |
| 15:30:49 | stephenfin | Maybe I missed something though. I'm looking at that commit you referenced now | |
| 15:31:08 | mriedem | stephenfin: it's called from PciDevice.create() https://review.openstack.org/#/c/523919/2/nova/objects/pci_device.py@234 | |