| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-12 | |||
| 13:41:04 | openstackgerrit | garyk proposed openstack/nova master: Conductor: ensure build cleanup works with cells https://review.openstack.org/526356 | |
| 13:54:12 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042 | |
| 14:09:19 | cdent | I rebase this a while ago, and thus it's on my radar. Seems a useful fix: https://review.openstack.org/#/c/389798/ | |
| 14:22:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate file injection https://review.openstack.org/522027 | |
| 14:36:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: conf: Do not inherit image signature props with snapshots https://review.openstack.org/527046 | |
| 14:51:43 | mriedem | oomichi_afk: can you take a look through this bp series starting here? https://review.openstack.org/#/c/524047/ | |
| 15:05:38 | cdent | jaypipes: big +1 on your recent "need to fully isolate" comment in email | |
| 15:06:02 | jaypipes | cdent: oh, you mean the MANO/NFVO environment? | |
| 15:06:10 | cdent | ya | |
| 15:06:17 | jaypipes | cdent: ya. | |
| 15:06:45 | cdent | couple more ya yas and we've got a song | |
| 15:08:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: add note about fixing admin-only APIs without a microversion https://review.openstack.org/527421 | |
| 15:11:14 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Re-use existing ComputeNode on ironic rebalance https://review.openstack.org/527423 | |
| 15:23:46 | mriedem | lyarwood: heads up - we have a 2 bug fixes for newton still before EOL - they are just waiting on review for their ocata counterparts https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton | |
| 15:24:04 | mriedem | the master and pike changes have all merged | |
| 15:24:30 | lyarwood | mriedem: ack, planning to spend some time on stable later today | |
| 15:24:51 | mriedem | ok those guys are probably highest priority now so we can eol newton | |
| 15:25:00 | lyarwood | kk | |
| 15:25:08 | mriedem | kind of surprised tony hasn't yelled at me yet | |
| 15:28:41 | mriedem | melwitt: this fixes an issue with the new volume attachment flow that is blocking trove CI https://review.openstack.org/#/c/527228/ - i'm going to work on beefing up test coverage in tempest since we missed this | |
| 15:28:48 | mriedem | we == me | |
| 15:36:43 | jaypipes | cdent: reviewed. | |
| 15:38:03 | cdent | thanks jay, I think I didn't make the comment in the about why inventories clear enough, will fix that when I fix the rest of it | |
| 15:38:20 | jaypipes | cdent: so you meant inventories and not allocation candidates? | |
| 15:38:33 | cdent | basic gist is: inventories doesn't do the optimization of _avoiding_ checking last modified | |
| 15:38:40 | jaypipes | cdent: cuz alloc candidates is the one you always set to current time... | |
| 15:38:43 | cdent | when the want_version is too low | |
| 15:38:45 | jaypipes | ah | |
| 15:38:47 | jaypipes | k | |
| 15:38:55 | jaypipes | either way, that wasn't the -1 cause :) | |
| 15:39:03 | cdent | yeah, I gathered that | |
| 15:39:15 | jaypipes | just the gabbit microversion dance :) | |
| 15:47:12 | smatzek | mriedem: I've gotten pretty close to root cause of Trove's other volume related gate breakage. As I suspected yesterday it's not really related to rebuild even though that's the main Nova call Trove is doing there. It looks like a behavior change in regular volume attach. Details documented in bug https://bugs.launchpad.net/nova/+bug/1737779 | |
| 15:47:13 | openstack | Launchpad bug 1737779 in OpenStack Compute (nova) "Volume attach sets mountpoint as /dev/na in Cinder attachment" [Undecided,New] | |
| 15:48:24 | cdent | jaypipes: I responded on the AttributeError question, I think it's right as is. | |
| 15:48:41 | jaypipes | ack | |
| 15:51:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Stabilize test_live_migration_abort func test https://review.openstack.org/527440 | |
| 15:51:38 | ildikov | smatzek: thanks for the detailed bug report! | |
| 15:53:52 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add cache headers to placement api requests https://review.openstack.org/521640 | |
| 15:53:52 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add info about last-modified to contrib docs https://review.openstack.org/526084 | |
| 15:54:25 | cdent | jaypipes: with luck that ^ gets it. The expected follow to do the unit tests Takashi asked for is on my list for this week. | |
| 15:55:26 | mriedem | ildikov: smatzek: i wonder if that's what this was for https://review.openstack.org/#/c/525787/3/nova/virt/block_device.py@448 ? | |
| 15:56:20 | jaypipes | cdent: k. | |
| 15:56:40 | mriedem | smatzek: i'll push a patch to add that back in so we can see if trove ci is happy with it | |
| 15:57:01 | mriedem | smatzek: is this recreatable in trove ci or are you testing it manually? | |
| 15:57:18 | smatzek | trove CI. | |
| 15:57:23 | mriedem | ok good | |
| 15:57:46 | ildikov | mriedem: yeah, that would make a lot of sense | |
| 15:59:00 | ildikov | mriedem: I thought we didn't remove that finally, mistake on my side | |
| 15:59:33 | smatzek | is the connector an object or a dict? | |
| 15:59:46 | mriedem | smatzek: dict | |
| 16:00:09 | smatzek | on the cinder side it's doing a .get('mountpoint') on the connector, so I'm not sure mount_device in the connector on the Nova side would help unless there is some key translation | |
| 16:01:46 | jaypipes | cdent: +W | |
| 16:01:51 | melwitt | mriedem: ack, will take a look | |
| 16:01:55 | cdent | jaypipes: rad | |
| 16:02:06 | cdent | only one more microversion conflict to go! | |
| 16:03:15 | jaypipes | cdent: :) | |
| 16:03:24 | jaypipes | cdent: I know the feeling very well. | |
| 16:03:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Wait for live_migration_rollback.start notification https://review.openstack.org/527444 | |
| 16:07:46 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass bdms to versioned notifications during finish_revert_resize https://review.openstack.org/527446 | |
| 16:08:49 | mriedem | smatzek: where are you seeing that in the cinder code? | |
| 16:09:05 | smatzek | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L4396 | |
| 16:10:01 | mriedem | ok that makes sense - with the old flow, we'd pass mountpoint to the os-attach API | |
| 16:10:10 | mriedem | and it looks like attachment_update needs the same thing | |
| 16:10:44 | mriedem | eh which sucks now because i have to handle attachment_update in multiple places | |
| 16:13:21 | ildikov | mriedem: can't we handle that centrally somehow? | |
| 16:14:16 | mriedem | i plan on adding a mountpoint kwarg to the attachment_update method and passing in self['mount_device'] from the DriverVolumeBlockDevice code (normal attach, bfv) and from the resize code | |
| 16:14:26 | mriedem | from the resize code, the mountpoint is i think just the bdm.device_name | |
| 16:15:03 | ildikov | mriedem: how did it work with the old flow? | |
| 16:15:24 | mriedem | but...the 'mount_device' in the driver block device code is after the blockinfo stuff has massaged the device_name, so i'm not sure if they will actually be the same thing | |
| 16:15:46 | mriedem | with the old flow, during resize, we didn't call attach again | |
| 16:16:22 | jaypipes | dansmith, mriedem: do we not have any functional tests for db schema migrations against MySQL in the gate? | |
| 16:16:50 | mriedem | jaypipes: the walk_migrations tests should run through mysql and postgresql | |
| 16:16:55 | mriedem | in the python unit test jobs | |
| 16:17:01 | jaypipes | that's what I thought too... | |
| 16:17:20 | ildikov | mriedem: ah ok, we passed it in the volume_api.attach() call | |
| 16:17:29 | mriedem | http://logs.openstack.org/87/525787/4/check/openstack-tox-py27/5a1b999/job-output.txt.gz#_2017-12-08_14_36_36_831356 | |
| 16:17:31 | mriedem | jaypipes: ^ | |
| 16:17:35 | mriedem | ildikov: yes | |
| 16:17:50 | mriedem | and for resize old flow we don't call block_device.attach() again | |
| 16:17:58 | mriedem | we just use init_connection and terminate_connection | |
| 16:18:06 | mriedem | with the new flow, we're doing attachment_updates now | |
| 16:19:00 | mriedem | actually we should be ok just pulling the bdm.device_name during resize https://review.openstack.org/#/c/525787/3/nova/virt/block_device.py@246 | |
| 16:19:05 | mriedem | because the driver block device code uses that | |
| 16:19:29 | mriedem | https://review.openstack.org/#/c/525787/3/nova/virt/block_device.py@408 | |
| 16:19:33 | ildikov | mriedem: yeah, I was just wondering whether we could have it updated and stored with the connector | |
| 16:19:49 | ildikov | mriedem: but can just use it from the BDM too, maybe less confusing that way | |
| 16:20:01 | mriedem | the connector is per host | |
| 16:20:04 | mriedem | the mountpoint is per volume | |
| 16:20:08 | mriedem | so doesn't really work that way | |
| 16:20:37 | mriedem | so, actually, it's really confusing that the attachment_update API expects the mountpoint in the connector dict rather than a top-level parameter on the PUT /attachments/{id}/ call itself | |
| 16:20:39 | mriedem | jgriffith: ^ | |
| 16:20:44 | mriedem | that seems like a bug in the API | |
| 16:20:59 | ildikov | I think it's because we're handling and saving things now per attachment | |
| 16:21:01 | mriedem | but of course is a microversion to fix | |
| 16:21:15 | mriedem | sure, it should still be a top-level field on the attachment though | |
| 16:21:23 | mriedem | not hidden down in the nebulous connector dict | |
| 16:21:55 | ildikov | it might've been intentional, but if it needs to be fixed we can do that with the microversion of course | |
| 16:23:26 | mriedem | we can workaround it for now | |
| 16:23:29 | mriedem | on the nova side | |