| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-11 | |||
| 12:09:51 | dtantsur | sambetts or vdrok, wanna do ^^^ or should I? | |
| 12:14:14 | dtantsur | okie | |
| 12:27:17 | openstackgerrit | Dmitry Tantsur proposed openstack/nova master: Re-use existing ComputeNode on ironic rebalance https://review.openstack.org/508555 | |
| 12:27:19 | dtantsur | I'm not sure I fully understand what is going on in the functional tests, but here is my attempt ^^^ | |
| 12:42:50 | openstackgerrit | Merged openstack/nova stable/pike: Document the real behavior of notify_on_state_change https://review.openstack.org/521870 | |
| 13:17:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 13:42:08 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042 | |
| 13:42:25 | jaypipes | happy Monday morning, supernovas! Who's still working this week? | |
| 13:43:02 | gibi | jaypipes: good morning! I'm still here until 20th of Dec | |
| 13:43:09 | jaypipes | gibi: cool :) | |
| 13:43:12 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | |
| 13:43:13 | edleafe | jaypipes: unfortunately, me | |
| 13:43:13 | jaypipes | glad to hear it! | |
| 13:43:17 | jaypipes | edleafe: :) | |
| 13:46:32 | openstackgerrit | Matthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | |
| 13:46:33 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid https://review.openstack.org/525599 | |
| 13:46:55 | cdent | jaypipes: I’ll be around until… uh 22nd I guess | |
| 13:47:42 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [DNM] test https://review.openstack.org/527045 | |
| 13:48:56 | jaypipes | cdent: cool beans. | |
| 13:50:10 | edleafe | For those around, nova scheduler subteam meeting in 10 minutes in #openstack-meeting-alt | |
| 13:53:17 | mdbooth | jaypipes: Speaking of which I just respun https://review.openstack.org/#/c/242602/25 following comments from mriedem (is he around this week?). I just added comments, but I fixed your nits from the previous patch as well as rebasing for a merge conflict later in the series. | |
| 13:54:15 | mdbooth | Would also appreciate a second opinion on the subject of unique constraints on nullable columns, but I did research that one carefully. | |
| 13:54:27 | mdbooth | In short, I'm very much in favour of them. | |
| 13:57:22 | jaypipes | mdbooth: will re-review shortly. | |
| 13:57:29 | mdbooth | jaypipes: Thanks | |
| 14:10:06 | mriedem | jaypipes: is it correct to say that nothing done in a db api method is committed until we start to exit a pick_context_manager_writer context? | |
| 14:10:19 | mriedem | like if we're updating multiple tables in a single method | |
| 14:13:44 | cdent | mriedem: or flush is callewd | |
| 14:13:56 | cdent | (which sometimes happens to find out an id() | |
| 14:14:12 | cdent | keyboards in the cold suck, especially when you already suck at typing | |
| 14:14:16 | mriedem | trying to figure out if there is a better way to fix the deadlock we're seeing in https://review.openstack.org/#/c/507473/15/nova/db/sqlalchemy/api.py w/o using the retry_on_deadlock decorator | |
| 14:14:26 | mriedem | cdent: radiant space heater for xmas | |
| 14:18:51 | jaypipes | mriedem: that is correct. | |
| 14:20:03 | mriedem | jaypipes: ok - so i guess we just have ot use the deadlock decorator in ^ then | |
| 14:20:09 | mriedem | unless anyone else has bright ideas | |
| 14:20:16 | jaypipes | mriedem: looking at it now. | |
| 14:26:23 | dtantsur | folks, can someone please take a look at https://review.openstack.org/#/c/508555/ ? it fixes our CI apparently | |
| 14:26:28 | dtantsur | mriedem, jaypipes ^^^ | |
| 14:26:55 | jaypipes | dtantsur: yes, will do. | |
| 14:27:08 | cdent | dtantsur: so that was it? I’m surprised it didn’t show up a bit sooner. | |
| 14:27:25 | dtantsur | cdent: all I can say that a patch with Depends-On it has passed the CI :) | |
| 14:28:07 | cdent | well it presumably needs to happen anyway, so motion in the right direction | |
| 14:28:16 | dtantsur | yep | |
| 14:28:42 | openstackgerrit | Merged openstack/python-novaclient master: Remove deprecated command in nova.rst https://review.openstack.org/526569 | |
| 14:29:02 | jaypipes | mriedem: yeah, that's sort of an odd place for the deadlock to occur. that basically means there are two greenthreads that are attempting to simultaneously (or near-simultaneously) calling action_event_finish() on an action with the *same* request ID. | |
| 14:29:20 | jaypipes | mriedem: which doesn't seem like it should happen, no? | |
| 14:29:41 | jaypipes | mriedem: i.e. there should not be >1 greenthread attempting to "finish" a particular task/event at the same time. | |
| 14:30:04 | jaypipes | mriedem: unless request ID is not a UUID? | |
| 14:30:16 | jaypipes | mriedem: if request ID is an auto-inc, it could happen. | |
| 14:30:58 | mriedem | request ID should be unique per user request | |
| 14:31:19 | mriedem | generated by some keystone or oslo middleware i tihnk | |
| 14:31:32 | jaypipes | mriedem: hmm, not necessarily... | |
| 14:31:33 | mriedem | https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/request_id.py | |
| 14:31:58 | mriedem | the failures all seem to happen on a resize test | |
| 14:32:04 | jaypipes | mriedem: see the comment and code on line 6302-6310 | |
| 14:32:37 | diga | jaypipes: Hi | |
| 14:32:38 | jaypipes | mriedem: seems that on a service restart, the action is retrieved by getting the "last created by instance UUID" | |
| 14:32:57 | jaypipes | mriedem: I'm wondering if that is returning an action ID that another greenthread might be operating on? | |
| 14:33:15 | mriedem | jaypipes: maybe, | |
| 14:33:15 | jaypipes | diga: hey. just saw your email. will email you an answer, ok? | |
| 14:33:22 | mriedem | we wouldn't have a compute restart in the middle of this tempest run | |
| 14:33:22 | diga | jaypipes: I have my setup ready but how to reproduce the issue is the big changel I am facing | |
| 14:33:24 | diga | jaypipes: sure | |
| 14:33:35 | mriedem | jaypipes: but we probably shouldn't update those kinds of actions anyway | |
| 14:33:37 | mriedem | so good spot | |
| 14:34:15 | mriedem | jaypipes: this is failing resize testing where we're rpc'ing back and forth with the same user context, | |
| 14:34:28 | mriedem | to decorated methods like prep_resize, resize_instance, finish_resize, etc | |
| 14:34:34 | mriedem | so it's possible we are hitting this quickly | |
| 14:35:54 | mriedem | jaypipes: yeah i think that's probably what's happening here | |
| 14:36:54 | mriedem | prep_resize updates it on the dest, rpc casts to resize_instance on the source which updates it again, which rpc casts back to the dest to finish_resize which updates the action again | |
| 14:36:59 | mriedem | 3 updates within a short window | |
| 14:39:37 | mriedem | jaypipes: left comments, thanks for the help | |
| 14:40:07 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | |
| 14:40:07 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | |
| 14:40:08 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | |
| 14:40:08 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | |
| 14:40:10 | edleafe | mriedem: ^^ rebased | |
| 14:40:13 | mriedem | yar | |
| 14:40:49 | jaypipes | mriedem: not sure I really helped, but ok :) | |
| 14:41:06 | mriedem | you greased my brain gears | |
| 14:42:18 | openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | |
| 14:42:30 | superdan | mriedem: that xen thing merged and this is fixed up ^ | |
| 14:42:33 | superdan | whoa | |
| 14:51:38 | mriedem | dansmith: service version needs to be fixed | |
| 14:51:43 | mriedem | otherwise lgtm | |
| 14:51:49 | dansmith | eh I bumped it? | |
| 14:52:04 | mriedem | rebase fail | |
| 14:52:11 | dansmith | oh doh | |
| 14:52:48 | openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | |
| 14:52:54 | dansmith | dammit, hang on | |
| 14:53:06 | dansmith | sheesh | |
| 14:53:08 | openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | |
| 14:53:22 | dansmith | did half of that on friday and then completed before max caffeine absorption = fail | |
| 14:57:30 | mriedem | +2 | |
| 14:58:06 | mriedem | gibi: you've been on this series before https://review.openstack.org/#/c/507638/ | |
| 14:58:09 | mriedem | ^ is the last patch | |
| 15:00:39 | jaypipes | mriedem: easy one. https://review.openstack.org/#/c/526973/ | |
| 15:05:02 | mriedem | jaypipes: this must be a response sample? https://review.openstack.org/#/c/526973/1/placement-api-ref/source/update-resource_provider.json | |
| 15:05:48 | mriedem | yeah i guess http://logs.openstack.org/73/526973/1/check/build-placement-api-ref/cbc7192/html/#id11 | |
| 15:06:04 | jaypipes | yessir | |