Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-12-07
15:47:03 ildikov mriedem: what you pasted above: https://review.openstack.org/#/c/525787/4/nova/virt/block_device.py@589
15:47:27 mriedem ildikov: what don't you get about ^ ?
15:47:43 mriedem ildikov: in that code, nova is creating the volume
15:47:44 mriedem agree?
15:47:57 ildikov mriedem: that why we need to create a new attachment here too: refresh_connection_info
15:48:21 mriedem ildikov: do you mean https://review.openstack.org/#/c/525787/4/nova/virt/block_device.py@473 ?
15:48:24 jaypipes mdbooth: you working on fixing those unit test failures on the BDM uuid patch?
15:48:42 ildikov yeah, I agree with that, I just thought we covered everything for that case of BFV as well as we removed check attach, so things needed to be ok on the Cinder side as well regarding volume state, etc.
15:49:29 ildikov mriedem: no, I meant line 589, I don't get why we need to add that one
15:50:36 mriedem ildikov: if we create the volume but don't create the attachment,
15:50:43 mriedem when we call super(...).attach()
15:50:54 mriedem https://review.openstack.org/#/c/525787/4/nova/virt/block_device.py@511 will be True
15:51:02 mriedem and we will go down _legacy_volume_attach
15:51:16 ildikov sorry, my bad, mixed it up
15:51:19 ildikov forget that one
15:51:24 openstackgerrit Ed Leafe proposed openstack/nova master: Refactor the code to check for sufficient hosts https://review.openstack.org/520242
15:51:24 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
15:51:25 openstackgerrit Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492
15:51:25 openstackgerrit Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159
15:51:26 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707
15:51:26 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
15:51:27 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
15:51:27 openstackgerrit Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
15:51:32 edleafe mriedem: jaypipes: ^^ rebased
15:51:46 edleafe mriedem: also added the alternates for resize patch
15:52:28 mriedem ildikov: so we're all good now?
15:52:55 mriedem edleafe: ok reapproved the bottom 4
15:53:09 ildikov I guess, I need to understand that part of the code as I thought we managed to cover everything regarding reserve back at the time of the old flow and check_attach removal
15:53:20 edleafe mriedem: thx
15:53:38 ildikov my bad, this code is super confusing... :/
15:53:40 mriedem ildikov: well, calling check_attach in the old flow on a volume that we *just* created was always kind of pointless
15:54:12 mriedem something would have had to slip in between the microseconds that the volume went to 'available' and we started using it
15:54:30 ildikov mriedem: I've never questioned that, I just said that we added extra an extra reserve call to have everything covered, but then it existed only in my head
15:54:50 mriedem i think we only ever reserved from the api
15:55:32 mriedem yeah https://github.com/openstack/nova/blob/stable/ocata/nova/virt/block_device.py#L250
15:55:39 ildikov yeah, I wasn't sure where exactly we create that volume I guess
15:55:39 mriedem check_attach wouldn't reserve
15:55:54 mriedem yup, for blank/image/snapshot it's created on the compute
15:55:57 mriedem right before we attach it
15:56:16 mriedem we should create the volumes way earlier, like in conductor, but that's not happening today
15:56:46 ildikov ok, so I'm just partially stupid, that's something :)
15:56:57 mriedem this is the attach code in ocata https://github.com/openstack/nova/blob/stable/ocata/nova/compute/api.py#L3666
15:57:08 mriedem https://github.com/openstack/nova/blob/stable/ocata/nova/compute/api.py#L3653
15:57:17 mriedem so that's the only time (aside from bfv with an existing volume) that we'd reserve
15:57:53 ildikov ok
15:58:24 mriedem i believe i have a todo sitting here to document how boot from volume actually works
15:58:29 mriedem because i explained it once in the mailing list
15:58:48 mdbooth jaypipes: Yeah. Working on something further down the stack atm.
15:59:08 mdbooth jaypipes: Wait, are they at the beginning of the stack, too?
15:59:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add regression test for bug 1735407 https://review.openstack.org/526095
15:59:14 openstack bug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer)
15:59:20 ildikov mriedem: if you have a link to that I would be happy to read it :)
15:59:20 jaypipes mdbooth: no, second patch in series
15:59:47 mdbooth Hmm, that was careless.
15:59:51 mdbooth jaypipes: fixing it now.
16:00:26 ildikov mriedem: we can have a quick meeting and see what's next
16:01:11 mdbooth Ah, fixed that locally, didn't realise I'd pushed the old one, sorry.
16:07:26 openstackgerrit Matthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603
16:09:02 maciejjozefczyk Hello Guys, im trying to debug why I've faced a problem with scheduling. My instances stucks in 'scheduling' state. After enabling debug on nova-scheduler I've found that a host was selected. On nova-compute side there were 0 info about building an instance. It could be possible that the failure point is nova-conductor?
16:16:57 tasker morning! couple of questions about nova metadata service: why ( and what for ) are there different dates in the URI? does "latest" coalesce the various other date entries and get all of the latest date from them? does "latest" count as a different date than the others? where is the metadata physically stored ( on disk or in a database )?
16:23:55 mriedem sdague: efried: i'm surprised our docs don't say anything about configuring [neutron] with a user that has the admin role
16:24:01 mriedem because we definitely require that
16:24:10 mriedem for doing thigns with the port binding profile
16:24:29 mriedem maybe the install guide does, but the config reference doesn't
16:26:36 mriedem hmm, not here https://docs.openstack.org/nova/latest/install/compute-install-ubuntu.html
16:27:19 efried mriedem This coming from https://review.openstack.org/#/c/509892/ ?
16:28:20 mriedem no
16:28:23 mriedem https://bugs.launchpad.net/cinder/+bug/1736773
16:28:25 openstack Launchpad bug 1736773 in Cinder "attachment-show is including `connection_info` for non-admin callers, it shouldn't" [High,Triaged] - Assigned to John Griffith (john-griffith)
16:31:25 mriedem https://docs.openstack.org/neutron/latest/install/compute-install-ubuntu.html#configure-the-compute-service-to-use-the-networking-service
16:31:35 mriedem the networking install guide mentions it, but not sure if that 'neutron' user is an admin
16:33:01 mriedem ah here it is https://docs.openstack.org/neutron/latest/install/controller-install-ubuntu.html#prerequisites
16:33:09 mriedem "Add the admin role to the neutron user:"
16:33:35 mriedem so if you've done everything correctly, things might work
16:33:53 mriedem but i could see people creating a special networking user for nova to talk to neutron which is a service role rather than admin role or something
16:34:03 mriedem assuming that's fine because the nova config section for [neutron] doesn't mention it
16:36:54 mriedem https://docs.openstack.org/cinder/latest/install/cinder-controller-install-ubuntu.html#configure-compute-to-use-block-storage
16:38:42 openstackgerrit Merged openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
16:42:45 efried wohoo! ^
16:42:54 cdent amazing
16:43:33 efried What, you haven't written a script for that yet?
16:44:56 cdent that would ruin the enjoyment
16:45:06 gibi getting n-rp REST merged... it is almost like Christmas
16:48:08 mgagne so I installed osc-placement, how can I use the CLI command? I tried with --os-beta-command and resource commands are not available.
16:48:11 mriedem jaypipes: done https://review.openstack.org/#/c/465160/9
16:50:32 jaypipes mriedem: cheers
16:52:39 openstackgerrit Merged openstack/nova master: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot https://review.openstack.org/400384
16:54:17 mriedem ildikov: http://lists.openstack.org/pipermail/openstack-dev/2017-April/115093.html was the ML thread i was thinking of
16:55:21 bauzas holy fsck, the libvirt driver doesn't know a shit about the compute node
16:55:22 ildikov mriedem: cool, thanks
16:55:35 bauzas like, it's not knowing the compute UUID
16:55:43 mriedem bauzas: why should it?
16:56:18 bauzas mriedem: since we're now passing the allocations, there will be a list of RP UUIDs with resources in them
16:56:26 bauzas mriedem: for the moment, it's not a problem
16:56:34 bauzas mriedem: given we don't support nested RPs
16:57:01 bauzas mriedem: but once we'll have more than one RP for a compute, then we'll pass all the related allocations to the drivers
16:57:21 bauzas then, how to know which one is for the root RP for example ?
16:57:22 mriedem sure, but the fact we don't have something that we've never had a need for before shouldn't be shocking
16:57:36 mriedem "wait, nova DOESN'T create ice cream?!"
16:58:07 bauzas mriedem: sure, I understand that, but I thought we would at least know more than just the hostname :)

Earlier   Later