Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-12-04
15:51:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242
15:51:55 mdbooth dansmith: Second question: update by uuid. I'm assuming that when you were adding this first time round you anticipated needing this. I don't think I need it. I could add it for completeness, or omit it until there's a caller. Personal preference would be the latter.
15:53:37 dansmith mdbooth: I probably had it for tests or something, but sure, no need to have it if there is no user
15:59:22 openstackgerrit Jackie Truong proposed openstack/python-novaclient master: Microversion 2.57 - Add trusted_image_certificates https://review.openstack.org/500396
16:07:37 mdbooth dansmith: Thanks
16:13:09 ildikov mriedem: hi, I updated the patch with the fixes to your comments
16:13:30 ildikov mriedem: I didn't have the stomach as of yet at least to do the split...
16:13:45 mriedem ildikov: ok
16:14:30 ildikov mriedem: if you have time plz continue to review and I will fix it in either one or two patches
16:15:16 mriedem i hope to get to it today, but have to work on some other stuff this morning
16:16:45 ildikov appreciated if you can get to it today
16:33:24 tssurya mriedem: I am stuck on this - https://bugs.launchpad.net/nova/+bug/1729806/comments/1 , because both those columns are of type "Text()" and SQL doesn't allow text type columns to have a unique constraint; any pointers on how you usually do this in nova ?
16:33:26 openstack Launchpad bug 1729806 in OpenStack Compute (nova) "nova-manage update_cell does not check if the same combination of transport_url and database_connection already exists" [Low,In progress] - Assigned to Surya Seetharaman (tssurya)
16:33:37 mriedem ildikov: i looked at the diff, comments in https://review.openstack.org/#/c/330285/
16:34:50 openstackgerrit Eric Fried proposed openstack/nova master: Make _Provider really private https://review.openstack.org/523932
16:36:24 dansmith tssurya: you could check before create, which isn't as good as a constraint, but it'd be an easy thing to do
16:36:29 openstackgerrit Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245
16:36:32 ildikov mriedem: tnx!
16:37:09 mriedem ildikov: and another one just now
16:37:18 mriedem ildikov: the shelved offloaded case probably needs some thought
16:37:23 mriedem could also see what johnthetubaguy thinks
16:37:39 ildikov mriedem: ok, I'll wait a bit longer before touching it :)
16:37:47 mriedem for all intents and purposes, a reserved volume is going to be the same as an in-use volume to nova
16:37:51 ildikov mriedem: sigh, I will look into the comments shortly
16:38:16 johnthetubaguy I was a touch worried about the change in shelved offloaded
16:38:28 mriedem there is an api behavior change with attaching a volume to a shelved offloaded instance with the new flow,
16:38:37 mriedem where the volume is left 'reserved' rather than 'in-use'
16:38:42 johnthetubaguy yeah, that seemed nasty
16:38:44 mriedem i could see client side app tooling failing / timing out on that
16:38:46 mriedem like tempest even
16:38:57 mriedem lots of client code waits for an attachment to go to in-use before it considers it done
16:39:07 johnthetubaguy yes, good point
16:39:10 tssurya dansmith: Yes, that is what I am doing in my review, I was just trying to add the constraint part too
16:39:42 dansmith tssurya: sounds like we might not be able to do the constraint part.. since urls can't be large, I'm not sure converting it to something other than text is a good idea
16:40:07 johnthetubaguy mriedem: I did raise that in a previous version, but forgot about it shortly after, +1 on it being bad
16:40:09 dansmith tssurya: we actually have some long urls ourselves, since we encode all the HA hosts in the transport url, and I think we do the same for our galera endpoints
16:40:40 efried cdent dansmith Did you see my "themed CI results" last week? I made one monochrome for cdent (http://184.172.12.213/manual/htmlify_logs/logs/n-cpu.txt.gz?theme=monochrome) and one solarized for both of you (http://184.172.12.213/manual/htmlify_logs/logs/n-cpu.txt.gz?theme=solarized)
16:40:55 tssurya dansmith: oh okay, yea then I will not pursue it, this came up https://review.openstack.org/#/c/523817/ in parallel to my patchset, so I thought I would investigate this
16:41:06 dansmith tssurya: cool
16:41:09 tssurya dansmith: thanks then, I will remove the constraint part then
16:41:12 mriedem edleafe: i'm going to make a concerted push on the alternate hosts series today, do you plan on rebasing https://review.openstack.org/#/q/topic:bp/return-alternate-hosts+status:open to resolve the merge conflicts at the top?
16:41:43 dansmith efried: I did not, but cool.. that still ends up with ascii in the logs if I curl download it though right?
16:42:25 efried dansmith I've actually got solutions that go both ways.
16:42:25 AJaeger_ sdague: could you review https://review.openstack.org/#/c/524353/ ,please? This updates jobs for os-api-ref and gets rid of tools/tox_install.sh
16:42:30 jaypipes efried: you are currently rebasing the series that ends in 520246, yes?
16:42:32 dansmith efried: ....
16:42:40 edleafe mriedem: I was waiting until there was renewed interest in the series. I can start rebasing now.
16:42:48 dansmith efried: well, from the purely browser-based view, solarized looks good to my eyes :)
16:42:52 mriedem edleafe: yup, it's my #1 priority today
16:43:01 efried dansmith I think what I've got on that server right now preserves the codes, because that's the way I prefer it, and that's my server :)
16:43:02 mriedem edleafe: i plan on having that series +2ed by thursday
16:43:32 edleafe mriedem: on it
16:43:32 efried dansmith Okay, duly noted. The way I've got it set up, it's fairly easy to add themes, and (in case you didn't notice) there are new links at the top allowing you to flip between themes.
16:43:52 dansmith efried: yeah, curl gives me ansified files
16:44:06 cdent efried: I did see it, solarized was also easy on my eyes. If there’s a way to curl and get non-ansified files that would be a cherry on top
16:44:26 cdent (sort of as another theme, I guess)
16:44:34 ildikov mriedem: johnthetubaguy: got busy, but will check back on it and we can chat about it
16:44:36 dansmith the theming happens in the browser I imagine
16:44:39 dansmith so doesn't affect curl
16:44:57 efried dansmith cdent I have solutions that *always* or *never* strip the ANSI colors; what I'd like to get to eventually is a way for you to curl download with a querystring that allows you to choose.
16:45:02 dansmith I'm not a hard -2 on the ansi logs, but I'd prefer it if I can get it
16:45:14 dansmith efried: that'd be cool
16:45:40 dansmith efried: just put me a curl link on the top somewhere so I can copy that, kinda like the download links in gerrit
16:46:07 efried dansmith The theming is actually an HTML filter that sits on the apache server and kicks in when the user agent is a browser (or something). Then there's a separate filter that you get when it's a download, that doesn't do the HTML conversion at all.
16:46:11 efried dansmith ++ good call
16:46:29 dansmith efried: ah, okay I dunno how that works, but cool
16:46:34 efried dansmith I usually right-click Save-As the file from the directory view, but a copyable link would be neat.
16:46:49 efried dansmith In case you're interested, the theme-ification patch: https://review.openstack.org/#/c/524744/
16:47:04 dansmith efried: yeah, copyable would be nice, because I wget them to my dev box.. right-click-save doesn't do what I want because it'd be on my local machine instead
16:47:19 efried dansmith I gotcha.
16:48:32 dansmith but yeah, aside from my complaints, looks awesome
16:48:52 dansmith sometimes being able to just switch the theme based on what you're looking for can be nice, and/or what you've been staring at for hours
16:56:28 mriedem jaypipes: easy refactor https://review.openstack.org/#/c/523492/
16:56:34 mriedem in the alt hosts series
16:56:36 artom What happened to nova-specs?
16:56:43 mriedem artom: ?
16:56:45 artom https://review.openstack.org/#/c/490824/ merged October 3rd
16:57:00 artom Latest commit in https://github.com/openstack/nova-specs/commits/master/specs is september 21
16:57:10 mriedem efried: ^ didn't you ask infra about this a week or two ago?
16:57:36 mriedem http://git.openstack.org/cgit/openstack/nova-specs/log/
16:57:45 mriedem the github mirror repo is definitely stale
16:57:55 artom Yeah
16:58:09 artom And maybe bring it up in #infra?
16:58:14 efried mriedem After spec freeze I noticed that they weren't getting published to specs.o.o -- sounds like that's a different issue.
16:58:35 efried ...which was resolved, at least at the time.
16:58:47 clarkb mriedem: artom efried the github mirror being stale is a known issue, the repo is corrupt according to github and won't accept pushes
16:59:01 clarkb if we take a gerrit downtime we can surgery the repo but we haven't had opportunity for that yet
16:59:08 artom clarkb, aha, thanks!
16:59:13 efried artom FWIW, that spec is published: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/libvirt-qemu-native-luks.html
16:59:13 mriedem oh yes
16:59:17 clarkb its been a low priority because we do host working mirrors elsewhere and github is just barely a thing we support
16:59:33 cfriesen has anyone ever considered an option to "tox -e pep8" that would run it only on the files in the top N commits?
16:59:33 artom efried, doh, of course!
16:59:43 efried cfriesen -- -HEAD
16:59:47 mriedem cfriesen: tox -e fast8
16:59:50 artom clarkb, yep, fair enough, thanks for, err, being aware?
17:00:05 mriedem fast8 is different
17:00:10 mriedem fast8 is pep8 on just the files changed
17:00:13 artom mriedem, I thought we're only at Fast and Furious 6 or 7
17:00:18 clarkb with the holidays coming up, things tend to slow down and we can probably more easily sneak in an extended gerrit downtime

Earlier   Later