Posted	Nick	Remark
#openstack-nova - 2017-12-01
17:25:15	mriedem	oh shelve http://lists.openstack.org/pipermail/openstack-dev/2017-December/125124.html
17:25:19	mriedem	you'll be the death of me
17:25:23	mriedem	alaski: ^ maybe you have ideas
17:25:26	mriedem	from 2013
17:27:06	cdent	shelve-tastic
17:31:41	mriedem	fried_rolls: failure here looks real
17:31:42	mriedem	https://review.openstack.org/#/c/524618/
17:31:45	mriedem	http://logs.openstack.org/18/524618/1/check/openstack-tox-functional/81f3dd8/testr_results.html.gz
17:31:51	mriedem	cur_rp_gen = self._resource_providers[rp_uuid]['generation'] TypeError: 'NoneType' object has no attribute '__getitem__'
17:32:44	mriedem	superdan: want to push this through stable? else i will https://review.openstack.org/#/c/509961
17:33:29	superdan	not really, but I will
17:33:49	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Fix incorrect known vcpuset when CPUPinningUnknown raised https://review.openstack.org/523644
17:39:10	mriedem	johnthetubaguy: bauzas: lyarwood: if you're still around, we should get these in https://review.openstack.org/#/q/I1a46ef1503be2febcd20f4594f44344d05525446
17:39:24	mriedem	fixes a regression introduced in a cve fix from a week or two ago
17:45:34	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Fix TypeError of _get_project_id when project_id is None https://review.openstack.org/524687
17:46:20	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: Vzstorage: synchronize volume connect https://review.openstack.org/524688
17:50:50	johnthetubaguy	mriedem: seems important, +2
17:51:20	mriedem	thanks
17:54:43	alaski	mriedem: so the idea with unshelving was that it should look like nothing had happened. So you boot instance from image A, image_ref points at A. Resize/migration should work. You shelve/offload/unshelve and have an instance running again, with image_ref A. It's supposed to be like nothing happened so resize/migration should still work. What's unclear to me, since I've been out of the loop for a bit,
17:54:45	alaski	is why resize/migration fails specifically after an unshelve.
17:57:04	alaski	I think the argument against updating image_ref was that something like a rebuild should use the original image, not the snapshot. But outside of that I don't recall any reasons not to update the image_ref
17:58:16	mriedem	ok so create with image A, shelve to create image B, unshelve with image B, rebuild with image A again
17:58:58	alaski	yeah. image B is an artifact of shelving but from a user point of view it never really exists.
17:59:25	mriedem	hmm, except it does, until we delete it
17:59:43	alaski	shelve/unshelve ideally has the vm exactly as it was before shelving, no updates to the vm at all.
17:59:46	mriedem	anywho, thanks, didn't think about the rebuild thing, but this all seems very slight of hand and confusing
18:00:01	mriedem	well,
18:00:11	mriedem	we still don't do that properly with volumes and ports completely i don't think
18:00:17	alaski	yes, that whole feature is very much slight of hand and confusing
18:00:29	mriedem	i will think on those over a 1000 calorie burrito
18:01:59	alaski	"ideally" that's how shelve works, in practice it clearly does not. I won't claim that the ideal is achievable, so it may be better to be pragmatic and just document it well.
18:02:43	alaski	maybe you'll come out of your food coma with an epiphany
18:08:39	openstackgerrit	Peter Penchev proposed openstack/nova master: Add the Nova libvirt StorPool attachment driver. https://review.openstack.org/140733
18:22:38	rabel	hi there. i need your thoughts on my last comment to https://review.openstack.org/#/c/402632/12 :) . it is about the datastore selection in vmware driver.
18:27:17	cdent	rabel: I suspect rgerganov is going to be best placed to answer that and he won’t be back around until Monday, but I can try to make sure he sees it
18:29:31	rabel	cdent: that would be great. thank you
18:29:43	cdent	✔
19:15:28	openstackgerrit	Merged openstack/nova stable/pike: Log consumer uuid when retrying claims in the scheduler https://review.openstack.org/509961
19:16:55	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408
19:16:55	openstackgerrit	Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
19:23:21	sdaniel_	Hi, I need some help about nova services :(
19:29:23	openstackgerrit	Jackie Truong proposed openstack/python-novaclient master: Microversion 2.57 - Add trusted_image_certificates https://review.openstack.org/500396
19:29:59	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] re-use existing conf with auth token middleware https://review.openstack.org/523403
19:30:39	cdent	mriedem: I came up with a somewhat different approach for the test of that ^ because the middleware is very kwargy instead of a attrtibutey
19:34:09	sdaniel_	I had to reconfigurate the network type from provider to self-service
19:34:30	sdaniel_	and after that know of my nova services won't come up
19:34:44	sdaniel_	(after i restarted them manually)
19:35:28	sdaniel_	I re-created the whole nova DBs and re-installed the nova packages, but nothing helped
19:36:42	sdaniel_	I cant restart the services
19:36:50	sdaniel_	I got this error in syslog: TypeError: __init__() got an unexpected keyword argument 'retry_on_request'
19:37:17	sdaniel_	Only just nova cant restart, neutron can
19:50:22	openstackgerrit	Merged openstack/nova stable/pike: Refined fix for validating image on rebuild https://review.openstack.org/523212
19:56:02	openstackgerrit	Merged openstack/python-novaclient master: Move zuulv3 jobs to project repo https://review.openstack.org/522099
19:56:33	openstackgerrit	Jackie Truong proposed openstack/python-novaclient master: Microversion 2.57 - Add trusted_image_certificates https://review.openstack.org/500396
19:58:25	openstackgerrit	Merged openstack/nova stable/ocata: Refined fix for validating image on rebuild https://review.openstack.org/523427
19:58:30	openstackgerrit	Merged openstack/nova stable/newton: Refined fix for validating image on rebuild https://review.openstack.org/523434
20:25:58	fried_rice	mriedem Yup, was just starting to look at that before "lunch". Should have it fixed here shortly.
20:34:06	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257
20:34:06	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777
20:34:07	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051
20:35:07	superdan	fried_rice: I hope "lunch" was something super well-deserving of quotes
20:35:44	fried_rice	superdan Tapping out people bigger and stronger than me. The actual eating is happening now, at my desk.
20:36:29	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612
20:36:55	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226
20:39:22	mriedem	i hope you're not eating the aforementioned tapped out people
20:40:28	coffee_cat	lol :)
20:41:22	cdent	“tapped out people and fried_rice”, it’s what’s for dinner
20:41:41	fried_rice	You could say I ate them for lunch.
20:54:09	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Store shelved snapshot image ref with instance after unshelve https://review.openstack.org/524726
20:58:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Check the return code when forcing TCG mode with libguestfs https://review.openstack.org/524727
21:05:06	mriedem	coffee_cat: already found a problem which i didn't think about before :)
21:05:09	mriedem	but easy fix
21:05:44	coffee_cat	mriedem: I would've been disappointed otherwise :)
21:05:56	mriedem	i don't think we supported multi-cell when this was written
21:06:03	mriedem	but now, we do
21:06:04	mriedem	bigly
21:06:33	mriedem	days since multi-cell multi-attach accidents: 0
21:06:52	coffee_cat	I certainly don't recall talking about multi-cell in this context before
21:07:15	coffee_cat	not sure about my feelings now that we do... :)
21:28:03	openstackgerrit	Jackie Truong proposed openstack/python-novaclient master: Microversion 2.56 - Enable cold migration with target host https://review.openstack.org/406707
21:28:03	openstackgerrit	Jackie Truong proposed openstack/python-novaclient master: Microversion 2.57 - Add trusted_image_certificates https://review.openstack.org/500396
21:36:21	fried_rice	superdan This in your wheelhouse? https://review.openstack.org/#/c/523932/
21:37:31	openstackgerrit	Eric Fried proposed openstack/nova stable/pike: Proper error handling by _ensure_resource_provider https://review.openstack.org/524618
21:38:06	fried_rice	mriedem ^ giblet move the placement fixture in master presumably for a similar reason. (Actually he duplicated it - we should remove the second one.)
21:41:20	openstackgerrit	Eric Fried proposed openstack/nova master: Trivial: Nix duplicate PlacementFixture() in test https://review.openstack.org/524734
21:41:27	fried_rice	mriedem Fixed that ^
21:44:58	mriedem	coffee_cat: https://review.openstack.org/#/c/330285/165
21:46:57	coffee_cat	mriedem: cool, thanks
21:47:15	coffee_cat	mriedem: I will get up a next version by Monday (I hope :)
21:47:31	mriedem	i don't think anything i pointed out is particularly hard to deal with
21:47:49	mriedem	i pointed out a chance to break some of this out into a separate patch too, if so desired
21:48:59	coffee_cat	yeah, looks fine
21:49:14	coffee_cat	if possible I would love not to maintain a longer chain
21:49:22	mriedem	i know,
21:49:25	mriedem	but at +1251 LOC,
21:49:39	coffee_cat	but that's mostly tests
21:49:39	mriedem	it becomes very hard to spot regressions and test coverage
21:49:51	mriedem	i made comments in the tests too :)
21:50:16	mriedem	anyway, i would understand if you don't want to split parts of it up at this point
21:50:19	mriedem	i said that in there too

Earlier   Later