| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-27 | |||
| 13:24:15 | nkorabli | If I understand you right, this is an issue that appears in Liberty only? | |
| 13:25:32 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L1976 is referring to the virtual numa topology of the guest. not the host numa topology | |
| 13:26:32 | sean-k-mooney | the first release of openstack with numa support did a 1:1 mapping between the virtual cellid to the host cellid howerver that was a mistake that was correct in later releases | |
| 13:28:48 | sean-k-mooney | nkorabli: there is also a rather little known option hw:numa_mempolicy which defaults to strict which allows you to specify if the guest memory must come from the same numa node as the vCPUS | |
| 13:29:11 | sean-k-mooney | i cant find the upstream docs but its memtioned here in the redhat docs https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux_OpenStack_Platform/6/html/Administration_Guide/section-flavors.html | |
| 13:30:12 | efried | edleafe Sched meeting is in half an hour, right? | |
| 13:36:04 | cdent | efried: appears so | |
| 13:36:25 | efried | cdent Takes me a couple weeks to get the time shift right. DST is stupid. | |
| 13:36:33 | cdent | yes and yes | |
| 13:37:01 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | |
| 13:39:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | |
| 13:43:54 | nkorabli | sean-k-mooney: thanks a lot! Let me test that out! | |
| 13:52:15 | openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | |
| 13:54:09 | edleafe | efried: yes, scheduler subteam meeting in 6 minutes in #openstack-meeting-alt | |
| 13:54:16 | efried | thx | |
| 13:56:22 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 13:56:23 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955 | |
| 14:18:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 14:18:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955 | |
| 14:41:09 | alex_xu | efried: looks like https://review.openstack.org/#/c/498737/2/nova/tests/functional/db/test_resource_provider.py@2981 same with https://review.openstack.org/#/c/518633/15/nova/tests/functional/db/test_allocation_candidates.py@1719 | |
| 14:42:12 | alex_xu | efried: I didn't found one similar to this yet https://review.openstack.org/#/c/498737/2/nova/tests/functional/db/test_resource_provider.py@3207 | |
| 14:46:03 | mriedem | gibi: are you looking for changes on this patch? https://review.openstack.org/#/c/516782/ | |
| 14:46:09 | mriedem | i see you didn't -1 it | |
| 14:46:54 | mriedem | alex_xu: regarding https://review.openstack.org/#/c/522305/ i'm inclined to just fix the bug since it's an admin-only API by default, so not really an interop concern, and it's a 1-line fix which we can then backport | |
| 14:47:09 | mriedem | i'll need to consider updating the microversion dev ref docs on admin APIs | |
| 14:47:57 | alex_xu | mriedem: ok, got it | |
| 14:50:04 | gibi | mriedem: It would be nice to close the bug 1730730 report as well with the patch but jaypipes seems has different oppinion | |
| 14:50:04 | openstack | bug 1730730 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with only sharing providers" [Undecided,Triaged] https://launchpad.net/bugs/1730730 | |
| 14:52:32 | gibi | jaypipes: is it OK for you if I quickly resping https://review.openstack.org/#/c/516782/ and add the closes-bug tag to the commit message? | |
| 14:52:50 | jaypipes | gibi: go for it. | |
| 14:53:06 | gibi | jaypipes: OK | |
| 14:54:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters() https://review.openstack.org/516782 | |
| 14:54:39 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM support matrix update https://review.openstack.org/523140 | |
| 14:55:38 | gibi | mriedem, alex_xu, jaypipes: here is the quick update, i'm +2 now on https://review.openstack.org/516782 | |
| 14:56:22 | alex_xu | gibi: done | |
| 15:00:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add x-openstack-request-id in API ref https://review.openstack.org/523007 | |
| 15:04:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix invalid minRam error message https://review.openstack.org/523142 | |
| 15:13:08 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027 | |
| 15:14:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | |
| 15:14:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add ProviderSummary.resource_class_names @property https://review.openstack.org/517646 | |
| 15:24:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Refined fix for validating image on rebuild https://review.openstack.org/521186 | |
| 15:24:57 | openstackgerrit | Dan Smith proposed openstack/nova master: Add regression test for rebuild with new image doubling allocations https://review.openstack.org/521153 | |
| 15:24:57 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix doubling allocations on rebuild https://review.openstack.org/521662 | |
| 15:27:08 | efried | dansmith Is https://review.openstack.org/#/c/507638/ related to the "Migration fixups" priority at https://etherpad.openstack.org/p/nova-ptg-queens-placement L49? | |
| 15:27:25 | efried | dansmith Perhaps a better question: what all is related to the "migration fixups" priority at ^ ? | |
| 15:27:46 | dansmith | that's the last one | |
| 15:27:51 | dansmith | all the others merged already | |
| 15:28:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement query param schema for delete assisted vol https://review.openstack.org/513668 | |
| 15:28:12 | openstackgerrit | Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399 | |
| 15:28:57 | efried | dansmith Cool. Looks like it needs a rebase? | |
| 15:29:02 | dansmith | hmm, yeah I guess so | |
| 15:30:13 | efried | dansmith (cdent) Is POST /allocations for multiple consumers (https://review.openstack.org/#/c/500073/) not related to the same effort? | |
| 15:30:23 | dansmith | it is | |
| 15:30:30 | efried | okay, thanks. | |
| 15:42:58 | openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | |
| 15:45:02 | openstackgerrit | jiangpf proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | |
| 15:45:12 | efried | jaypipes edleafe dansmith Draft: http://paste.openstack.org/show/627496/ -- As owners of the Three Priorities, would you please vet this for proper inclusion of linkitude? | |
| 15:49:42 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary self.flags and ConfPatcher https://review.openstack.org/522993 | |
| 15:53:35 | edleafe | efried: except for the double spaces after periods, it looks good | |
| 15:53:58 | efried | edleafe Thanks. Appreciate you taking a look. I'll work on the spacing thing. | |
| 15:54:21 | edleafe | It probably looks fine on a typewriter | |
| 15:55:35 | efried | edleafe That's how I proofread all my work. | |
| 16:24:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Versioned notifications for service create and delete https://review.openstack.org/519588 | |
| 16:36:25 | jaypipes | efried: sure, looks fine to me, thank you! | |
| 16:36:32 | efried | jaypipes Thanks. | |
| 16:43:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Address nits from service create/destroy notification review https://review.openstack.org/523162 | |
| 16:44:15 | cdent | nice placement functional test to get in: https://review.openstack.org/#/c/493865/ | |
| 17:00:27 | openstackgerrit | Merged openstack/nova master: Implement query param schema for flavor index https://review.openstack.org/515413 | |
| 17:00:34 | openstackgerrit | Merged openstack/nova master: Implement query param schema for fping index https://review.openstack.org/513890 | |
| 17:13:52 | dansmith | mriedem: this is about to pass check: https://review.openstack.org/#/c/521186/ | |
| 17:13:57 | dansmith | we gonna get that in soon? | |
| 17:15:26 | mriedem | haven't looked at the latest, | |
| 17:15:36 | mriedem | was going through your live migration swap allocs change quick | |
| 17:30:18 | mriedem | dansmith: ok looks like the only change in https://review.openstack.org/#/c/521186/ is the NUMATopologyFilter (which is looking at image properties so we should run it on rebuild) and the commit message title | |
| 17:32:17 | mriedem | artom: are you good with ^ now? | |
| 17:32:25 | mriedem | i think the only thing remaining is a release note | |
| 17:53:48 | openstackgerrit | Merged openstack/python-novaclient master: [ci] Use pseudo-random names for new resources https://review.openstack.org/479777 | |
| 18:00:31 | dansmith | mriedem: yep, which you were going to do | |
| 18:00:57 | mriedem | yup | |
| 18:12:40 | belmoreira | mriedem, dansmith I have been working in enabling placement in newton with a nova_api DB per cell. I have some comments. Are you around? | |
| 18:13:22 | dansmith | belmoreira: depends, are they nice comments? | |
| 18:14:09 | belmoreira | :) a problem actually. And I would like your guidance | |
| 18:14:31 | belmoreira | A problem that I found is the deletion of the build_request in nova_api. Conductor that runs in the cell will try to delete it from the local nova_api | |
| 18:15:14 | dansmith | does the api cell have a dedicated nova_api db? | |
| 18:15:52 | dansmith | I guess it must | |
| 18:16:10 | belmoreira | yes, on cellsV1 we also have the same concept | |
| 18:16:32 | dansmith | what I mean is, you have a placement for the api cell, and a placement for each compute cell | |
| 18:16:42 | mriedem | belmoreira: is this when we delete an instance? it gets routed to the child cell api and that tries to delete the build request? | |
| 18:16:51 | dansmith | so I'm guessing the api puts in a buildrequest, but the compute cell tries to delete it during boot | |
| 18:17:23 | dansmith | which means you keep getting the buildrequest listed out of the api, and maybe compute goes to delete it, finds it deleted, and assumes the instance was deleted? | |
| 18:17:49 | belmoreira | dansmith, the plan was to enable placement also in api_cell just to be already there for the pike upgrade | |
| 18:18:59 | belmoreira | dansmith the issue is because the build_request is not deleted, the instance is created but remains in build state when the user list its instances | |
| 18:19:13 | dansmith | okay so the first half of what I said | |
| 18:19:24 | belmoreira | yes | |
| 18:19:32 | dansmith | belmoreira: so you'll need something in the instance sync back to the api cell that deletes the build request | |
| 18:20:27 | belmoreira | dansmith what I did was to change delete_build_request to delete the request from the nova_api DB in the top cell | |
| 18:20:53 | belmoreira | basically adding a new conf option to point to that DB that is used in this function | |
| 18:20:55 | dansmith | belmoreira: I think you want to delete the buildrequest here: https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L998 | |
| 18:21:41 | dansmith | if you can test that, I think we could probably merge that change | |
| 18:22:27 | belmoreira | but it does it in the nova_api DB? | |