| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-21 | |||
| 16:30:16 | efried | mriedem ^ | |
| 16:31:07 | openstackgerrit | Merged openstack/nova master: Deduplicate keypair notification samples https://review.openstack.org/521562 | |
| 16:31:39 | openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for neutron client https://review.openstack.org/509892 | |
| 16:31:55 | openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for keystone conf & requests https://review.openstack.org/507693 | |
| 16:32:22 | openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for cinder client https://review.openstack.org/508345 | |
| 16:32:38 | niraj_singh | i am working on service token for cinder nova interaction. | |
| 16:32:39 | niraj_singh | Cinder backend is NFS and Nova backend is LVM. | |
| 16:32:39 | niraj_singh | Conf option for nova and cinder: http://paste.openstack.org/show/626972/ | |
| 16:32:39 | niraj_singh | i am creating volume snapshot that is attached to an instance. | |
| 16:32:39 | niraj_singh | while creating snapshot i am getting error at compute side. | |
| 16:32:39 | niraj_singh | Please find the log :http://paste.openstack.org/show/626966/ | |
| 16:32:41 | niraj_singh | Any help? | |
| 16:33:18 | bauzas | ralonsoh: https://pypi.python.org/pypi/os-traits/0.4.0 is there | |
| 16:34:07 | bauzas | ralonsoh: could you please provide a new patchset that would use it and just depend on https://review.openstack.org/#/c/521883/ ? | |
| 16:34:23 | ralonsoh | bauzas: i'll submit another patch for https://review.openstack.org/#/c/466051/ | |
| 16:34:29 | bauzas | ralonsoh: cool thanks | |
| 16:37:56 | efried | sdague I think this was one you and I talked about: https://review.openstack.org/#/c/512329/ | |
| 16:43:32 | gibi | jianghuaw: I see I missed the party in https://review.openstack.org/#/c/512580 and now it is on the gate. Sorry for not having the bandwidth to check it earlier | |
| 16:48:52 | openstackgerrit | Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/519066 | |
| 16:49:45 | moshele | stephenfin: done ^ | |
| 16:52:12 | openstackgerrit | Jay Pipes proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027 | |
| 16:52:13 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add ProviderSummary.resource_class_names @property https://review.openstack.org/517646 | |
| 16:52:14 | openstackgerrit | Jay Pipes proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119 | |
| 16:52:14 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | |
| 16:52:14 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617 | |
| 16:52:15 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | |
| 16:52:15 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | |
| 16:52:16 | openstackgerrit | Jay Pipes proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189 | |
| 16:52:18 | jaypipes | efried: et voila. ^ | |
| 16:52:25 | efried | jaypipes ack | |
| 16:54:11 | sean-k-mooney | jaypipes: did you just push shared RP support or just traits to model shared and non shared RPs? | |
| 16:57:32 | sean-k-mooney | stephenfin: regarding embedded niantics i believe Intel sells embedded mezzanine form factor cards to dell/hp and there is also a version that is integrated into the motherboard too. | |
| 16:57:55 | efried | sean-k-mooney We're kinda working shared in as we go - at least to the point of maintaining existing functionality. Though we won't officially "support" it in Q, I don't imagine. | |
| 16:58:32 | stephenfin | dansmith: Could you take a look at this? https://review.openstack.org/#/c/396184/ Think it's something I should backport after | |
| 16:59:14 | dansmith | stephenfin: oh gawd | |
| 16:59:21 | dansmith | stephenfin: yeah, will look when I get off this call | |
| 16:59:26 | stephenfin | (y) | |
| 16:59:28 | sean-k-mooney | efried: ah cool. | |
| 17:03:46 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947 | |
| 17:03:47 | mriedem | efried: you'll like this ^ let's not fail with NoneType errors during re-auth | |
| 17:04:01 | mriedem | niraj_singh had a real issue and then left | |
| 17:04:43 | efried | mriedem https://review.openstack.org/#/c/512329/ | |
| 17:05:05 | sean-k-mooney | stephenfin: so looking at that you infer the request for pinning by checking "self.cpu_pinning is not None" what dose self.cpu_pinning contain? will that check work if i explcitly set the policy to shared in the flavour | |
| 17:05:36 | stephenfin | sean-k-mooney: We _used_ to do that, then we added a field to actually store the policy | |
| 17:05:47 | efried | mriedem And yeah, I just sent him an email. | |
| 17:06:19 | stephenfin | With recent object versions, we check the policy field. However, that patch ensure the older object versions continue to work | |
| 17:06:22 | efried | mriedem I bet he didn't realize the conf split that happened a couple months ago, and has his stuff in the wrong conf file. | |
| 17:06:50 | mriedem | efried: replied on yours | |
| 17:06:54 | mriedem | i don't like raising a random exception here | |
| 17:07:20 | efried | mriedem Having seen yours, I suspected that would be the case. | |
| 17:07:30 | mriedem | well, | |
| 17:07:35 | mriedem | it punishes the user for the operator screwing up | |
| 17:07:41 | efried | mriedem I would rather fail early. | |
| 17:07:49 | efried | mriedem Because otherwise they probably get the original bug | |
| 17:07:50 | mriedem | plus, it could leak 500s out of the api | |
| 17:08:23 | mriedem | the original bug is the user token times out and you can't re-auth, which is no different from not using the service user stuff | |
| 17:08:41 | mriedem | with your change, the operator screws up and the api user is punished, plus we probably get 500s for this now | |
| 17:09:00 | mriedem | because i'm sure there is REST API code calling glance/cinder/neutron client stuff and not handling the error you're raising | |
| 17:09:01 | efried | mriedem The service will fail very early, likely before the user even got his hands on it. | |
| 17:09:52 | mriedem | you're assuming operators are doing full api test coverage, including all of the proxy apis which are going to hit tis code | |
| 17:10:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: test: Store the OutputStreamCapture fixture https://review.openstack.org/515146 | |
| 17:10:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-status: Migrate to cliff https://review.openstack.org/515147 | |
| 17:10:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename 'policy_check' -> 'policy' https://review.openstack.org/515148 | |
| 17:10:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-policy: Migrate to cliff https://review.openstack.org/515149 | |
| 17:10:23 | efried | mriedem It only has to be hit once from one API. Like if they create a flavor or an image or whatever. | |
| 17:10:42 | efried | mriedem Which admins tend to do early on before they hand their cloud off to users, true? | |
| 17:10:58 | efried | mriedem So I guess we don't cover the case where they've got an existing cloud and they just decide to enable this thing. | |
| 17:11:58 | mriedem | i also wouldn't backport yours | |
| 17:12:14 | mriedem | because if i'm on stable and pick that up, and all of a sudden i start getting 500s, i'd be annoyed | |
| 17:14:29 | efried | mriedem Is backporting a consideration? The service user thing is experimental, right? | |
| 17:14:42 | mriedem | i don't consider it experimental | |
| 17:14:49 | mriedem | it's been in since ocata and we run with it enabled in our nova-next job | |
| 17:14:54 | mriedem | so yes i was going to backport | |
| 17:15:06 | mriedem | i've also marketed this feature during 2 summit project update talks | |
| 17:15:17 | efried | mriedem https://github.com/openstack/nova/blob/master/nova/conf/service_token.py#L43 | |
| 17:15:27 | efried | So I guess we oughtta take that line out ^ | |
| 17:15:37 | jaypipes | sean-k-mooney: that series touches both traits and shared resource providers | |
| 17:15:48 | jaypipes | sean-k-mooney: it's a combo of me, efried and gibi. | |
| 17:16:54 | mriedem | efried: yeah i'd be fine with that | |
| 17:16:58 | mriedem | i'd leave it disabled by default | |
| 17:21:17 | openstackgerrit | Eric Fried proposed openstack/nova master: Service token is not experimental https://review.openstack.org/521955 | |
| 17:21:19 | efried | mriedem ^ | |
| 17:23:13 | mriedem | wanna remove the 'this is disabled by default' line? | |
| 17:23:16 | mriedem | then i'm +2 | |
| 17:23:58 | dansmith | artom_: good comments, thanks for those | |
| 17:24:10 | dansmith | mriedem: you might want to look at those before you push up a rev and see if you have opinions | |
| 17:24:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated 'multi_instance_display_name_template' opt https://review.openstack.org/499612 | |
| 17:24:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Simplify instance name generation https://review.openstack.org/516573 | |
| 17:24:47 | artom_ | dansmith, yey, my brain works! | |
| 17:27:22 | sean-k-mooney | stephenfin: sorry had to step away for a minute. well what i was wondering is wether "is not none" is enough e.g. can self.cpu_pinning contain "shared" | |
| 17:29:46 | mriedem | efried: +2 on https://review.openstack.org/#/c/490057 - thanks for the quick updates | |
| 17:29:59 | stephenfin | sean-k-mooney: cpu_pinning contains a dict of host to guest CPU mappings | |
| 17:30:11 | efried | mriedem Thanks. | |
| 17:30:13 | stephenfin | You're thinking of 'cpu_policy', which would contain 'shared' or 'dedicated' | |
| 17:30:48 | openstackgerrit | Merged openstack/nova master: Merge flavor extensions controller code https://review.openstack.org/516104 | |
| 17:33:49 | sean-k-mooney | stephenfin: yes i just noticed self.cpu_pinning is a proxy field for cpu_pinning_raw whic is a dict of integers presumable the vCPU to pCPU mappings | |
| 17:34:06 | efried | mriedem I dup'd my bug (https://bugs.launchpad.net/nova/+bug/1724689) to yours and abandoned my patch. | |
| 17:34:06 | openstack | Launchpad bug 1733642 in OpenStack Compute (nova) "duplicate for #1724689 AttributeError: 'NoneType' object has no attribute 'get_token'" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | |
| 17:34:42 | mriedem | efried: ok, i was going to dupe my bug against yours but ok :) | |
| 17:34:47 | artom_ | I feel like naming it "policy" is confusing us | |