| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-15 | |||
| 23:31:54 | dansmith | but using shelve as the poster child is probably a weaker argument than delete | |
| 23:32:14 | mriedem | yeah, anything to do with ports and volumes + shelve is a roll of the dice | |
| 23:32:25 | mriedem | given we didn't actually terminate connetions for the last 4 years for volumes on unshelve | |
| 23:32:25 | dansmith | yeah | |
| 23:32:41 | dansmith | well, doing the same thing as delete is defensible so if that's the plan it seems reasonable | |
| 23:32:52 | mriedem | alright | |
| 23:33:12 | mriedem | i'll see if can wordsmith a reasonable commit message | |
| 23:33:24 | mriedem | because there is also prior art in this area which always confuses me | |
| 23:35:11 | gmann | yikun: re: on https://review.openstack.org/#/c/518644/11 | |
| 23:36:04 | gmann | yikun: all param in query are as string so we use type as string, if any param is integer then we can use non_integer or positive_integer schema | |
| 23:37:13 | gmann | yikun: and on additionalProperties=True we kept that for backward compatibility but at validation layer all the additional properties will be ignored and stripout | |
| 23:38:17 | gmann | yikun: if you are doing migration pagination with microversion then you can make it False. anyways i will check the patch series today | |
| 23:38:39 | mriedem | gmann: i updated that one today | |
| 23:38:47 | mriedem | the schema thing anyway | |
| 23:39:04 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.54 - Enable reset keypair while rebuild https://review.openstack.org/519572 | |
| 23:39:35 | gmann | mriedem: it is with version bump ? | |
| 23:39:51 | mriedem | no | |
| 23:39:55 | mriedem | it's all backward compatible | |
| 23:39:59 | mriedem | because additionalProperties=True | |
| 23:40:24 | mriedem | i removed cell_name from the list of query parameters in the schema because it's not used anywhere in the actual nova code, | |
| 23:40:29 | mriedem | novaclient sends it, but shouldn't | |
| 23:40:38 | mriedem | so i'm just treating cell_name like additionalProperties | |
| 23:40:49 | mriedem | in a far flung future microversion we can change all of that | |
| 23:42:06 | gmann | mriedem: i see. | |
| 23:42:12 | gmann | got confuse with https://review.openstack.org/#/q/topic:bp/add-pagination-and-change-since-for-migration-list+(status:open+OR+status:merged) | |
| 23:42:34 | gmann | that patch is just putting schema for existing filters. | |
| 23:42:38 | mriedem | yes, | |
| 23:42:46 | gmann | patch topic was new BP | |
| 23:42:47 | mriedem | it was part of https://review.openstack.org/#/c/330406/ originally and i asked that he split it out | |
| 23:42:53 | gmann | ok | |
| 23:43:33 | mriedem | ah yeah https://review.openstack.org/#/c/330406/58/nova/api/openstack/compute/schemas/migrations.py@47 | |
| 23:43:43 | mriedem | so in 2.55 he'd now restrict to the list of known parameters | |
| 23:44:01 | gmann | nice. | |
| 23:44:35 | gmann | and all pagination param are single_param.+1 | |
| 23:51:50 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | |
| 23:51:51 | openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | |
| 23:51:51 | openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | |
| 23:51:52 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | |
| 23:51:52 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | |
| 23:51:53 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | |
| 23:51:53 | openstackgerrit | Ed Leafe proposed openstack/nova master: Refactor the code to check for sufficient hosts https://review.openstack.org/520242 | |
| 23:52:12 | edleafe | mriedem: ^^ refactored | |
| 23:53:38 | efried | jaypipes I find it very confusing that _Provider represents a node in a tree of providers, but ProviderTree actuall represents any number of such trees. | |
| 23:54:12 | efried | Rename ProviderTree to ProviderTrees. Or ProviderBush. | |
| 23:56:38 | edleafe | efried: ProviderVine? | |
| 23:57:06 | efried | edleafe ProvideMeVino | |
| 23:57:24 | edleafe | I like the way you think! | |
| 23:57:38 | eandersson | btw does placement take actual resources into account when scheduling vms on overcommited hosts? | |
| 23:59:04 | eandersson | In Mitaka we are hitting this when the compute is out of memory, but the scheduler still thinks there is room available | |
| 23:59:05 | eandersson | > qemu-kvm: cannot set up guest memory 'pc.ram': Cannot allocate memory | |
| 23:59:08 | openstackgerrit | Eric Fried proposed openstack/nova master: Iterator for a provider tree https://review.openstack.org/520243 | |
| 23:59:28 | efried | jaypipes We're gonna need that ^ | |
| 23:59:42 | mriedem | eandersson: are you setting the reserved space config? | |
| 23:59:51 | eandersson | Yea | |
| #openstack-nova - 2017-11-16 | |||
| 00:00:00 | eandersson | This is with overcommit 1.5 on memory, which is fine in most cases for us | |
| 00:00:02 | mriedem | reserved_host_memory_mb | |
| 00:00:04 | mriedem | ^ | |
| 00:00:15 | eandersson | The problem is that if one or two VMs are using all their memory | |
| 00:00:24 | eandersson | the overcommit ratio won | |
| 00:00:26 | eandersson | won't work | |
| 00:00:44 | mriedem | the reserved_host_memory_mb config option is used to tell placement that there is reserved space on a compute that can't be claimed by nova | |
| 00:00:49 | mriedem | and the scheduler will take that into account | |
| 00:01:30 | eandersson | Lets say you have 10GB memory, and 4 VMs with 5GB each and overcommit set to 2x (total 20GB) | |
| 00:02:00 | eandersson | or even better 12GB memory, 4 VMs with 5GB etc and reserved_host_memory_mb set to 2GB | |
| 00:02:29 | eandersson | If three of those VMs are actually using 10GB in total | |
| 00:02:37 | eandersson | The forth VM will fail to be created | |
| 00:03:32 | eandersson | but the scheduler will think that there is room on the VM, as it thinks the compute has 20+2GB memory | |
| 00:04:23 | mriedem | have you tried to recreate that in ocata? | |
| 00:04:36 | mriedem | otherwise i'm going to have to phone a friend (jaypipes) | |
| 00:04:53 | eandersson | I haven't yet | |
| 00:05:02 | eandersson | tbh it's not a big deal, but it's the issue causing the duplicate ips | |
| 00:05:13 | eandersson | (so fixing the dup ips and worst case it will reschedule) | |
| 00:05:15 | mriedem | ok, well, reschedules is a big deal we're trying to kill off | |
| 00:05:28 | mriedem | and still support reschedules with cells v2 | |
| 00:05:37 | mriedem | so we're assuming that reschedules shouldn't happen due to failed claims | |
| 00:05:58 | eandersson | I'll see if I can test it in Ocata or Pike. | |
| 00:05:59 | mriedem | at least now that in pike with the filter scheduler we 'claim' in the scheduler rather than the compute | |
| 00:06:03 | mriedem | try it with pike | |
| 00:06:11 | mriedem | pike is the scheduler change to allocate resources in the scheduler rather than compute | |
| 00:06:15 | mriedem | using placement with the filter scheduler | |
| 00:06:18 | eandersson | Only tested it in Mitaka so far, but would motivate us to upgrade sooner :D | |
| 00:06:26 | mriedem | if things still don't work and yo'ure hitting reschedules, that would be very good to know | |
| 00:10:25 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_inventory from the resource tracker https://review.openstack.org/520246 | |
| 00:10:44 | efried | jaypipes And here's where I'm going with it ^ | |
| 00:12:21 | openstackgerrit | Hongbin Lu proposed openstack/nova-specs master: [WIP] Choose default network on ambiguity https://review.openstack.org/520247 | |
| 00:26:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Always deallocate networking before reschedule if using Neutron https://review.openstack.org/520248 | |
| 00:26:12 | mriedem | eandersson: here you go ^ | |
| 00:26:42 | eandersson | <3 | |
| 00:26:51 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix missing metavar in aggregate-update https://review.openstack.org/512485 | |
| 00:27:04 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Set the 'Upgrade impact' subsection as optional https://review.openstack.org/517223 | |
| 00:27:19 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Rocky https://review.openstack.org/514101 | |
| 00:27:29 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579 | |
| 00:27:49 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | |
| 00:28:03 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update document related to host aggregate https://review.openstack.org/514499 | |
| 01:09:45 | alex_xu | gmann: cleanup few things https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:cleanup_extension | |
| 01:09:58 | alex_xu | gmann: I rememer we have a blueprint for those cleanup, do you have the link? | |
| 01:21:49 | gmann | alex_xu: yea, you can use this https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-queens | |
| 01:21:49 | alex_xu | gmann: thanks | |
| 01:21:49 | gmann | alex_xu: i think i created etherpad also for that, may be forgot to ping you. | |
| 01:21:49 | gmann | let me search | |