Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-14
15:51:20 tristanC mriedem: could we get +2 on the patches as well as the related change on stable/newton?
15:51:41 jianghuaw_ mriedem, could you suggest what I should do to move forward these two patches? https://review.openstack.org/#/q/topic:vdiStream+(status:open+OR+status:merged)+project:+openstack/nova
15:52:01 mriedem tristanC: that's why i pinged dan and sylvain
15:52:06 mriedem they are stable core
15:52:16 mriedem and master branch core for that matter...
15:52:50 tristanC does the pre-OSSA update looks good to you?
15:53:05 mriedem tristanC: the etherpad?
15:53:21 tristanC yes, https://etherpad.openstack.org/p/ofe4voc7sg
15:53:22 mriedem etherpad looks fine
15:53:30 sean-k-mooney hum... on the plus side my openstack --os-cloud devstack-admin --os-region RegionOne compute service list --host vhost-user --service nova-compute -c ID -f value issue also happens on ubuntu. on the negitive side it also happens on ubuntu ...
15:53:53 mriedem sean-k-mooney: what issue?
15:54:18 tristanC mriedem: thanks!
15:54:31 mriedem jianghuaw_: do you mean regarding the blueprint?
15:54:38 sean-k-mooney mriedem: devstack is failing for me with "Didn't find service registered by hostname after 60 seconds" checking for the nova compute service to be registered
15:55:02 jianghuaw_ mriedem, yes.
15:55:03 jaypipes sean-k-mooney: apologies, keep getting ripped away :(
15:55:10 mriedem sean-k-mooney: does the hostname match what's getting created via the discover_hosts CLI?
15:55:24 mriedem discover_hosts CLI is what creates the host mappings in the cell in the api db
15:55:46 sean-k-mooney mriedem: ill check the conductor console auth and scheduer are registered
15:55:48 mriedem jianghuaw_: i wish you would have asked several weeks ago, before the spec freeze
15:56:03 jaypipes crlb: yessir
15:56:22 openstackgerrit Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464
15:56:51 jianghuaw_ mriedem, that's a shame. I thought I asked here to get reviewing on the patches.
15:57:46 jianghuaw_ mriedem, I thought that's spec-less BP.
15:58:14 mriedem jianghuaw_: it is a specless bp, but i generally consider new bp approval freeze to be at the same time as the spec freeze, which was october 19
15:58:16 mriedem nearly a month ago
15:58:30 mriedem it's my fault for not being clear about that,
15:58:43 mriedem but also, specless blueprints are supposed to be brought up in the weekly nova meeting to get discussion and approval
15:58:52 jianghuaw_ mriedem, sorry. That's my fault.
15:58:57 tssurya dansmith : thanks for the review I will address the comments soon, and yes you are right about the integrity issue with regards to us ending up with a different list of uuids than what we actually deleted, the same problem also exists between the list of records inserted into the shadow tables and the list archived - we had a bug reported ; https://bugs.launchpad.net/nova/+bug/1727266
15:58:57 openstack Launchpad bug 1727266 in OpenStack Compute (nova) "archive_deleted_instances is not atomic for insert/delete" [Undecided,In progress] - Assigned to Surya Seetharaman (tssurya)
15:59:13 tssurya dansmith : maybe we need to first query for the list of records whose deleted flag is set; use that list to insert into the shadow tables, archive from the actual tables and also return the same list for deleting the instance_mappings and request specs ?
15:59:48 mriedem jianghuaw_: https://docs.openstack.org/nova/pike/contributor/blueprints.html#specs "When a blueprint does not require a spec it still needs to be approved before the code which implements the blueprint is merged. Specless blueprints are discussed and potentially approved during the Open Discussion portion of the weekly nova IRC meeting. See trivial specifications for more details."
16:00:17 dansmith tssurya: just about to jump on a call so I can't really process that in my head at the moment, so can you put it in the review for me to read when I circle back?
16:00:23 jianghuaw_ mriedem, got it. Thanks.
16:00:33 tssurya dansmith : yes of course
16:00:42 crlb jaypipes I'm running tox locally and getting no errors. However, on the review, Zuul, Dell, and Xen, appear to give errors that I don't understand. Is there something else I should be doing?
16:00:50 dansmith tssurya: thanks
16:01:38 mriedem tristanC: +2s on https://review.openstack.org/#/q/I11746d1ea996a0f18b7c54b4c9c21df58cc4714b
16:01:40 tristanC dansmith: thanks, appreciated the fast review!
16:01:41 dansmith mriedem: tristanC I just hit the last one
16:01:46 dansmith heh, yep
16:01:48 mriedem dansmith: thanks
16:02:05 mriedem i will assume bauzas is on the same call
16:02:08 jaypipes crlb: how are you running tox locally?
16:02:15 jaypipes crlb: do this: tox -epy27,pep8
16:02:23 jaypipes crlb: and you'll see the same errors.
16:02:31 tristanC i'm waiting for vmt +2 on the ossa (https://review.openstack.org/519686) to send the advisory
16:04:54 mriedem ack
16:05:35 bauzas mriedem: thanks for helping with https://review.openstack.org/#/c/519662/
16:05:54 sean-k-mooney mriedem: so looking at the nova_api db the host_mappins is empty as is the compute_nodes table in the cell1 db however the devstack@n-cpu.service is running on the hsot according to systemctl
16:05:55 bauzas and thanks for the tests
16:06:17 mriedem tristanC: small typo in your patch
16:10:47 sean-k-mooney mriedem: huh i just realised there is a giant Guru Meditation report dump in the nova-compute journalctl log. is there a partcalar part that i should read in that to figure out what failed
16:11:25 mriedem i think that happens when you kill the service?
16:11:40 mriedem i'd check for errors in the n-cpu logs about why the compute node record wasn't created
16:12:06 mriedem are the conductor services running?
16:12:23 jaypipes sean-k-mooney: the guru part.
16:14:28 bauzas mriedem: dansmith: FWIW, I'm having a big problem with my IRC bouncer so for the moment, I'm not getting a notify if someone asks me
16:14:46 bauzas mriedem: but yeah, just saw your pings
16:17:24 sean-k-mooney mriedem: according to openstack compute service list yes. that said on ubuntu i actully have a tracback and a libvirt issue. on centos it prints no No Traceback! in one of the green tread imediatly after connecting to libvirt
16:18:41 mriedem efried: remember that ksa adapter bug i pointed out to you on saturday? did that amount to anything?
16:18:50 mriedem person was having failures connecting to glance
16:18:56 openstackgerrit Matthew Booth proposed openstack/nova stable/pike: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/519631
16:18:56 openstackgerrit Matthew Booth proposed openstack/nova stable/pike: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/519632
16:19:15 efried mriedem I don't believe it was a ksa adapter thing. I responded in the bug report. I think they had either their conf or their catalog misconfigured.
16:19:39 mriedem ok you must have invalidated the bug?
16:19:47 efried mriedem I marked it as Incomplete
16:19:52 mriedem oh ok
16:20:15 efried mriedem From what I could tell, they were running pike, so it would be before my ksa adapter code, FWIW.
16:20:57 efried I mean, still going through ksa adapters & sessions ultimately
16:23:04 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: fix link to creating unit tests in contributor guide https://review.openstack.org/519482
16:23:42 mriedem bauzas: don't forget the two changes below https://review.openstack.org/#/c/519684/
16:24:20 bauzas done
16:25:06 mriedem thanks. dansmith ^ when you're off your call
16:25:52 mriedem tristanC: changes are all approved, just need to approve the dependencies on the newton change
16:25:58 mriedem i'll request releases on all stable branches once those are merged
16:26:01 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
16:26:17 mriedem and then we'll eol newton
16:32:37 prometheanfire mriedem: https://review.openstack.org/#/c/519672/ doesn't apply to 16.0.2 cleanly, are we expecting releases soon with the fix (for pike/ocata at least)?
16:33:47 mriedem prometheanfire: "(10:25:59 AM) mriedem: i'll request releases on all stable branches once those are merged"
16:34:05 prometheanfire thanks, just rejoined the channel at 10:33
16:34:09 mriedem doh
16:34:12 prometheanfire :P
16:36:37 dansmith mriedem: got them sorry
16:36:53 mriedem thanks, np
16:37:14 mriedem welcome back to the land of the (koala) free
16:40:32 dansmith you mean "welcome back to the land of internet"
16:40:43 dansmith and yes, it's good to be back on the right side of the wet noodle
16:43:54 mriedem tonyb: would you be against changing this release note on stable/pike to be 'fixes' or 'other' rather than 'features'? https://review.openstack.org/#/c/513717/4/releasenotes/notes/bug-1721179-87bc7b64215944c0.yaml
16:44:01 mriedem i don't want to alarm people reading stable patch release notes
16:44:57 sean-k-mooney efried: just comming to the end of the video on Ironic-Nova traits discussion. given the audiunce and topic it makes sense that only the ironic case was discussed but everything discussed also need to work with just plain nova
16:45:09 efried sean-k-mooney Yup.
16:45:18 efried sean-k-mooney Somehow...
16:45:52 sean-k-mooney efried: so with nova i need to be able to request the vm to be placed on a hypervior with secure boot enabled on the host not the vm
16:46:44 efried sean-k-mooney Does enabling secure boot on the hypervisor entail bouncing the compute service?
16:47:10 sean-k-mooney efried: i expcitly do not want to enabled it. i want to find a hypervisor with it enabled
16:47:38 sean-k-mooney efried: the config map thing iss irrelevent in this case as i do dont want to change configuration
16:48:15 sean-k-mooney efried: but yes it would require a host reboot to chage secureboot and it would require the host os is signed and the signing key is sored in the firmware
16:48:51 efried sean-k-mooney Okay, great. What I'm getting at is: if you enable secure boot on a hypervisor, and you have to restart the host (or at least restart the compute service) then we can make the case that the virt driver should set the SECURE_BOOT_CAPABLE trait on that host's RP.

Earlier   Later