Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-13
20:37:20 tasker ok. I'll have that and a test (i hope) submitted in a little bit.
20:59:35 openstackgerrit Merged openstack/nova master: Enable reset keypair while rebuilding instance https://review.openstack.org/379128
21:26:17 tasker this url https://docs.openstack.org/nova/latest/reference/unit_tests.html is no longer valid. does anyone know where it ended up?
21:31:45 mriedem tasker: https://docs.openstack.org/nova/latest/contributor/testing.html#unit-tests ?
21:33:26 mriedem that page linking to the hacking repo docs seems like the wrong thing to do...
21:37:55 mriedem it was probably supposed to link to this https://github.com/openstack/nova/blob/master/HACKING.rst#creating-unit-tests
21:40:22 tasker sorry -- got sidetracked because of /.
21:41:06 tasker the latter is where I ended up after some trolling.
21:52:14 mriedem i'll fix the link in our docs to point at nova/HACKING.rst, although that is pretty outdated
21:52:14 mriedem 1. use mock, not stubs or mox; 2. easiest to start with an existing test over the same function, copy it and tweak for what you need to test
21:52:14 tasker thanks for the suggestion. I'm doing 2 now and just saw 1 in one of the other tests.
21:52:15 mriedem there might be an existing test for the OverLimit failure, and your change makes it fail if yo'ure not mocking out the unquiesce_instance call you added
21:52:15 mriedem mtreinish: nova uses os-testr which uses stestr now right?
21:52:15 mriedem so nova saying it's using testr isn't really accurate anymore
21:53:22 mtreinish mriedem: actually nova is using stestr directly in most places now
21:53:45 mriedem ah yeah stestr run '{posargs}'
21:59:17 mtreinish mriedem: if you're updating the nova docs, the user manual for stestr is: http://stestr.readthedocs.io/en/latest/MANUAL.html
21:59:45 mriedem yup, just linking to the main index
22:04:29 efried patchbot seems to be down
22:15:27 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: fix link to creating unit tests in contributor guide https://review.openstack.org/519482
22:15:41 mriedem efried: looks like it's working for me
22:16:28 efried mriedem Okay. Maybe it just hates me. I just rebased this whole series https://review.openstack.org/#/c/516778/ and nothing popped up.
22:20:35 openstackgerrit Michael Still proposed openstack/nova master: Move remaining uses of parted to privsep. https://review.openstack.org/519483
22:20:35 openstackgerrit Michael Still proposed openstack/nova master: Convert users of tune2fs to privsep. https://review.openstack.org/519484
22:52:34 squid hi, i seem to sporadically have nova snapshots failing, with rbd as the backend, it throws the error "ERROR oslo_messaging.rpc.server ImageNotAuthorized: Not authorized for image fc378659-9d6f-41d6-8c7f-a7d08c2bdb54"
22:52:39 squid any idea what might be causing this?
22:54:38 calebb this is using the faster rbd backend snapshots as well
22:58:11 calebb sorry i'll put this in #openstack
22:59:24 tasker most places I see ImageNotAuthorized being thrown are a synonym to HTTPForbidden. check the OpenStack user that's initiating the call. Also check the glance / rbd authentication and make sure that glance has proper access to the requisite pools.
22:59:58 openstackgerrit Eric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380
23:00:37 efried gibi Hey, I noticed that one of the other tests related to bug 1730730 started passing when incorporated into Jay's series, so I rebased yours on the same.
23:00:37 openstack bug 1730730 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with only sharing providers" [Undecided,New] https://launchpad.net/bugs/1730730
23:01:04 efried gibi The behavior changed - we're no longer getting the partial candidates (missing some resources). But we are still getting the duplicates. See above.
23:05:05 calebb tasker: thanks, i'll look into those things more, but at first glance (heh) they seem correct
23:06:14 openstackgerrit Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464
23:08:17 tasker still not seeing the test in my head yet. I've got one test at nova/tests/functional/regressions/test_bug_1554631.py that deals with cinder OverLimit but doesn't deal with the snapshot_volume_backed function. and then there's nova/tests/unit/compute/test_compute_api.py that has several tests of snapshot_volume_backed.
23:10:22 tasker as best I can see it in my head, I want to mock the cinder_client. something like 1) cinder_client = mock({snapshot_volume.side_effect = cinderclient.exceptions.OverLimit}), 2) call snapshot_volume_backed with the mock cinder_client, 3) check that the proper exception was raised, and 4) check that the instance in unquiesecd / thawed.
23:11:06 mriedem tasker: yes, i'd avoid the functional test you referenced, and just add a unit test
23:11:14 tasker ok.
23:11:38 mriedem test_bug_1554631 is dealing with the volume/snapshot proxy apis which are deprecated and not what you're trying to fix
23:11:56 mriedem you'll also need to mock out the quiesce_instance call so that it "passes"
23:13:21 mriedem tasker: looks like you could hack something into test_snapshot_volume_backed_with_quiesce
23:13:40 tasker sorry .. first time using mock. so, this is a mock.patch(compute.api), altering quiesce_instance() and unquiesce_instance()?
23:13:43 mriedem make fake_volume_create_snapshot raise an exception
23:14:59 mriedem i'm not sure that you'd need to mock anything in there
23:16:17 tasker I thought about tweaking compute/test_compute_api.py to fit my needs but thought that might be too much. instead, I've fretted all afternoon. . /
23:16:29 tasker I'll see what I can do with that.
23:17:39 mriedem tasker: i'm thinking something like this http://paste.openstack.org/show/626204/
23:18:17 tasker yeah .. that's right where I was heading.
23:18:38 mriedem except self.compute_api.snapshot_volume_backed will raise that OverQuota failure, so you'd need to handle that as well
23:19:42 tasker overs="snapshots"? what's 'overs'?
23:19:51 mriedem part of the OverQuota error message
23:19:52 mriedem it's a kwarg
23:20:14 mriedem https://github.com/openstack/nova/blob/master/nova/exception.py#L1054
23:20:21 mriedem http://paste.openstack.org/show/626205/
23:23:31 tasker and then use "tox" to test it?
23:25:51 tasker or stestr?
23:32:08 mriedem tox
23:32:27 mriedem tasker: you can just run that one test like so: tox -e py27 -- test_snapshot_volume_backed_with_quiesce_create_snap_fails
23:32:44 mriedem and now i'm afk for awhile
23:46:35 openstackgerrit Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464
23:47:11 tasker mriedem: thanks for the help. got the test in place and it's passing. (never sure if that's a full good thing).
#openstack-nova - 2017-11-14
01:40:21 openstackgerrit Yikun Jiang proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644
02:15:35 openstackgerrit licanwei proposed openstack/nova master: cli 'nova-manage db sync' can't upgrade cell1 https://review.openstack.org/519275
02:43:22 openstackgerrit Eric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters() https://review.openstack.org/516782
02:43:22 openstackgerrit Eric Fried proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027
02:43:23 openstackgerrit Eric Fried proposed openstack/nova master: Add ProviderSummary.resource_class_names @property https://review.openstack.org/517646
02:43:23 openstackgerrit Eric Fried proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119
02:43:24 openstackgerrit Eric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380
02:43:48 openstackgerrit Yikun Jiang proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644
03:17:08 openstackgerrit Yikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871
03:18:15 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:18:40 openstackgerrit Yikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273
03:24:59 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:56:38 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
03:57:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
04:02:53 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326
04:18:34 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
05:19:44 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
06:44:48 openstackgerrit Merged openstack/nova master: Correct log message when removing a security group https://review.openstack.org/519313
07:18:02 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration_get_by_uuid in db api. https://review.openstack.org/511421
07:18:02 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
07:18:03 openstackgerrit Yikun Jiang proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644
07:18:03 openstackgerrit Yikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871
07:18:04 openstackgerrit Yikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273
07:18:05 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
07:20:02 openstackgerrit Nguyen Van Trung proposed openstack/nova-specs master: Add linters test to run spec validation https://review.openstack.org/519561
07:22:47 openstackgerrit Yikun Jiang proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644
07:24:33 openstackgerrit Yikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871
07:25:31 openstackgerrit Yikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871
07:25:50 openstackgerrit Yikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273
07:26:11 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
07:51:39 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.54 - Enable reset keypair while rebuild https://review.openstack.org/519572
08:06:17 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.55 - Enable cold migration with target host https://review.openstack.org/406707
08:13:59 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
08:23:28 openstackgerrit Nguyen Van Trung proposed openstack/nova-specs master: Add linters test to run spec validation https://review.openstack.org/519561
08:26:46 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257
08:48:32 openstackgerrit Saverio Proto proposed openstack/nova stable/pike: Correct log message when removing a security group https://review.openstack.org/519583
08:51:59 openstackgerrit Saverio Proto proposed openstack/nova stable/pike: Correct log message when removing a security group https://review.openstack.org/519583
08:53:01 openstackgerrit Saverio Proto proposed openstack/nova stable/ocata: Correct log message when removing a security group https://review.openstack.org/519585

Earlier   Later