| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-13 | |||
| 14:28:08 | ygl | bauzas: hmm | |
| 14:28:40 | bauzas | like, placement is having a separate routing mechanism AFAIK | |
| 14:30:03 | bauzas | yeah, it uses wsgify | |
| 14:31:15 | ygl | bauzas: thanks for your time | |
| 14:31:22 | bauzas | yeah, placement is totally different https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/placement/handler.py | |
| 14:31:44 | bauzas | ygl: so that really depends on your wishes | |
| 14:32:19 | ygl | bauzas: you are the first personto help me with the code flow of nova thanks for that | |
| 14:32:31 | bauzas | np | |
| 14:34:20 | openstackgerrit | David Wahlstrom proposed openstack/nova master: Fix changes-since search filter https://review.openstack.org/519356 | |
| 14:35:41 | openstackgerrit | David Wahlstrom proposed openstack/nova master: Fix changes-since search filter https://review.openstack.org/519356 | |
| 14:36:17 | openstackgerrit | David Wahlstrom proposed openstack/nova master: Fix changes-since search filter https://review.openstack.org/519356 | |
| 14:40:30 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | |
| 14:43:20 | sdague | efried: you good now, or are there more questions? | |
| 14:43:47 | efried | sdague I believe bauzas answered everything, thanks. | |
| 14:43:56 | sdague | ok, great | |
| 14:49:01 | jianghuaw | bauzas, dansmith, alex_xu: It's appreciated a lot if you can help to review these patches on vGPU: https://review.openstack.org/#/q/topic:bp/add-support-for-vgpu+(status:open) | |
| 14:49:46 | jianghuaw | With these patches, the simple vGPU feature works well for XenAPI. | |
| 14:50:56 | bauzas | jianghuaw: of course, will do | |
| 14:51:10 | jianghuaw | bauzas, thanks:-) | |
| 14:51:38 | bauzas | jianghuaw: just a bit sick today, and still jetlagging from the summit, so don't expect full steam ahead until tomorrow hopefully :) | |
| 14:53:46 | jianghuaw | bauzas, ah. Sorry for that. Take care and hope you will be well soon. | |
| 14:57:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | |
| 14:58:34 | gibi | efried, jaypipes: I found another / simpler case to reproduce bug 1731072 | |
| 14:58:34 | openstack | bug 1731072 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with multiple aggregates" [Undecided,New] https://launchpad.net/bugs/1731072 | |
| 14:59:22 | efried | gibi Looking... | |
| 14:59:46 | efried | (gibi FYI, Jay's out training today) | |
| 15:00:28 | gibi | efried: basically you don't need overlapping RCs to see the bug | |
| 15:01:55 | efried | gibi +1, nice. | |
| 15:02:58 | gibi | efried: I realized that this could be a possible case when I read your regression test. Btw, that looks good so I'm going to +W it now | |
| 15:03:37 | efried | gibi Thanks! | |
| 15:03:58 | gibi | efried: thank your for the bug report and the regression test :) | |
| 15:09:19 | openstackgerrit | Eric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests} https://review.openstack.org/514092 | |
| 15:09:28 | efried | gibi ^ rebased & fixed up that message, good catch. | |
| 15:10:27 | gibi | efried: looking... | |
| 15:10:52 | efried | gibi Ahdang, missed an unused import. One sec... | |
| 15:11:21 | openstackgerrit | Eric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests} https://review.openstack.org/514092 | |
| 15:11:24 | efried | gibi Done. | |
| 15:13:57 | gibi | efried: thanks for the update, +2 | |
| 15:14:03 | efried | Thanks! | |
| 15:14:53 | efried | gibi Don't know how much longer you're around, but if I can help tweak any of Jay's patches to get them moving, let me know. | |
| 15:18:56 | gibi | efried: I think I still have an hour so you can hit me with a patch | |
| 15:19:38 | efried | gibi I was saying if you know of any of Jay's patches that need tweaks, I can get that done so we can keep them moving. | |
| 15:19:51 | efried | At this point I guess everything he has is in merge conflict, so maybe I'll go start rebasing. | |
| 15:20:41 | efried | gibi Meanwhile, if you want some easy +Ws.... | |
| 15:21:37 | efried | gibi https://review.openstack.org/#/c/516783/ and https://review.openstack.org/#/c/517626/ | |
| 15:21:51 | gibi | efried: ahh I underderstand now. I only see merge conflicts and patches waiting for others to look at | |
| 15:21:58 | gibi | efried: looking... | |
| 15:22:52 | efried | gibi There's also one more bug-provin' patch for allocation candidates: https://review.openstack.org/#/c/518633/ | |
| 15:23:16 | efried | gibi ...and the one you looked at earlier which I updated per your comments: https://review.openstack.org/#/c/518982/ | |
| 15:27:00 | gibi | efried: yeah, I opened https://review.openstack.org/#/c/518633/ before but I think I need a fresh mind to walk throught he complexity there, so maybe tomorrow :) | |
| 15:27:15 | efried | okay | |
| 15:27:26 | gibi | I looking that the test helper patch now | |
| 15:32:29 | gibi | that looks good too | |
| 15:34:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | |
| 15:35:05 | gibi | I think I managed to make it even stranger ^^ | |
| 15:35:22 | gibi | I managed to get the same allocation candidate from placement twice | |
| 15:44:00 | tasker | when making a snapshot of a volume-backed instance, the nova driver will queisce the instance's volumes prior to the snapshot. it looks like if the instance fails a snapshot, the exception isn't caught and the instance and its volumes are never thawed: master/nova/compute/api.py#L2738 | |
| 15:45:00 | tasker | am I missing something? I'm still trying to trace through the code to see if the volumes are thawed after and exception. I can't find anything in launchpad regarding this either (could be that I'm not using the right search terms). | |
| 15:48:54 | mriedem | tasker: which release? | |
| 15:50:46 | openstackgerrit | Elod Illes proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539 | |
| 15:50:46 | openstackgerrit | Elod Illes proposed openstack/nova master: factor out compute service start in ServerMovingTest https://review.openstack.org/503037 | |
| 15:50:47 | openstackgerrit | Elod Illes proposed openstack/nova master: Change live_migrate tests to use fakedriver https://review.openstack.org/505202 | |
| 15:50:48 | openstackgerrit | Elod Illes proposed openstack/nova master: Use FakeLiveMigrateDriver in notification test https://review.openstack.org/519405 | |
| 15:50:55 | tasker | the above is git master as of a few minutes ago. | |
| 15:51:24 | tasker | commit a4fc1bcd | |
| 15:52:07 | tasker | I have Mitaka in production where I noticed this problem and I see that function unchanged between Mitaka (commit 9825c80) and current master. | |
| 16:01:34 | tasker | in my case, the snapshot failed due to OverLimit returned by the cinderclient. The exeception bubbles up, and I'm still not seeing anywhere that unquiesces / thaws the instance after the exception. | |
| 16:05:03 | mriedem | ok i remember someone fixing the handling of the OverLimit from cinder, but would have to see if the unquiesce is ever run on failure | |
| 16:05:18 | mriedem | the overlimit used to cause a 500 response from the API | |
| 16:07:32 | maciejjozefczyk | mriedem: We talked during summit about bug in calculating used resources in resource_tracker. The bug is there: https://bugs.launchpad.net/nova/+bug/1729621 | |
| 16:07:32 | openstack | Launchpad bug 1729621 in OpenStack Compute (nova) "Inconsistent value for vcpu_used" [Undecided,New] | |
| 16:07:41 | tasker | the traceback from this morning: http://paste.openstack.org/show/626180/ | |
| 16:08:02 | maciejjozefczyk | I mentioned possible solutions (1. option imo seems to be the right one); could you take a look? | |
| 16:18:24 | mriedem | maciejjozefczyk: sure, thanks for pointing out the bu | |
| 16:18:25 | mriedem | *bug | |
| 16:20:47 | mriedem | maciejjozefczyk: nice recreate :) | |
| 16:28:18 | openstackgerrit | Merged openstack/nova master: Test allocation_candidates with only sharing RPs https://review.openstack.org/518382 | |
| 16:29:44 | tasker | mriedem: I'm not seeing so. the only time I see `unquiesce` called is from compute/api.py#L2807 after the volumes finish snapping. but there is no exception handling between quiesce and unquiesce. if an exception is raised, it goes right past the unuqiesce on its way out the stack. | |
| 16:32:18 | mriedem | tasker: same here | |
| 16:32:26 | mriedem | tasker: want to report a bug? | |
| 16:34:14 | openstackgerrit | Merged openstack/nova master: Update contributor microversion doc for compute https://review.openstack.org/517626 | |
| 16:39:38 | efried | mriedem Do you want me to do anything with https://review.openstack.org/#/c/519034/ ? | |
| 16:40:09 | mriedem | efried: not at this moment no | |
| 16:40:17 | mriedem | efried: i'd like jaypipes to also know about this and look at it | |
| 16:40:30 | mriedem | i'm playing catch up on internal stuff today | |
| 16:40:57 | efried | mriedem Okay. Should I bother to keep rechecking it? I'm convinced that it at least avoids the problem, though of course it's probably just masking the root cause. | |
| 16:42:05 | openstackgerrit | Merged openstack/nova master: placement: Contributor doc microversion checklist https://review.openstack.org/516783 | |
| 16:42:41 | mriedem | efried: i'd like others more involved with placement code to look to see if they have any ideas on root cause | |
| 16:42:57 | mriedem | because i'm not sure why we'd be hitting this with a single scheduler CI job | |
| 16:43:07 | efried | rgr | |
| 16:44:06 | mriedem | johnthetubaguy: sdague: want to slam through this bit of spec accounting? https://review.openstack.org/#/c/516033/ | |
| 16:44:44 | mriedem | stephenfin: you were +W on this before, just needed a rebase https://review.openstack.org/#/c/514782/ | |
| 17:02:56 | dtantsur | folks, who's left the nova_cells meeting running? :) | |
| 17:03:40 | efried | mriedem dansmith Do you have the power to #endmeeting for dtantsur ? | |
| 17:04:23 | dtantsur | I suspect no | |
| 17:04:31 | dtantsur | somebody unrelated has started it, sorry for noise here | |
| 17:04:50 | openstackgerrit | Elod Illes proposed openstack/nova master: Transform instance-live_migration_pre notification https://review.openstack.org/482070 | |
| 17:31:14 | openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/519165 | |
| 17:38:58 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | |
| 17:42:56 | mriedem | sdague: i'm +2 on the keypair reset during rebuild change now https://review.openstack.org/#/c/379128/ | |