| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-13 | |||
| 09:04:13 | openstackgerrit | Spencer Yu proposed openstack/nova master: Use safer ast.literal_eval instead of eval https://review.openstack.org/519268 | |
| 09:05:06 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Change Subnet.dhcp_server to contain multiple IPs https://review.openstack.org/509107 | |
| 09:14:38 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205 | |
| 09:19:03 | openstackgerrit | licanwei proposed openstack/nova master: cli 'nova-manage db sync' can't upgrage cell1 https://review.openstack.org/519275 | |
| 09:26:35 | openstackgerrit | LIU Yulong proposed openstack/nova master: Enable reset keypair while rebuilding instance https://review.openstack.org/379128 | |
| 09:45:33 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | |
| 10:09:26 | openstackgerrit | Spencer Yu proposed openstack/nova master: [WIP]Use defusedxml function instead of lxml.etree.parse https://review.openstack.org/519291 | |
| 10:24:28 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/519127 | |
| 10:24:55 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | |
| 10:28:25 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/519165 | |
| 11:24:30 | openstackgerrit | Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399 | |
| 11:35:52 | openstackgerrit | sahid proposed openstack/nova master: libvirt: disconnect volume from host during detach https://review.openstack.org/515008 | |
| 11:46:22 | openstackgerrit | Saverio Proto proposed openstack/nova master: Correct log message when removing a security group from a port https://review.openstack.org/519313 | |
| 11:51:41 | zioproto | How do I tag this review as low hanging fruit ? | |
| 11:54:05 | zioproto | I mean this one https://bugs.launchpad.net/nova/+bug/1731889 | |
| 11:54:05 | openstack | Launchpad bug 1731889 in OpenStack Compute (nova) "Nova logs adding security group to port when is actually removing a security group from a port" [Undecided,In progress] - Assigned to Saverio Proto (zioproto) | |
| 12:29:36 | openstackgerrit | sean mooney proposed openstack/nova master: add vif info to migration object https://review.openstack.org/515423 | |
| 12:35:50 | gibi | zioproto: you can tag triaged but unassigned bugs as low hanging with the tag low-hanging-fruit. You cannot really tag a review as low hanging but I will go and look at your patch now | |
| 12:39:31 | efried | gibi Greetings! | |
| 12:40:47 | zioproto | gibi: thanks | |
| 12:41:26 | gibi | efried: hi! | |
| 12:42:44 | gibi | zioproto: please fix the commit message then I will +2 your patch | |
| 12:45:20 | openstackgerrit | Saverio Proto proposed openstack/nova master: Correct log message when removing a security group https://review.openstack.org/519313 | |
| 12:45:21 | zioproto | gibi: done ! | |
| 12:51:00 | gibi | zioproto: thanks, +2 | |
| 13:06:45 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 13:16:18 | openstackgerrit | Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | |
| 13:18:00 | efried | gibi ^ -- I had had some trouble using sets in similar situations in the past because some things aren't hashable. But this seems to have worked out okay. Thanks for the suggestion. | |
| 13:19:07 | gibi | efried: cool, I will check that shortly | |
| 13:19:16 | efried | Thanks! | |
| 13:19:29 | gibi | efried: do you know the reason of the functional test failures in https://review.openstack.org/#/c/385693/ ? | |
| 13:19:35 | efried | ... | |
| 13:19:56 | gibi | efried: I guess it is 'Invalid microversion: Unacceptable version header: 1.12' | |
| 13:20:28 | efried | gibi Yeah, looks that way. | |
| 13:21:10 | efried | gibi We don't have 1.12 yet, right? | |
| 13:21:40 | gibi | efried: yeah, as far as I see it is not on master | |
| 13:21:47 | gibi | then I understand, thanks :) | |
| 13:22:14 | gibi | sometimes it is hard to follow what is merged and what is not from nrp | |
| 13:22:28 | efried | Now we need to figure out *WHICH* proposed 1.12 this is dependent on. And it should have a Depends-On accordingly. | |
| 13:23:13 | ygl | hi all | |
| 13:23:37 | gibi | the patch needs to be able to set parent_provider_uuid during RP creation | |
| 13:23:44 | ygl | I want to know the code flow when we excute nova boot command | |
| 13:23:57 | ygl | i have cloned the git for nova | |
| 13:24:36 | ygl | how does the control reaches to nova.api.openstack.compute.servers from the nova api ? | |
| 13:24:38 | gibi | efried: so I guess the patch needs this https://review.openstack.org/#/c/384807/ | |
| 13:24:51 | efried | gibi I was half a second behind you :) | |
| 13:25:04 | ygl | can someone help me with the control flow for launching an instance | |
| 13:25:52 | efried | ygl jaypipes just put out a nice article explaining that flow. Lemme find it for you... | |
| 13:26:02 | ygl | efried: sure thank you | |
| 13:26:13 | gibi | efried: I guess I have the advantages having my second caffe already | |
| 13:26:27 | efried | ygl https://github.com/jaypipes/articles/blob/master/openstack/walkthrough-launch-instance-request.md | |
| 13:26:42 | ygl | efried: let me check it once | |
| 13:30:19 | efried | edleafe- Will there be a scheduler meeting this morning? | |
| 13:33:09 | ygl | efried: thanks for the link. I have a question | |
| 13:33:27 | efried | ygl I'll help if I can. Jay's not on yet. | |
| 13:33:52 | efried | But you clearly read way faster than I do. | |
| 13:34:04 | ygl | efried: after validating the request , it constructs a build request. Which code is responsible in invoking the build request function ? | |
| 13:35:13 | efried | ygl The article links to https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L880 | |
| 13:35:40 | efried | ygl If you look down that function to L927, it looks like the build request is finally built there. | |
| 13:47:50 | ygl | efried: my question is what invokes that build function ? | |
| 13:49:05 | efried | ygl https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L1121 | |
| 13:50:53 | efried | ygl https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L1620 | |
| 13:53:11 | ygl | efried: does this function nova.api.openstack.compute.servers.ServersController.create() invoke build request function ? | |
| 13:53:15 | bauzas | f*ck, my IRC bouncer died | |
| 13:53:21 | bauzas | RIP | |
| 13:53:26 | efried | bauzas We still love you. | |
| 13:54:08 | bauzas | that, and my internal DNS server :( | |
| 13:54:18 | efried | ygl That seems like a reasonable assumption. | |
| 13:55:00 | ygl | efried: i am searching for that connection between the two events | |
| 13:55:29 | gibi | bauzas: welcome back! | |
| 13:55:45 | bauzas | gibi: well, ty | |
| 13:55:50 | efried | ygl Yeah, that's tricky, and I'm not super well-versed on how that works. Perhaps bauzas or stephenfin would know off the top. | |
| 13:56:08 | bauzas | just having a sickness too :p | |
| 13:56:26 | bauzas | sometimes, you love coming back to your house | |
| 13:56:45 | ygl | bauzas: Hi, can you help me with this https://github.com/jaypipes/articles/blob/master/openstack/walkthrough-launch-instance-request.md please ? | |
| 13:57:43 | ygl | bauzas: I am trying to understand what actually invokes the build request function ? | |
| 13:58:27 | efried | bauzas ygl is trying to figure out how we get from an API call to boot an instance, down to the create method in here: https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L1620 | |
| 13:59:13 | bauzas | ygl: have you seen the links ?N | |
| 13:59:26 | openstackgerrit | David Wahlstrom proposed openstack/nova master: Fix changes-since search filter https://review.openstack.org/519356 | |
| 13:59:31 | bauzas | https://github.com/jaypipes/articles/blob/master/openstack/walkthrough-launch-instance-request.md#construct-build-request | |
| 13:59:39 | bauzas | linking to https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L880 | |
| 14:00:43 | efried | bauzas Yeah, we walked that back to nova.compute.api.API.create, but don't know how the call into the REST API gets there. | |
| 14:01:02 | ygl | bauzas: my question is after the http validation by "nova.api.openstack.compute.servers.ServersController.create()" , what actually invookes the build request function ? | |
| 14:01:08 | bauzas | ah | |
| 14:01:14 | bauzas | sec | |
| 14:01:22 | ygl | bauzas: sure | |
| 14:01:36 | bauzas | it calls nova.compute.api.::create() AFAIR | |
| 14:02:00 | bauzas | ie. https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L1584 | |
| 14:03:06 | bauzas | ygl, efried: there, it is https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/compute/servers.py#L542 | |
| 14:03:28 | bauzas | if cellsv1, it can go to the cells API | |
| 14:03:38 | bauzas | but if not, it directly calls the above method | |
| 14:04:17 | efried | bauzas gibi Any interest in having a scheduler meeting in edleafe-'s absence? | |
| 14:04:38 | bauzas | efried: sorry, I'm a bit sick | |
| 14:04:52 | efried | Sorry to hear that. Rest up! | |
| 14:04:55 | bauzas | honestly, nothing to tell about the Sydney suumit | |
| 14:05:44 | gibi | efried:If it just the two of us then I think we can skip the meeting | |
| 14:05:53 | efried | wfm | |
| 14:05:59 | ygl | efried: can you find out for me how the control flows after the POST /servers to the create server function ? | |
| 14:06:36 | efried | ygl That sounds like wsgi stuff. Fraid I'm not the guy there. | |
| 14:06:44 | efried | ygl What is it you're actually trying to do here? | |