Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-01
20:46:45 jaypipes mriedem: I don't see anything else calling _remove_deleted_instances_allocations() other than that place in update_available_resource...
20:47:12 mriedem yeah and the only thing calling update_available_resource is the compute manager in the periodic and in post_live_migration
20:47:37 mriedem the periodic does run every minute...
20:47:56 mriedem but still, we'd have to be hitting that same window between claim in scheduler and creation in cell db
20:48:02 mriedem unless that window is pretty large
20:48:33 jaypipes mriedem: seems fairly unlikely to me.
20:48:40 jaypipes hitting the window that often...
20:48:50 mriedem let me see how often the debug message before this change shows up
20:50:59 openstackgerrit Merged openstack/nova master: Make put_allocations() retry on concurrent update https://review.openstack.org/516708
20:51:07 mriedem seeing the old message show up in logs in another patch, but far less (3, 4 and 6 hits in 3 different jobs)
21:04:13 mriedem not really sure what's up with this, unless it's just totally random based on how slow the node is in the CI job
21:06:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Time how long select_destinations() takes in conductor https://review.openstack.org/517108
21:13:39 mriedem looking at some logs for an ocata patch i don't see "Deleting allocations that remained for this" show up at all, so definitely prompte by the race introduced by doing the allocation creation in the scheduler in pike
21:22:52 mriedem edleafe: _schedule in the FilterScheduler should be returning a list of lists of selected hosts right?
21:23:21 mriedem i don't think _legacy_find_hosts does that if include_alternates is False
21:23:36 mriedem which means we'd get an IndexError in select_destinations
21:26:26 mriedem https://bugs.launchpad.net/nova/+bug/1729445
21:26:27 openstack Launchpad bug 1729445 in OpenStack Compute (nova) "Potential IndexError if using the CachingScheduler and not getting alternates" [Medium,Triaged]
21:28:12 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: see if finding alternate hosts takes a long time https://review.openstack.org/517111
21:52:02 efried jaypipes Still around?
21:52:18 jaypipes efried: yes. still working on sharing providers + traits
21:53:12 efried jaypipes I'm trying to ascertain whether there's any reason to keep the group_by at https://review.openstack.org/#/c/516778/3/nova/objects/resource_provider.py@2513
21:53:47 efried Upon reading it, I thought it should actually be `distinct` instead - but I can't see any way the query would produce the same RP ID more than once in the result set anyway.
21:54:14 jaypipes efried: correct, it wouldn't.
21:54:19 efried k
21:54:21 efried thx
21:54:32 jaypipes efried: but I'm actively working on this series.. just FYI.
21:54:51 efried jaypipes Yeah, I'm just making notes, wasn't planning to publish my sandbox (yet).
21:55:01 jaypipes danke
21:55:17 efried jaypipes I'm reviewing this perhaps more thoroughly than necessary, as an educational exercise.
21:55:24 jaypipes ack
21:55:32 jaypipes I appreciate it very muc
21:55:34 jaypipes much
21:59:03 edleafe mriedem: yes
21:59:07 efried jaypipes Okay, dropped some comments on PS3 - perhaps you want to hit them in your current edit.
22:14:15 openstackgerrit Jay Pipes proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027
22:14:15 openstackgerrit Jay Pipes proposed openstack/nova master: WIP: handle traits with sharing providers https://review.openstack.org/517119
22:14:45 jaypipes efried: gonna take a dinner break. see ^ for just how complex the sharing providers with required traits code becomes...
22:14:56 efried jaypipes Ack
22:15:13 jaypipes efried: will come back to this later. let me know if you add/modify stuff and I'll re-pull.
22:15:27 efried jaypipes rgr, not planning to touch anything else tonight.
22:16:02 jaypipes k
23:04:30 openstackgerrit Merged openstack/nova master: Remove compatibility method from FlavorPayload https://review.openstack.org/514943
23:12:08 openstackgerrit Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613
23:25:39 openstackgerrit Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613
23:29:34 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge flavor extensions controller code https://review.openstack.org/516104
23:32:30 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
23:32:30 openstackgerrit Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159
23:32:31 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707
23:32:31 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
23:32:32 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
23:34:08 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge flavor extensions controller code https://review.openstack.org/516104
23:37:02 openstackgerrit Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613
23:41:51 efried jaypipes I hit my brain-fry limit. See you tomorrow.
23:50:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix return type in FilterScheduler._legacy_find_hosts https://review.openstack.org/517134
23:50:54 mriedem edleafe: ^
#openstack-nova - 2017-11-02
00:30:15 mriedem oops guess i have unit test failures
01:12:06 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
01:13:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
01:13:50 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.54 - List/Show all server migration types https://review.openstack.org/430839
01:14:33 openstackgerrit jichenjc proposed openstack/nova master: remove glance usage inside compute https://review.openstack.org/511392
01:14:34 openstackgerrit jichenjc proposed openstack/nova master: Remove direct usage of glance.generate_image_url https://review.openstack.org/511397
01:14:51 openstackgerrit Takashi NATSUME proposed openstack/nova stable/pike: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513717
01:15:09 openstackgerrit Takashi NATSUME proposed openstack/nova stable/ocata: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513721
01:15:46 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix test_get_volume_config method https://review.openstack.org/489467
01:16:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579
01:16:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514
01:17:09 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix an example in "Delete Assisted Volume Snapshot" https://review.openstack.org/514128
01:17:28 openstackgerrit Takashi NATSUME proposed openstack/nova master: Update document related to host aggregate https://review.openstack.org/514499
01:21:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix return type in FilterScheduler._legacy_find_hosts https://review.openstack.org/517134
01:40:45 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: Handle InstanceNotFound when setting password via metadata https://review.openstack.org/472933
01:42:16 alex_xu efried: hey, i'm here
01:51:07 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: Add error message on metadata API https://review.openstack.org/517152
01:57:20 melwitt alex_xu: hey, I was wondering if you could help guide a new contributor on their review here, it's about the api routing table I think you have expertise about https://review.openstack.org/#/c/516796
01:58:42 alex_xu melwitt: got it, I will check it today
01:58:51 melwitt sweet, thanks
02:02:44 alex_xu melwitt: np
02:05:33 openstackgerrit Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
02:10:44 openstackgerrit Tristan Cacqueray proposed openstack/nova master: Mask the token used to allow access to consoles https://review.openstack.org/220622
02:18:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove instance.keypairs migration code https://review.openstack.org/517158
02:41:19 gmann alex_xu: fixed comment, - https://review.openstack.org/#/c/516104/
02:41:33 alex_xu gmann: thanks, will check soon
02:41:43 gmann alex_xu: thanks.
02:57:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Fix a broken link in placement doc https://review.openstack.org/517163
03:02:25 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190
03:38:11 openstackgerrit Merged openstack/nova master: Refactor claim_resources() to use retries decorator https://review.openstack.org/516709
04:04:23 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146
04:13:16 openstackgerrit Michael Still proposed openstack/nova master: Move infiniband vif plugging to privsep. https://review.openstack.org/515197
04:13:17 openstackgerrit Michael Still proposed openstack/nova master: Move midonet vif plugging to privsep. https://review.openstack.org/515198
04:13:17 openstackgerrit Michael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep. https://review.openstack.org/515336
04:13:18 openstackgerrit Michael Still proposed openstack/nova master: Move contrail vif plugging to privsep. https://review.openstack.org/515916
06:02:53 openstackgerrit Tristan Cacqueray proposed openstack/nova master: Mask the token used to allow access to consoles https://review.openstack.org/220622
06:18:46 openstackgerrit jichenjc proposed openstack/nova master: Remove unnecessary checks for root_gb = 0 https://review.openstack.org/516569
06:20:52 openstackgerrit jichenjc proposed openstack/nova master: Fix warning on {'cell_id': 1} is an invalid UUID https://review.openstack.org/505471
06:26:43 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190
06:31:54 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
06:40:30 openstackgerrit jichenjc proposed openstack/nova master: conf: remove deprecated 'project_id_regex' opt https://review.openstack.org/501057
07:04:33 openstackgerrit jichenjc proposed openstack/nova master: WIP: clean test https://review.openstack.org/517185
07:12:40 openstackgerrit jichenjc proposed openstack/nova master: conf: remove deprecated 'project_id_regex' opt https://review.openstack.org/501057
07:46:19 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035

Earlier   Later