Earlier  
Posted Nick Remark
#openstack-nova - 2017-10-27
20:06:23 bauwser leakypipes: which is a problem with the VGPU resources
20:06:27 leakypipes bauwser: why?
20:06:30 bauwser since they're not in the compute node
20:07:05 leakypipes bauwser: ah, yeah...
20:07:17 bauwser leakypipes: I thought about that
20:07:30 leakypipes bauwser: that line can be moved to after the call to get_inventory() eventually
20:07:36 bauwser leakypipes: that's my point :p
20:07:43 leakypipes yup
20:07:52 bauwser I was asking you if you were okay with that :)
20:08:38 bauwser leakypipes: we could also persist the inventory
20:08:58 bauwser leakypipes: so passing it to the _resource_change method too
20:09:18 bauwser and so, not setting the inventory if that's not changing too :)
20:09:26 bauwser anyway, lemme provide the chnage
20:10:11 leakypipes bauwser: that's kind of what my nested resource provider series is doing.
20:12:40 leakypipes bauwser: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L609
20:12:56 leakypipes bauwser: basically, that needs to come before the _resource_changed() thing in the RT.
20:13:09 leakypipes bauwser: or we just get rid of the _resource_changed() thing entirely...
20:13:17 bauwser mmmm
20:14:53 bauwser leakypipes: what I honestly need is to look at your series :p
20:26:42 fried_rice leakypipes Sure makes it trickier to test...
20:27:18 leakypipes fried_rice: makes what trickier to test?
20:28:05 fried_rice leakypipes The resource groups being objects instead of a big dict I can just build up and compare. It's not a big deal. Just prolly going to write some test-only methods on the objects.
20:28:18 leakypipes fried_rice: ack.
20:28:58 leakypipes fried_rice: well, I prefer if you don't add methods to the objects themselves. rather, add a comparator method to the test class.
20:29:11 leakypipes assertRequestGroupsSame() or something like that...
20:29:27 fried_rice leakypipes Yuh.
20:31:26 fried_rice leakypipes But then I have to build up RequestGroups for the 'expected' side.
20:31:37 leakypipes fried_rice: correct.
20:31:45 leakypipes fried_rice: which is explicit. and good.
20:32:04 fried_rice leakypipes But reduces the test coverage, cause I'm using Thing to test Thing.
20:32:20 fried_rice leakypipes Again, not a big deal, can do.
20:32:29 leakypipes fried_rice: if Thing is just a plain-old-data object, that's good.
20:36:49 openstackgerrit Merged openstack/nova master: Update placement api-ref: allocations link in 1.11 https://review.openstack.org/515748
20:42:36 openstackgerrit Michael Still proposed openstack/nova master: Move infiniband vif plugging to privsep. https://review.openstack.org/515197
20:42:37 openstackgerrit Michael Still proposed openstack/nova master: Move midonet vif plugging to privsep. https://review.openstack.org/515198
20:42:37 openstackgerrit Michael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep. https://review.openstack.org/515336
20:42:38 openstackgerrit Michael Still proposed openstack/nova master: Move control vif plugging to privsep. https://review.openstack.org/515916
20:44:24 openstackgerrit Michael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep. https://review.openstack.org/515336
20:44:24 openstackgerrit Michael Still proposed openstack/nova master: Move contrail vif plugging to privsep. https://review.openstack.org/515916
20:53:02 openstackgerrit Merged openstack/nova master: [placement] Allow _set_allocations to delete allocations https://review.openstack.org/501051
20:55:14 mriedem fried_rice: comments in 16 and 18 https://review.openstack.org/#/c/492247/
20:55:21 fried_rice ...
20:56:43 fried_rice mriedem Roger wilco, will update. Thanks.
20:56:58 mriedem |_o_|
20:57:10 mriedem 3 points if you do
20:57:22 mriedem superdan knows what that 3 points is for
20:57:29 cdent been a lot of football today
20:57:34 mriedem heh
20:57:46 mriedem that reminds me
20:57:51 mriedem vikings in london on sunday
20:58:06 mriedem that means i get football at 8:30, noon, 3:30 and 7:30
20:58:30 cdent apparently when the nfl go to london _loads_ of people go nutbar and dress up for the game
20:58:32 superdan obviously three points for a three pointer shot from midfield
20:58:42 cdent which when I heard about it, completely surprised me
20:58:48 superdan swish
20:58:51 superdan goooooooal
20:59:03 mriedem close, field goal
20:59:15 mriedem cdent: yes, if you watch the game, it's all people dressed up in different stuff
20:59:21 mriedem because there is no home team, just ex-pats
20:59:22 cdent weird
20:59:50 mriedem i think the official home team is jacksonville or miami, both of whom are pretty bad every year, so you're welcome
20:59:56 cdent is it ex-pats? I was under the impression it was crazy brits deciding they love american football and not knowing how to show it
20:59:58 mriedem could be worse,
21:00:00 mriedem could be the gd browns
21:00:12 mriedem oh shit
21:00:19 mriedem guess who the vikings play on sunday in london?
21:00:24 mriedem the f'ing browns!
21:03:00 openstackgerrit Merged openstack/nova master: Only filter/weigh hosts once if scheduling a single instance https://review.openstack.org/513931
21:03:25 bauwser mriedem: well, Barca-Juv was in NYC this summer :p
21:03:40 mriedem no one knows what that is
21:03:48 bauwser gdi
21:03:50 bauwser man, soccer!
21:04:19 bauwser you know, the game that US folks try to play and at the end, they loose :p
21:04:25 mriedem unless they are women
21:04:33 cdent us women’s soccer rocs
21:04:47 bauwser that's correct :)
21:06:12 cdent tickets to the london nfl games are a lot cheaper than I would have predicted
21:06:32 mriedem because they need to fill the seats to look good on t
21:06:35 mriedem *tv
21:06:55 cdent fried_rice: can you try a bit harder, only 50% of my pending patches are in merge conflict
21:07:11 fried_rice cdent Somebody had to take the fall.
21:07:36 cdent I think if leakypipes merges a couple more de-orms that should break the rest of the nova ones
21:09:53 cdent they’re a bit like mile markers on the highway
21:57:50 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146
22:00:24 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
22:01:35 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
22:12:38 openstackgerrit Merged openstack/nova master: rt: Implement XenAPI get_inventory() method https://review.openstack.org/339204
22:32:30 rm_work Do you guys have a feel for how commonly deployments use the AZ extension?
22:32:45 rm_work I'm curious if it's close to 100%, or much less
22:33:38 mriedem i'd say pretty common
22:33:46 openstackgerrit Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151
22:33:46 openstackgerrit Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223
22:33:47 openstackgerrit Eric Fried proposed openstack/nova master: ResourceRequest.to_querystring() https://review.openstack.org/515811
22:33:49 mriedem but probably better input if you ask in #openstack-operators
22:33:56 rm_work hmm, k
22:41:25 bfife kashyap / melwitt; thanks for https://review.openstack.org/#/c/514339/. what i came here to sort out :-)
22:45:50 fried_rice mriedem Okay, so here's how those deprecations work with ksa...
22:46:28 fried_rice If you were to access the deprecated opt directly (e.g. CONF.placement.os_region_name), you would get the deprecation message from the deprecated_reason.
22:46:32 fried_rice But you would never do that.
22:47:01 fried_rice What actually happens is you call utils.get_ksa_adapter, which references that var from within ksa, where it keys off of the fact that we passed that guy as a deprecated opt.

Earlier   Later