Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-27
15:51:55 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples https://review.openstack.org/515751
15:55:04 fried_rice sdague FYI, I think there's still something wrong with that cinder patch. I should -W it.
15:59:34 leakypipes rabel: reviewed.
16:00:23 rabel leakypipes: thank you
16:09:55 cdent leakypipes: see my response on https://review.openstack.org/#/c/510626/ for why project_id and user_id was not added on /rp/u/allocations _now_
16:19:53 jianghuaw leakypipes, bauwser: I have a question about vGPU's inventory update. it invoking get_inventory() when compute_node is changed: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L807
16:20:42 jianghuaw But for vGPU, we only report it via inventory no new fields saved in obj of compute_node.
16:22:32 jianghuaw I see there is inventory caching in resource provider tree. and a new function update_inventory() is implemented.
16:22:53 jianghuaw But I assume that's only for nest-RP. right?
16:23:06 openstackgerrit David Rabel proposed openstack/nova master: VMware: add support for graceful shutdown of instances https://review.openstack.org/494169
16:24:00 jianghuaw leakypipes, bauwser: I think our plan is to implement vGPU by associate the inventory on compute node as the first step. so not depending on the n-r-p.
16:25:21 jianghuaw then how to trigger the inventory update without resource provider tree?
16:27:35 bauwser jianghuaw: see my libvirt change
16:27:48 bauwser jianghuaw: I'm hoping to push a new revision by tonight
16:29:18 jianghuaw is this already included in the existing patch? bauwser
16:29:57 jianghuaw or will be in the new revision?
16:30:21 rabel leakypipes: is the new patchset ok?
16:30:25 jianghuaw bauwser, I didn't see that part in https://review.openstack.org/#/c/514763
16:35:18 jianghuaw bauwser, I was thinking we should make it to invoke get_inventory regardless compute_node changed or not. caching inventory locally; and update inventory to placement if inventory changed.
16:36:49 jianghuaw bauwser, Good to know you've already considered it.
16:40:22 jianghuaw leakypipes, bauwser, superdan: it's appreciated if you can have a look at this patch for get_inventory in XenAPI: https://review.openstack.org/#/c/339204/
16:40:43 jianghuaw hope it be an easy one:-)
16:40:47 leakypipes jianghuaw: will do shortly. on phone right now.
16:41:07 jianghuaw leakypipes, thanks:-)
16:45:31 leakypipes cdent: yes, that makes sense.
16:47:30 bauwser jianghuaw: sorry, I was super busy prepping the new rev
16:47:40 bauwser jianghuaw: so, basically, we have the same problem with libvirt
16:47:52 bauwser jianghuaw: for example, we have a list of supported types
16:48:04 bauwser jianghuaw: then, the operator selects a specific type
16:48:16 bauwser (if you see my change, we only support one)
16:48:33 bauwser jianghuaw: so, the inventory is saying N+M
16:48:50 bauwser where N is the allocatable mdevs, and M is the already allocated ones
16:49:38 bauwser if the operator modifies that, then it's creating a problem because when you create a mdev by a type, the other types for the same device are getting 0 allocable mdevs
16:51:13 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763
16:51:23 bauwser jianghuaw: new revision ^
16:51:38 jianghuaw yes. I see. It can't create mdev for the other types once created a specific type of mdev.
16:51:51 jianghuaw looking at it
16:53:18 jianghuaw bauwser, no. my problem is different: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L807
16:53:38 jianghuaw it will return if the compute_node resource is not changed.
16:54:51 jianghuaw bauwser, at the moment it only compare some resource fields of compute-node's: e.g. vcpu, memory.
16:54:52 bauwser jianghuaw: so, what's your concern ?
16:55:44 jianghuaw the vGPU resource is not saved in compute-node. so my concern is the vGPU inventory may be not be updated if the other resource is not changed.
16:56:01 bauwser a-ja
16:56:47 jianghuaw bauwser, as vGPU is only reported by get_inventory()
16:57:19 bauwser jianghuaw: right, good point
16:57:39 bauwser jianghuaw: so we should somehow signal those the old way
16:58:11 bauwser not saying to add the VGPU resources in the Computenode object :)
16:58:29 bauwser just having a way to signal it thru update_available_resources
16:58:31 openstackgerrit Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247
16:58:43 bauwser or other way, I dunno
16:58:48 bauwser I need to think about it
16:59:17 jianghuaw I see. what I was thinking is to invoked always get_inventory().
16:59:56 jianghuaw but I'm not sure if that's acceptable.
17:01:58 jianghuaw bauwser, here it defines update_inventory https://github.com/openstack/nova/blob/master/nova/compute/provider_tree.py#L233
17:02:18 bauwser jianghuaw: one way to see that is that we could call get_inventory() first, pass it to _resource_change, keep it in memory and compare it at the next _resource_change run
17:02:39 jianghuaw but it requires some way to determine how and when to get the new inventory.
17:02:47 bauwser because _resource_change is just for making sure we don't update the DB every 60 secs
17:03:24 openstackgerrit Merged openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028
17:03:30 bauwser jianghuaw: for Queens, I really would like my series to not be depending on n-r-p
17:04:40 jianghuaw bauwser, the n-r-p seems in good progress. isn't it?
17:04:57 jianghuaw maybe we can use n-r-p?
17:07:31 jianghuaw bauwser, anyway I also agree that passing it to _resource_change looks like a good solution.
17:07:59 bauwser jianghuaw: I can write that change
17:08:09 jianghuaw I'd like to see the viewpoint from leakypipes also.
17:08:30 bauwser I need to dinner, but I'd be around by the next 2 hours
17:08:31 jianghuaw bauwser, yes you can go ahead with the change.
17:08:49 bauwser jianghuaw: which TZ are you in ?
17:09:07 jianghuaw I'm in China.
17:09:12 jianghuaw so 1:09 am:-)
17:09:59 jianghuaw please go ahead with your dinner. We can chat further on next Monday.
17:10:07 jianghuaw :-)
17:13:21 bauwser ++
17:13:28 bauwser jianghuaw: and go to bed
17:13:30 bauwser !
17:14:37 jianghuaw bauwser, cheers. wish you a nice weekend:-)
17:16:58 openstackgerrit Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151
17:16:59 openstackgerrit Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223
17:18:29 jianghuaw bauwser, when you come back, hope you have seconds to look at this patch for get_inventory in xenapi: https://review.openstack.org/#/c/339204
17:19:31 jianghuaw bauwser, also I have a patching to report vGPU resources from XenAPI: https://review.openstack.org/#/c/512965/
17:20:21 jianghuaw I'm preparing another patch to create vGPU inventory.
17:24:42 openstackgerrit Ed Leafe proposed openstack/nova master: Only filter/weigh hosts once if scheduling a single instance https://review.openstack.org/513931
17:24:42 openstackgerrit Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
17:24:43 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
17:24:43 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159
17:24:44 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
17:24:44 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
17:31:39 jianghuaw leakypipes, thanks for the +2.
17:32:30 leakypipes jianghuaw: np
17:32:38 leakypipes jianghuaw: now go to bed! :)
17:33:04 jianghuaw :)
17:45:31 openstackgerrit Merged openstack/nova master: Include /resource_providers/uuid/allocations link https://review.openstack.org/499826
17:50:43 openstackgerrit Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223
18:35:30 mriedem figleaf: superdan: leakypipes: cdent: how would you guys all love to have a thrilling hangout to make sure we're on the same page about https://review.openstack.org/#/c/510159/ ?
18:35:36 mriedem assuming cdent not so much given friday night fun time
18:35:54 superdan you mean now?
18:36:05 cdent i’m around actually, but haven’t been following along today
18:36:20 mriedem superdan: i'm game, i don't think this would be a long call
18:36:22 mriedem else it waits
18:37:40 mriedem i think in at least one retrospective we said, 'when in doubt, hangout'
18:37:55 mriedem and, 'if it's brown, flush it down'

Earlier   Later