| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-27 | |||
| 14:42:44 | openstackgerrit | Merged openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | |
| 14:43:58 | bauwser | jianghuaw: friday nick FWIW | |
| 14:47:31 | openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247 | |
| 14:47:43 | fried_rice | mriedem See if those responses make sense ^ | |
| 14:48:59 | openstackgerrit | Merged openstack/nova master: rp: Remove RP.get_traits() method https://review.openstack.org/509027 | |
| 15:03:02 | fried_rice | leakypipes superdan https://review.openstack.org/#/c/499826/ please if you have a sec. (I'm trying to win cdent's prize.) (And the race to 1.11.) | |
| 15:07:55 | jianghuaw | bauwser, thanks:-) | |
| 15:11:59 | leakypipes | fried_rice: I'm trying to win the same prize :) | |
| 15:12:16 | fried_rice | leakypipes Oh, if that de-orm stuff counts, you're gonna win. | |
| 15:12:16 | leakypipes | fried_rice: damn it. | |
| 15:12:27 | leakypipes | fried_rice: nah, the n-r-p series adds 1.11 | |
| 15:12:38 | leakypipes | it's ok, though. I can rebase easy enough. | |
| 15:12:58 | fried_rice | leakypipes Yeah, we had like seven different 1.11 patches in flight. | |
| 15:13:06 | leakypipes | yeah it's cool :) | |
| 15:13:14 | leakypipes | I mean.. cool as in I know we did :) | |
| 15:13:19 | leakypipes | not that I relish rebasing | |
| 15:13:36 | fried_rice | leakypipes It made me think there ought to be a way to automate it. But that way lies madness. | |
| 15:13:50 | leakypipes | fried_rice: indeed | |
| 15:15:03 | mriedem | fried_rice: you didn't update the placement api-ref https://review.openstack.org/#/c/499826/ | |
| 15:15:09 | mriedem | time to -1? | |
| 15:15:31 | fried_rice | mriedem I thought it was because that guy already documented the missing link | |
| 15:16:00 | cdent | le sigh. so much rebase. | |
| 15:16:21 | mriedem | https://developer.openstack.org/api-ref/placement/#id2 ? | |
| 15:16:32 | fried_rice | mriedem Yeah, not. | |
| 15:16:38 | mriedem | fried_rice: just roll it on top | |
| 15:16:44 | mriedem | but know that i'm watching, always watching | |
| 15:16:45 | fried_rice | mriedem Will do. | |
| 15:17:03 | leakypipes | that reminds me I need to update the n-r-p REST API patch to amend the devref docs | |
| 15:17:08 | fried_rice | mriedem leakypipes I *was* thinking there should be some kind of "add a microversion checklist" internal doc for devs. | |
| 15:17:23 | mriedem | fried_rice: there are docs on adding microversions, | |
| 15:17:27 | mriedem | for both compute and placement | |
| 15:21:03 | mriedem | fried_rice: this is the doc for compute microversions https://docs.openstack.org/nova/pike/contributor/microversions.html | |
| 15:21:24 | mriedem | fried_rice: maybe add something here? https://docs.openstack.org/nova/pike/contributor/microversions.html#other-necessary-changes | |
| 15:21:56 | fried_rice | mriedem Remind me where the source for the api-ref docs is? | |
| 15:21:58 | mriedem | and this for placement https://docs.openstack.org/nova/pike/contributor/placement.html#microversions | |
| 15:22:03 | mriedem | nova/api-ref? | |
| 15:22:09 | mriedem | nova/placement-api-ref | |
| 15:22:56 | bauwser | mriedem, sdague: crazy thoughts, could we just get rid of block_device_mapping.device_name as an API param ? | |
| 15:23:00 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples https://review.openstack.org/515740 | |
| 15:23:11 | mriedem | bauwser: i already tried | |
| 15:23:13 | bauwser | mriedem, sdague: it's not like we can pretend it works | |
| 15:23:33 | bauwser | mriedem: the fun part of that is OSC https://github.com/openstack/python-openstackclient/blob/e0d7119c6dcba5666f2a0916b9a6e347e2e2758c/openstackclient/compute/v2/server.py#L621 | |
| 15:23:44 | mriedem | bauwser: https://review.openstack.org/#/c/452546/ | |
| 15:28:00 | leakypipes | fried_rice, mriedem: I'm just going to wait on updating the REST API n-r-p patch to update the placement-api-ref until fried_rice's patch lands, since I'm gonna need to change to 1.12 anyway. | |
| 15:28:11 | fried_rice | ack | |
| 15:28:42 | bauwser | mriedem: not fully understanding the problem with device names that feodor is mentioning | |
| 15:29:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples https://review.openstack.org/515745 | |
| 15:29:55 | bauwser | mriedem: oh they somehow want some way to identify which BDM to update | |
| 15:30:05 | bauwser | don't BDMs have UUIDs ? | |
| 15:30:15 | mriedem | bauwser: not yet | |
| 15:30:26 | mriedem | bauwser: but mdbooth is adding them in i think | |
| 15:31:04 | bauwser | mriedem: so that would solve the problem IMHO | |
| 15:33:12 | mdbooth | bauwser: Indeed I will add BDM uuids. | |
| 15:33:25 | mriedem | bauwser: idk, it | |
| 15:33:37 | mriedem | it's been a long time since i had ftersin's bfv issue in my head | |
| 15:33:42 | mriedem | but it was something for ec2 of course | |
| 15:33:46 | mdbooth | bauwser: I was thinking during our call earlier, btw, that device names in the context of the api do mean something, just not really what people think. | |
| 15:34:05 | mdbooth | Which looks like what I wrote in that review ages ago that I'd completely forgotten about. | |
| 15:34:36 | mdbooth | i.e. 'sda' means 'the first disk on a scsi bus' | |
| 15:35:00 | mdbooth | It *doesn't* mean that your linux OS will create it as /dev/sda, though | |
| 15:35:33 | bauwser | mdbooth: right, it's an identifier | |
| 15:35:51 | mdbooth | tags mean something specific | |
| 15:36:04 | bauwser | mdbooth: but for the worst, we decided that this identifier should look like a device name, which is IMHO the worst terrible idea | |
| 15:36:10 | rabel | Hi there, can we merge https://review.openstack.org/#/c/494169/ now? I think it is really ready by now. | |
| 15:36:12 | mdbooth | uuids would also mean something specific, although I don't have any plans to expose them to the user explicitly | |
| 15:36:46 | bauwser | mdbooth: looks to me it's a cinder problem | |
| 15:36:50 | mdbooth | bauwser: Yes, agreed. | |
| 15:37:01 | mdbooth | ... but not to cinder ... | |
| 15:37:03 | bauwser | mdbooth: if you need something to tag your volumes, it's cinder, not nova | |
| 15:37:06 | mdbooth | How's it a cinder thing? | |
| 15:37:23 | mdbooth | Nah, that's totally a Nova thing | |
| 15:37:52 | mdbooth | Cinder just gives us a repository of bits. It's entirely Nova's domain how that's presented to the guest. | |
| 15:38:37 | bauwser | mdbooth: what is the purpose of tagging that? | |
| 15:39:10 | bauwser | I'm surely not getting the full picture, but I don't get why I need to keep information on how my volume is presented to the guest | |
| 15:39:15 | mdbooth | Device tagging? It's so the guest OS can identify specific devices which were specified by the api. | |
| 15:39:39 | bauwser | mdbooth: oh, but that's a totally different problem | |
| 15:39:52 | bauwser | mdbooth: and surely device names don't solve it | |
| 15:40:15 | bauwser | mdbooth: if you need some device tagging like we did for NICs, I understand that's a nova problem | |
| 15:40:23 | mdbooth | Device tagging is a much, much better way to solve the same problem. | |
| 15:40:34 | bauwser | I just don't understand why it blocks us to get rid of device names | |
| 15:40:52 | bauwser | because device names wasn't helping to solve the problem you mention on the guest side | |
| 15:41:17 | bauwser | it's even worst : you think it will help | |
| 15:41:27 | bauwser | by 'you', I mean the application developer | |
| 15:41:41 | bauwser | so for example, I'm a user | |
| 15:42:01 | bauwser | I'm using device names because I think it will give me a way to know which device I'm getting on the guest side | |
| 15:42:07 | bauwser | guess what ? It doesn't work | |
| 15:42:37 | bauwser | like I said to you in our meeting, I played with it in Essex | |
| 15:42:41 | bauwser | and Folsom | |
| 15:42:45 | bauwser | totally a mess | |
| 15:43:00 | openstackgerrit | Eric Fried proposed openstack/nova master: Update placement api-ref: allocations link in 1.11 https://review.openstack.org/515748 | |
| 15:43:01 | bauwser | I learned hard that device names weren't a firm contract | |
| 15:43:18 | fried_rice | mriedem leakypipes ^ I didn't bother to base it on the one in the gate; should I? | |
| 15:43:58 | leakypipes | fried_rice: I don't personally mind if mriedem is cool with that | |
| 15:45:29 | mriedem | add a depends-on at least | |
| 15:45:34 | leakypipes | fried_rice: +2 from me. | |
| 15:45:51 | leakypipes | fried_rice: good point from mriedem on the depends-on | |
| 15:47:21 | openstackgerrit | Eric Fried proposed openstack/nova master: Update placement api-ref: allocations link in 1.11 https://review.openstack.org/515748 | |
| 15:47:28 | fried_rice | leakypipes mriedem depends-on ^ | |
| 15:47:45 | mdbooth | bauwser: Was just reading that review back. I've evicted that context from my mental cache ;) | |
| 15:48:18 | mdbooth | bauwser: Sounds like the issue was that there's an existing useful interaction with image-defined bdms | |