| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-27 | |||
| 13:52:39 | superdan | mriedem: that is really obj_to_dict() for doing unholy things.. it doesn't serialize an object | |
| 13:52:50 | mriedem | ok - was trying to figure out why we needed this https://review.openstack.org/#/c/515539/1/nova/scheduler/utils.py@a83 | |
| 13:52:57 | mriedem | when we had already converted objects to primitives above | |
| 13:53:01 | mriedem | guess it's not what i thought it was | |
| 13:53:12 | mriedem | like the bears in that cardinals game in the late 90s | |
| 13:53:20 | mriedem | with the dennis green post-game conference | |
| 13:53:23 | mriedem | leakypipes: ^ | |
| 13:53:25 | superdan | because someone wants a dict that looks like the object, probably for compat | |
| 13:53:56 | superdan | I would confirm, but a83 is not a line number | |
| 13:54:06 | mriedem | it's the left side of the diff | |
| 13:54:38 | belmoreira | mriedem yes, and then upgrade control plane/compute nodes to pike, and do the cellsV2 mappings. All of this in downtime of course. maybe it will be more error prone and easier than the DB merging | |
| 13:54:59 | mriedem | belmoreira: "less" error prone? | |
| 13:55:18 | superdan | oh sure enough | |
| 13:55:30 | mriedem | ok i'll just return the to_primitive call with a note | |
| 13:55:38 | belmoreira | s/more/less :) | |
| 13:56:02 | leakypipes | mriedem: not sure why the jsonutils call is there :( | |
| 13:56:41 | superdan | belmoreira: the merging should be easy I would think.. tbh that seems less concerning that running ocata computes for a period of time to build new placement data, but it's your call.. I assume you'll test it | |
| 13:56:47 | mriedem | leakypipes: i meant the football reference! | |
| 13:56:58 | mriedem | i need at least one football person in this channel | |
| 13:57:00 | mriedem | clarkb: | |
| 13:57:08 | leakypipes | mriedem: sorry, you lost me at hello on that one. | |
| 13:57:11 | superdan | mriedem: I'm still a big confused, because that's jsonutils, not obj_to_primitive | |
| 13:57:45 | mriedem | superdan: i removed the jsonutils.to_primitive becaues it's calling that on a request_spec dict, which i thought had already-serialized items in it, | |
| 13:57:55 | mriedem | because of the obj_to_primitive calls that happen above for the instance and flavor | |
| 13:58:00 | mriedem | so i thought it was a redundant call and removed it | |
| 13:58:06 | mriedem | leakypipes: https://www.youtube.com/watch?v=SWmQbk5h86w | |
| 13:58:20 | superdan | mriedem: oh I see.. dear god | |
| 13:58:32 | superdan | mriedem: those are dictified instance and flavor not a serialized instance | |
| 13:58:40 | mriedem | let'em off the hook jay | |
| 13:59:07 | leakypipes | mriedem: :) ok, gotcha now. | |
| 13:59:29 | superdan | I think what we've learned here is that football references have no place in a nerd hangout | |
| 13:59:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup build_request_spec https://review.openstack.org/515539 | |
| 14:01:15 | leakypipes | superdan: a lesson learned. it's a game of inches. sometimes you just need to go for it on fourth and ten. | |
| 14:01:24 | belmoreira | superdan if the data it's correctly recreated I would prefer to let the resource tracker do it. At the end should be faster than all the work required for the DB merging. Yes, I will test and let you know. Thanks | |
| 14:03:33 | mriedem | leakypipes: pretty risky unless you're in the red zone under the 2 minute warning and behind by over 3 | |
| 14:03:40 | mriedem | then you have no choise | |
| 14:03:41 | mriedem | *choice | |
| 14:04:23 | leakypipes | mriedem: right. though that's just a hail-mary pass to superdan at that point. | |
| 14:05:31 | mriedem | belmoreira: ok - the key thing being that you leave one compute at ocata until all of the other pike computes have reported their information | |
| 14:06:04 | mriedem | belmoreira: and you'd need some tooling to verify that is done, like querying placement for all active instances to make sure they show up with allocations | |
| 14:08:41 | belmoreira | mriedem ok. thanks | |
| 14:09:04 | bauwser | mriedem: https://review.openstack.org/#/c/515530/2/nova/conductor/manager.py@831 are you sure we can't have a rebuild where host=None ? I thought it was | |
| 14:09:18 | mriedem | bauwser: not for "rebuild" | |
| 14:09:27 | bauwser | mmmm | |
| 14:09:38 | bauwser | okay, then nevermind my -1, I'll changeit | |
| 14:09:49 | mriedem | bauwser: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2948 | |
| 14:09:56 | mriedem | rebuild wants to bypass the scheduler | |
| 14:10:15 | bauwser | that was my only concern, I was wanting to make sure that we were rebuilding by using the right image, which is image_ref | |
| 14:10:23 | bauwser | I mean, the target image | |
| 14:10:25 | mriedem | see the plethora of comments in the rebuild_intsance method i added recently about all of the fun conditionals and in what cases we get there from the voodoo in the api | |
| 14:10:32 | bauwser | yeah | |
| 14:10:33 | mriedem | bauwser: yeah that's a long-standing bug | |
| 14:10:45 | mriedem | "new image for rebuild!? sure, what the hell, we trust you!" | |
| 14:11:02 | bauwser | yeah :( | |
| 14:11:16 | bauwser | I thought we were checking the image even for a rebuild | |
| 14:11:39 | bauwser | the evacuate is a special case because we can pass a destination as a target on the CLI | |
| 14:11:53 | bauwser | while rebuild is not | |
| 14:12:05 | mriedem | https://bugs.launchpad.net/nova/+bug/1667667 | |
| 14:12:07 | openstack | Launchpad bug 1667667 in OpenStack Compute (nova) "Rebuilding instance ignores image's property hw_disk_bus" [Low,In progress] - Assigned to 赵明俊 (falseuser) | |
| 14:12:19 | bauwser | I wonder what a true use ris | |
| 14:12:23 | bauwser | user is* | |
| 14:12:45 | bauwser | wait, you said we use instance.host right? | |
| 14:12:52 | mriedem | bauwser: for "rebuild" | |
| 14:12:54 | mriedem | yes | |
| 14:12:54 | bauwser | so, we're *always* rebuilding on the same host ? | |
| 14:12:59 | mriedem | for "rebuild" yes | |
| 14:13:04 | bauwser | WAAAAAAAAT | |
| 14:13:11 | bauwser | a world is failling down to me | |
| 14:13:17 | mriedem | rebuild != evacuate | |
| 14:13:21 | bauwser | that I know | |
| 14:13:40 | bauwser | I just thought we were just finding another host unless you allow the rebuild on the same host | |
| 14:13:57 | mriedem | that wasn't the bug, it was this one https://bugs.launchpad.net/nova/+bug/1664931 | |
| 14:13:59 | openstack | mriedem: Error: malone bug 1664931 not found | |
| 14:16:27 | bauwser | mriedem: okay, looks like I just forgot | |
| 14:16:38 | bauwser | mriedem: then, we need to tackle ^ | |
| 14:16:53 | bauwser | the patch is still valid in my mind | |
| 14:17:40 | mriedem | fried_rice: sdague: https://review.openstack.org/#/c/492247/ | |
| 14:19:16 | fried_rice | mriedem These get handled by passing them to KSA. | |
| 14:19:35 | fried_rice | mriedem But I'll see if cfg.DeprecatedOpt has a way for me to fill out 'since' and 'reason'. | |
| 14:19:36 | mriedem | fried_rice: the options themselves aren't called out as deprecated, | |
| 14:19:39 | mriedem | or when they were deprecated | |
| 14:19:52 | mriedem | fried_rice: you'd mark the nova opts as deprecated | |
| 14:19:55 | mriedem | in their definition | |
| 14:19:59 | mriedem | as normal | |
| 14:20:15 | fried_rice | ah, okay, will do. | |
| 14:20:23 | mriedem | but, i'm not done with this review yet, | |
| 14:20:24 | mriedem | so hold up | |
| 14:22:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | |
| 14:22:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | |
| 14:22:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820 | |
| 14:22:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860 | |
| 14:23:52 | openstackgerrit | Merged openstack/nova-specs master: Remove barbican from scope of ksa adapter work https://review.openstack.org/511524 | |
| 14:27:08 | openstackgerrit | Jianghua Wang proposed openstack/nova master: rt: Implement XenAPI get_inventory() method https://review.openstack.org/339204 | |
| 14:28:52 | jianghuaw | bauzas, leakypipes: ^ | |
| 14:29:23 | mriedem | fried_rice: ok comments inline | |
| 14:29:28 | fried_rice | mriedem Thanks | |
| 14:29:58 | jianghuaw | bauzas, thanks for spotting the issue. | |
| 14:32:53 | openstackgerrit | Merged openstack/nova master: Convert IVS VIF plugging / unplugging to privsep. https://review.openstack.org/515196 | |
| 14:34:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | |
| 14:34:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | |