Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-26
22:16:44 mriedem maybe that's some rhosp special sauce ?!
22:16:53 melwitt mriedem: that's not really relevant I don't think. I was hesitant to change/remove too much from a commit message I didn't write, but kashyap is away at kvm forum
22:17:27 melwitt I think the thing that's wrong that's happening is libvirt driver isn't honoring the nova.conf setting for disk_cachemodes and there's nothing automatic about ceph there
22:18:35 mriedem hmm, maybe it comes from the rbd image backend via image properties or something, idk
22:18:46 melwitt just depends on how the nova.conf is deployed, I'm guessing our deployment tooling sets nova.conf that way for ceph or something
22:18:49 mriedem but it's confusing in the commit message b/c there is no code in nova that defaults the cache_mode for rbd disks to writethrough
22:19:21 melwitt yeah, I was torn about whether to hack up the commit message because I agree it's confusing
22:19:50 mriedem ok i'd -1
22:21:44 mriedem i'll just mod the commit inline and +W
22:22:58 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339
22:23:13 melwitt mriedem: okay. to your question about the disk_cachemodes, yes, the _set_cache_mode function takes the setting from the CONF.libvirt.disk_cachemodes and applies it
22:23:19 mriedem yup
22:23:49 melwitt k, thanks for updating the commit message
22:24:01 mriedem oh wait maybe it's this _supports_direct_io method
22:24:05 mriedem def disk_cachemode(self):
22:24:29 mriedem which sends the cache mode into the rbd imagebackend
22:24:33 mriedem maybe that's what he meant
22:27:03 mriedem yeah so maybe that's what it was
22:28:00 melwitt I dunno, in the ceph case the high perf value is writeback, not writethrough
22:30:58 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339
22:31:49 mriedem done, approved
22:31:54 mriedem melwitt: want to start the backport party?
22:32:02 mriedem then dansmith and i can +W those
22:32:40 melwitt mriedem: yep, on it
22:32:45 mriedem cool, thanks
22:35:32 openstackgerrit melanie witt proposed openstack/nova stable/pike: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/515538
22:41:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Cleanup build_request_spec https://review.openstack.org/515539
22:41:13 melwitt mriedem: are we supposed to leave multiple cherry-pick comments in the commit message? I can't remember
22:41:28 mriedem melwitt: not a big deal
22:41:31 melwitt like if I cherry picked from pike to ocata. okay
22:41:44 mriedem if you are then just leave them in there
22:41:58 melwitt ack
22:42:45 tonyb melwitt: It makes things slightly easier but really it only helps if your first cherry-pick had fixups that you don't want to do a second time.
22:43:03 tonyb melwitt: my tools work with either scenario
22:43:24 mriedem heh, tony's special stable tools
22:43:27 melwitt okay, cool. I started doing it this way after I think dansmith pointed out maybe less likely to hit conflicts this way
22:43:45 tonyb melwitt: cool
22:43:56 tonyb mriedem: FWIW I
22:44:07 openstackgerrit melanie witt proposed openstack/nova stable/ocata: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/515540
22:44:24 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add microversion to allow setting flavor description https://review.openstack.org/515213
22:44:41 tonyb 'll probably wait for your +2 and the +2W them even thought they haven't actually landed on "upper" branches
22:44:52 tonyb mriedem: they're "magic tools" not special ;P
22:45:25 mriedem oh sorry
22:45:31 mriedem so like rabbits in hats
22:45:36 mriedem coins behind ears
22:45:38 mriedem shitty magic
22:45:55 mriedem ha, sorry tony :)
22:46:13 tonyb mriedem: I'll cope
22:46:32 mriedem i'm not sure what tooling you have which is scraping commit messages for (cherry picked from) messages
22:47:05 tonyb mriedem: one of my magic tools: http://eavesdrop.openstack.org/irclogs/%23openstack-requirements/%23openstack-requirements.2017-10-26.log.html#t2017-10-26T07:02:00
22:48:05 tonyb mriedem: I have a git plugin call diff-backport that grabs the review and the sha for the cherrypick and compares them so can see where they diverge
22:48:25 tonyb mriedem: makes it quick to see conflicts that havn't been called out
22:49:22 tonyb mriedem: It also verifies that the cherry-picked commit has merged
22:49:51 mriedem it's like the swiss army knife of stable review tools
22:50:03 tonyb mriedem: I *should* teach it to look for ^.*Bug: (\d+)$ and open that in a browser
22:50:24 mriedem umm tony
22:50:29 tonyb mriedem: Just automates the simple stuff so my gray matter doesn't get over taxed (which is easy to do)
22:50:34 mriedem that regex will fail if the # is properly used for the bug number
22:50:56 mriedem or lower-case b
22:50:59 mriedem people do it
22:51:28 tonyb mriedem: Oh I'd use re.IGNORE_CASE
22:52:38 tonyb mriedem: wat do you mean there ...?
22:53:11 openstackgerrit melanie witt proposed openstack/nova stable/newton: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/515543
22:53:32 mriedem Closes-Bug: #123456
22:53:33 openstack bug 123456 in xine-lib (Ubuntu) "podcast crashes amarok" [Undecided,Fix released] https://launchpad.net/bugs/123456
22:55:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Pass RequestSpec to ConductorTaskAPI.build_instances https://review.openstack.org/515495
22:55:38 tonyb mriedem: Ahh okay
23:00:03 mriedem stvnoyes: ildikov: jgriffith: looks like the cinder v3 attach patch in nova now allows you to attach the same volume to the same instance:
23:00:04 mriedem http://logs.openstack.org/26/515426/1/check/legacy-tempest-dsvm-py35/0f534c8/job-output.txt.gz#_2017-10-26_16_09_57_091507
23:06:08 mriedem tonyb: dansmith: +2 on all of these now https://review.openstack.org/#/q/I7370cc2942a6c8c51ab5355b50a9e5666cca042e
23:13:40 tonyb mriedem_away, dansmith, melwitt: done
23:33:18 melwitt mriedem_away: live migration job passed on https://review.openstack.org/#/c/508271 \o/
23:37:14 tonyb melwitt: when we EOL newton your 2 DNM changes will get abandoned, just so you know
23:37:31 melwitt tonyb: ack, thanks
#openstack-nova - 2017-10-27
01:16:02 mriedem melwitt: nice re https://review.openstack.org/#/c/508271 - maybe you want to +2 :)
01:16:43 melwitt mriedem: yep, wanted to get the a-ok from you first in case there was anything else
01:37:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port https://review.openstack.org/465787
01:37:20 mriedem cfriesen: finally got back to updating that ^ still needs unit tests, but i'm seeing the code hitting in the live migration job now that the live migration tests in tempest are building a tenant network
01:54:52 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: remove extraneous retry assignment in cleanup method https://review.openstack.org/409199
02:02:50 Kevin_Zheng https://review.openstack.org/#/c/507769/
02:03:48 Kevin_Zheng mriedem ^ what should I do about this? Should I add it in master
02:03:48 Kevin_Zheng or stable/pike?
02:04:10 Kevin_Zheng oh, just saw Tony's comment
02:06:29 mriedem hmm, well, master will be kind of weird if we fix the bug in 17.0.0
02:06:38 mriedem we'd have to remove the release note from master if it gets fixed there
02:07:18 Kevin_Zheng so add a new one just in stable/pike?
02:07:54 mriedem i think do it in master, and then if we get it fixed in master we'll remove the reno in the same patch
02:08:03 mriedem i think reno can deal with deleted release notes
02:08:11 Kevin_Zheng OK
02:24:22 mriedem Kevin_Zheng: http://lists.openstack.org/pipermail/openstack-operators/2017-October/014459.html
02:25:10 Kevin_Zheng Thanks alot
02:25:57 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [WIP]Implement query param schema for flavor index https://review.openstack.org/515413
03:05:44 openstackgerrit Chen Hanxiao proposed openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459
03:13:39 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
03:28:36 openstackgerrit Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:29:25 openstackgerrit Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:42:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix instance lookup in hide_server_addresses extension https://review.openstack.org/467772
03:48:05 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port https://review.openstack.org/465787
03:51:29 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Remove incorrect comment about instance.locked https://review.openstack.org/515306
03:53:30 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Avoid unnecessary lazy-loads in mutated_migration_context https://review.openstack.org/515581

Earlier   Later