Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-26
19:56:08 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Add _get_providers_with_any_resource method https://review.openstack.org/514197
19:56:08 openstackgerrit Eric Fried proposed openstack/nova master: Enable _get_usages_by_provider_and_rc not filter on the resource class id https://review.openstack.org/514649
19:56:09 openstackgerrit Eric Fried proposed openstack/nova master: Add _get_traits_by_rp_ids method https://review.openstack.org/511184
19:56:09 openstackgerrit Eric Fried proposed openstack/nova master: Add ProviderSummaryList object https://review.openstack.org/514198
19:56:10 openstackgerrit Eric Fried proposed openstack/nova master: Add more caches for the ProviderSummary and ProviderSummaryList https://review.openstack.org/514199
19:56:10 openstackgerrit Eric Fried proposed openstack/nova master: Add AggregatedProviderSummary and AggregatedProviderSummaryList objects https://review.openstack.org/514200
19:56:11 openstackgerrit Eric Fried proposed openstack/nova master: Add has_resources method to the AggregatedProviderSummary object https://review.openstack.org/514650
19:56:11 openstackgerrit Eric Fried proposed openstack/nova master: Add as_allocation_request_obj method to AggregatedProvierSummary obj https://review.openstack.org/514651
19:56:12 openstackgerrit Eric Fried proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766
19:56:32 efried alex_xu ^ I uncovered a bug, so I WIP'd the bottom change - see notes in commit message.
19:56:34 mikal jaypipes: Mr Finucane and I have a question for you on https://review.openstack.org/#/c/515196 when you have a moment.
19:58:06 cfriesen efried: mriedem: thanks, just wanted to make sure it wasn't something I missed
19:59:03 bfife kashyap: ping, bug#1706083. In Newton after an upgrade, I'm not seeing the proper cache value assigned to ephemeral ceph-backed storage on newly created instances. I've traced it to this commit
20:04:07 jaypipes mikal: done
20:06:50 mikal jaypipes: thanks man
20:13:33 mriedem edleafe: why would the tests care?
20:13:39 mriedem because of equality checks?
20:14:06 edleafe yeah
20:14:20 mriedem hmm, i think in other tests we have some types of compare_obj methods
20:14:31 mriedem which compare the fields
20:14:41 edleafe comparing the expected selection with the one that the filter_scheduler returns
20:15:21 mriedem i don't have a real strong objection to leaving it though
20:15:25 mriedem i just thought it was unused
20:15:53 edleafe Yeah, we went through this back in PS 5-7
20:16:07 mriedem the good old PSs
20:16:24 edleafe I had an explicit __eq__ method, and Jay wanted me to use the mixin instead
20:16:43 mriedem i think the mixin would be better than our own __eq__ sure
20:16:48 mriedem since that's what it's for
20:17:09 openstackgerrit Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
20:17:10 edleafe ok, here it comes...
20:17:10 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
20:17:10 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159
20:17:11 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
20:17:11 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
20:19:53 mriedem lgtm
20:20:22 openstackgerrit Merged openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168
20:43:01 mriedem bauzas: interested about your thoughts on this when you're up https://bugs.launchpad.net/nova/+bug/1727855
20:43:02 openstack Launchpad bug 1727855 in OpenStack Compute (nova) "conductor rebuild_instance does not properly handle image_ref if request_spec is not provided" [Low,Triaged]
20:58:41 dansmith mriedem: jaypipes I was hoping we could avoid merging that object until we had all the patches above it settled,
20:58:49 dansmith since we've changed it like a hundred times already
20:59:38 mriedem oh i see
20:59:40 mriedem yeah that's fair
20:59:40 jaypipes dansmith: it's dependent on mriedem's https://review.openstack.org/#/c/513931 anyway.
20:59:58 mriedem mine is actually fixing a perf thing, but yeah
21:00:05 mriedem jaypipes: maybe we convert to +1s
21:00:09 dansmith jaypipes: sure but that one is easy to merge ahead of all the rest
21:00:20 jaypipes dansmith: I removed the +W
21:00:33 mriedem changed to +1
21:00:37 dansmith jaypipes: thanks
21:00:40 mriedem maybe we need to put a -2 pin in there?
21:00:47 mriedem there are other cores that aren't privy to this convo
21:01:04 dansmith that's fine
21:01:13 mriedem shit meeting itme
21:10:47 openstackgerrit Jay Pipes proposed openstack/nova master: rp: Remove RP.get_traits() method https://review.openstack.org/509027
21:11:03 openstackgerrit Jay Pipes proposed openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028
21:11:12 openstackgerrit Jay Pipes proposed openstack/nova master: rp: remove _HasAResourceProvider mixin https://review.openstack.org/509036
21:11:20 openstackgerrit Jay Pipes proposed openstack/nova master: rp: break functions out of _set_traits() https://review.openstack.org/509908
21:18:44 melwitt does anyone happen to know what's going bonkers in the legacy-grenade-dsvm-neutron-multinode-live-migration job failing what seems like all the time? http://logs.openstack.org/31/513931/3/check/legacy-grenade-dsvm-neutron-multinode-live-migration/a5f4740/logs/testr_results.html.gz
21:18:54 mriedem melwitt: yes
21:19:20 mriedem https://review.openstack.org/#/c/508271/
21:19:23 mriedem it's mfing ceph
21:19:23 mriedem again
21:19:28 mriedem + superconductor
21:19:46 mriedem i pleaded for help in last week's meeting but to no avail
21:19:56 mriedem sdague is probably able to sort that one out easily
21:19:58 mriedem if i say his name enough
21:20:00 mriedem sdague:
21:20:34 melwitt oh :( I'll try to look at it too. I didn't notice it in the meeting notes (my fault)
21:20:51 mriedem we need to be able to source the local.conf
21:20:56 mriedem created via grenade
21:21:01 mriedem to know if we're doing superconductor or not
21:21:41 melwitt oh, hrm
21:21:42 mriedem this might just be easier to do: if [ -f /etc/nova/nova-cpu.conf ]; then
21:21:46 mriedem hacky but it would work
21:21:57 mriedem if ^ then superconductor, else singleconductor
21:22:27 melwitt do we not already have some kind of logic about superconductor vs singleconductor? I mean, how is the decision made in the first place
21:22:35 melwitt just "if grenade, then"?
21:22:47 mriedem grenade forces singleconductor mode
21:23:00 mriedem the CELLSV2_SETUP flag goes into local.conf
21:23:05 mriedem which is what i'm trying to source here
21:23:09 mriedem but don't have permission apparently
21:23:11 melwitt okay. so things downstream of that need to be able to determine what mode it's in
21:23:15 mriedem yup
21:23:49 mriedem i think when this post_test_hook runs, all we have for variables is what devstack-gate gives us
21:23:58 mriedem which is why $GRENADE_OLD_BRANCH works
21:27:03 melwitt I wonder if we could check for the presence of the n-super-cond service? or is that not a thing hooks can do
21:27:24 mriedem it's running on the dest node so i think that's possible
21:27:30 mriedem can try that quick
21:27:32 melwitt is_service_enabled n-super-cond
21:27:36 mriedem yeah
21:28:07 mriedem let me wrap up what i'm currently fixing
21:28:21 mriedem dansmith: btw, i've been thinking,
21:28:21 melwitt k
21:28:40 mriedem it would be really nice if we had an online_data_migration that found all of your old instances that don't have request_specs,
21:28:56 openstackgerrit Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151
21:28:59 mriedem built a request spec for them - like we do EVERYWHERE in the api and conductor, and then we just burned all of that backward compat code out in a later release
21:29:03 openstackgerrit Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223
21:29:07 dansmith I thought we did?
21:29:29 mriedem migrate_instances_add_request_spec
21:29:30 mriedem heh

Earlier   Later