Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-25
14:25:48 dansmith my first response is to say no, we don't
14:25:59 dansmith because pike computes won't have any nesting
14:26:12 dansmith and just the presence of the nested stuff doesn't break us,
14:26:39 dansmith what would cause a problem is if we could be migrating between a pike and queens node where the queens node has some nested resources that we have to account for in that thing
14:28:33 efried dansmith Presumably the scheduler on the pike node would just request the resources from whatever RPs are available on the pike node, which won't be nested.
14:28:57 mriedem scheduler is global
14:29:12 efried Right, point remains.
14:29:13 mriedem you upgrade scheduler before computes
14:29:15 dansmith efried: we don't do that new behavior until all the computes are upgraded
14:29:32 dansmith efried: because the old ones assume doubled allocations
14:29:48 mriedem and pike computes don't know how to cleanup allocations using the migration uuid
14:29:56 mriedem which is another way of saying what dan just said i think
14:29:59 dansmith right
14:32:03 efried Just so my brain doesn't explode, I need to zoom out a little bit and frame all of this in terms of how to grab numbered resource groupings from the flavor for the sake of scheduling.
14:32:27 openstackgerrit Pavel Gluschak (scsnow) proposed openstack/nova master: Fixed concurrent access to direct io test file https://review.openstack.org/515091
14:33:03 efried I think for now I just need to sum up all the resources and continue to pass in the single dict to remove_provider_from_instance_allocation
14:33:47 cdent efried: overhangs are the best part
14:33:48 efried And only keep them split up for the scheduler side of things, which is resources_from_request_spec
14:34:16 dansmith efried: currently I think that's right yeah
14:34:42 gibi mriedem: As you suggested last week I reached out to the author of bp service-create-destroy-notification and he stated he is still planning to work on the implementation.
14:34:44 efried This keeps us throwing good money after bad, digging deeper into the shared RP tech debt hole, but I don't see an alternative without boiling the ocean.
14:35:00 efried dansmith mriedem Thanks y'all.
14:35:22 cdent bonus points for boiling the ocean
14:35:28 mriedem gibi: cool thanks
14:35:46 efried cdent No penalties for mixing metaphors?
14:36:00 cdent good lord from me? no way.
14:36:06 cdent mixed metaphors are the best
14:37:15 openstackgerrit Sylvain Bauza proposed openstack/nova master: Accept all standard resource classes in flavor extra specs https://review.openstack.org/514942
14:37:15 openstackgerrit Sylvain Bauza proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
14:37:16 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763
14:41:43 efried How's the new hire stuff going jaypipes? Winding down?
14:43:36 jaypipes efried: it's going.
14:46:03 dansmith jaypipes: that well huh?
14:46:16 mriedem dansmith: sorry for getting to this late, but questions inline https://review.openstack.org/#/c/508595/
14:47:52 dansmith mriedem: standard operating procedure for you, I know
14:48:00 mriedem :(
14:48:05 dansmith mriedem: that comment was added recently by you right? maybe just rebase noise
14:48:11 mriedem yes
14:48:17 mriedem when cleaning out the system_metadata stuff
14:48:33 mriedem i'm not -1 for that, that could be added back on top later
14:48:38 dansmith gonna pull it out of the gate? I'm still reading
14:48:46 mriedem -1 is for the lack of testing with limits, unless i'm missing something
14:48:52 mriedem *build_requests + limits in the sortmaster
14:52:09 dansmith mriedem: you think it's broken or just want more coverage?
14:52:25 dansmith since it's all the same logic (no special limit decrementing) it's not much of a gap
14:52:44 mriedem there was a test for build requests + limits which was removed,
14:52:48 mriedem so i think we want that coverage yeah
14:53:10 mriedem you could replay it on top of this change if you want (not the series, just this change)
14:54:56 dansmith I would rather not keep that test the way it was, since it tests the instance_list module from above the compute api, but I'm happy to slap a limit base test into instance_list
14:55:25 dansmith mriedem: it's fairly deep into the gate (spot 15 out of 42) but if you want to pull it out, I'll add it to that patch, else I can pile the coverage on top
14:55:43 mriedem just put it on top
14:55:44 mriedem that's fine
15:04:23 dansmith did they just restart zuul or something?
15:07:49 jaypipes gibi: please see my explanation on https://review.openstack.org/#/c/377215/53/nova/tests/functional/db/test_resource_provider.py
15:08:05 dansmith mriedem: so, actually, I think we should pull that from the gate, since everything just restarted
15:08:20 dansmith mriedem: I think there might be a bug that this test will uncover
15:08:25 openstackgerrit Chris Dent proposed openstack/nova master: Move project_id and user_id to Allocation object https://review.openstack.org/500410
15:08:26 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Allow _set_allocations to delete allocations https://review.openstack.org/501051
15:08:26 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Limit number of attempts to delete allocations https://review.openstack.org/507224
15:08:27 openstackgerrit Chris Dent proposed openstack/nova master: Include project_id and user_id in AllocationList.get_all_by_consumer_id https://review.openstack.org/512420
15:08:27 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Include project_id and user_id in GET /allocations https://review.openstack.org/512421
15:08:28 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Enable PUT dict to /allocations/{consumer_uuid} https://review.openstack.org/510625
15:08:28 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Document the changes to PUT and GET /allocations/{consumer_uuid} https://review.openstack.org/510626
15:08:28 jaypipes gibi: it's a weird one, for sure, but the mock there isn't actually to make the test work properly. it's to exercise one part of the WHERE clause that exists in that get_all_by_filters() method
15:08:29 openstackgerrit Chris Dent proposed openstack/nova master: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073
15:08:29 bauzas dansmith: yup, looks like
15:08:46 bauzas dansmith: zuulv3 website was timing out
15:08:56 bauzas now the jobs are just restarting
15:09:41 openstackgerrit Dan Smith proposed openstack/nova master: Merge build requests into the sortmaster 9000 https://review.openstack.org/508595
15:09:41 openstackgerrit Dan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method https://review.openstack.org/509002
15:09:42 openstackgerrit Dan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells https://review.openstack.org/509003
15:10:08 dansmith mriedem: ^ just to kick ito ut
15:10:35 openstackgerrit Sylvain Bauza proposed openstack/nova master: Accept all standard resource classes in flavor extra specs https://review.openstack.org/514942
15:10:36 openstackgerrit Sylvain Bauza proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
15:10:36 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763
15:14:05 mriedem dansmith: ack
15:20:22 melwitt stephenfin: I addressed your comments on https://review.openstack.org/#/c/498983 by refactoring the tests if you could please re-look at it when you can
15:20:36 stephenfin melwitt: Will do (y)
15:21:04 melwitt thanks
15:45:24 efried Procedural question: is it legit to link a blueprint in a docstring?
15:49:24 edleafe efried: I don't know that it is prohibited, but I generally prefer docstrings to stand alone, so I would tend to quote the relevant part of the bp.
15:49:25 mriedem efried: we don't build docstrings
15:49:27 mriedem so doesn't matter
15:50:32 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
15:50:43 efried Was thinking more for the sake of future developers wanting to figure out what's going on. If there's a reason not to do so, like the spec might move or change or disappear. But it's easy enough to avoid it. Thanks.
15:51:17 liuyulong sdague, mriedem, hello there, what about this now https://review.openstack.org/#/c/379128/, the patch of bp/rebuild-keypair-reset.
15:52:13 cdent efried: are you talking about a spec.o.o link or launchpad link? if the former, I’d say go for it
15:52:20 cdent if the latter, no
15:52:27 dansmith mriedem: I'm just going to drop this patch
15:52:32 efried cdent Yeah, the former.
15:52:58 dansmith mriedem: there'll be an issue with pagination with it (limits alone work fine), and that test I removed wouldn't have caught it
15:53:25 efried cdent Sigh, except for the whole line width thing.
15:53:27 dansmith mriedem: I've paged out a lot of context on this, and it's going to require re-tooling, which isn't going to happen until after summit
15:53:33 dansmith just fyi
15:53:35 cdent miagra
15:54:25 mriedem liuyulong: i have to get back to reviewing it, but busy with something else right now
15:55:04 mriedem dansmith: ack, shitty but understandable
15:55:41 mriedem dansmith: is the paging issue because we handle build requests separately from the scatter / gather sorted instances in cells thing?
15:55:47 dansmith mriedem: yeah, I wish I had written a test for this when I wrote the rest, I dunno why I didn't
15:56:44 dansmith mriedem: it's because the marker could be in build requests which we look up differently from other things, and because we need to be able to do that special value-based marker resume thing in there too

Earlier   Later