Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-17
08:39:50 rabel and could someone help me with https://review.openstack.org/#/c/402632/ ? zuul does not seem to be rechecking for a week
08:45:26 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for inventories https://review.openstack.org/457533
08:45:27 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for allocations https://review.openstack.org/457534
08:45:27 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for usages https://review.openstack.org/457535
08:45:28 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for aggregates https://review.openstack.org/505643
08:45:28 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes https://review.openstack.org/511182
08:45:29 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters https://review.openstack.org/511183
08:45:34 gibi rabel: as http://zuulv3.openstack.org/ does not show that your patch is handled by zuul right now you can simply recheck https://review.openstack.org/#/c/402632/ again
08:46:29 rabel gibi: thanks for the hint. i did so a week ago, but nothing has happened. do you know why?
08:47:38 gibi rabel: in the past weeks infra tried to migrate from zuul v2 to zuul v3 and that resulted several restart of zuul. I guess your patch was affected by such a restart
08:48:10 rabel gibi: ah ok. thank you!
09:04:25 jichen cdent: hi ,may I ask a placement rest api question?
09:05:00 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190
09:05:43 cdent jichen: yes, sure. what’s up?
09:06:00 jichen cdent: we have some code like : req.response.location = util.resource_class_url(req.environ, rc)
09:06:09 jichen but I didn't see any response in the output
09:06:22 jichen I think nova compute api has something like Location: xxxx ?
09:06:39 jichen Date: Tue, 17 Oct 2017 08:49:01 GMT
09:06:40 jichen Server: Apache/2.4.18 (Ubuntu)
09:06:42 jichen Content-Length: 62
09:06:43 jichen Content-Type: application/json
09:06:45 jichen OpenStack-API-Version: placement 1.10
09:06:46 jichen vary: OpenStack-API-Version
09:06:48 jichen x-openstack-request-id: req-d638ece0-f12d-4d06-8f04-1f68c8a21650
09:06:49 jichen Connection: close
09:06:54 jichen this is what I got from a 'curl xxx' to placement
09:07:50 jichen I mean, in the response header, do we plan to have a header about Location or not?
09:07:51 cdent jichen: what request were you making?
09:08:51 jichen curl -g -i -X PUT "http://192.168.122.243/placement/resource_providers/929b0597-e4e0-47f7-b4af-9a8c2c8f61d0/traits?nameith:CUSTOM" -H "OpenStack-API-Version: compute 2.53" -H "Content-Type: application/json" -H "OpenStack-API-Version: placement 1.10" -H "X-Auth-Token: gAAAAABZ5cPl6wpCFyQIbl2-JLuKEEOiUSNaeu7OGtcqoBRz-mDwP8bGS6IfdA139oVqv4AGKSGHpCBklbx6seqrsNPwUB_yZY5kmUAXxg5B_FB7V99RJV_Db3ovJu2xHlk
09:08:53 jichen YJ5sn9mo3di0kzJtl5AT0dxaL_iCR8GVp1rEEajIwvg0DSk3E8Eo" -d '{"resource_provider_generation": 17, "traits": ["CUSTOM_ABC"]}'
09:09:29 cdent location will show up in response to only some requests: post to create one inventory, post to create a resource class, put to create a resource class, post to create a resource provider, put to create a trait
09:09:44 cdent so in that example you’ve done a PUT to a resource provider, which does not support location header
09:09:52 cdent as written at least
09:09:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move restart_compute_service to a common place https://review.openstack.org/512551
09:09:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552
09:09:55 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553
09:09:56 openstack bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,New] https://launchpad.net/bugs/1724172
09:10:25 jichen stack@ubuntu1:~$ curl -g -i -X PUT "http://192.168.122.243/placement/resource_providers/929b0597-e4e0-47f7-b4af-9a8c2c8f61d0/traits" -H ack-API-Version: compute 2.53" -H "Content-Type: application/json" -H "OpenStack-API-Version: placement 1.10" -H "X-Auth-Token: gAAAAABZ5cPl6wpCFyQIbl2-JLuKEEOiUSNaeu7OGtcqoBRz-mDwP8bGS6IfdA139oVqv4AGKSGHpCBklbx6seqrsNPwUB_yZY5kmUAXxg5B_FB7V99RJV_Db3ovJu2xHlkYJ5sn
09:10:27 jichen 9mo3di0kzJtl5AT0dxaL_iCR8GVp1rEEajIwvg0DSk3E8Eo" -d '{"resource_provider_generation": 18, "traits": ["CUSTOM_ABC"]}'
09:10:28 jichen HTTP/1.1 200 OK
09:10:30 jichen Date: Tue, 17 Oct 2017 09:09:54 GMT
09:10:31 jichen Server: Apache/2.4.18 (Ubuntu)
09:10:33 jichen Content-Length: 62
09:10:34 jichen Content-Type: application/json
09:10:36 jichen OpenStack-API-Version: placement 1.10
09:10:37 jichen vary: OpenStack-API-Version
09:10:39 jichen x-openstack-request-id: req-4ce20136-afb8-405e-86ff-2397a21cc1c2
09:10:39 cdent jichen: you’re right that we should probably be consistent about it, but it looks like we weren’t. I think the logic that was used is that a location header is a good idea if the response is empty
09:10:40 jichen Connection: close
09:10:42 jichen {"traits": ["CUSTOM_ABC"], "resource_provider_generation": 19}
09:10:44 jichen sorry, wrong lURL
09:11:03 jichen 2nd URL I used is to PUT traits
09:11:10 cdent jichen: for long pastes like that it is better to use a pastebin like http://paste.openstack.org/
09:11:17 jichen ok, right now
09:11:31 cdent that’s put to add traits to a resource provider, not to create a trait
09:11:57 jichen cdent: http://paste.openstack.org/show/623800/
09:14:20 priya__ hi ..could somebody review the commit - https://review.openstack.org/#/c/508533/
09:14:44 cdent jichen: right, so that request corresponds with this handler: https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/trait.py#L217-L248 which does not set the header
09:14:52 cdent jichen: do you think it should?
09:16:37 jichen cdent: I guess I used wrong URL ... I think we should not add a header as this is a just 'associate'
09:16:59 jichen so I will update the document of placement api ref.. it doesn't have the info about this header
09:18:10 masber good afternoon all, I am having an issue resizing nodes. My hardware runs NUMA and I pin my vcpus for better performance. I could not resize the instance because it could not fit any NUMA node so what I did was to shutdown the vms on that node so the kvm could relocate them and make more space for the extra resources
09:18:51 cdent I think we didn’t end up adding the info about headers because there’s no clear use case for them. When I wrote the first bits of the code that did add a location header, I did it because it is standard form: create something? then put a location header in the response. We don’t necessarily need to cloud the documentation with that except perhaps in the case of POST /resource_providers (because that tells you wha
09:18:51 cdent was created)
09:19:01 cdent jichen: in everything else there are other ways
09:19:04 masber I resized the node while it was shutdown, and then I tried to confirm the resize but confirmation failed saying "cannot resize instance while it is in vm_state resized"
09:19:40 masber since then I can even start resizing the node as state stays as active
09:19:45 masber *can't
09:20:03 masber is this a bug or am I doing something stupid?
09:21:12 jichen cdent: ok, I can live with that, I thought we return location for every thing we created like you mentioned; and you are right, seems no clear use case for that, thanks for your guide
09:21:50 cdent jichen: you’re welcome, and thank you for trying to make sure we are consistent, we can probalby do better on that.
09:22:25 jichen cdent: yes, I will make more analysis on that :), thanks
09:22:52 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for allocations https://review.openstack.org/457534
09:22:52 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for usages https://review.openstack.org/457535
09:22:53 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: CLI for aggregates https://review.openstack.org/505643
09:22:53 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: [WIP] CLI for resource classes https://review.openstack.org/511182
09:22:54 openstackgerrit Andrey Volkov proposed openstack/osc-placement master: [WIP] RP list: member_of and resources parameters https://review.openstack.org/511183
09:31:43 priya__ cdent : Could you please review https://review.openstack.org/#/c/508533/
09:32:59 cdent priya__: yes, will put it on my list for today
09:33:54 priya__ thank you !
10:45:13 openstackgerrit Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580
11:11:16 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257
11:16:23 ralonsoh alex_xu: hi, if you have time, can you take a look at https://review.openstack.org/#/c/502306/?
11:17:23 ralonsoh alex_xu: BTW, this one was approved last cycle. Half of the code is already merged. I would like to have it approved this cycle to continue the work: https://review.openstack.org/#/c/504895/
11:24:17 openstackgerrit edan david proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613
12:21:30 cdent alex_xu: if you didn’t see this bit of irc chat yesterday, it covers some of the issues with shared providers and traits: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-10-16.log.html#t2017-10-16T18:37:18
12:21:50 cdent it took quite a while to figure out what efried was talking about but we finally figured it out in that chat
12:25:05 efried That's me. It can take a while to figure out wtf I'm talking about.
12:25:28 efried I'd like to think it's because they're such advanced concepts, I have to explain them carefully to lesser mortals.
12:25:41 efried (In case you're just joining us, naw, that ain't it.)
12:26:25 cdent that ^^ was driven by alex’s latest comment on your spec, on the principle of more context is better
12:27:41 efried cdent I know, and I appreciate it. I'm just ribbin ya.
12:29:15 cdent I know, I’m giving you context on the context giving, for sake of contextualizing the people in our context, contextually
12:29:47 alex_xu ralonsoh: yea, add it to my review list
12:30:04 cdent soon the ai which is learning human behavior from the log of this channel will achieve consciousness, and presumably wipe us from the face of the earth
12:30:16 alex_xu cdent: efried yea, I read that today
12:30:37 alex_xu cdent: efried, the current trait implement supports that case
12:31:08 alex_xu the current trait implement will try to collect the traits from the RP and sharing RP which in the same aggregates
12:31:22 efried alex_xu The case where RAID5 and SSD are split across the compute RP and the shared storage RP?
12:32:32 alex_xu the problem is the current implementation of https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L2453 doesn't return the correct PRs

Earlier   Later