| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-13 | |||
| 08:32:27 | openstackgerrit | zhangyangyang proposed openstack/nova master: Remove method get_by_service_id https://review.openstack.org/511767 | |
| 09:00:35 | openstackgerrit | Huan Xie proposed openstack/nova master: [WIP] VGPU: Define vgpu related resources https://review.openstack.org/511180 | |
| 10:07:36 | victor | exit | |
| 10:32:11 | openstackgerrit | Chhavi Agarwal proposed openstack/nova master: Volume detach should have instance uuid https://review.openstack.org/511804 | |
| 11:04:08 | openstackgerrit | priyaduggirala proposed openstack/nova master: Rename parameters in call() of nova/image/glance.py https://review.openstack.org/508533 | |
| 11:11:36 | openstackgerrit | Merged openstack/nova master: Implement query param schema for GET hypervisor(2.33) https://review.openstack.org/507344 | |
| 11:53:03 | epalper | hi, I'm trying to nova vm from opnfv functest deployment seeing the following error in nova-compute.log | |
| 11:53:05 | epalper | https://paste.ubuntu.com/25731708/ | |
| 11:53:39 | epalper | could you please tell me what is going on during nova boot ? | |
| 12:04:48 | efried | alex_xu What's the best source of information for me to understand the semantics of shared/aggregates? | |
| 12:05:05 | efried | Is there a nice doc? Is it described in a spec? | |
| 12:05:20 | efried | I pawed around specs a bit yesterday and couldn't find what I was looking for. | |
| 12:26:09 | efried | D'oh | |
| 12:32:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: fix cleaning up evacuated instances https://review.openstack.org/510938 | |
| 12:41:50 | openstackgerrit | Bhagyashri Shewale proposed openstack/nova-specs master: Skip instance backup image creation when rotation 0 https://review.openstack.org/511825 | |
| 12:54:19 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Convenience Allocations objects for compute https://review.openstack.org/511831 | |
| 12:57:11 | openstackgerrit | zhangyangyang proposed openstack/nova master: Remove method get_by_service https://review.openstack.org/511835 | |
| 13:14:34 | openstackgerrit | Viktor Bass proposed openstack/nova master: doc: Fix command output in scheduler document https://review.openstack.org/511839 | |
| 13:20:45 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Make TestRPC inherit from the base nova TestCase https://review.openstack.org/511842 | |
| 13:22:22 | openstackgerrit | melanie witt proposed openstack/nova master: Remove old-style quotas code https://review.openstack.org/511689 | |
| 13:23:02 | mriedem | melwitt: so did you and dan get to the bottom of https://launchpad.net/bugs/1722404 ? | |
| 13:23:05 | openstack | Launchpad bug 1722404 in OpenStack Compute (nova) pike "Database transactions can fail with "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" because of scatter_gather_cells" [High,In progress] - Assigned to melanie witt (melwitt) | |
| 13:25:47 | melwitt | mriedem: not 100% sure yet but it makes sense and looks promising based on my local unit test reproducer. dansmith has a patch up https://review.openstack.org/#/c/511651 | |
| 13:25:48 | openstackgerrit | Dmitry Tantsur proposed openstack/nova master: Pick ironic nodes without VCPU set https://review.openstack.org/511844 | |
| 13:25:55 | dtantsur | fallout from our inventory work in the end of Pike ^^^ vdrok FYI | |
| 13:26:56 | melwitt | mriedem: the theory is that the culprit is we only do a shallow copy.copy() of the context when we return a new RequestContext during cell targeting, and that makes hidden oslo.db state get shared across the threas | |
| 13:26:58 | melwitt | *threads | |
| 13:30:40 | dansmith | melwitt: I'll write some tests for that | |
| 13:32:31 | mriedem | melwitt: dansmith: queried logstash on those warnigns, | |
| 13:32:38 | mriedem | linked the results in the change, there are quite a few hits on both | |
| 13:32:48 | dansmith | yep, I know of a couple places that will trigger it | |
| 13:33:04 | dansmith | mriedem: well, one of the warnings that is.. do you see both? | |
| 13:33:12 | mriedem | yes | |
| 13:35:14 | dansmith | okay, so that's actually good, | |
| 13:35:29 | dansmith | because it plays into the theory that we leak that internal context somewhere across a target | |
| 13:38:38 | melwitt | cool. yeah, the more I've thought about it, the more I think that's what it is | |
| 13:40:03 | mriedem | bauwser: replied in https://review.openstack.org/#/c/501017/ | |
| 13:42:04 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215 | |
| 13:42:04 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | |
| 13:45:33 | Laurene | mriedem: Hi,We're requesting +1/-1 reporting permission to Nova changes for IBM zVM CI. Can you help me to resolve it ? | |
| 13:46:01 | Laurene | mriedem: We have posted a mail on the ML:http://lists.openstack.org/pipermail/openstack-dev/2017-October/123488.html | |
| 13:46:03 | melwitt | mriedem, dansmith: I'm gonna be heading out for a weekend trip in about an hour, so just FYI | |
| 13:47:26 | fried_rice | melwitt You real busy til then? Feel like reviewing a spec? :* | |
| 13:47:55 | dansmith | melwitt: okay | |
| 13:48:15 | openstackgerrit | Eric Fried proposed openstack/nova master: Convenience Allocations objects for compute https://review.openstack.org/511831 | |
| 13:48:32 | fried_rice | superdan ^ step 1 in allocations-to-spawn | |
| 13:48:54 | superdan | cool | |
| 13:50:25 | melwitt | fried_rice: hah | |
| 13:51:01 | openstackgerrit | Eric Fried proposed openstack/nova master: Convenience Allocations objects for compute https://review.openstack.org/511831 | |
| 13:51:21 | fried_rice | d'oh, forgot to git add test suite, fixed ^ | |
| 13:54:13 | superdan | mriedem: you want me to closes-bug: #1722404 on this patch right? | |
| 13:54:14 | openstack | bug 1722404 in OpenStack Compute (nova) pike "Database transactions can fail with "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" because of scatter_gather_cells" [High,In progress] https://launchpad.net/bugs/1722404 - Assigned to melanie witt (melwitt) | |
| 13:55:48 | openstackgerrit | Dmitry Tantsur proposed openstack/nova master: Pick ironic nodes without VCPU set https://review.openstack.org/511844 | |
| 13:55:53 | dtantsur | this ended being a can of worms, but I guess that's the complete fix ^^^ | |
| 13:57:35 | mriedem | superdan: sure | |
| 13:57:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Regenerate context during targeting, and sanity check some things https://review.openstack.org/511651 | |
| 13:58:09 | superdan | mriedem: should we revert the previous patch or just note it on the bug? | |
| 13:58:24 | mriedem | superdan: so the previous patch doesn't fix anything right? does it hurt anything? | |
| 13:58:34 | mriedem | Laurene: done | |
| 14:01:11 | Laurene | mriedem:That's great! thanks very much! | |
| 14:01:14 | melwitt | mriedem: it increases contention for the cell cache so should probably revert it | |
| 14:02:11 | superdan | mriedem: it doesn't fix anything, but it does mean that the threads get untargeted contexts and are required to target them themselves, which is a little less clean I think | |
| 14:10:17 | superdan | mriedem: I'm hoping that this will get rid of the transaction context warning, and yeah I can track down the re-targeting warning in later patches | |
| 14:10:40 | superdan | mriedem: would you rather me separate the fix and the warnings so we don't backport the warnings? | |
| 14:10:49 | superdan | probably makes sense | |
| 14:14:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Regenerate context during targeting, and sanity check some things https://review.openstack.org/511651 | |
| 14:14:54 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add cell retargeting warnings https://review.openstack.org/511864 | |
| 14:15:32 | mriedem | yeah | |
| 14:15:36 | mriedem | sapd_: are you around? | |
| 14:15:55 | mriedem | sapd_: if you're still having that problem, can you see if https://review.openstack.org/511651 fixes it for you? | |
| 14:16:40 | mriedem | superdan: had a couple of nits in here https://review.openstack.org/#/c/511651/4/nova/tests/unit/test_context.py | |
| 14:17:04 | superdan | mriedem: I looked for assertis | |
| 14:17:33 | superdan | ah yeah I see it | |
| 14:17:47 | superdan | three uses among hundreds of is not none, so I missed it | |
| 14:19:49 | mriedem | leaving another comment, sec | |
| 14:21:03 | superdan | mriedem: hurry up, I want to get to saying "wtf" to a bunch of fried_rice's patch | |
| 14:22:51 | mriedem | done | |
| 14:23:01 | mriedem | just was asking for a comment above the from_dict/to_dict dance, | |
| 14:23:13 | mriedem | i had to make sure that did the thing we wanted, | |
| 14:23:18 | mriedem | and that it somehow didn't invalidate our caching | |
| 14:23:38 | bauwser | mriedem: thanks for having taken time to summarize the outcome,+2d | |
| 14:23:46 | mriedem | bauwser: thanks | |
| 14:24:16 | mriedem | sdague: happy with the changes here? https://review.openstack.org/#/c/501017/ | |
| 14:24:32 | gibi | Why does the compute manager only want to clean up an evacuated instance at startup if the virt driver still report such instance? https://github.com/openstack/nova/blob/d9212edb8fe8376c218cc40e0bee1540083b25e6/nova/compute/manager.py#L655 | |
| 14:25:01 | openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | |
| 14:25:23 | gibi | I could imagine situations when a compute is recovered in a way that the hypervisor does not see the instance any more but the allocations are still not cleaned up | |
| 14:25:28 | sdague | mriedem: sold | |
| 14:27:19 | mriedem | gibi: hmm, probably just legacy behavior because the RT only cared about things running on it at that time | |
| 14:27:45 | mriedem | the RT will pull instances based on host, and if the instance was evacuated to another host, the old recovered source RT won't find those instances and track them anymore | |
| 14:28:37 | gibi | but as the rt periodic task will not clean up these instances any more we have to clean up evacuated instance even if they are not visible to the hypervisor any more | |
| 14:28:50 | gibi | at startup explicitly | |
| 14:29:23 | gibi | I guess I need to create a functional test for this case as well | |
| 14:29:53 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Send Allocations to spawn https://review.openstack.org/511879 | |
| 14:29:57 | openstackgerrit | Dan Smith proposed openstack/nova master: Regenerate context during targeting, and sanity check some things https://review.openstack.org/511651 | |
| 14:29:58 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add cell retargeting warnings https://review.openstack.org/511864 | |
| 14:30:03 | mriedem | gibi: so i assume you're thinking about moving the RP allocation cleanup outside of that for loop and add a new for loop on the 'evacuations' instances right? | |
| 14:30:15 | gibi | mriedem: something like that | |
| 14:30:45 | gibi | mriedem: the driver.destroy still need to be only run for the instances that are known by the hypervisor but the resource cleanup should run on all the evacuated instances | |
| 14:31:00 | mriedem | gibi: yeah probably | |
| 14:31:55 | gibi | mriedem: I will do this change separatly from the current fix | |