| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-09 | |||
| 15:25:24 | sean-k-mooney | johnthetubaguy: o/ | |
| 15:25:35 | johnthetubaguy | sean-k-mooney: hi | |
| 15:26:10 | sean-k-mooney | johnthetubaguy: QQ im just looking at the compute manager class in the pre live migration fuction https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/compute/manager.py#L5542-L5557 | |
| 15:26:39 | sean-k-mooney | johnthetubaguy: this is where we will have to consume the new neutron port bining api above the virt drivers correct | |
| 15:26:45 | jaypipes | dansmith: ok, I'll see what I can do | |
| 15:27:11 | dansmith | jaypipes: regardless, I've +2d a bunch of the early part of that de-orm set | |
| 15:27:31 | dansmith | so if our gate was working at all, we could merge those soonish | |
| 15:28:01 | sean-k-mooney | johnthetubaguy: so instead of getting current bindings with self.network_api.get_instance_nw_info(context, instance) i will need to create the destingation port bindings and the activate them later | |
| 15:28:22 | sean-k-mooney | johnthetubaguy: just trying to make sure https://review.openstack.org/#/c/375580/5/specs/queens/approved/neutron-new-port-binding-api.rst is accurate | |
| 15:28:33 | johnthetubaguy | sean-k-mooney: it calls through to here today: https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L327 | |
| 15:28:56 | johnthetubaguy | https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/network/neutronv2/api.py#L327 | |
| 15:30:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove dead code of api.fault notification sending https://review.openstack.org/505164 | |
| 15:30:47 | sean-k-mooney | johnthetubaguy: right so that si called on line https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/compute/manager.py#L5556 | |
| 15:31:12 | gibi | stephenfin, mriedem: could you check back to https://review.openstack.org/#/c/505164 I updated the reno based on stephenfin's excellent suggestions | |
| 15:31:17 | johnthetubaguy | sean-k-mooney: yes, that's the one | |
| 15:31:41 | johnthetubaguy | sean-k-mooney: but should be no changes to the compute manager, only changes in the network layer | |
| 15:33:07 | sean-k-mooney | johnthetubaguy: well what i wanted to check is where is the xml generated for the remote node is it is the prelivemigration on line 5547 or after the networking call on 5556 | |
| 15:34:03 | sean-k-mooney | i had the perception that i might need to change the order of those calls also im currently trace through the code to confim though | |
| 15:35:49 | johnthetubaguy | sean-k-mooney: for the XML stuff, its all about adding the correct details into migrate_data so this method gets it correct: https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/virt/libvirt/driver.py#L6357 | |
| 15:37:41 | sean-k-mooney | ah cool thanks that is what i was looking for. i can trace out how that gets populated now that i know where to look | |
| 15:39:18 | johnthetubaguy | sean-k-mooney: have a look at this bit: https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/virt/libvirt/driver.py#L6930 | |
| 15:58:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance. |
|
| 15:58:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance. |
|
| 15:58:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.create https://review.openstack.org/483969 | |
| 15:58:38 | sean-k-mooney | johnthetubaguy: right so that is part of the virt diriver prelive migration function which is called before setup_networks_on_host which is why i taught i might need to swap the order of those calls | |
| 16:00:24 | gibi | mriedem, stephenfin: I had to rebase https://review.openstack.org/#/c/483324 to adapt some new test cases from master. You were both +2 before so could you check it again? | |
| 16:01:05 | sean-k-mooney | johnthetubaguy: any way you confimed im looking more or less in the right part of the code so ill trace through it and confim the current workflow and what we need for the new workflow | |
| 16:03:44 | johnthetubaguy | sean-k-mooney: I guess you want to send the updated port bindings to os-vif on the destination node, before handing control back to the source node? | |
| 16:05:46 | sean-k-mooney | johnthetubaguy: am well i want to create the binding for the destionation before i create destination xml so that if the interfaces defintion change i can update that section of xml. e.g. linux bridge to ovs or iptables to contrack firewall | |
| 16:05:53 | jaypipes | dansmith: I don't get it... I cherry-pick this patch locally: https://review.openstack.org/#/c/509030/ onto master (trying to re-order the de-orm series) and the cherry-pick applies code that is from the patch underneath it (https://review.openstack.org/#/c/509029/) :( | |
| 16:05:53 | openstackgerrit | Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512 | |
| 16:06:30 | johnthetubaguy | sean-k-mooney: agreed | |
| 16:06:47 | dansmith | jaypipes: if you want to pastebin a list in the right order, I can try to do it | |
| 16:07:06 | jaypipes | dansmith: I thought cherry-pick was supposed to only apply the diff of the specific patch and nothing else? | |
| 16:07:08 | sean-k-mooney | johnthetubaguy: in the current flow i generate teh xml and then bind which mean today when i live migrate form a lb host to ovs it work but livirt still plugs the tap into linux brige and neutron wait for the port to show up on ovs | |
| 16:07:30 | dansmith | jaypipes: not really, but it's only supposed to do the one you ask for, which is what you're saying yeah | |
| 16:08:51 | sean-k-mooney | johnthetubaguy: works was ment to be in qoutes because it live migrate but you networking is screwed untill you hard reboot the vm | |
| 16:09:04 | jaypipes | dansmith: well, this is what I'm *trying* to do... http://paste.openstack.org/show/623122/ | |
| 16:09:44 | dansmith | jaypipes: k, lemme try | |
| 16:09:58 | jaypipes | dansmith: and what I tried was git checkout master && git pull && checkout -b de-orm-rp && git cherry-pick 0c1a5bc | |
| 16:10:16 | jaypipes | dansmith: but that applied changes from ca983c1 for some reason | |
| 16:13:32 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: de-ORM ResourceProvider.get_by_uuid() https://review.openstack.org/509025 | |
| 16:13:32 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: Move RP._get|set_aggregates() to module scope https://review.openstack.org/509026 | |
| 16:13:33 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: remove CRUD operations on Inventory class https://review.openstack.org/509029 | |
| 16:13:33 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: streamline InventoryList.get_all_by_rp_uuid() https://review.openstack.org/509030 | |
| 16:13:34 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: remove dead code in Allocation._create_in_db() https://review.openstack.org/509031 | |
| 16:13:34 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: remove ability to delete 1 allocation record https://review.openstack.org/509032 | |
| 16:13:35 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: fix up AllocList.get_by_resource_provider_uuid https://review.openstack.org/509033 | |
| 16:13:35 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: rework AllocList.get_all_by_consumer_id() https://review.openstack.org/509035 | |
| 16:13:36 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: Remove RP.get_traits() method https://review.openstack.org/509027 | |
| 16:13:36 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028 | |
| 16:13:37 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: remove _HasAResourceProvider mixin https://review.openstack.org/509036 | |
| 16:13:37 | openstackgerrit | Dan Smith proposed openstack/nova master: rp: break functions out of _set_traits() https://review.openstack.org/509908 | |
| 16:13:39 | dansmith | jaypipes: that look right? ^ | |
| 16:14:03 | dansmith | had to re-order one thing from your list, but otherwise that ordering was fine | |
| 16:15:04 | jaypipes | dansmith: yep, that'll work. thanks man, really appreciated. | |
| 16:15:09 | dansmith | np | |
| 16:15:19 | jaypipes | dansmith: I see you just slid the CRUD one before the Streamline one. k. | |
| 16:15:30 | dansmith | had to else huge esplosion | |
| 16:15:46 | jaypipes | yes, that's the espolosion I was dealing with.. | |
| 16:46:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1721652 in the functional test env https://review.openstack.org/510176 | |
| 16:46:32 | openstack | bug 1721652 in OpenStack Compute (nova) pike "Evacuate cleanup fails at _delete_allocation_for_moved_instance" [High,Confirmed] https://launchpad.net/bugs/1721652 | |
| 16:47:39 | gibi | mriedem: I managed to push a functional regression for bug 1721652 https://review.openstack.org/510176 | |
| 16:47:40 | openstack | bug 1721652 in OpenStack Compute (nova) pike "Evacuate cleanup fails at _delete_allocation_for_moved_instance" [High,Confirmed] https://launchpad.net/bugs/1721652 | |
| 16:49:22 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Enable PUT dict to /allocations/{consumer_uuid} https://review.openstack.org/510625 | |
| 16:49:22 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Document the changes to PUT /allocations/{consumer_uuid} https://review.openstack.org/510626 | |
| 16:50:16 | mriedem | gibi: ok, cool | |
| 16:54:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539 | |
| 16:54:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: factor out compute service start in ServerMovingTest https://review.openstack.org/503037 | |
| 16:54:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159 | |
| 17:22:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unnecessary BDM destroy during instance delete https://review.openstack.org/510635 | |
| 17:27:06 | openstackgerrit | Merged openstack/nova master: Remove useless periodic task that expires quota reservations https://review.openstack.org/506822 | |
| 17:30:03 | openstackgerrit | Merged openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | |
| 17:30:40 | openstackgerrit | Merged openstack/nova master: Fix typo in test_prep_resize_errors_migration https://review.openstack.org/510591 | |
| 17:38:48 | jaypipes | can we please boot the EMC ScaleIO CI system? :( | |
| 17:39:09 | melwitt | mriedem: ack | |
| 17:42:17 | openstackgerrit | Merged openstack/nova master: Make setenv consistent for unit, func, and api-samples https://review.openstack.org/507976 | |
| 17:50:01 | mriedem | ericyoung: can the emc scaleio ci just be run on the one patch that adds the imagebackend? | |
| 17:52:25 | Tengu | hello! | |
| 17:52:36 | Tengu | anyone can tell me a bit more about this log message? 2017-10-09 19:49:34.201 2665 DEBUG nova.compute.utils [req-08080314-ca07-499b-b559-a30632b6a773 f3cef0caace94cf0af3d7c21b3706583 553ad7544f5a4479b4eb346dc7a76a82 - default default] [instance: 9f503af3-ab45-43e6-be45-b0dbcff60483] Cannot attach VIF 4529caaf-3b69-4314-899c-a2090fe6114b to the node 4aa07b6d-ccf0-4f2b-8938-e20b07ff0156 due to error: | |
| 17:52:42 | Tengu | Unable to attach VIF 4529caaf-3b69-4314-899c-a2090fe6114b, not enough free physical ports. (HTTP 400) notify_about_instance_usage /usr/lib/python2.7/site-packages/nova/compute/utils.py:328 | |
| 17:53:36 | Tengu | I'm trying to deploy an overcloud (tripleO), and I have some issues with the Ceph nodes, the deploy script being unable to find the two nodes. I'm wondering if this log entry can explain why, and what it means. | |
| 18:11:46 | mriedem1 | efried: happy monday | |
| 18:17:57 | mriedem | sdague: you were +2 on this before, assume you still like it https://review.openstack.org/#/c/505317/6 | |
| 18:20:00 | sdague | mriedem / efried - why did that shuffle get added? | |
| 18:20:02 | mriedem | efried: looks like https://review.openstack.org/#/c/490057/ needs to be rebased and there are quite a few test failures | |
| 18:20:46 | mriedem | sdague: it's not added | |
| 18:20:47 | sdague | oh, never mind, it was there before the patch is just highlighting weirdly | |
| 18:20:51 | mriedem | yeah | |
| 18:25:04 | openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | |
| 18:25:04 | openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | |
| 18:25:05 | openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | |
| 18:25:05 | openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | |
| 18:31:40 | jaypipes | dansmith: I'll definitely fix up that unit test miss thing. just in the middle of rebasing the n-r-p series now for the ID vs. uuid stuff. | |
| 18:32:41 | dansmith | jaypipes: ack | |
| 18:46:47 | melwitt | sdague, mriedem: my devstack hack patch for the ceph job https://review.openstack.org/#/c/509663/ | |
| 18:47:45 | sdague | melwitt: we typically don't want any of the plugin conditional code to leak into there | |
| 18:48:01 | sdague | melwitt: is there an appropriate plugin phase for the ceph plugin to do it? | |
| 18:48:05 | mriedem | melwitt: so this is progress right? http://logs.openstack.org/63/509663/4/experimental/gate-tempest-dsvm-py35-full-devstack-plugin-ceph-ubuntu-xenial-nv/2b03b3a/logs/devstacklog.txt.gz#_2017-10-06_05_26_37_113 | |
| 18:48:11 | mriedem | sdague: apparently not | |