| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-09 | |||
| 10:04:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Convert floating IP tests to ddt https://review.openstack.org/471360 | |
| 10:17:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove dead code of api.fault notification sending https://review.openstack.org/505164 | |
| 10:19:09 | openstackgerrit | Claudiu Belu proposed openstack/nova master: doc: Adds Hyper-V PCI passthrough details https://review.openstack.org/510467 | |
| 10:24:28 | mdbooth | lyarwood: Would you mind casting your eye over https://review.openstack.org/#/c/510106/ ? It's your previously approved spec, but with additional api goodness as requested by mriedem in code review. | |
| 10:25:15 | lyarwood | mdbooth: ack, I'll try to take a look today, when is the deadline btw? | |
| 10:26:13 | mdbooth | lyarwood: Soon :) I'm still going to have to hassle some cores. | |
| 10:26:27 | lyarwood | mdbooth: kk, it's the 19th FYI | |
| 10:27:57 | mdbooth | lyarwood: I had that noted down somewhere. Right now it's generally in the 'soon' bucket :) | |
| 10:33:21 | gibi | bauzas, stephenfin: hi, if you have some time, there is a not soo complex patch needing a second +2 https://review.openstack.org/#/c/505164/ | |
| 10:50:22 | stephenfin | gibi: Done. The reno needs a little sprucing up but otherwise +" | |
| 10:50:25 | stephenfin | * +2 | |
| 10:51:27 | gibi | stephenfin: thanks I fill fix that up soon | |
| 10:51:58 | gibi | stephenfin: also thanks for looking at https://review.openstack.org/#/c/483969/ | |
| 10:52:17 | gibi | stephenfin: unfortunately that is the last in the series | |
| 10:52:34 | gibi | stephenfin: the first is https://review.openstack.org/#/c/483324 | |
| 10:52:48 | openstackgerrit | Merged openstack/nova master: Add 400 as error code for resource class delete https://review.openstack.org/508080 | |
| 10:59:07 | rgerganov | Does anyone know why Zuul gives -1 on a patch which can be clearly applied on master? https://review.openstack.org/#/c/509417/ | |
| 10:59:36 | rgerganov | I have +1 from Jenkins, so how to "recheck" only Zuul? | |
| 10:59:40 | kashyap | rgerganov: #openstack-infra folks would know | |
| 11:00:06 | rgerganov | kashyap, ok, I will try to ask there | |
| 11:07:02 | openstackgerrit | sahid proposed openstack/nova master: pci: update PciDevice object field 'address' to accept NULL https://review.openstack.org/508175 | |
| 11:07:03 | openstackgerrit | sahid proposed openstack/nova master: pci: add for PciDevice object new field mdev https://review.openstack.org/508176 | |
| 11:07:03 | openstackgerrit | sahid proposed openstack/nova master: pci: generalize object unit-tests for different framework https://review.openstack.org/508177 | |
| 11:07:04 | openstackgerrit | sahid proposed openstack/nova master: pci: generalize stats unit-tests for different framework https://review.openstack.org/508179 | |
| 11:07:05 | openstackgerrit | sahid proposed openstack/nova master: pci: add support for mdev device type https://review.openstack.org/508178 | |
| 11:07:05 | openstackgerrit | sahid proposed openstack/nova master: libvirt: update PCI node device to report mdev devices https://review.openstack.org/508183 | |
| 11:07:06 | openstackgerrit | sahid proposed openstack/nova master: libvirt: report mdev resources https://review.openstack.org/508184 | |
| 11:07:06 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add support to start vm with using mdev (vGPU) https://review.openstack.org/508185 | |
| 11:07:07 | openstackgerrit | sahid proposed openstack/nova master: functional: rework fakelibvirt host pci devices https://review.openstack.org/508186 | |
| 11:07:07 | openstackgerrit | sahid proposed openstack/nova master: functional: resuse SRIOV funtional tests for MDEV devices https://review.openstack.org/508187 | |
| 11:07:08 | openstackgerrit | sahid proposed openstack/nova master: WIP - functional: rewrite class to generate pci devices https://review.openstack.org/508835 | |
| 11:31:03 | sdague | zuul is in testing mode | |
| 11:31:10 | sdague | don't worry about zuul -1 votes | |
| 12:18:28 | jaypipes | bauzas: can you explain what you meant by "and how Python is bad with module-level functions" please? | |
| 12:38:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Flatten functions https://review.openstack.org/367470 | |
| 12:38:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: De-duplicate _numa_get_flavor_XXX_map_list https://review.openstack.org/385074 | |
| 12:38:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Rename '_numa_get_constraints_XXX' functions https://review.openstack.org/385072 | |
| 12:38:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraints' functions https://review.openstack.org/385071 | |
| 12:38:32 | sean-k-mooney | jaypipes: dansmith matt does not seam to be around so ill ask ye. the lab hosting the intel nfv ci has had its firewall fixed to allow ssh again. | |
| 12:38:46 | jaypipes | sean-k-mooney: oh, nice. | |
| 12:38:56 | sean-k-mooney | jaypipes: dansmith so the ci is now being triggered again but its broken | |
| 12:39:29 | jaypipes | sean-k-mooney: it's not voting though is it? | |
| 12:39:51 | sean-k-mooney | jaypipes: im haveing troble internally getting this proritied to fix. should i ask them to leave it commenting or put it into silent mode | |
| 12:40:03 | sean-k-mooney | its not gateing | |
| 12:40:14 | jaypipes | sean-k-mooney: put it in silent mode until it can be fixed I think. | |
| 12:40:41 | jaypipes | sean-k-mooney: and if you need some muscle to come over and bonk some heads to get it fixed, lemme know ;) | |
| 12:40:43 | bauzas | jaypipes: hola | |
| 12:40:52 | sean-k-mooney | jaypipes: ok will do. | |
| 12:41:03 | jaypipes | bauzas: bonjour, monsieur | |
| 12:41:25 | bauzas | jaypipes: using top-level functions is IMHO bizarre | |
| 12:42:09 | jaypipes | bauzas: "and how Python is bad with module-level functions" <-- what do you mean by "bad" though? | |
| 12:42:37 | jaypipes | bauzas: is there something poor-performing or something about module-level functions that I don't know about? | |
| 12:43:40 | bauzas | jaypipes: the main problem with module-level functions is they are global | |
| 12:44:59 | jaypipes | bauzas: I'm not following you... | |
| 12:45:13 | bauzas | jaypipes: sorry, I'm trying to explain | |
| 12:45:48 | bauzas | jaypipes: I'm not really *against* using module functions | |
| 12:45:56 | bauzas | jaypipes: it's just another design pattern | |
| 12:46:11 | bauzas | jaypipes: but the problem I see with using that pattern is about | |
| 12:46:32 | bauzas | 1/ we could have a long list of functions | |
| 12:46:43 | bauzas | 2/ each function is set globally by python | |
| 12:47:21 | bauzas | which means for 2/ you need to make sure to not use a global variable | |
| 12:47:47 | jaypipes | bauzas: you need to make sure not to use global variables in staticmethods as well... | |
| 12:48:24 | bauzas | not really | |
| 12:48:30 | bauzas | you can use class variables | |
| 12:49:09 | bauzas | the main problem is about the variables scopes | |
| 12:49:09 | jaypipes | bauzas: sorry, I guess I just don't see the difference | |
| 12:50:31 | Tengu | hello! | |
| 12:51:23 | Tengu | small question: I'd like to get some stats regarding OVS using collectd, I guess I'll need to configure some SNMP plugin in collectd? or are there better way? (note: not sure this is the right channel… ?) | |
| 12:52:07 | bauzas | jaypipes: sorry that's where I have some problems explaining | |
| 12:52:11 | jaypipes | Tengu: hi :) definitely not the right channel :) | |
| 12:52:22 | jaypipes | Tengu: are you an OpenStack user? | |
| 12:52:24 | bauzas | jaypipes: honestly, https://softwareengineering.stackexchange.com/questions/171296/staticmethod-vs-module-level-function is what I want to explain | |
| 12:52:48 | bauzas | there are not so much differences in between using the static deco and just a module-scoped function | |
| 12:52:56 | Tengu | jaypipes: yup - sorry, OVS in openstack env - should have precised. | |
| 12:53:16 | bauzas | it's more about what kind of maintainability you want to get, and if you want to make sure to not have problems later | |
| 12:53:53 | jaypipes | bauzas: these functions are operating on the database, not on the objects. Which is why I want to have them in separate module-level functions. | |
| 12:54:26 | jaypipes | Tengu: I think the best thing would be to ask your question on the openstack-operators@ mailing list. | |
| 12:54:40 | Tengu | jaypipes: hmm ok. | |
| 12:55:31 | jaypipes | bauzas: also... did you read the part in the question that says "I've googled this question, and it seems there's some general agreement that module-level functions are preferred over static methods because it's more pythonic."? :) | |
| 12:56:22 | bauzas | jaypipes: well, the dude is wrong when he's saying ". Static methods have the advantage of being bound to its class" | |
| 12:56:36 | bauzas | because static methods are *unbound* AFAIK | |
| 12:56:45 | bauzas | I was rather pointing the best answer | |
| 12:57:35 | bauzas | tbc, I see the CRUD ops as just being against a specific table | |
| 12:57:39 | jaypipes | bauzas: I think we'll just have to agree to disagree on this one. It's a code style preference, nothing more. | |
| 12:57:48 | bauzas | in that case, I just feel those should be defined as static | |
| 12:58:08 | bauzas | jaypipes: agreed, I was about to say the same, it's just a pattern discussion | |
| 12:58:14 | bauzas | nothing wrong from your side | |
| 12:58:18 | bauzas | just stylistic | |
| 12:58:34 | bauzas | that said, I did not -1d for that | |
| 12:58:51 | bauzas | I rather pointed the problem of explicitelly telling which columns to return | |
| 12:59:12 | bauzas | from a maintenability PoV, that is concerning me | |
| 13:00:33 | jaypipes | bauzas: and I responded that I prefer to have the columns be listed explicitly for the reason I outlined in my response to you. I gave you a specific example of what happens when you add a field to the ORM model and that field is a relationship() result and all of a sudden your queries that use that ORM model bloat up unnecessarily. | |
| 13:03:06 | bauzas | jaypipes: hum, seems like I missed that point then | |
| 13:03:13 | bauzas | if so, I apologize | |
| 13:03:26 | bauzas | jaypipes: in https://review.openstack.org/#/c/509025/2/nova/objects/resource_provider.py@405 ? | |
| 13:03:42 | jaypipes | yes | |
| 13:03:49 | bauzas | the Gerrit formatting messed up most of your comment | |
| 13:03:56 | jaypipes | bauzas: the comment I made on Oct 6 at 2:50pm | |
| 13:04:09 | jaypipes | bauzas: ugh, yeah :( | |
| 13:05:04 | bauzas | hah, I thought you were telling me *why* to not use ORM objects, which I don't disagree | |