Posted	Nick	Remark
#openstack-nova - 2017-10-05
15:51:25	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/pike: fix unstable shelve offload functional tests https://review.openstack.org/509818
15:51:51	dansmith	cdent: fwiw, I agree with you on this: https://review.openstack.org/#/c/495854/4/nova/scheduler/utils.py
15:51:52	dansmith	I would have made it a classmethod
15:51:55	dansmith	not a big deal of course, but that's what I would have done
15:52:43	cdent	<british>cheers
15:54:57	edleafe	dansmith: heh, I had a 'from_host_state()' method on the orginal version. Should have left it there. :)
15:55:19	dansmith	just my preference.. doesn't matter
15:56:04	dansmith	edleafe: out of curiosity, why is this three patches instead of two with the object definition first?
15:56:16	openstackgerrit	Matt Riedemann proposed openstack/nova master: Remove metadata/system_metadata filter handling from get_all https://review.openstack.org/509819
15:56:28	dansmith	looking now, it seems like if you did the object patch first, you could have squashed the first and third together, which would be less back and forth
16:39:29	openstackgerrit	Chris Friesen proposed openstack/nova master: Add validation for cpu_realtime_mask https://review.openstack.org/468203
16:44:57	openstackgerrit	Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
16:44:58	openstackgerrit	Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
16:44:58	openstackgerrit	Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
16:44:59	openstackgerrit	Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
16:44:59	openstackgerrit	Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638
16:50:33	openstackgerrit	Matt Riedemann proposed openstack/nova stable/pike: fix unstable shelve offload functional tests https://review.openstack.org/509818
16:54:46	openstackgerrit	Merged openstack/nova master: Add attachment_get call to volume/cinder_api https://review.openstack.org/506805
17:01:21	mriedem	melwitt: you should probably look at this one https://review.openstack.org/#/c/506822/
17:01:28	mriedem	i think it's ok, but don't want to mess it up
17:04:18	dansmith	mriedem: https://review.openstack.org/#/c/498950/16/nova/tests/unit/conductor/tasks/test_migrate.py line 119, I asserted that it chose the migration type correctly
17:04:26	dansmith	mriedem: did you mean I didn't check that it detects resizes?
17:09:01	mriedem	dansmith: yeah
17:09:12	dansmith	okay
17:09:26	mriedem	but a follow up is fine
17:41:52	openstackgerrit	Dan Smith proposed openstack/nova master: Add test for resize migration type detection https://review.openstack.org/509852
18:13:36	openstackgerrit	Merged openstack/nova master: Update RT aggregate map less frequently https://review.openstack.org/489633
18:14:11	openstackgerrit	Merged openstack/nova master: Don't shell out to mkdir, use ensure_tree() https://review.openstack.org/492326
18:14:14	dansmith	man, having only 80% of nodepool available has a bigger impact on throughput than I would have expected
18:16:24	mriedem	hey, they can surely flip the switch back to 0% throughput again
18:16:29	mriedem	if you don't pipe down
18:16:29	mriedem	smith
18:16:40	dansmith	heh
18:17:48	melwitt	mriedem: sure, will do
18:40:39	cdent	mriedem: is this back in business? https://review.openstack.org/#/c/267587/
18:46:42	mriedem	cdent: the spec isn't approved yet
18:46:53	mriedem	cdent: the multiattach stuff is all dependent on the new style volume attachment stuff
18:47:40	cdent	ah. I got so excited by seeing it laying around.
18:48:03	cdent	the feature that failed to live but won’t die
18:49:05	dansmith	too fast to live, too young to die
18:49:09	dansmith	james dean.
19:02:59	dansmith	mriedem: I was just looking at my live migration patch wondering why it wasn't failing a test because it doesn't clean up by migration uuid on rollback
19:03:09	dansmith	and then ran tests again to check, which it failed
19:03:15	dansmith	confused because I thought this was passing
19:03:24	dansmith	found the test that tests this, which I fail
19:03:33	dansmith	dug through the path to figure out where we're cleaning up now
19:03:51	dansmith	didn't find it, almost filed a bug
19:03:52	dansmith	re-read test, found bug reference, found patch that addeded
19:03:58	dansmith	remembered I reviewed and approved that
19:04:05	dansmith	and that you have a fix on top of it waiting for +W
19:04:29	dansmith	so, altogether a pretty productive hour.. total work product output: one +W vote
19:12:59	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-vif stable/newton: Updated from global requirements https://review.openstack.org/373293
19:13:12	openstackgerrit	Merged openstack/nova master: fix unstable shelve offload functional tests https://review.openstack.org/509759
19:15:16	dansmith	jaypipes: this is needed for the migration uuid stuff, if you wanna slap yer +W on it: https://review.openstack.org/#/c/508699/
19:15:24	openstackgerrit	Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
19:15:24	openstackgerrit	Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
19:15:25	openstackgerrit	Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
19:15:25	openstackgerrit	Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
19:15:26	openstackgerrit	Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638
19:15:34	jaypipes	dansmith: on it.
19:16:02	jaypipes	dansmith: the whole series I presume?
19:16:19	dansmith	jaypipes: just that linked one is what I want right now
19:16:33	dansmith	jaypipes: I was just pushing the series in parallel to begging for your +W
19:16:53	dansmith	jaypipes: i.e. https://review.openstack.org/#/c/508699/
19:18:41	mriedem	dansmith: heh, well, i did beg for reviews a few times on that one
19:18:54	dansmith	mriedem: I know, I had a lot of stuff in my head at the time
19:18:57	mriedem	oh wait not that one
19:19:27	mriedem	was thinking this one https://review.openstack.org/#/c/507687/
19:19:31	mriedem	is that what you meant?
19:19:52	mriedem	yeah it is, nvm
19:20:24	mriedem	just about done with this epic internal email on scheduler configuration
19:20:26	dansmith	mriedem: I meant the one I linked
19:20:33	dansmith	oh
19:20:42	dansmith	you mean my earlier story, yes, I was talkin gabout 687
19:22:55	mriedem	36 minutes until a call about instance users
19:22:56	mriedem	yay!
19:23:17	mriedem	i need a trombone as mine is in the shop
19:23:21	dansmith	mriedem: btw, since I re-pushed that whole migration set, I squashed that extra test patch into the bottom
19:23:47	melwitt	I can't remember what "instance users" was about. maybe I should be grateful
19:24:51	sdague	anyone seen any of the john hopkins folks recently on irc? I was going through their image signing spec and code and just had a few quick questions
19:25:28	mriedem	sdague: nope
19:26:09	sdague	neither dane nor kaitlin are here unless I suck at tab completing. But I'm not sure if others have irc nicks.
19:28:22	mriedem	that's who i was looking for
19:29:17	mriedem	cdent: btw this is the goal https://review.openstack.org/#/c/330285/
19:29:22	mriedem	for the new style volume attach stuff,
19:29:35	mriedem	jgriffith is working on a new microversion on the cinder side, patch is up for that now but needs some work,
19:29:48	mriedem	but then the nova change will require that new cinder microversion and we can work on getting the nova patch in,
19:29:51	mriedem	and then it's multiattach time
19:30:15	openstackgerrit	melanie witt proposed openstack/nova master: Make setenv consistent for unit, func, and api-samples https://review.openstack.org/507976
19:30:58	mriedem	cdent: have your corporate overlords expressed an interest in multiattach?
19:31:47	cdent	not that I’m aware of, but my corporate overlords interests via me are pretty focused
19:31:56	cdent	I would assume they probably are interested
19:32:29	cdent	my interest is mostly sparked by observing it for enough ptgs, summits, midcycles to think of it is a somewhat annoying friend
19:33:47	openstackgerrit	melanie witt proposed openstack/nova master: Make setenv consistent for unit, func, and api-samples https://review.openstack.org/507976
19:34:47	mriedem	melwitt: i believe, to summarize, an instance user was the ability for a guest to get a token to do things
19:34:57	melwitt	ohhh
19:35:06	melwitt	that was the new vendordata thing right?
19:35:07	mriedem	but i was never really involved (by my own choosing) in that discussion, so i'm blissfully ignorant
19:35:22	jaypipes	dansmith: k, done
19:35:29	melwitt	or that discussion resulted in the new vendordata I thought

Earlier   Later