| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-04 | |||
| 16:30:42 | cfriesen | bauzas: the nice thing about that is that it works with existing flavors/images | |
| 16:31:01 | cfriesen | bauzas: we're talking about a new filter anyway | |
| 16:31:03 | bauzas | cfriesen: say I already have aggregates that are tagged and filters | |
| 16:31:20 | bauzas | cfriesen: how can that work in an upgrade way? | |
| 16:31:39 | bauzas | you would default no namespace to the current behaviour ? | |
| 16:31:43 | cfriesen | bauzas: yes | |
| 16:31:53 | bauzas | cfriesen: honesty, I don't like that | |
| 16:31:55 | cfriesen | in the existing filters | |
| 16:32:02 | bauzas | you can create as many aggregates as you want | |
| 16:32:10 | cfriesen | in the new filter we'd want consistent behaviour for both image/flavor | |
| 16:32:11 | bauzas | and a host can be part of 1:N aggs | |
| 16:32:51 | bauzas | so, if you need strict isolation for only a couple of keys, why just not define two aggregates, one containing keys with no strictness, and the other with keys needing to be strict ? | |
| 16:32:53 | cfriesen | bauzas: with strict matching you'd need the flavor/image to match all the strict keys from all the aggregates the host is in | |
| 16:33:47 | cfriesen | bauzas: you're thinking a "strict-match" boolean flag on the aggregate? yeah, that could work. | |
| 16:34:00 | bauzas | I'm just talking of the current proposal | |
| 16:34:18 | bauzas | he proposes to add new keys that are global per-aggregate | |
| 16:35:17 | bauzas | cfriesen: in that case, if you need some keys with strict isolation, and some with not, just define two aggregates and only apply the new metadata tag image_strict_isolation=True to the aggregate containing the keys you want to be strict | |
| 16:36:34 | mriedem | dansmith: looking at https://review.openstack.org/#/c/498950/ - it occurs to me that if prep_resize fails, i don't think we ever set the migration status to 'failed' | |
| 16:36:40 | mriedem | dansmith: which i think is just a latent bug | |
| 16:37:26 | mriedem | if resize_instance fails it will, but we might not get that far | |
| 16:38:34 | cfriesen | bauzas: I guess. Although AggregateInstanceExtraSpecsFilter doesn't do isolation currently, and AggregateImagePropertiesIsolation doesn't ensure that what you specify in the image is present in the aggregate. | |
| 16:38:52 | mriedem | dansmith: oh i know why - because we never had the migration before that point, because the RT always created it | |
| 16:39:13 | cfriesen | bauzas: hence the rationale for a new filter with common behaviour | |
| 16:39:25 | dansmith | mriedem: right, because _prep_resize's with resize_claim would do that right? | |
| 16:39:33 | mriedem | yeah | |
| 16:39:39 | mriedem | but now you're passing down a migration record and not handling errors | |
| 16:40:00 | dansmith | yup | |
| 16:40:24 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | |
| 16:42:07 | dansmith | the bottom one if this series was just kicked out of the gate anyway, so I'll rebase and freshen since we're like 8 hours from merge anyway | |
| 16:46:21 | bauzas | cfriesen: I don't disagree | |
| 16:46:36 | mriedem | dansmith: still going through this if you want to hold up | |
| 16:46:41 | mriedem | into the conductor stuff now | |
| 16:46:46 | cfriesen | bauzas: will comment on the review | |
| 16:46:50 | dansmith | mriedem: sure | |
| 16:48:33 | cfriesen | bauzas: it occurs to me that combining flavor extra-specs and image properties is tricky...some of that logic is way down in the virt code. | |
| 16:53:36 | mriedem | dansmith: ok done :) | |
| 16:54:09 | dansmith | mriedem: I can't wait to see what gifts you have left for me | |
| 16:54:16 | mriedem | they are bountiful | |
| 16:54:27 | mriedem | i'm going to go pat myself on the back with lunch | |
| 16:56:32 | mriedem | jaypipes: cdent: fyi https://review.openstack.org/#/c/498950/ | |
| 16:57:25 | cdent | mriedem: mlph | |
| 16:57:37 | cdent | this shit is too confusing | |
| 17:10:08 | mriedem | cdent: yeah, there are like 10 things that happen outside the scenes of everything... | |
| 17:18:37 | efried | jaypipes ( cdent ) I finished reviewing the series starting at https://review.openstack.org/#/c/470575/ -- is there anything else to look at for NRP or related at the moment? | |
| 17:18:46 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Network bandwitdh resource provider https://review.openstack.org/502306 | |
| 17:19:06 | cdent | efried: have you seen jay’s orm removal stack? | |
| 17:19:12 | cdent | it’s tangentially related | |
| 17:19:16 | efried | What's an orm/ | |
| 17:19:17 | efried | ? | |
| 17:19:23 | efried | (But I guess not) | |
| 17:19:44 | cdent | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:no-orm-resource-providers | |
| 17:21:16 | efried | cdent rgr | |
| 17:22:30 | cdent | efried: you’re already aware of alex’s traits work I think? | |
| 17:22:48 | efried | cdent Ah, sort of, but need to plug into it. Got a starter patch? | |
| 17:23:36 | cdent | it’s currently merge conflict, but: https://review.openstack.org/#/c/489206/7 | |
| 17:23:59 | efried | beaut | |
| 17:24:49 | efried | Amago eat, will dig in after. | |
| 17:28:30 | cfriesen | question for someone with more sqlalchemy-foo than I....will the soft_delete() call at https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L5932 affect both the "aggregate" table and the "aggregate_hosts" table? Or just the "aggregate" table? | |
| 17:35:52 | openstackgerrit | priyaduggirala proposed openstack/nova master: Rename parameters in call() of nova/image/glance.py https://review.openstack.org/508533 | |
| 17:40:02 | openstackgerrit | Merged openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486 | |
| 17:40:47 | openstackgerrit | Merged openstack/nova stable/ocata: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506760 | |
| 17:42:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | |
| 17:42:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | |
| 17:42:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | |
| 17:42:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | |
| 17:42:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | |
| 17:42:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | |
| 17:45:40 | mriedem | cfriesen: the latter | |
| 17:45:48 | mriedem | there is no such thing as cascading soft deletes | |
| 17:46:00 | mriedem | cfriesen: you could write a simple db api unit test to recreate that | |
| 17:52:08 | cfriesen | mriedem: I think that our online_data_migration will end up leaving a bunch of entries in the "aggregate_hosts" table after a migration....though properly written code shouldn't care. | |
| 17:52:31 | cfriesen | /s/migration/upgrade | |
| 17:53:35 | mriedem | write a test to show that | |
| 17:57:46 | dansmith | mriedem: are you sure that dest_host is the ip in the case of cold migration? https://review.openstack.org/#/c/508603/1/nova/objects/migration.py | |
| 17:58:03 | dansmith | I was surprised to find this was true for live migration a couple weeks ago when debugging a real thing, | |
| 17:58:14 | dansmith | but I'm not sure it's the same for cold migration | |
| 17:58:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Only query BDMs once in API during rebuild https://review.openstack.org/509574 | |
| 17:58:42 | mriedem | dansmith: yeah, that's what the RT sets it to | |
| 17:59:04 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L368 | |
| 17:59:15 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L393 | |
| 17:59:32 | mriedem | does live migration even set the migration.dest_host anywhere? | |
| 17:59:52 | melwitt | mriedem: it looks like the ceph package from the pike uca pulls in python-pastedeploy which gets install in parallel with a pip installed PasteDeploy package and keystone can't start because it has trouble referencing when there are multiple? (see last comment on https://ask.openstack.org/en/question/11458/keystone-all-importerror-cannot-import-name-deploy/) | |
| 17:59:57 | dansmith | actually we don't use moveclaim for live migration right? | |
| 18:00:04 | mriedem | dansmith: correct | |
| 18:00:05 | dansmith | maybe I had that reversed | |
| 18:00:11 | mriedem | that's why live migration creates the migratoin in conductor | |
| 18:00:16 | dansmith | ack | |
| 18:00:32 | dansmith | I think it's wrong for us to be setting the ip in that host field | |
| 18:00:42 | dansmith | in a "it's wrong but I'm not going to fix it any time soon" sort of way | |
| 18:00:57 | mriedem | dansmith: heh agree that it's surely confusing as hell | |
| 18:01:06 | mriedem | hence my putting a patch to comment on those damn fields | |
| 18:01:11 | mriedem | b/c i have to re-look it up every time | |
| 18:01:13 | dansmith | yeah | |
| 18:02:37 | clarkb | melwitt: on ubuntu (where uca is a thing) the deb packages should install to /usr and pip installed things to /usr/local. So if you get the order sorted out I expect it would just work | |
| 18:03:30 | mriedem | melwitt: weird, is there an ubuntu bug report? | |
| 18:03:36 | mriedem | we could ask jamespage about a fix | |
| 18:03:56 | mriedem | melwitt: alternatively we could workaround that maybe in the devstack-plugin-ceph repo by monkeying with the packages | |
| 18:08:34 | mriedem | heh, wtf, the compute rpcapi method for reboot_instance has a 'block_device_info' parameter that is always None from the API | |
| 18:13:36 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028 | |
| 18:13:36 | openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove CRUD operations on Inventory class https://review.openstack.org/509029 | |