Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-28
07:33:05 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/489029
07:44:40 openstackgerrit Merged openstack/nova stable/pike: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507552
07:59:51 openstackgerrit jichenjc proposed openstack/nova master: Add 400 as error code for resource class delete https://review.openstack.org/508080
08:07:52 openstackgerrit jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083
08:23:40 openstackgerrit jichenjc proposed openstack/nova master: remove CONF.vendordata_driver https://review.openstack.org/501510
08:25:38 openstackgerrit jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083
08:27:57 johnthetubaguy alex_xu are you working with lei-zh on https://review.openstack.org/#/c/468797?
09:00:14 openstackgerrit Merged openstack/nova stable/pike: Refactor ServerMovingTests for non-move tests https://review.openstack.org/507195
09:14:00 gmann oomichi: are you ok with create_or_update_* in this https://review.openstack.org/#/c/504439/11 ?
09:18:12 openstackgerrit Matthew Booth proposed openstack/nova master: Make etree.tostring() emit unicode everywhere https://review.openstack.org/507488
09:18:12 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/507202
09:18:31 bhagyashris avolkov: Hi,
09:18:53 avolkov bhagyashris: hi
09:18:58 mdbooth stephenfin: I wrote the test you asked for on https://review.openstack.org/#/c/507488/
09:19:02 mdbooth Then I unwrote it :)
09:19:19 mdbooth Can you have a quick look at my reply in case I misunderstood?
09:20:13 bhagyashris avolkov: I just want to discuss regarding the patch: https://review.openstack.org/#/c/409644/ I have respond to your comment can you please take some in sights
09:35:15 avolkov bhagyashris: left a comment there
09:35:38 bhagyashris avolkov: Thank you :)
09:42:08 bhagyashris avolkov: I will fix the review comment thank you for review :)
09:45:10 openstackgerrit Ghanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101
09:48:07 artom lyarwood, around?
09:48:24 artom The -W can come off https://review.openstack.org/#/c/499208/ I think, right?
09:48:34 artom Since https://review.openstack.org/#/c/468514/ landed
09:49:52 artom Same for https://review.openstack.org/#/c/468319/
09:59:13 openstackgerrit Ghanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101
10:01:28 lyarwood artom: hey yeah
10:01:32 lyarwood artom: ack looking
10:35:52 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
11:17:57 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116
11:25:20 openstackgerrit Chris Dent proposed openstack/nova master: Do not monkey patch eventlet in unit tests https://review.openstack.org/507923
11:25:21 openstackgerrit Chris Dent proposed openstack/nova master: DNM: Don't monkey patch eventlet in functional https://review.openstack.org/506668
11:25:21 openstackgerrit Chris Dent proposed openstack/nova master: Do not setup conductor in BaseAPITestCase https://review.openstack.org/508120
11:33:46 mdbooth cdent: Remind me, were you proposing removing eventlet from tests?
11:33:57 cdent I was yes
11:34:18 cdent there are monkey_patch calls at the top of the unit and functional trees
11:34:26 cdent removing the one at the top of unit is no problem
11:34:39 cdent the one at the top of functional is a problem, but limited
11:34:59 mdbooth cdent: Data point: I've used eventlet in tests explicitly a couple of times because its locking primitives can be killed with Ctrl-C, whereas the regular python ones can't.
11:35:14 cdent used explicitly: great
11:35:23 mdbooth This has no impact on the test usually, but is really useful when you're debugging it
11:35:25 cdent it’s the global monkey patching that i think is bad news
11:36:13 mdbooth Cool, just thought I'd bring it up
11:36:26 cdent yeah, thanks.
11:37:09 cdent In my digging around it looks like there’s still a fair amount of tests under unit that ought to be under functional, but I’m pretty sure I don’t want to fall in that hole (yet)
11:40:26 cdent yeah, I grepped for ‘start_service’ as sort of an initial feel around and the boundary has been permeated
11:45:35 cdent johnthetubaguy, stephenfin : can you guys weigh in on https://review.openstack.org/#/c/469048/ it’s some placement docs that have been languishing for a long time
11:46:16 cdent and this is a test that’s also been languishing, adds a bit more coverage: https://review.openstack.org/#/c/485209/
11:46:37 cdent gibi: you too on both of those
11:51:31 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116
12:05:23 sdague ok, the qemu >= 2.10 patch should really really be ready this time - https://review.openstack.org/#/c/505673/ - stephenfin, bauzas, johnthetubaguy if anyone wants to take a quick look
12:10:04 mdbooth Any chance of some eyes on this: https://review.openstack.org/#/c/507202/
12:10:20 mdbooth It's a data corruptor with no current mitigation other than "don't do that"
12:10:57 mdbooth The dependent patch is an annoying python 3-ism
12:11:46 mdbooth That's unfair, it's a bug in the libvirt python bindings, and a questionable default choice in the lxml python bindings
12:20:14 cdent mdbooth: that etree default stuff has bit me so many times
12:20:24 cdent (not in an openstack context, but elsewhere)
12:21:10 cdent sdague: no one will believe you until you use a 3rd “really”
12:21:29 mdbooth cdent: It bit me, so I did my usual trick of fixing the whole problem rather than just my bit. Ironically, that decision usually bites me.
12:39:07 stephenfin mdbooth: Comments left. One of us is missing something :)
12:39:24 mdbooth stephenfin: Thanks. Look in a bit.
12:48:39 openstackgerrit konstantin proposed openstack/nova master: switch from filesystem to disk for parallels containers https://review.openstack.org/506687
12:48:40 openstackgerrit konstantin proposed openstack/nova master: don't add device address if there is no any units https://review.openstack.org/506686
12:54:55 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/ocata: Updated from global requirements https://review.openstack.org/490256
12:57:05 cdent thanks stephenfin for the robust review
13:04:14 openstackgerrit Artom Lifshitz proposed openstack/nova stable/ocata: Test InstanceNotFound handling in 'nova usage' https://review.openstack.org/482219
13:09:32 openstackgerrit Artom Lifshitz proposed openstack/nova stable/pike: Test InstanceNotFound handling in 'nova usage' https://review.openstack.org/499208
13:14:18 alex_xu johnthetubaguy: yea, we are work on that together
13:15:54 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048
13:22:12 johnthetubaguy alex_xu: cool, I was just thinking that spec didn't use the flavor extra specs mapping dansmith was talking about at the PTG
13:22:59 johnthetubaguy alex_xu: I added comments on the spec anyways
13:25:11 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/ocata: Updated from global requirements https://review.openstack.org/490256
13:25:18 alex_xu johnthetubaguy: yea, I just read that, thanks
13:29:00 stephenfin cdent: Some more comments left on that patch from stuff I missed first go round. After those are addressed, I'm +2
13:29:15 cdent stephenfin: ✔
13:35:21 openstackgerrit Alex Xu proposed openstack/nova-specs master: Add trait support in the allocation candidates API https://review.openstack.org/497713
13:35:21 mdbooth stephenfin: https://review.openstack.org/#/c/507488/2/nova/tests/unit/virt/libvirt/test_guest.py
13:35:33 mdbooth stephenfin: They won't be converted to byte strings?
13:35:40 mdbooth I don't understand.
13:35:52 mdbooth We don't need to convert anything to bytestring.
13:36:01 stephenfin mdbooth: Isn't that what this is doing? https://review.openstack.org/#/c/507488/2/nova/virt/libvirt/guest.py
13:36:21 stephenfin if they're unicode values, convert to bytestrings (str in Python 2.7)
13:36:23 openstackgerrit Bhagyashri Shewale proposed openstack/nova master: Don't create instance backup image if rotation is 0 https://review.openstack.org/409644
13:36:37 mdbooth Not bytestrings, regular strings
13:36:43 mdbooth But only for python2
13:36:59 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/newton: Updated from global requirements https://review.openstack.org/373293
13:37:11 mdbooth We're not interested in what happens to bytestrings, because we don't expect to receive them
13:37:56 mdbooth Just a sec, lemme dig out the libvirt python bindings again...
13:38:02 stephenfin mdbooth: I'm using the wrong terminology so
13:38:21 alex_xu johnthetubaguy: ^ try to address your comment
13:38:30 stephenfin Whatever the default string type in Python3 is
13:38:34 stephenfin *Python 2
13:38:46 stephenfin i.e. six.binary_type
13:39:22 mdbooth stephenfin: The default string type in Python3 is unicode
13:39:32 mdbooth Oh, python2
13:39:40 mdbooth It's not binary type
13:39:49 mdbooth b'foo' != 'foo'
13:40:12 stephenfin mdbooth: Yeah it is, in Python 3
13:40:14 stephenfin *Python 2
13:40:16 stephenfin dammit

Earlier   Later