Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-26
15:23:08 sdague mriedem / gibi: https://review.openstack.org/#/c/505673/5/nova/tests/unit/virt/libvirt/test_utils.py
15:23:24 jaypipes cdent: cool, will check shortly.
15:23:55 mriedem sdague: i think he meant there is no unit test for the driver code setting the variable in https://review.openstack.org/#/c/505673/5/nova/tests/unit/virt/libvirt/test_driver.py
15:23:58 gibi sdague: that test sets the images.QEMU_VERSION directly, but you have some code in the driver.py that sets images.QEMU_VERSION
15:24:46 mriedem like test_next_min_qemu_version_ok
15:24:55 openstackgerrit Chris Dent proposed openstack/nova master: [placement] gabbi tests for shared custom resource class https://review.openstack.org/485209
15:25:03 mriedem gibi: you can -1 and i can add the test later
15:25:10 sdague mriedem: he already did
15:25:16 mriedem ok
15:26:01 gibi :)
15:27:02 mriedem dansmith: you said os reboot and restack would cleanup devstack?
15:27:29 dansmith mriedem: reboot and stack
15:27:38 mriedem ok
15:32:23 openstackgerrit Evgeny Antyshev proposed openstack/nova master: Add ploop procedures to privsep.libvirt https://review.openstack.org/507569
15:40:38 openstackgerrit Sean Dague proposed openstack/nova master: Support qemu >= 2.10 https://review.openstack.org/505673
15:40:47 sdague gibi / mriedem unit test added
15:41:55 gibi sdague: looking
15:45:20 gibi sdague: thanks, looks good, +2
15:45:47 sdague mriedem: ok, you next, reminding you of the "be faster and merge things" principle from the PTG :)
15:47:17 dansmith sdague: he's currently working on being fast and merge things on my instance list patch
15:47:28 dansmith sdague: but I'll look at yours so he can continue to be fast and merge on my patch
15:47:32 sdague :)
15:47:40 sdague it's pretty small and should be straight forward
15:50:36 mriedem sdague: i shouldn't approve my own change
15:51:48 sdague mriedem: it's barely your change any more
16:02:22 gibi I've just realized that I have to migrate the notification burndown chart from openshift 2 to 3 until end of September. This will be joyful
16:02:35 mdbooth stephenfin: Are the changes to https://review.openstack.org/#/c/507488/ evil?
16:03:07 mdbooth Thinking specifically of the 'if six.py2:' in libvirt/guest.py
16:03:26 mdbooth I still think it's saner to have unicode everywhere, and convert to something else at the point of use
16:04:12 dansmith cdent: are you working your way up that migration uuid series? if so, I'll hold off pushing that fix you just identified until you have a chance to nit out on anything else
16:04:27 stephenfin mdbooth: No, I'd probably do the same thing
16:04:40 dansmith meaning, you can identify more nit-ish things and I can fix them, vs. just pushing for nits later
16:04:59 cdent dansmith: yup (on phone at the moment though)
16:05:15 dansmith cdent: okay, np
16:06:55 stephenfin mdbooth: though I would like to see one of the tests slightly reworked, if that makes sense to you?
16:07:47 mdbooth stephenfin: Sure thing. I'll take a look in the morning.
16:07:51 openstackgerrit Merged openstack/nova master: Remove SCREEN_LOGDIR from devstack install setting https://review.openstack.org/507425
16:07:54 stephenfin (y)
16:20:46 bauzas edleafe: jaypipes: cdent: I thought we would be talking of how we would lead reschedules in https://review.openstack.org/#/c/498830/
16:21:34 bauzas edleafe: jaypipes: cdent: I see a couple of comments in that spec review, but have you settled down on discussing reschedules as being out of scope for that spec?
16:21:59 dansmith cdent: ah I see you have +1s on most of the rest of the set anyway, so I'll just push
16:22:14 cdent dansmith: i’m in the midst of the last one now
16:22:25 dansmith cdent: ah okay then I'll wait
16:22:37 cdent so give me a couple of minutes (phone call was shorter than expected)
16:22:48 dansmith yeah not trying to rush you
16:23:20 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
16:23:21 dansmith I just want to push that review button and get that squirt of dopamine you know :P
16:24:14 edleafe bauzas: reschedules will be a different spec
16:24:55 bauzas edleafe: so the spec is litterally just for mentioning which object the scheduler will return to conductor ?
16:25:01 rybridges Hey guys. I am using the ocata release and am wondering if there is any way to print the user data associated with an instance that i own from the cli with the openstack client
16:25:02 bauzas edleafe: looks uber too much
16:25:21 bauzas I mean, super heavy
16:26:03 edleafe bauzas: since this will be sent over RPC, we needed agreement on it so that we don't find ourselves changing it later
16:26:04 bauzas I'd be up concentrating our minds on how we plan to pass that object
16:26:23 bauzas edleafe: we did a couple of RPC changes that didn't require a spec fortunately
16:26:34 bauzas but I leave the mic to mriedem
16:26:45 edleafe bauzas: the idea is to get it close to correct before we make the change
16:26:46 dansmith bauzas: specs are cheap
16:27:06 dansmith if edleafe wants separate specs, I don't think there's a problem
16:27:11 edleafe bauzas: and given the amount of discussion on the Selection object spec, I'd say it was a good thing to do
16:27:16 dansmith we should focus on getting the work done and not the process
16:27:16 bauzas dansmith: well, I'd rather then look at code, but okay :)
16:27:22 bauzas yeah that
16:27:37 edleafe bauzas: the work is being done in parallel
16:28:00 bauzas edleafe: well, okay
16:28:37 bauzas edleafe: the thing is, if you want a spec, fine with me, but then precise the scope
16:28:48 bauzas since it was a work item, I was expecting more
16:29:14 dansmith mriedem: so I was just looking at this for evac and live migration.. this method _moves_ allocations to the destination, not copies AFAICT: https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L222-L224
16:29:16 dansmith mriedem: is that right?
16:29:18 bauzas if the spec isn't targeting to mention how reschedules would be done, fair enough but just make sure you clearly scope that
16:29:23 cdent dansmith: dobne
16:29:25 cdent done!
16:30:29 dansmith cdent: yes the last one is less done
16:32:40 mriedem dansmith: copies
16:33:10 dansmith mriedem: oh does claim_resources() do the doubling thing?
16:33:17 mriedem no
16:33:30 mriedem it takes the allocations for the instance on the source node, and makes those same allocations for the instance on the dest node
16:33:40 dansmith which will erase the source allocation
16:33:41 mriedem it's basically what the scheduler would do,
16:33:44 dansmith because... only one consumer
16:33:55 mriedem oh it calls claim_resources,
16:33:57 mriedem so yeah it doubles
16:34:02 mriedem this is the thing where force=True
16:34:07 mriedem so we don't call the scheduler to double the allocs
16:34:20 mriedem and i said i wanted to move back into the scheduler, but we'd need a skip_filters flag in select_destinations
16:34:27 dansmith okay I didn't think claim_resources was the doubling one, but maybe so, I'll dig a bit
16:34:39 mriedem claim_resources calls the double stuff method
16:34:59 dansmith okay
16:35:48 dansmith cdent: can you look at my comment on the DRY thing and see if you buy what I'm sellin' ?
16:38:24 cdent dansmith: I will buy that with an entire whole dollar, if you comment the plan
16:38:50 dansmith ack
16:40:23 dansmith cdent: you saw the "when we have an atomic operation we should remove this" right?
16:42:13 cdent yes, but (unless I missed it) there’s no “this dupe with that other thing but we don’t care cuz”
16:42:27 dansmith I will add more words
16:42:31 cdent I’ll still buy it for a dollar even if you don’t
16:45:16 openstackgerrit Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948
16:45:16 openstackgerrit Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
16:45:17 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
16:45:17 openstackgerrit Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
16:45:18 openstackgerrit Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420

Earlier   Later