| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-26 | |||
| 13:23:43 | bauzas | ack | |
| 13:36:22 | mdbooth | stephenfin: Eurgh. So it seems that in python2.7 libvirt binding's migrateToURI3() barfs if destination_xml is unicode. | |
| 13:38:55 | mdbooth | stephenfin: think I'm going to leave that etree.tostring() patch always producing unicode, but I'm going to add a 2/3 hack next to the migrateToURI3 which handles the difference, because IMHO the libvirt bindings should accept a unicode string there, and it's just saner. | |
| 13:39:03 | kashyap | Matt, hmm, the assertThat() mismatch seems to be related to ID: | |
| 13:39:04 | kashyap | 2017-09-26 12:26:17.199293 | 2017-09-26 12:26:17.198 | reference = u'ubuntu-xenial-2-node-rax-ord-11137317-923993' | |
| 13:39:07 | kashyap | 2017-09-26 12:26:17.200739 | 2017-09-26 12:26:17.200 | actual = u'ubuntu-xenial-2-node-rax-ord-11137317' | |
| 13:39:19 | mdbooth | kashyap: Yes, that's just asserting that the migration happened | |
| 13:39:28 | mdbooth | i.e. assert id == the destination | |
| 13:40:00 | mdbooth | I hate python3 | |
| 13:40:15 | mdbooth | And python2 | |
| 13:40:28 | mdbooth | But the 2->3 split especially | |
| 13:40:49 | kashyap | Ah, I see. (about the assert ID) | |
| 13:49:02 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | |
| 13:51:32 | sdague | mriedem: I was diving through thinking more about https://review.openstack.org/#/c/507239/ last night, why do you think that external locking is required there? Because it should blow up if not provided but is needed | |
| 13:52:21 | mriedem | sdague: i thought that also locked those tests to run serially | |
| 13:52:26 | mriedem | maybe i should be using https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/fixture/lockutils.py#L22 | |
| 13:52:32 | mriedem | ^ is actually what i started using | |
| 13:52:36 | sdague | mriedem: serial to what? | |
| 13:52:49 | openstackgerrit | konstantin proposed openstack/nova master: switch from filesystem to disk for parallels containers https://review.openstack.org/506687 | |
| 13:52:49 | openstackgerrit | konstantin proposed openstack/nova master: don't add device address if there is no any units https://review.openstack.org/506686 | |
| 13:53:11 | mriedem | sdague: to other tests | |
| 13:53:26 | mriedem | like, things that would be mocking those nova.rpc globals | |
| 13:53:42 | sdague | all the tests in a worker run serially | |
| 13:53:50 | sdague | and the tests between workers are in completely different processes | |
| 13:54:00 | sdague | with no shared state | |
| 13:54:42 | eantyshev | mikal: Hello! Regarding your review https://review.openstack.org/#/c/492325 | |
| 13:54:57 | sdague | The reason we had REQUIRES_LOCKING at all was because oslo required a directory name or it exploded | |
| 13:55:22 | sdague | but we feed those all temp directories anyway, they never cross lock between workers | |
| 13:56:33 | eantyshev | it fails on parallels virt_type, and I'd like to update it for you, don't you mind? | |
| 13:56:34 | sdague | but I actually don't think that default behavior holds any more, and we can probably fully delete that variable anyway, as it definitely confuses people as to what it does | |
| 13:56:54 | sdague | mriedem: https://review.openstack.org/#/c/507253/ - I was experimenting this morning | |
| 13:59:57 | mriedem | avolkov: you might like to take a crack at this https://bugs.launchpad.net/nova/+bug/1719460 | |
| 13:59:58 | openstack | Launchpad bug 1719460 in OpenStack Compute (nova) "(perf) Unnecessarily joining instance.services when listing instances regardless of microversion" [Medium,Triaged] | |
| 13:59:59 | mriedem | should be pretty simple | |
| 14:03:06 | dansmith | mriedem: any outcome from your testing yesterday? | |
| 14:03:43 | mriedem | dansmith: i've got the clean slate, just getting setup to start the 2nd scenario with the 500 ACTIVE and 500 ERROR instances | |
| 14:03:49 | mriedem | for the cell0 and cell1 listing | |
| 14:03:55 | dansmith | okay | |
| 14:04:11 | mriedem | going to need to do that flavor thing because otherwise it's a 60 second rpc timeout per call to select_destinations | |
| 14:04:27 | dansmith | yeah | |
| 14:06:53 | gibi | mriedem, sdague: this also means that the problems we see with the rpc tests in bug 1685333 is not beacuase of the lack of locking | |
| 14:06:54 | openstack | bug 1685333 in OpenStack Compute (nova) "Fatal Python error: Cannot recover from stack overflow. - in py35 unit test job" [High,Confirmed] https://launchpad.net/bugs/1685333 | |
| 14:06:54 | sdague | mriedem: is there a reset on rpc variables that is needed that's not happening? | |
| 14:07:19 | mriedem | sdague: the TestRPC class does a reset per test method | |
| 14:07:39 | sdague | gibi: I don't see how it could be. It might be a deadlock | |
| 14:07:48 | mriedem | dansmith: also came across this last night https://bugs.launchpad.net/nova/+bug/1719487 | |
| 14:07:50 | openstack | Launchpad bug 1719487 in OpenStack Compute (nova) "nova-manage db archive_deleted_rows is not multi-cell aware" [Wishlist,Triaged] - Assigned to Zhenyu Zheng (zhengzhenyu) | |
| 14:07:57 | sdague | the biggest issue though is it doesn't have the timeout bits in place, so it's hard to see what's going on | |
| 14:08:10 | sdague | I think if we trigger the timeout we get a stack trace | |
| 14:08:18 | gibi | sdague: that would be nice | |
| 14:08:22 | dansmith | mriedem: meh | |
| 14:08:50 | mriedem | meh?! | |
| 14:08:55 | mriedem | it's wishlist, sure | |
| 14:09:02 | dansmith | MEH | |
| 14:09:05 | mriedem | gdi | |
| 14:09:13 | gibi | sdague, mriedem: we are at the start of the cycle so I'm brave enough to try to remove the whole locking code and see what happens | |
| 14:09:48 | mriedem | dansmith: oh yeah, also came across this last night https://review.openstack.org/#/c/502236/ | |
| 14:09:49 | mriedem | derp | |
| 14:11:10 | dansmith | ack yeah | |
| 14:11:48 | mriedem | gibi: you can be brave locally to start :) | |
| 14:11:53 | sdague | gibi: yeh, well we should at least get the test_rpc under timeout control, regardless of the rest of it | |
| 14:13:10 | gibi | mriedem: I can definitly do that | |
| 14:13:20 | avolkov | mriedem: ack | |
| 14:13:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Make TestRPC inherit from the base nova TestCase https://review.openstack.org/507239 | |
| 14:14:11 | mriedem | ^ removes the lock thing | |
| 14:14:15 | mriedem | so we'll have the timeout fixture | |
| 14:15:29 | gibi | sdague: agree. I found one more place where we use the testtools.TestCase directly. I left a comment in your review | |
| 14:15:46 | sdague | gibi: in the fixtures? | |
| 14:16:00 | gibi | sdague: here https://github.com/openstack/nova/blob/62c4535a85f7d37f1c9da1e8a747f25ec63dc785/nova/tests/unit/api/openstack/test_requestlog.py#L38 | |
| 14:16:18 | sdague | ah, cool, good catch | |
| 14:16:39 | mriedem | i thought ^ was intentional | |
| 14:16:45 | mriedem | for the placement split or something | |
| 14:17:06 | gibi | sdague: I think fixtures are OK to derive from testtools.TestCase as we use fixtures like mixins | |
| 14:17:23 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507552 | |
| 14:17:23 | sdague | gibi: yeh, some of the more advanced ones should see the timeout | |
| 14:17:29 | sdague | but I think that's follow on | |
| 14:17:33 | sdague | mriedem: it's a good question | |
| 14:18:30 | gibi | sdague, mriedem: at least this request_log test should be also under timeout control | |
| 14:18:36 | sdague | gibi: so, I'd actually rather handle nova/tests/unit/api/openstack/test_requestlog.py as follow on, because those actually do most of the fixture setup (except the timeout one) manually | |
| 14:18:44 | sdague | so it's going to be a bit more extensive change there | |
| 14:18:52 | sdague | I do agree that we should get that under timeout control | |
| 14:19:02 | sdague | but test_rpc is failing a lot now | |
| 14:19:16 | gibi | sdague: I'm OK with that approach. Then I'm +2 on your patch introducing BasicTestCase | |
| 14:19:17 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507556 | |
| 14:20:00 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507557 | |
| 14:20:57 | manasm | bauzas: here is the exception I saw with the resize -2017-09-22 07:49:16.377 13573 ERROR nova.api.openstack.extensions File "/usr/lib/python2.7/site-packages/nova/scheduler/utils.py", line 567, in setup_instance_group | |
| 14:20:58 | manasm | 2017-09-22 07:49:16.377 13573 ERROR nova.api.openstack.extensions request_spec.instance_group.hosts = list(group_info.hosts) | |
| 14:20:59 | manasm | 2017-09-22 07:49:16.377 13573 ERROR nova.api.openstack.extensions | |
| 14:21:01 | manasm | 2017-09-22 07:49:16.377 13573 ERROR nova.api.openstack.extensions AttributeError: 'NoneType' object has no attribute 'hosts' | |
| 14:21:03 | manasm | 2017-09-22 07:49:16.377 13573 ERROR nova.api.openstack.extensions | |
| 14:21:07 | jaypipes | mriedem, dansmith, gibi, sdague, bauzas: any of you noticed weird glitches in the new Gerrit web UI where the screen blinks and flashes when you open up long in-page comments? | |
| 14:21:18 | dansmith | no | |
| 14:21:23 | jaypipes | hmmm | |
| 14:21:32 | gibi | at least not yet | |
| 14:21:37 | jaypipes | it's a good thing I don't have Tourettes. | |
| 14:21:57 | jaypipes | or epilepsy I gues | |
| 14:22:49 | jaypipes | efried: around? want to chat about "trait inheritance"... | |
| 14:23:01 | efried | jaypipes I thought you'd never ask :* | |
| 14:23:06 | jaypipes | lol | |
| 14:23:18 | efried | jaypipes I have also experienced the gerrit UI glitchiness. | |