Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-26
10:45:34 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257
10:54:09 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Implement query param schema for simple_tenant_usage https://review.openstack.org/507480
10:54:10 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/507481
11:02:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: cover migration cases with functional tests https://review.openstack.org/493865
11:04:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764
11:04:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297
11:04:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459
11:09:56 gibi bauzas: could you make a quick look at https://review.openstack.org/#/c/504930/ ? it is a single line of test case improvement that removes an test instability.
11:14:00 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
11:21:16 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/507202
11:21:17 openstackgerrit Matthew Booth proposed openstack/nova master: python3: Specify unicode explicitly calling etree.tostring() https://review.openstack.org/507488
11:22:15 mdbooth stephenfin: You were looking at ^^^
11:22:59 mdbooth There was a python3 problem in the first version of that patch. Turns out it's a general problem with etree.tostring() which other tests were ignoring by mocking out :/
11:23:23 mdbooth Hence the prior patch to fix all etree.tostring() calls
11:33:45 mdbooth gibi: Before I rebase it, any chance you could promote your +1 here to a +2: https://review.openstack.org/#/c/479802/8 ?
11:33:55 mdbooth Then I'll rebase in a bit after it merges
11:37:46 openstackgerrit Matthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration https://review.openstack.org/479802
11:37:46 openstackgerrit Matthew Booth proposed openstack/nova master: Use Migration object in ComputeManagerMigrationTestCase https://review.openstack.org/502126
11:37:47 openstackgerrit Matthew Booth proposed openstack/nova master: Automatically revert resize which fails on destination https://review.openstack.org/462521
11:37:48 mdbooth Actually meh it was a clean rebase anyway. Should keep the existing +2.
11:56:36 openstackgerrit Lajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources https://review.openstack.org/497399
12:13:04 openstackgerrit Alex Xu proposed openstack/nova-specs master: Add trait support in the allocation candidates API https://review.openstack.org/497713
12:14:51 bauzas gibi: sorry was outside, but back now, +W'd
12:16:21 gibi bauzas: thanks
12:16:39 gibi mdbooth: I'm on a meeting but opened the review so I will check it
12:17:02 efried ratailor Did you get your questions answered about the osc microversion?
12:17:24 ratailor efried, not yet. could you help ?
12:18:01 efried ratailor Your observation is correct, and by design. As for the reasoning behind it... that's complicated.
12:18:42 efried ratailor But if you want a specific microversion in osc, you can ask for it with an env var, CLI opt, or (I think) conf var.
12:19:13 bauzas efried: if the microversion is not asking for a new attribute :p
12:19:27 efried Yeah, there's that :)
12:19:37 mdbooth efried: OSC will happily send invalid requests because it doesn't understand those microversions, though.
12:20:02 manasm bauzas: running into an issue with resize on an upgraded env from Ocata to Pike, the resize fails at following call in scheduler_utils.setup_instance_group method -
12:20:04 mdbooth At that point, the user might as well just open telnet and type the http themselves :)
12:20:07 efried ratailor A lot of it has to do with the fact, as bauzas and mdbooth are pointing out, that osc has not maintained functional parity with microversions.
12:20:07 manasm request_spec.instance_group.hosts = list(group_info.hosts)
12:20:49 manasm bauzas: this is because the instance_group is set to None in the request_spec.
12:21:03 manasm Is there a known issue around that?
12:21:04 bauzas manasm: do you have an open bug for that?
12:21:14 manasm not yet
12:21:18 ratailor efried, To make it as stable as possible. right ?
12:21:30 ratailor efried, and backward compatible.
12:21:49 efried ratailor The reasoning may not be quite that high-minded :)
12:21:59 ratailor efried, cool
12:22:07 mdbooth This is a data corruptor with a simple fix: https://review.openstack.org/#/c/507202/
12:22:20 bauzas manasm: AFAIR, we create a new InstanceGroup object when looking at the primitive dicts
12:22:40 ratailor efried, Thanks!
12:22:56 efried ratailor If you want more history/explanation on the osc side, find dtroyer. I don't remember offhand which channel is the accepted one for talking about the CLI, but I know he's in #openstack-dev
12:22:58 mdbooth Affects libvirt live migration with attached volumes
12:23:25 efried ratailor Possibly #openstack-sdks
12:23:52 ratailor efried, sure, Thanks!
12:24:12 efried ratailor yw, good luck.
12:24:19 ratailor efried, actually I was searching him only, but didn't found in core openstack channels.
12:24:27 ratailor efried, Thanks for your help!
12:24:52 efried It may be a tad early for him to be on just yet, but he's at least got bouncers in those two channels.
12:25:10 manasm bauzas: yes, we have the new InstanceGroup object but the we are trying to assign it to request_spec.instance_group which is None.
12:25:47 bauzas efried: ratailor: FWIW, I already provided a point for the Sydney Forum about OSC vs. our CLI in https://etherpad.openstack.org/p/SYD-nova-brainstorming L35
12:26:08 bauzas I'd love to hear operators about what they use and how
12:27:29 ratailor bauzas, ++1
12:28:06 bauzas manasm: you said when you resize?
12:28:16 bauzas manasm: so we're getting the ReqSpec from the DB first
12:28:53 bauzas if there was no group yet for that instance, then the ReqSpec.instance_group field could be None
12:28:55 manasm yes, btw we get the object from db using - objects.InstanceGroup.get_by_instance_uuid(context, instance_uuid), and if it is None then we don't hit the issue.
12:32:27 bauzas manasm: wait, I need to look at the code for resize
12:32:36 bauzas do you have a stacktrace to share?
12:38:52 kashyap mdbooth: FWIW, looks good. Compact summary, and a nice fix: https://review.openstack.org/#/c/507202/2
12:39:56 mdbooth It breaks some tempest tests, though :/
12:40:02 mdbooth Probably means I didn't think of something.
12:40:20 mdbooth It does look obvious, though.
12:40:26 stephenfin mdbooth: Reviewed both. Tidy job
12:40:45 kashyap mdbooth: Wonder if you want to link to to the virDomainMigrateFlags page: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateFlags
12:40:58 kashyap Which talks about WTF actually the flag VIR_MIGRATE_NON_SHARED_INC is
12:41:07 kashyap If you think it's not needed, disregard me
12:42:30 kashyap Maybe not required. Those who want to know about it, a simple look up will fetch it
12:44:40 kashyap BTW, the "tempest-dsvm-full-xenial" succeeded
12:51:23 kashyap Ah, it's the "gate-grenade-dsvm-neutron-ubuntu-xenial" that failed.
12:52:03 mdbooth kashyap: Yep, in the block migration tests :)
12:52:13 mdbooth I suspect the failure there is probably related ;)
12:52:44 mdbooth kashyap: If you have time to investigate those failures, btw, I have to do something else right now. Otherwise I'll get to them later.
12:52:53 kashyap mdbooth: I'm looking at the log - http://logs.openstack.org/02/507202/2/check/gate-tempest-dsvm-py35-ubuntu-xenial/8485b63/console.html
12:53:10 kashyap I'll note on the review if I learn something new from the log
12:53:56 openstackgerrit Yikun Jiang proposed openstack/nova master: Update Instance action's updated_at when action event updated. https://review.openstack.org/507473
12:54:51 kashyap So the right log is - http://logs.openstack.org/02/507202/2/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/b210147/console.html
12:55:33 openstackgerrit konstantin proposed openstack/nova master: switch from filesystem to disk for parallels containers https://review.openstack.org/506687
12:55:34 openstackgerrit konstantin proposed openstack/nova master: don't add device address if there is no any units https://review.openstack.org/506686
12:57:18 openstackgerrit Yikun Jiang proposed openstack/nova master: Update Instance action's updated_at when action event updated. https://review.openstack.org/507473
12:59:33 openstackgerrit Eric Fried proposed openstack/nova master: nova.utils.get_ksa_adapter() https://review.openstack.org/488137
13:00:37 openstackgerrit Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247
13:00:43 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/ocata: Updated from global requirements https://review.openstack.org/490256
13:02:52 openstackgerrit Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
13:02:58 openstackgerrit Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
13:06:19 openstackgerrit Sean Dague proposed openstack/nova master: Break out BasicTestCase https://review.openstack.org/507253
13:06:20 openstackgerrit Sean Dague proposed openstack/nova master: Don't use mock.patch.stopall https://review.openstack.org/507527
13:06:20 openstackgerrit Sean Dague proposed openstack/nova master: Remove REQUIRES_LOCKING as nothing needs process locking in the tests https://review.openstack.org/507528
13:06:21 openstackgerrit Sean Dague proposed openstack/nova master: WIP: demonstrate no use of external locking https://review.openstack.org/507529
13:08:33 openstackgerrit Eric Fried proposed openstack/nova master: Don't fix protocol-less glance api_servers anymore https://review.openstack.org/505317
13:12:57 openstackgerrit Yikun Jiang proposed openstack/nova master: Update Instance action's updated_at when action event updated. https://review.openstack.org/507473
13:16:40 sdague gibi: so, interesting fact from this morning, I'm pretty convinced we don't need any of the REQUIRES_LOCKING code
13:20:47 sdague gibi: also, if you are able to take a look at the qemu 2.10 support patch, that would be cool - https://review.openstack.org/#/c/505673/
13:20:53 sdague or bauzas

Earlier   Later