Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-21
22:16:08 efried mriedem Fixed that version and added co-author line ^
22:17:25 mriedem we can describe the operations in a follow up
22:17:42 mriedem not as pretty is right!
22:18:01 mriedem not sure why the reqs job was failing then
22:18:46 mriedem oh it's the space
22:18:53 mriedem it literally has to match "sphinxcontrib-seqdiag>=0.8.4 # BSD"
22:19:48 mriedem maybe not, this might work
22:20:20 efried I had it as .5 before
22:20:36 mriedem yup see that now
22:20:40 mriedem cool, this should pass
22:20:42 mriedem glorious
22:20:52 efried yeah, it's not complaining about the actdiag one, which has two spaces before the comment as well.
22:42:04 openstackgerrit Merged openstack/nova master: Drop support for the Cinder v2 API https://review.openstack.org/501874
22:45:19 openstackgerrit Jay Pipes proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575
22:45:20 openstackgerrit Jay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921
22:45:23 openstackgerrit Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
22:45:23 openstackgerrit Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
22:45:26 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
22:45:28 openstackgerrit Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
23:15:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Add recreate test for unshelve offloaded instance spawn fail https://review.openstack.org/506414
23:18:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add a regression test for bug 1718455 https://review.openstack.org/506092
23:18:15 openstack bug 1718455 in OpenStack Compute (nova) "[pike] Nova host disable and Live Migrate all instances fail." [Medium,In progress] https://launchpad.net/bugs/1718455 - Assigned to Sylvain Bauza (sylvain-bauza)
23:19:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix definitely move single instance when created concurrently https://review.openstack.org/506093
23:31:12 openstackgerrit Hongbin Li proposed openstack/nova master: Remove method "_get_host_ref_from_name" https://review.openstack.org/504796
23:35:55 openstackgerrit Dan Smith proposed openstack/nova master: Fix a pagination logic bug in test_bug_1689692 https://review.openstack.org/505661
23:35:55 openstackgerrit Dan Smith proposed openstack/nova master: Use improved instance_list module in compute API https://review.openstack.org/505418
23:35:56 openstackgerrit Dan Smith proposed openstack/nova master: Remove legacy fault-loading routines https://review.openstack.org/505456
23:35:56 openstackgerrit Dan Smith proposed openstack/nova master: Fix CellDatabases fixture swallowing exceptions https://review.openstack.org/506312
23:35:57 openstackgerrit Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416
#openstack-nova - 2017-09-22
00:19:54 mriedem melwitt pulling out the zingers on the sorted instances list series tonight
00:21:33 melwitt trying to be a cool cat
00:24:24 openstackgerrit Merged openstack/nova master: Add base implementation for efficient cross-cell instance listing https://review.openstack.org/504983
00:25:36 dansmith woot
00:26:09 openstackgerrit Dan Smith proposed openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947
00:26:10 openstackgerrit Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948
00:26:10 openstackgerrit Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949
00:26:11 openstackgerrit Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950
00:26:11 openstackgerrit Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419
00:26:12 openstackgerrit Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420
00:26:25 dansmith this is still super WIP except for the first patch ^
00:26:30 dansmith and a giant mess to boot
00:26:41 dansmith but, it's getting there
00:31:36 dansmith melwitt: replied to your [0] question, and I can slap a comment into the fixes patch at the end if you want
00:31:44 dansmith if you are otherwise likely to be okay with the rest
00:31:48 dansmith same for your docstring mriedem
00:34:07 melwitt okay, yeah a comment would be nice for the fixes patch. the rest looked fine to me
00:37:03 openstackgerrit Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416
00:37:06 dansmith voilla ^
00:38:13 openstackgerrit Merged openstack/nova master: Make instance_list honor global query limit https://review.openstack.org/504984
00:39:15 dansmith aww yeah
00:39:39 dansmith melwitt: mriedem: the gate phoned and said it was lonely. just sayin'.
00:42:53 melwitt the gate calls you on the phone? I'm jell
00:43:56 dansmith don't be, it's rarely good news
00:44:10 melwitt heh
00:44:56 mriedem what the f are you two talking about
00:45:29 melwitt cool cat stuff
00:47:05 mriedem dansmith: this is kind of a "add an assertion check here?" question https://review.openstack.org/#/c/504985/8/nova/tests/unit/db/test_db_api.py@10793
00:47:35 dansmith mriedem: assert what?
00:47:58 dansmith oh, I see
00:48:02 mriedem yeah
00:48:03 mriedem that
00:48:03 dansmith make sure the first one did the thing I want?
00:48:17 mriedem yes
00:48:23 dansmith but at the end we know we've gotten them all ...
00:49:06 mriedem yeah ok
00:49:09 mriedem fair enough
00:49:50 dansmith I can slap more checking into the fixes patch if you want
00:50:18 melwitt slap chop
00:50:55 mriedem it's just kind of hard to grok what this is doing
00:51:05 dansmith the first call is using the existing db method,
00:51:15 mriedem it starts with the 256 memory_mb instance
00:51:31 dansmith so if it wasn't sorting properly, we'd have a big problem and other tests would fail (hopefully?)
00:51:46 mriedem and then i guess it pages through each time, and should hit those other instances in order
00:51:53 mriedem so next after 256+1 would be the 512 instance
00:51:57 dansmith mriedem: it does, and I just put things in the db in a weird order to make sure we don't rely on the ordering in the db but the sorting
00:52:08 mriedem yeah noted that
00:52:11 mriedem which is nice
00:52:45 mriedem and the key_name in the values is just there for?
00:53:11 mriedem just to show we aren't sorting on key_name?
00:53:49 dansmith I think I was copying my other unit test examples from the other patches, but yeah I can remove that if you think it's confusing
00:55:06 mriedem ok left some comments inline, you can add docs to it in the end if you want
00:55:57 openstackgerrit Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416
00:55:59 dansmith mriedem: ^
00:57:04 dansmith mriedem: does that help at all? or is it still too obscure because I'm not comparing against a static obvious list?
00:58:42 mriedem you only updated the commit message
00:59:07 dansmith gah
00:59:27 openstackgerrit Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416
00:59:31 dansmith sorry
01:01:08 mriedem ok, left a comment about the key_name thing in the last change
01:02:39 openstackgerrit Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416
01:02:54 dansmith got it
01:03:30 mriedem i think i'm getting the global marker patch now
01:03:37 mriedem understanding the patch before it is key
01:10:30 mriedem so for the ip filtering we do in python in the compute api, does the end of this result in us returning a sorted/filtered list to the code that then processes the ip filter regex?
01:15:03 dansmith mriedem: I'm not sure I understand.. that filtering code is in the api, right? we shouldn't be changing what it sees
01:15:14 mriedem yeah i just haven't gotten there yet
01:15:22 dansmith okay
01:15:27 mriedem this is all basically a shim in between the db api and that code that processes the result and filters by ip regex
01:15:28 mriedem ok
01:15:36 dansmith right

Earlier   Later